Following tdf#173579 by removing broken dynamic loading of collators,
I focused on Kurdish Latn collation.
Root cause and fix provided by GPT-5.6 Luna
Cause:
when "kmr-Latn-TR", LO uses Language "qlt", Country "TR" (Turkey), Variant "kmr-Latn-TR"
but "kmr-Latn-TR" wasn't used in LOCAL_RULE_LANGS (a variable generated in i18npool/CustomTarget_collator.mk)
and used in i18npool/source/collator/collator_unicode.cxx, method Collator_Unicode::loadCollatorAlgorithm
so "func" and "funclen" weren't initialized with appropriate collator functions.
Fix:
rename file and functions containing "ku" by using "kmr_Latn"
(I suppose the right move since it mimics Eike Rathke's commit 45d4b9b5e3
"renamed ku* to kmr-Latn*, fdo#63460")
Add a specific use case bKmrLatn to load "kmr_Latn" collator functions
to deal with "qlt" language (yes it's a bit kludgy...)
We must remind that "kmr_Latn" can be used for "kmr_Latn_TR" but also with "kmr_Latn_SY"
that's why I avoided using "kmr_Latn_TR"
Also, to avoid the bKmrLatn specific case,
I thought about changing "LangID" tag of i18npool/source/localedata/data/kmr_Latn_TR.xml
from "qlt" into "kmr-Latn" but I'm not sure of the impact.
Change-Id: Ifc608da19b4bd2d05667121e3c6f2455f5d45ca9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210977
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
On pc Debian testing x86-64 with master sources + clang 21.1,
autogen.sh generates config_host.mk with:
export CC=/usr/bin/ccache clang -std=gnu23
export CC_FOR_BUILD=/usr/bin/ccache clang -std=gnu23
it's because a recent change in autoconf.
The pb is it makes Firebird part building in LO fail.
Add ac_cv_prog_cc_c23=no as a workaround for the moment.
Change-Id: I13f49153e82b4f670fe170ef5df6f072b0c7d336
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211193
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
There was lacking the ControllerItem for metric part.
I took example on sw/source/uibase/sidebar/PageFormatPanel.cxx
Also, in the notify part, there was lacking the SID_ATTR_METRIC case.
Change-Id: I9fed8255634cee2e2ed3b4ebf6ffe1e06e038df6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211268
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
After de43ed1088
"merge index_data into i18npool
(*) it is a small library
(*) this avoids another dynamic symbol lookup
(*) this unblocks more --enable-mergedlibs optimisation
"
SAL_DLLPUBLIC_EXPORT has been removed so collators weren't available for
dynamic loading use. So there was only 1 kind of sort possible in Japanese
(see description in the bugreport).
To make Japanese (but not only them) collators work again,
I kept on the same way of the quoted commit by removing
DISABLE_DYNLOADING blocks and by adding declarations of functions
in i18npool/inc/collator_unicode.hxx
Change-Id: I36529c12ae67fe7eb0562c6798ef55fdbea02f04
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211111
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
The pb was that a substitution for the nonexisting font was done and successful
without taking into account a explicitely font provided.
So before calling FindFontSubstitute, test nTokenPos to know if there's
a substitute font.
I started from https://bugs.documentfoundation.org/show_bug.cgi?id=108243#c13
but the root cause was found and a fix proposed by ChatGpt (GPT-5.6 Luna).
I tested the initial odt file provided in the bugtracker it worked.
I also did the same test without substitution font provided, it was ok too
since it was replaced by a Noto font.
Change-Id: I992d1ed5e4ebcf8795718001d17f8afda32e4735
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210680
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
Try to fix in WASM Jenkins:
In file included from /home/tdf/jenkins/workspace/lo_gerrit/tb/src_wasm/vcl/source/app/salplug.cxx:78:
/home/tdf/jenkins/workspace/lo_gerrit/tb/src_wasm/vcl/inc/headless/svpinst.hxx:100:36: error: non-virtual member function marked 'override' hides virtual member function
100 | bool DoExecute(int &nExitCode) override;
| ^
/home/tdf/jenkins/workspace/lo_gerrit/tb/src_wasm/vcl/inc/salinst.hxx:237:18: note: hidden overloaded virtual function 'SalInstance::DoExecute' declared here: different number of parameters (0 vs 1)
237 | virtual bool DoExecute();
| ^
1 error generated.
make[1]: *** [/home/tdf/jenkins/workspace/lo_gerrit/tb/src_wasm/solenv/gbuild/LinkTarget.mk:338: /home/tdf/lode/jenkins/workspace/lo_gerrit/tb/build_master/workdir/CxxObject/vcl/source/app/salplug.o] Error 1
make[1]: *** Waiting for unfinished jobs....
In file included from /home/tdf/jenkins/workspace/lo_gerrit/tb/src_wasm/vcl/headless/svpprn.cxx:33:
Change-Id: Id1ae3ae246fb86516ee6b9b383a3ee23180bc277
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210987
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
As Eike indicated in https://bugs.documentfoundation.org/show_bug.cgi?id=146404#c4
COLOR format codes are preserved in ods/fods format.
The pb was the missing map back.
Indeed, we had the mapping for [COLOR<something>] => Color value (eg: "ffaa16")
but not the reverse mapping Color value => [COLOR<something>]
Eike had provided the right code pointer in xmlnumfi.cxx.
First, I thought using PaletteManager but this one is in svx and svx shouldn't be used in xmloff
(dependency pb).
Then I used ChatGpt (GPT-5.6 Luna) and it pointed the right process.
It just consisted to use a similar callback system (DECL_LINK, IMPL_LINK, LINK) of GetUserDefinedColor.
In addition, by testing all this, I noticed that maList in XColorList::GetIndexOfColor was empty.
So I added the Load call in case mbListDirty is true.
Change-Id: I0ef6b5901f2e4c757e88994412dbf79a13100ffd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210518
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
The pb appears with 0d7be893f5:
Table Style: introduce insert/delete Table... command available from
with ods pData->GetTableStyleInfo() is nullptr so buttons like "Modify"
but also "Delete" or all the "Options" part, are enabled (sensitive=true)
with xlsx pData->GetTableStyleInfo() is not null and these same buttons are disabled.
I don't know if the return of GetTableStyleInfo is ok for both cases but I don't know why
we should test this to know if these buttons should be enabled or not.
To be homogeneous, I also did the same for m_xAssignFrame.
Change-Id: Ib2295f26b53163a9612159c1564227d9b2b8ca9a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210506
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
...and are used on more than one sheet
Part of bt:
0 0x00007f2273ae44c0 in std::out_of_range::out_of_range(char const*) () at /usr/lib/x86_64-linux-gnu/libstdc++.so.6
1 0x00007f2273aaddb6 in std::__throw_out_of_range_fmt(char const*, ...) () at /usr/lib/x86_64-linux-gnu/libstdc++.so.6
2 0x00007f225147be88 in std::__sv_check (__size=1, __pos=2, __s=0x7f2250754f39 "basic_string_view::substr") at /usr/lib/gcc/x86_64-linux-gnu/15/../../../../include/c++/15/string_view:75
3 0x00007f225147bdc1 in std::basic_string_view<char16_t, std::char_traits<char16_t> >::substr (this=0x7ffd3afc7078, __pos=2, __n=18446744073709551615)
at /usr/lib/gcc/x86_64-linux-gnu/15/../../../../include/c++/15/string_view:340
4 0x00007f22520f4e5a in ScFormatRangeStyles::GetIndexOfStyleName (this=0x5618ec8485a0, rString=u"t", rPrefix=u"ce", bIsAutoStyle=@0x7ffd3afc72f7: true)
at /home/julien/lo/libreoffice/sc/source/filter/xml/XMLStylesExportHelper.cxx:709
5 0x00007f22521aa673 in ScXMLExport::AddStyleFromCells
(this=0x5618ec0dfc80, xProperties=uno::Reference to (ScCellRangesObj *) 0x5618ec7b5008, xTable=uno::Reference to (ScTableSheetObj *) 0x5618ec81a1d8, nTable=1, pOldName=0x0)
at /home/julien/lo/libreoffice/sc/source/filter/xml/xmlexprt.cxx:2128
6 0x00007f22521aea70 in ScXMLExport::collectAutoStyles (this=0x5618ec0dfc80) at /home/julien/lo/libreoffice/sc/source/filter/xml/xmlexprt.cxx:2560
7 0x00007f22521af8ca in ScXMLExport::ExportAutoStyles_ (this=0x5618ec0dfc80) at /home/julien/lo/libreoffice/sc/source/filter/xml/xmlexprt.cxx:2661
...
I noticed tdf#166939 which is similar and already fixed by Mike Kaganski with faab5ca617
"tdf#166939: Don't pass invalid starting index when creating a view
A style name can be as short as one character; a two-character prefix
can already be too long."
Since we're in a similar case (a one-character style name), let's apply the same way
but for ScFormatRangeStyles::GetIndexOfStyleName which has the extra parameter "bIsAutoStyle".
Change-Id: Ida411dec712bbf39620fd9c2919dc6b0cffe92ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209406
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
After 2016 Gsoc rework of color tab, UpdateModified is:
- useless since the color pick isn't relied with m_pColorList
- wrong since there's no case where color pick button should be disabled.
So when starting a brand new odp and right click on Area, color pick button should be enabled.
Change-Id: I5b1b0f0c3eb7e100a69379ca014eeb1b14263611
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209317
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
this can be called from different cases, at least these:
1) csv file opening
sc/source/ui/unoobj/filtuno.cxx ScFilterOptionsObj::execute, part "!bExport && aFilterString == SC_TEXT_CSV_FILTER_NAME"
(eg: tdf#171097). In this part, we added in the same commit pInStream->SetStreamEncoding(RTL_TEXTENCODING_DONTKNOW)
since we can't presume about the encoding of a csv
=> we need to call DetectEncoding
2) copy paste of 2 CJK lines in Calc from another application
sc/source/ui/view/viewfun5.cxx ScViewFunc::PasteDataFormatFormattedText,
part "nFormatId == SotClipboardFormatId::STRING || nFormatId == SotClipboardFormatId::STRING_TSVC..."
(eg: tdf#172587). In this part, we use ScImportStringStream which sets explicitely the encoding to RTL_TEXTENCODING_UNICODE
=> we don't need to call DetectEncoding
3) use of Text to Columns function (in Calc/Data)
sc/source/ui/view/cellsh2.cxx ScCellShell::ExecuteDB, part SID_TEXT_TO_COLUMNS
(eg: tdf#166299). In this part, we use a SvMemoryStream and we already sets the encoding to RTL_TEXTENCODING_UNICODE
=> we don't need to call DetectEncoding
So the changes are:
- only call DetectEncoding when the encoding of the stream is RTL_TEXTENCODING_DONTKNOW
- encoding of the csv is considered by default unknown so we call the detection afterwards
Change-Id: Id98e152a1a0a19535ed6cfc1b23387a16b122558
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209287
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
rData.sChanged.getLength() - rData.nLen can be negative
when initial data is longer than the changed data
so nSum can be negative too.
So change type of nSum so a negative value isn't transformed in a big positive value.
Also in this case, no need to check if there's some space left.
Change-Id: I9a90a7917509f332463832728e0ab705af136f0b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209186
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
Instead of selecting the first encoding returned by ucsdet_detectAll
(except the 5 CJK when they have confidence of 10), recalculate
confidence by removing 10 only when one of the 5 CJK encodings then
check each encoding returned by ucsdet_detectAll and select the one with
the max confidence with this new rule.
I also tested this again on tdf#172905, no regression.
Change-Id: I6a8e2b30e8467fefd53c02296484e48ca467c662
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209143
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Save the pFillStyleItem in FuCopy::DoExecute
so we can test it if it's a FillStyle_SOLID in CopyDlg::Reset.
If it's the case, we can use the last colors, if not we use automatic colors.
Change-Id: I2d4ea4a0d7eb5794aee3af771c51ca1e63d93ff7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209136
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
+ endianness must be remembered when it was present in the csv.
(I took example on 509ab788ba
tdf#82254 - Don't remove UTF-8 BOM from CSV when saving file
except QA test. I don't know how to do it)
Change-Id: I5043fa20c44e2e08bb43fbae0838b5d3d2f46575
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208981
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
whereas 0 is the starting point (eg for iso-8859-*)
So don't retain the CJK character sets if they're just at 10
and there's no other character sets
+ add some debug traces to track charsets detected by libicu
and their associated confidence
Change-Id: I7d89d06ffb963143276aff749e7d1a6f7a531cca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208899
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Index retrieved corresponded to blue value, that's why:
-the right circle of the first line
-the two circles from left of the second line
-the second circle of the last line
were modified.
Change-Id: I57a5334ca11f5b987d4125c88810991f83d44d42
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208817
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Regression from 5707b5dce7
tdf#101083 speed up SVG rendering with pattern fill (2)
This is the same thing I did in
commit 3cbe3a0259
Author: Noel Grandin <noel.grandin@collabora.co.uk>
Date: Mon Jun 14 15:05:59 2021 +0200
tdf#101083 speed up SVG rendering with pattern fill
but cut and paste from the VclPixelProcessor2D to the CairoPixelProcessor2D code.
Which makes this SVG render in reasonable time when using the cairo backend.
We can probably do even better by cutting out the usage of VCL here, but this
is good enough for now.
+ apply the same as af2175bb87
crashtesting: divide by zero
since:
commit 7b807a6b79
Date: Fri Jun 21 12:28:30 2024 +0200
tdf#161086 bitmap location wrong with SVG with an embedded PNG
bodge it by using the requested width/height and not the possibly
zero on fail actual sizes
Change-Id: Ie0e0462e564a568f99d1c5b9c62f71049f71f9b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208275
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
The patch fails for Windows so I put it specifically for Linux.
Done with the advice from Chatgpt (GPT-5.5)
With Python 3.14.6 from Debian testing (updated 2026-07-18) and no python in autogen.input
Traceback (most recent call last):
File "/home/julien/lo/libreoffice/workdir/UnpackedTarball/fontconfig/fc-const/./fc-const.py", line 181, in <module>
main()
~~~~^^
File "/home/julien/lo/libreoffice/workdir/UnpackedTarball/fontconfig/fc-const/./fc-const.py", line 158, in main
type=argparse.FileType('w'),
~~~~~~~~~~~~~~~~~^^^^^
File "/usr/lib/python3.14/argparse.py", line 1368, in __init__
warnings.warn(
~~~~~~~~~~~~~^
"FileType is deprecated. Simply open files after parsing arguments.",
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
category=PendingDeprecationWarning,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
stacklevel=2
^^^^^^^^^^^^
)
^
PendingDeprecationWarning: FileType is deprecated. Simply open files after parsing arguments.
Traceback (most recent call last):
File "/home/julien/lo/libreoffice/workdir/UnpackedTarball/fontconfig/fc-genericfamily/./fc-genericfamily.py", line 189, in <module>
sys.exit(main())
~~~~^^
File "/home/julien/lo/libreoffice/workdir/UnpackedTarball/fontconfig/fc-genericfamily/./fc-genericfamily.py", line 156, in main
type=argparse.FileType("w", encoding="utf-8"),
~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.14/argparse.py", line 1368, in __init__
warnings.warn(
~~~~~~~~~~~~~^
"FileType is deprecated. Simply open files after parsing arguments.",
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
category=PendingDeprecationWarning,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
stacklevel=2
^^^^^^^^^^^^
)
^
Change-Id: I5a9e319562642c94b81076a33433a29ace32f400
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208245
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
I suppose after 4fb31ea85f
tdf#105933 GSoC: New Dialog to Edit Table Styles
Following Karthic's advice, I removed all
style:font-name style:font-name-asian style:font-name-complex attributes
+ "skip exporting these in `SvxTableStylesExport::exportTextProperties`"
Change-Id: I90f440d6db7ec4024f1900c8061f1675debff6ed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/207815
Tested-by: Jenkins
Reviewed-by: Karthik Godha <karthik.godha@collabora.com>
Just launch Writer for example and notice this log on console:
warn:svx.dialog:651266:651266:svx/source/dialog/rlrcitem.cxx:75: SvxTabStopItem expected
Pb is SID_SVX_START + 946 is already used in include/svx/svxids.hrc with SID_ATTR_TABSTOP_VERTICAL
So use another free slot, SID_SVX_START + 1069
(which was indeed free contrary to what the comment said in include/svx/svxids.hrc)
Like this I suppose since 69e902d085
tdf#162120 Implement style:writing-mode-automatic (end of 2025)
Change-Id: I65c766ec1b8574fe7db5eca35bfd2c91735f3e2a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/207697
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Patch libepubgen so cover image has "cover" in its name and not "image"
+ add meta info
Adapt qa tests.
Change-Id: I0177113b113050252aac5bc2e1b5efc0a3ed2613
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/207575
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
* Update dictionaries from branch 'master'
to e13b2aa178669cb0b79610a18e97788ed7b9b3c7
- fr_FR: remove .idx file and its reference in makefile
idx are automatically generated by solenv/gbuild/Dictionary.mk
Quotation:
339 # An index for the thesaurus is generated and added to the dictionary as
340 # well.
Change-Id: Iebc9f294fa257d5d6d413fb6df3628a14a063ed2
Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/207643
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
I tried to understand the mayhem of notification/broadcast and finally gave up.
After more searching, I found that we can lock the view and that's why I used.
I hope it doesn't bring some regression but at least QA tests seem ok.
Change-Id: I067703e2c7cacd884548f768c4f2d983975a1d99
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/207477
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
I thought I could just mimick the existing mechanism to retrieve list styles
but a list style is defined with:
- 1 "text:list-style" tag which only contains the attribute "style:name"
- several (most of times 10) "text:list-level-style-number" or "text:list-level-style-bullet" subtags
Remark: these subtags contains other elements but we haven't dealt with them
I'd have hoped there was a simpler way but I haven't found it.
Change-Id: I438dbca7769f3d4110818df414f0997886180c59
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/207020
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
+ change testList QA test accordingly
TODO: in this commit we always use ordered list (since it's the example of the bugtracker)
but we should find the way to know if we must use ordered or unordered list.
Change-Id: Ibcc5281a1fae869808af7054128e412a18bec3e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205853
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
It's because by default LO also insert replacement image since svg is a vector format
but for epub we shouldn't use this mechanism.
So retrieve the old value of AddReplacementImages option and set it to false temporarily.
Change-Id: I5156c386a089fa0f88018872e546afc3a1e0b5f6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205807
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Test bLeftToRight to know if we must use StaticWhichCast with SID_ATTR_PARA_LEFT_TO_RIGHT
or SID_ATTR_PARA_RIGHT_TO_LEFT
It requires to add "TypedWhichId<SfxBoolItem>" for SID_ATTR_PARA_RIGHT_TO_LEFT
Regression from c0b0a18f5c:
Related tdf#140226: use StaticWhichCast in ww8graf+drwtxtex (sw)
Change-Id: I59f98d7b3285c12154ad69e9e2727d66ea1dfd3e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205476
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
Open Base, then Tools/Table Filter...
gives:
soffice.bin: /home/julien/lo/libreoffice/vcl/unx/gtk3/gtkinst.cxx:14618:
(anonymous namespace)::GtkInstanceTreeView::GtkInstanceTreeView(GtkTreeView *, GtkInstanceBuilder *, bool):
Assertion `!gtk_tree_view_get_show_expanders(m_pTreeView) && "a liststore can only be used if no tree structure is needed"' failed.
part of bt when asserting
4 0x00007ff19ec30424 in __assert_fail_base
(fmt=<optimized out>, assertion=<optimized out>, file=<optimized out>, line=<optimized out>, function=0x7ff18c553d4f "(anonymous namespace)::GtkInstanceTreeView::GtkInstanceTreeView(GtkTreeView *, GtkInstanceBuilder *, bool)") at ./assert/assert.c:118
5 0x00007ff18c6d6341 in (anonymous namespace)::GtkInstanceTreeView::GtkInstanceTreeView (this=0x556ee931d0b0, pTreeView=0x556eea917940, pBuilder=0x556ee93149c0, bTakeOwnership=false)
at /home/julien/lo/libreoffice/vcl/unx/gtk3/gtkinst.cxx:14618
6 0x00007ff18c6d5814 in std::make_unique<(anonymous namespace)::GtkInstanceTreeView, _GtkTreeView*&, (anonymous namespace)::GtkInstanceBuilder*, bool>
(__args=@0x7ffd2853c190: 0x556eea917940, __args=@0x7ffd2853c178: 0x556ee93149c0, __args=@0x7ffd2853c177: false) at /usr/lib/gcc/x86_64-linux-gnu/15/../../../../include/c++/15/bits/unique_ptr.h:1084
7 0x00007ff18c69ed9a in (anonymous namespace)::GtkInstanceBuilder::weld_tree_view (this=0x556ee93149c0, id="treeview") at /home/julien/lo/libreoffice/vcl/unx/gtk3/gtkinst.cxx:24074
8 0x00007ff118cee620 in dbaui::OTableSubscriptionPage::OTableSubscriptionPage
(this=0x556ee9f2bba0, pPage=0x556eea92a460, pTablesDlg=0x556ee894b490, _rCoreAttrs=SfxItemSet of pool 0x556ee92f4e00 with parent 0x0 and Which ranges: [(1, 61)] = {...})
at /home/julien/lo/libreoffice/dbaccess/source/ui/dlg/tablespage.cxx:56
9 0x00007ff118cf2c8e in std::make_unique<dbaui::OTableSubscriptionPage, weld::Container*, dbaui::OTableSubscriptionDialog*, SfxItemSet&>
(__args=@0x7ffd2853c410: 0x556eea92a460, __args=@0x7ffd2853c408: 0x556ee894b490, __args=SfxItemSet of pool 0x556ee92f4e00 with parent 0x0 and Which ranges: [(1, 61)] = {...})
Change-Id: I629acb671ce0d1baaa83f3740109487ffdef2d8e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205025
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Python script used:
import re
from pathlib import Path
def transform(content: str) -> str:
i = 0
out = []
n = len(content)
while i < n:
if content.startswith("SfxItemSetFixed<", i):
i += len("SfxItemSetFixed<")
# --- parse template <...> avec équilibrage ---
depth = 1
start = i
while i < n and depth > 0:
if content[i] == '<':
depth += 1
elif content[i] == '>':
depth -= 1
i += 1
template = content[start:i-1]
# --- skip espaces ---
while i < n and content[i].isspace():
i += 1
# --- variable ---
m = re.match(r'[A-Za-z_]\w*', content[i:])
if not m:
out.append("SfxItemSetFixed<" + template + ">")
continue
var = m.group(0)
i += len(var)
# --- skip espaces ---
while i < n and content[i].isspace():
i += 1
# --- arguments (...) ---
if i >= n or content[i] != '(':
out.append("SfxItemSetFixed<" + template + ">" + var)
continue
i += 1
depth = 1
start = i
while i < n and depth > 0:
if content[i] == '(':
depth += 1
elif content[i] == ')':
depth -= 1
i += 1
args = content[start:i-1]
# --- remplacement ---
out.append(f"SfxItemSet {var}(SfxItemSet::makeFixedSfxItemSet<{template}>({args}))")
else:
out.append(content[i])
i += 1
return ''.join(out)
def process_file(path: Path):
text = path.read_text(encoding="utf-8")
new_text = transform(text)
if new_text != text:
backup = path.with_suffix(path.suffix + ".bak")
backup.write_text(text, encoding="utf-8")
path.write_text(new_text, encoding="utf-8")
print(f"Updated: {path}")
# --- scan files ---
for ext in ("*.cxx", "*.hxx"):
for file in Path(".").rglob(ext):
process_file(file)
Change-Id: I6b90d403777422d0d7aaa7b49bc117e653441eb7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203935
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
Julien Nabet