ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

Fix FIXME comment + add extra info

Browse Source 
Change-Id: I80cbe8bd38104229807ea467d95cec4b4edd5d53
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/204470
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
This commit is contained in:
Julien Nabet
2026-04-27 17:48:45 +02:00
parent c1ab7ab723
commit 73bbc860d1
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sd/source/ui/func/fupage.cxx
+5 -2
View File
@@ -534,8 +534,10 @@ void FuPage::ApplyItemSet( const SfxItemSet* pArgs )
if( pArgs->GetItemState(mrDoc.GetPool().GetWhichIDFromSlotID(SID_ATTR_LRSPACE),
true, &pPoolItem) == SfxItemState::SET )
{
// FIXME for tdf#140226: using static_cast<const SvxULSpaceItem*>(pPoolItem)
// FIXME for tdf#140226: using pPoolItem->StaticWhichCast(SID_ATTR_LRSPACE)->ResolveLeft/Right
// makes UITest_impress_tests fail
// more precisely tdf134734.TestClass.test_master_page_background
// for the record, pPoolItem->StaticWhichCast(EE_PARA_LRSPACE)->ResolveLeft/Right works
nLeft = static_cast<const SvxLRSpaceItem*>(pPoolItem)->ResolveLeft();
nRight = static_cast<const SvxLRSpaceItem*>(pPoolItem)->ResolveRight({});
@@ -547,8 +549,9 @@ void FuPage::ApplyItemSet( const SfxItemSet* pArgs )
if( pArgs->GetItemState(mrDoc.GetPool().GetWhichIDFromSlotID(SID_ATTR_ULSPACE),
true, &pPoolItem) == SfxItemState::SET )
{
// FIXME for tdf#140226: using static_cast<const SvxULSpaceItem*>(pPoolItem)
// FIXME for tdf#140226: using pPoolItem->StaticWhichCast(SID_ATTR_ULSPACE)->GetUpper/Lower
// makes UITest_impress_tests fail
// more precisely tdf134734.TestClass.test_master_page_background
nUpper = static_cast<const SvxULSpaceItem*>(pPoolItem)->GetUpper();
nLower = static_cast<const SvxULSpaceItem*>(pPoolItem)->GetLower();