ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

-Werror,-Wimplicit-fallthrough in vcl

Browse Source 
/home/julien/lo/libo_perf/vcl/unx/generic/dtrans/bmp.cxx:123:9: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
  123 |         default:
      |         ^
/home/julien/lo/libo_perf/vcl/unx/generic/dtrans/bmp.cxx:123:9: note: insert '[[fallthrough]];' to silence this warning
  123 |         default:
      |         ^
      |         [[fallthrough]];
/home/julien/lo/libo_perf/vcl/unx/generic/dtrans/bmp.cxx:123:9: note: insert 'break;' to avoid fall-through
  123 |         default:
      |         ^
      |         break;
1 error generated.

when with don't use enable-debug.
So we need #ifdef NDEBUG/#endif to not have "unreachable code" error.

Change-Id: I15b8b2af79d13de0140522d4537f85951b2c55d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/207195
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
This commit is contained in:
Julien Nabet
2026-06-23 21:51:30 +02:00
parent 2123854706
commit 3fceaee085
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
vcl/unx/generic/dtrans/bmp.cxx
+3
View File
@@ -120,6 +120,9 @@ static sal_uInt8* X11_getPaletteBmpFromImage(
break;
case 1:
assert(false);
#ifdef NDEBUG
[[fallthrough]];
#endif
default:
case 8:
nHeaderSize = 1084;