ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
520,958 Commits 3 Branches 3 Tags
main
Commit Graph
196 Commits
Author SHA1 Message Date
Andrea Gelmini 37e1aec4ed Fix typos 
Change-Id: I121af263271437cf4013ef006d401a06ba3507b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210444
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2026-09-03 08:54:54 +02:00
Andrea Gelmini 30cc365def Fix typos 
Change-Id: I42e6c0c272cd5b83bb2747d938049a64d4b19936
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210443
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
 2026-09-03 08:50:28 +02:00
Andrea Gelmini 4f86cfa577 Fix typos 
Change-Id: Ic09e8f2877a7106eb074586662d1733828d85197
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209422
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
 2026-08-21 14:19:46 +02:00
Mike Kaganski 315349828a Fix --enable-werror gcc build on Linux 
Commit 8ed30e4a243a3efdfe380852d20910bc4a02e181 (Move ToolboxController
to use OPropertyContainerImplHelper, 2026-04-10) introduced cases similar
to the problem handled in commit 3917b082b9f4530d305cd947ab47658f6883c4f1
(Fix --enable-werror gcc build on Linux, 2026-04-09).

In file included from /home/mk/core/framework/inc/uielement/complextoolbarcontroller.hxx:28,
                 from /home/mk/core/framework/inc/uielement/comboboxtoolbarcontroller.hxx:24,
                 from /home/mk/core/framework/source/uielement/comboboxtoolbarcontroller.cxx:20:
/home/mk/core/include/svtools/toolboxcontroller.hxx:86:31: error: ‘virtual void svt::ToolboxController::disposing(const com::sun::star::lang::EventObject&)’ was hidden [-Werror=overloaded-virtual=]
   86 |         virtual void SAL_CALL disposing( const css::lang::EventObject& Source ) override;
      |                               ^~~~~~~~~
/home/mk/core/framework/inc/uielement/comboboxtoolbarcontroller.hxx:44:22: note:   by ‘virtual void framework::ComboboxToolbarController::disposing(std::unique_lock<std::mutex>&)’
   44 |         virtual void disposing(std::unique_lock<std::mutex>& rGuard) override;
      |                      ^~~~~~~~~

Change-Id: Ic41be4d39b032864c3427d17a85502e36f31dce9
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/757
Reviewed-by: Justin Luth <justin.luth@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit e95308f8dc2e5c1088686eaa1552126eea9745d0)
(cherry picked from commit d6a555ec61272006e801764dd46a493bbbf3e90a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205689
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-26 00:41:16 +02:00
Mike Kaganski bce4bc55f9 Move ToolboxController to use OPropertyContainerImplHelper 
Quite a large inheritance chain, which all needed replace dispose
with disposing, and make sure the locking is correct.

Introduce comphelper::unique_unlock, RAII class for scoped release
of std::unique_lock, to help ensure the invariant established in
commit 4fc1ab0ca8d9bb0f0b8344d0537882aab1d6d2c0 (add assert to keep
WeakComponentImplHelperBase::disposing callees honest, 2026-04-04).

Change-Id: I72c98c25c01b8042428ef2376c6aba3c6b15ec87
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/248
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit 8ed30e4a243a3efdfe380852d20910bc4a02e181)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205688
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-26 00:41:07 +02:00
Andrea Gelmini 1a70694e33 Fix typo "then"->"than" + "its" -> "it's" 
Change-Id: I5386ca02fdcd415eb56f9a593d180ac991d88656
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202914
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
 2026-03-29 09:50:27 +02:00
Andrea Gelmini 6da6760ed1 Fix typo "then"->"than" + "its" -> "it's" 
Change-Id: I824cee5fe1ad6596e99ab0423797cefa29c81139
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202915
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2026-03-29 09:47:37 +02:00
Mike Kaganski c19cd51da5 Fix Windows non-PCH build after "more forward declarations" change 
C:\lo\core\include\cppu/unotype.hxx(300): error C2665: 'cppu::detail::cppu_detail_getUnoType': no overloaded function could convert all the argument types
 C:\lo\build\workdir\UnoApiHeadersTarget\udkapi\normal\com/sun/star/beans/NamedValue.hpp(45): note: could be 'const com::sun::star::uno::Type &com::sun::star::beans::cppu_detail_getUnoType(const com::sun::star::beans::NamedValue *)' [found using argument-dependent lookup]
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &com::sun::star::beans::cppu_detail_getUnoType(const com::sun::star::beans::NamedValue *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const com::sun::star::beans::NamedValue *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\build\workdir\UnoApiHeadersTarget\udkapi\normal\com/sun/star/beans/XFastPropertySet.hpp(69): note: or       'const com::sun::star::uno::Type &com::sun::star::beans::cppu_detail_getUnoType(const com::sun::star::beans::XFastPropertySet *)' [found using argument-dependent lookup]
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &com::sun::star::beans::cppu_detail_getUnoType(const com::sun::star::beans::XFastPropertySet *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const com::sun::star::beans::XFastPropertySet *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\build\workdir\UnoApiHeadersTarget\udkapi\normal\com/sun/star/beans/XPropertiesChangeListener.hpp(60): note: or       'const com::sun::star::uno::Type &com::sun::star::beans::cppu_detail_getUnoType(const com::sun::star::beans::XPropertiesChangeListener *)' [found using argument-dependent lookup]
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &com::sun::star::beans::cppu_detail_getUnoType(const com::sun::star::beans::XPropertiesChangeListener *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const com::sun::star::beans::XPropertiesChangeListener *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\build\workdir\UnoApiHeadersTarget\udkapi\normal\com/sun/star/beans/XMultiPropertySet.hpp(91): note: or       'const com::sun::star::uno::Type &com::sun::star::beans::cppu_detail_getUnoType(const com::sun::star::beans::XMultiPropertySet *)' [found using argument-dependent lookup]
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &com::sun::star::beans::cppu_detail_getUnoType(const com::sun::star::beans::XMultiPropertySet *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const com::sun::star::beans::XMultiPropertySet *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\build\workdir\UnoApiHeadersTarget\udkapi\normal\com/sun/star/beans/XPropertySetOption.hpp(59): note: or       'const com::sun::star::uno::Type &com::sun::star::beans::cppu_detail_getUnoType(const com::sun::star::beans::XPropertySetOption *)' [found using argument-dependent lookup]
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &com::sun::star::beans::cppu_detail_getUnoType(const com::sun::star::beans::XPropertySetOption *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const com::sun::star::beans::XPropertySetOption *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\build\workdir\UnoApiHeadersTarget\udkapi\normal\com/sun/star/beans/XVetoableChangeListener.hpp(60): note: or       'const com::sun::star::uno::Type &com::sun::star::beans::cppu_detail_getUnoType(const com::sun::star::beans::XVetoableChangeListener *)' [found using argument-dependent lookup]
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &com::sun::star::beans::cppu_detail_getUnoType(const com::sun::star::beans::XVetoableChangeListener *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const com::sun::star::beans::XVetoableChangeListener *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\build\workdir\UnoApiHeadersTarget\udkapi\normal\com/sun/star/beans/XPropertySetInfo.hpp(73): note: or       'const com::sun::star::uno::Type &com::sun::star::beans::cppu_detail_getUnoType(const com::sun::star::beans::XPropertySetInfo *)' [found using argument-dependent lookup]
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &com::sun::star::beans::cppu_detail_getUnoType(const com::sun::star::beans::XPropertySetInfo *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const com::sun::star::beans::XPropertySetInfo *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\build\workdir\UnoApiHeadersTarget\udkapi\normal\com/sun/star/beans/Property.hpp(81): note: or       'const com::sun::star::uno::Type &com::sun::star::beans::cppu_detail_getUnoType(const com::sun::star::beans::Property *)' [found using argument-dependent lookup]
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &com::sun::star::beans::cppu_detail_getUnoType(const com::sun::star::beans::Property *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const com::sun::star::beans::Property *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\build\workdir\UnoApiHeadersTarget\udkapi\normal\com/sun/star/beans/XPropertyChangeListener.hpp(59): note: or       'const com::sun::star::uno::Type &com::sun::star::beans::cppu_detail_getUnoType(const com::sun::star::beans::XPropertyChangeListener *)' [found using argument-dependent lookup]
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &com::sun::star::beans::cppu_detail_getUnoType(const com::sun::star::beans::XPropertyChangeListener *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const com::sun::star::beans::XPropertyChangeListener *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\build\workdir\UnoApiHeadersTarget\udkapi\normal\com/sun/star/beans/PropertyChangeEvent.hpp(92): note: or       'const com::sun::star::uno::Type &com::sun::star::beans::cppu_detail_getUnoType(const com::sun::star::beans::PropertyChangeEvent *)' [found using argument-dependent lookup]
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &com::sun::star::beans::cppu_detail_getUnoType(const com::sun::star::beans::PropertyChangeEvent *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const com::sun::star::beans::PropertyChangeEvent *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\build\workdir\UnoApiHeadersTarget\udkapi\normal\com/sun/star/beans/UnknownPropertyException.hpp(54): note: or       'const com::sun::star::uno::Type &com::sun::star::beans::cppu_detail_getUnoType(const com::sun::star::beans::UnknownPropertyException *)' [found using argument-dependent lookup]
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &com::sun::star::beans::cppu_detail_getUnoType(const com::sun::star::beans::UnknownPropertyException *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const com::sun::star::beans::UnknownPropertyException *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\build\workdir\UnoApiHeadersTarget\udkapi\normal\com/sun/star/beans/PropertyVetoException.hpp(54): note: or       'const com::sun::star::uno::Type &com::sun::star::beans::cppu_detail_getUnoType(const com::sun::star::beans::PropertyVetoException *)' [found using argument-dependent lookup]
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &com::sun::star::beans::cppu_detail_getUnoType(const com::sun::star::beans::PropertyVetoException *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const com::sun::star::beans::PropertyVetoException *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\build\workdir\UnoApiHeadersTarget\udkapi\normal\com/sun/star/beans/XPropertySet.hpp(97): note: or       'const com::sun::star::uno::Type &com::sun::star::beans::cppu_detail_getUnoType(const com::sun::star::beans::XPropertySet *)' [found using argument-dependent lookup]
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &com::sun::star::beans::cppu_detail_getUnoType(const com::sun::star::beans::XPropertySet *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const com::sun::star::beans::XPropertySet *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\core\include\cppu/unotype.hxx(253): note: or       'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const com::sun::star::uno::XInterface *)'
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const com::sun::star::uno::XInterface *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const com::sun::star::uno::XInterface *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\core\include\cppu/unotype.hxx(247): note: or       'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const com::sun::star::uno::Exception *)'
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const com::sun::star::uno::Exception *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const com::sun::star::uno::Exception *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\core\include\cppu/unotype.hxx(221): note: or       'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const com::sun::star::uno::Any *)'
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const com::sun::star::uno::Any *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const com::sun::star::uno::Any *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\core\include\cppu/unotype.hxx(215): note: or       'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const com::sun::star::uno::Type *)'
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const com::sun::star::uno::Type *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const com::sun::star::uno::Type *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\core\include\cppu/unotype.hxx(210): note: or       'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const rtl::OUString *)'
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const rtl::OUString *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const rtl::OUString *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\core\include\cppu/unotype.hxx(204): note: or       'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const sal_Unicode *)'
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const sal_Unicode *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const sal_Unicode *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\core\include\cppu/unotype.hxx(197): note: or       'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const cppu::UnoCharType *)'
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const cppu::UnoCharType *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const cppu::UnoCharType *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\core\include\cppu/unotype.hxx(192): note: or       'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const double *)'
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const double *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const double *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\core\include\cppu/unotype.hxx(187): note: or       'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const float *)'
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const float *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const float *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\core\include\cppu/unotype.hxx(181): note: or       'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const sal_uInt64 *)'
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const sal_uInt64 *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const sal_uInt64 *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\core\include\cppu/unotype.hxx(176): note: or       'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const sal_Int64 *)'
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const sal_Int64 *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const sal_Int64 *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\core\include\cppu/unotype.hxx(170): note: or       'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const sal_uInt32 *)'
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const sal_uInt32 *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const sal_uInt32 *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\core\include\cppu/unotype.hxx(165): note: or       'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const sal_Int32 *)'
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const sal_Int32 *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const sal_Int32 *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\core\include\cppu/unotype.hxx(159): note: or       'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const sal_uInt16 *)'
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const sal_uInt16 *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const sal_uInt16 *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\core\include\cppu/unotype.hxx(149): note: or       'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const cppu::UnoUnsignedShortType *)'
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const cppu::UnoUnsignedShortType *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const cppu::UnoUnsignedShortType *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\core\include\cppu/unotype.hxx(144): note: or       'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const sal_Int16 *)'
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const sal_Int16 *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const sal_Int16 *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\core\include\cppu/unotype.hxx(139): note: or       'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const sal_Int8 *)'
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const sal_Int8 *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const sal_Int8 *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\core\include\cppu/unotype.hxx(134): note: or       'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const sal_Bool *)'
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const sal_Bool *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const sal_Bool *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\core\include\cppu/unotype.hxx(129): note: or       'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const bool *)'
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const bool *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const bool *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\core\include\cppu/unotype.hxx(124): note: or       'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const cppu::UnoVoidType *)'
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const cppu::UnoVoidType *)': cannot convert argument 1 from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *' to 'const cppu::UnoVoidType *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
 C:\lo\core\include\cppu/unotype.hxx(260): note: or       'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const com::sun::star::uno::Reference<interface_type> *)'
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const com::sun::star::uno::Reference<interface_type> *)': could not deduce template argument for 'const com::sun::star::uno::Reference<interface_type> *' from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *'
 C:\lo\core\include\cppu/unotype.hxx(240): note: or       'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const com::sun::star::uno::Sequence<E> *)'
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const com::sun::star::uno::Sequence<E> *)': could not deduce template argument for 'const com::sun::star::uno::Sequence<E> *' from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *'
 C:\lo\core\include\cppu/unotype.hxx(227): note: or       'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const cppu::UnoSequenceType<T> *)'
 C:\lo\core\include\cppu/unotype.hxx(300): note: 'const com::sun::star::uno::Type &cppu::detail::cppu_detail_getUnoType(const cppu::UnoSequenceType<T> *)': could not deduce template argument for 'const cppu::UnoSequenceType<T> *' from 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *'
 C:\lo\core\include\cppu/unotype.hxx(300): note: while trying to match the argument list '(cppu::UnoType<com::sun::star::beans::PropertyValue>::get::T1 *)'
 C:\lo\core\include\cppu/unotype.hxx(300): note: the template instantiation context (the oldest one first) is
 C:\lo\core\include\framework/addonsoptions.hxx(56): note: see reference to class template instantiation 'com::sun::star::uno::Sequence<com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>>' being compiled
 C:\lo\core\include\com/sun/star/uno/Sequence.hxx(59): note: while compiling class template member function 'com::sun::star::uno::Sequence<com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>>::Sequence(void)'
 C:\lo\core\include\framework/addonsoptions.hxx(57): note: see the first reference to 'com::sun::star::uno::Sequence<com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>>::Sequence' in 'framework::MergeMenuInstruction::MergeMenuInstruction'
 C:\lo\core\include\com/sun/star/uno/Sequence.hxx(60): note: see reference to function template instantiation 'const com::sun::star::uno::Type &cppu::getTypeFavourUnsigned<com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>>(const com::sun::star::uno::Sequence<com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>> *)' being compiled
 C:\lo\core\include\com/sun/star/uno/Sequence.hxx(332): note: see reference to function template instantiation 'const com::sun::star::uno::Type &cppu::getTypeFavourUnsigned<com::sun::star::beans::PropertyValue>(const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> *)' being compiled
 C:\lo\core\include\com/sun/star/uno/Sequence.hxx(332): note: see reference to function template instantiation 'const com::sun::star::uno::Type &cppu::getTypeFavourUnsigned<com::sun::star::beans::PropertyValue>(const T *)' being compiled
 with
 [
 T=com::sun::star::beans::PropertyValue
 ]
 C:\lo\core\include\cppu/unotype.hxx(325): note: see reference to class template instantiation 'cppu::UnoType<com::sun::star::beans::PropertyValue>' being compiled
 C:\lo\core\include\cppu/unotype.hxx(292): note: while compiling class template member function 'const com::sun::star::uno::Type &cppu::UnoType<com::sun::star::beans::PropertyValue>::get(void)'
 C:\lo\core\include\cppu/unotype.hxx(325): note: see the first reference to 'cppu::UnoType<com::sun::star::beans::PropertyValue>::get' in 'cppu::getTypeFavourUnsigned'
 C:\lo\core\include\com/sun/star/uno/Sequence.hxx(332): note: see the first reference to 'cppu::getTypeFavourUnsigned' in 'cppu::getTypeFavourUnsigned'
 C:\lo\core\include\com/sun/star/uno/Sequence.hxx(332): note: see the first reference to 'cppu::getTypeFavourUnsigned' in 'cppu::getTypeFavourUnsigned'
 C:\lo\core\include\com/sun/star/uno/Sequence.hxx(60): note: see the first reference to 'cppu::getTypeFavourUnsigned' in 'com::sun::star::uno::Sequence<com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>>::Sequence'
 C:\lo\core\include\framework/addonsoptions.hxx(57): note: see the first reference to 'com::sun::star::uno::Sequence<com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>>::Sequence' in 'framework::MergeMenuInstruction::MergeMenuInstruction'

Change-Id: I03af3e11adef9b6ca827e764fd43bf873a56e709
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200157
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2026-02-24 13:40:06 +01:00
Gabor Kelemen 1d9b441da8 tdf#146619 Use more forward declarations in include/framework 
Change-Id: I7a41c72fbd16fcde45c59ec19814be7962ded194
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199384
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
 2026-02-21 14:59:51 +01:00
Heiko Tietze a4341164a1 Resolves tdf#38850 - Allow configuration of toolbars 
Toggle on/off for visibility, locked state, and sensitivity,
the latter behind ExperimentalMode as it works only to suppress
the toolbar but not to make it always visible

Change-Id: Ia65a27045472d42fc013970bf9de64320f2dbcdc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195836
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Jenkins
 2026-02-14 08:36:52 +01:00
Michael Weghorn e22352dcaf framework: Move layoutmanager.hxx to top-level include/ 
Move the so far framework-internal headers layoutmanager.hxx
and the uielement.hxx one that it includes to the
top-level include/ directory and mark LayoutManager as
FWK_DLLPUBLIC.

This is to prepare for a new version of Heiko's [1]
that doesn't require UNO API changes, but can use
the LayoutManager class directly.

[1] https://gerrit.libreoffice.org/c/core/+/195836/9

Change-Id: I7439274c29814ef23c6fde11770e1519e54bc0b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197338
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Jenkins
 2026-02-14 08:36:24 +01:00
Gabor Kelemen 96cb87ca01 tdf#146619 Use more forward declarations in include/vcl/[a-o] 
these were skipped in previous runs, since they contain some code behind #if

After inspecting these, it seems like the removals should not cause trouble.

Change-Id: I867ffc53254057e4bae43690214a2ab7ce0caa8f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197493
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
Tested-by: Jenkins
 2026-01-22 09:42:36 +01:00
Michael Weghorn 3bbc98757a weld: Move weld::Toolbar to own header 
Move the class out of weld.hxx into its own header, in
order to make it easier to keep an overview and to avoid
having to recompile ~all UI code when the class is
modified.

Change-Id: Ie54aef229609f131d3d53874c9390339566880f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196947
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2026-01-10 23:19:56 +01:00
Gabor Kelemen 3896908d68 tdf#146619 Run IWYU again on include/[f-i]* 
Change-Id: Id9ee32e8583c3917fbe927a070f5ad3b5f6f3b9d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192745
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
 2025-11-08 22:01:12 +01:00
Simon Chenery da79780f43 tdf#143148 replace include guards with pragma once in dir include/framework 
Change-Id: I9e4c1033ea6624d8fe9861968402d6a3e756c966
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190190
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2025-10-03 10:49:05 +02:00
Aung 8ce2cf3973 tdf#41777 Add window size and position for each document 
-Extend ViewDataSupplier to work with window state for supported
 applications like sw, sc, sd
-Extend sm DocumentPropertySupplier to work with window state
-Add OldWindowState string member to SfxViewShell inherited
 classes for sw, sc and sd
-Add OldWindowState string member to SmDocShell class for sm

 Imported window state is stored in the model shells
 or the ViewShells if available. This data is accessed by services
 like ViewDataSupplier and DocumentPropertySupplier used by
 persistentwindowstate.cxx. It is needed to store the window state
 data since frame is not available to get to resize
 and reposition by the time importing document has finished.

-Add windowstatehelper header and source files in the framework
 module for getting/exporting the size and position of
 windows. Also add associated file and library to make files for
 exporting/using these helper methods across different modules.

-Modify impl_searchRecycleTarget method in loadenv.cxx

 New frames are created for saved documents when launched from
 the start center. This is to apply their own window state
 separately from the backing window.
 New docs and templates still recycle the backing window frame.

-Make the backing window close afterwards after the new frame has
 been created and the document gets loaded successfully
 (modified in loadenv.cxx)



Change-Id: Ia5ad606e744621f267dae6cd468b0c430b2ebf1d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185189
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
 2025-09-24 06:44:43 +02:00
Noel Grandin e2b2eec732 BitmapEx->Bitmap in AddonsOptions 
now that Bitmap can handle transparency

Change-Id: Iaa82c9596c27409b1361bd430f2d6b7eaf4eefd3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188817
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-08-02 13:33:13 +02:00
Noel Grandin 03caa7db14 tdf#167073 Extension MRI does not start 
revert
    commit 39f2c62847
    simplify TaskCreatorService
and
    commit 96b6d13c9a.
    [API CHANGE] no need for TaskCreatorService to be exposed via UNO

I missed that this service is in use.

Change-Id: I97b01668f7ba313335f9fbd8cf0e398dfc1b5ca0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186643
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-06-18 15:26:32 +02:00
Noel Grandin 39f2c62847 simplify TaskCreatorService 
now that it is no longer an UNO service, we can simplify it,
and returning a more explicit type.

Change-Id: Ibd0f56e04ac26f09b57dc295febcf26202f16a2a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186495
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-06-14 19:34:10 +02:00
Noel Grandin 96b6d13c9a [API CHANGE] no need for TaskCreatorService to be exposed via UNO 
This is a purely internal usage thing.

Change-Id: I8d13d21c791bc88a2fc288fb97f7877eecab3e73
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186494
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-06-14 19:34:01 +02:00
Gabor Kelemen 72df5a6fdf Drop unneeded forward declarations from include/ 
test drive the new bin/find-unneeded-includes --fwdecl mode

Change-Id: I507fa2b172ec9e348d1d91066ea241f02187b5ed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179321
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2025-01-03 09:32:27 +01:00
lynn_edem 961f8bdce4 tdf#143148 Use #pragma once instead of include guards 
Change-Id: I3ff0f661a3b4109b79ec13dad4e3472378048ec7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175705
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
 2024-11-03 11:05:46 +01:00
Noel Grandin ca8c59c7e6 use more concrete UNO type in framework 
Change-Id: I3ee54f3967339ab52c04f48a047bc29fc5161680
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173159
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-09-11 16:14:54 +02:00
Noel Grandin 6e4ba9b13d convert TitleHelper to comphelper::WeakImplHelper 
Change-Id: I81571a0786a4d13e049dba82ba6e4f3509887fa4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165572
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-03-30 18:01:46 +01:00
Noel Grandin 8ef4dc07cd improve loplugin:staticmethods 
Some of the exclusions were too aggressive. Restrict them to only the
important classes, which exposes some more places this plugin applies.

Change-Id: I1b2d1fb24391adc71ed0984f94168f61a149479f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165154
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-03-22 11:47:36 +01:00
Noel Grandin cd35a509ef reduce symbol visibility in --enable-mergelibs=more mode 
Change-Id: If811c9ec336543227db73c990248b9113846cf2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164657
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-03-13 08:14:38 +01:00
Noel Grandin 033aaeec9e use more UNLESS_MERGELIBS 
Change-Id: I351a9127fb26369d8f598b6d6519d7e490fa476b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163190
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-02-12 20:25:54 +01:00
Gabor Kelemen f8cd283749 Rewrite bin/find-unusedheaders.py 
This script was broken, not only in the implementation
(it gives too many false positives in a suspiciously short, <1s time)
but in its approach as well: only considering stuff that is compiled
under Linux inherently leaves out other platform specific or experimental
stuff.

Rewrite it using another approach: grep for mentions of each
header in the modules or global ones in include/ everywhere.

Runtime of this script is about 15 minutes, seems to give only
a few relevant hits.

Change-Id: Ifb92f41f11ca9a2bf14eec617a469003becb78fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161234
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
 2023-12-24 11:50:26 +01:00
Stephan Bergmann bd6fb0cd3e Extended loplugin:ostr: Rewrite some O[U]StringLiteral -> O[U]String 
...in include files.  This is a mix of automatic rewriting in include files and
manual fixups (mostly addressing loplugin:redundantfcast) in source files that
include those.

Change-Id: I1f3cc1e67b9cabd2e9d61a4d9e9a01e587ea35cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158337
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2023-10-23 11:04:42 +02:00
Noel Grandin 37a4d67d68 flatten DocumentUndoGuard 
which is a small object, and doesn't need a pimpl pattern

Change-Id: Ib76f6e5ad0347be61fe29b22f57e1211ce3337cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148172
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-03-03 13:44:15 +00:00
Stephan Bergmann 19691c3b68 Revert all the recent loplugin:unocast changes 
...as obsoleted by ef53355355 "Rudimentary support
for dynamic_cast on UNO proxy objects".

This reverts all of:
4cfcc9ac37 "loplugin:unocast (framework::Desktop)"
03efbf72f4 "loplugin:unocast
 (vclcanvas::TextLayout)"
80099fdd51 "loplugin:unocast (SalGtkXWindow)"
cc147f576d "loplugin:unocast
 (sdext::presenter::CachablePresenterView)"
40db42be1d "loplugin:unocast
 (vclcanvas::CanvasFont)"
2d1e7995ea "loplugin:unocast (CairoColorSpace)"
4c0bbe4bd9 "loplugin:unocast
 (canvas::ParametricPolyPolygon)"
8980366662 "loplugin:unocast
 (vclcanas::CanvasBitmap)"
d5e0c2c8db "loplugin:unocast
 (sfx2::DigitalSignatures)"
c0c4519e0d "loplugin:unocast
 (VCLXAccessibleComponent)"
feb8b833a6 "loplugin:unocast (VCLXDialog)"
1fa58cc6cc "loplugin:unocast (VCLXMultiPage)"
f481f036de "loplugin:unocast
 (DocumentSettingsSerializer)"
73df933f5f "loplugin:unocast
 (css::embed::EmbeddedUpdate)"
420165ab0e "loplugin:unocast
 (canvas::tools' StandardColorSpace, StandardNoAlphaColorSpace)"
9abe8ee067 "loplugin:unocast (MutableTreeNode)"
9f3022ceb0 "loplugin:unocast (VCLXTabPage)"
1be70dda02 "loplugin:unocast
 (vcl::unotools::VclCanvasBitmap)"
d6a70bb641 "loplugin:unocast
 (basegfx::unotools::UnoPolyPolygon)"
5a14f009e6 "loplugin:unocast
 (xmlsecurity::Certificate)"
99009c9535 "loplugin:unocast (sd::Annotation)"
0c7585c5fa "loplugin:unocast (sd::TextApiObject)"
24e14afd1b "loplugin:unocast
 (SignatureVerifierImpl)"
1a7ad0c10d "loplugin:unocast
 (pcr::PropertyEventTranslation)"
a97e2d2702 "loplugin:unocast (RangePageBreaks)"
19dfdf86ad "iloplugin:unocast
 (pcr::OFormattedNumericControl)"
f9785ea595 "loplugin:unocast
 (frm::OInterfaceContainer)"
5e5f40a4a9 "loplugin:unocast (ScVbaShapes)"
27b35b2c21 "loplugin:unocast (ScVbaShapeRange)"
cb3108f860 "cid#1517812 Dereference null return
 value"
feba0ddb15 "loplugin:unocast
 (weld::TransportAsXWindow)"
4d6c232165 "loplugin:unocast
 (oox::ForumlaImExportBase)"
4844c096a8 "loplugin:unocast
 (cairocanvas::SurfaceProvider)"
9a0b523e0a "loplugin:unocast
 (cairocanvas::CanvasBitmap)"
8a5648d8e5 "loplugin:unocast
 (cairocanvas::TextLayout)"
28c27a0623 "loplugin:unocast
 (cairocanvas::CanvasFont)"
53bc223cb3 "loplugin:unocast
 (cairocanvas::RepaintTarget)"
5f70b0b9f6 "loplugin:unocast (SvXMLImport)"
068187a898 "loplugin:unocast (VCLXWindow)"
88b4f96620 "loplugin:unocast
 (sfx2::sidebar::SidebarController)"
f1b7a69b28 "loplugin:unocast
 (SvxLineStyleToolBoxControl)"
ba76f0ba7e "loplugin:unocast
 (i18npool::Calendar_gregorian)"
840154daf9 "loplugin:unocast
 (framework::AddonsToolBarWrapper)"
b0e9c4c5f0 "loplugin:unocast
 (GrammarCheckingIterator)"
8ee6cfc965 "loplugin:unocast
 (ucb::ucp::ext::Content)"
5b8cd77c11 "loplugin:unocast
 (basic::SfxScriptLibraryContainer)"
9e73ff9fce "loplugin:unocast
 (sdext::presenter::PresenterNotesView)"
a98acca8fb "loplugin:unocast
 (SelectionChangeHandler)"
c0b59ad6e3 "Consistently use
 comphelper::getSomethingImpl<I>(aIdentifier, this)"
276e3ccbdd "loplugin:unocast
 (vclcanvas::RepaintTarget)"

Change-Id: I37c73e3422a5154bf6cb647640d2d3f23db8bc34
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145063
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2023-01-05 11:45:51 +00:00
Stephan Bergmann 4cfcc9ac37 loplugin:unocast (framework::Desktop) 
(See the upcoming commit introducing that loplugin:unocast on why such
dynamic_casts from UNO types are dangerous.)

Change-Id: Ifcf713b0543e78a124f613bcbda496069a280dab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144762
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-12-23 22:57:07 +00:00
Maxim Monastirsky dbeb697d62 tdf#149956 Rework toolbar image flipping 
An unified code, covering both vcl and weld cases. For
SidebarToolBox, the controller is created before items
are inserted, so we listen for item insert event to set
initially correct state.

Change-Id: I3841f21883104b4d3f8541c97ec7fa5fc0bec575
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139022
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
 2022-08-30 13:08:39 +02:00
Maxim Monastirsky 4fb8c0d14c tdf#149741 tdf#149956 Make flipping work also in the sidebar 
- Reset the icon each time, as there seems to be no easy
way to retrieve the existing icon from a gtk widget in
order to mirror it, like we used to do for vcl. Similar
approach is currently taken in
ToolboxButtonColorUpdaterBase::Update.

- Store the flipping state also in GtkInstanceToolbar,
similar to vcl's ToolBox. This seems to be the easiest
way to make flipping not break on icon theme change,
covering all 4 cases (ToolBarManager, SidebarToolBox,
ToolbarUnoDispatcher, GenericToolbarController), w/o
too involved changes in each. This might benefit from
some refactoring later on, but should be good enough
for now.

- One unsolved problem is the appearance of flipped
icons with svg themes, as the regular variant is handed
to gtk directly, whereas the flipped one is loaded by us,
resulting with a different (blurry) look.

Change-Id: I48c16827b46fb75fd798a041851af6e2648ae8fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139021
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
 2022-08-30 13:08:03 +02:00
Andrea Gelmini 4827d5cb15 Removed executable bits from source file 
Change-Id: I0f36bec337e6167668a0fccd48b5a047327a9215
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137374
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2022-07-23 17:53:38 +02:00
PoonamShokeen 053f470316 tdf#143148 Use pragma once instead of include guards 
Change-Id: I7061e0985c51910ba6a8b862cd755b8b4f7016bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137279
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
 2022-07-22 19:53:13 +02:00
Maxim Monastirsky f87c7018fa No need for SfxWeldToolBoxControllerFactory 
sfx2::sidebar::ControllerFactory::CreateToolBoxController
only supports creating controllers using the uno factory,
or GenericToolbarController as a fallback. Given that we
already handle the uno factory case in
ToolBarManager::CreateControllers, all this complexity is
really just for creating GenericToolbarController with a
different ctor, which we can do locally as well.

Change-Id: I3a5a3cda95a6c5db97615286e93630214f76cbfc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137149
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
 2022-07-17 22:36:53 +02:00
Noel Grandin c60ad041e8 clang-tidy modernize-pass-by-value in framework 
Change-Id: I024653154c51389bb27f3e94b422ff7fc1c9b46b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135296
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-06-02 12:12:15 +02:00
Miklos Vajna b3f2ae52e3 framework: fix crash on Writer startup when using --enable-ext-wiki-publisher 
As reported by Julien, once the mediawiki extension is installed, the
xHandler in framework::DispatchProvider::implts_searchProtocolHandler()
points to an UNO component implemented in Java, and we crash in
dynamic_cast<>(), at least on Linux with gcc 7.5 and libstdc++.

This dynamic_cast<>() call was added in commit
c0fa456436 (tdf#149261 sdext: fix crash on
starting the presenter console for the 2nd time, 2022-05-26), to allow
the presenter console to opt out from protocol handler caching. It was
expected that the proxy object created for a Java UNO component would
simply return nullptr when we try to dynamic_cast<>() it down to a C++
interface.

Fix the problem by moving the interface to an UNO one: this side-steps
the dynamic_cast<>() crash at the price of introducing an UNO interface,
which is not meant to be part of the public UNO API (but at least it's
not published).

It may still make sense to improve the bridges/ code at some stage to
not crash in dynamic_cast<>() on generated Java proxy objects.

Change-Id: Iaac44515339e0dc15dddc3be45ef7dee7331e47a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135114
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2022-05-30 12:08:03 +02:00
Miklos Vajna c0fa456436 tdf#149261 sdext: fix crash on starting the presenter console for the 2nd time 
This started with commit 3f768cddd2
(framework: avoid re-creating protocol handler instances all the time,
2022-05-02). In case there are 2 monitors, then one monitor shows the
slideshow, the other shows the presenter console. The presenter
console's protocol handler in
sdext::presenter::PresenterProtocolHandler::Dispatch::Dispatch() has
mpPresenterController->GetWindowManager() as an empty reference on the
2nd time the presentation starts.

The above commit started to cache protocol handler instances at a frame
level for performance reasons, and this is meant to be safe in general,
but the presenter console's window manager is re-created between
slideshow runs, so it depends on framework/ code to re-create the
protocol handler all the time, which is problematic here.

Fix the problem by introducing a framework::CacheInfo interface that
allows protocol handler implementations to signal if they want to avoid
being cached.

This should be good enough for now, but if later it turns out that there
are too many broken protocol handlers out there, then we can consider
flipping the default and only cache handlers which explicitly opt in for
this behavior. This is not done in this commit.

Change-Id: Ic159813b1b339540bc8c4e780c4d6d7d2d4d2445
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135020
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
 2022-05-26 15:09:30 +02:00
Noel Grandin 8a29fb3098 osl::Mutex->std::mutex in framework::TransactionManager 
Change-Id: I8a1c8e8ccec8ca64cc4f615ea8e9e415a343996d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134396
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-05-17 08:09:33 +02:00
Noel Grandin 0690040384 osl::Mutex->std::mutex in framework::Gate 
Change-Id: I72f0ed62a65dbd487a29f409d1941a50cecb894f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134301
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-05-14 12:37:28 +02:00
Noel Grandin d3849255b7 use more string_view in INetURLObject 
Change-Id: I4462f7cf4740fa4d1b129d76a0775f4250f41bbd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133555
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-04-29 08:53:22 +02:00
Noel Grandin fdfd517a6f loplugin:stringviewparam whitelist some more functions 
for which we have o3tl:: equivalents

Change-Id: I4670fd8b703ac47214be213f41e88d1c6ede7032
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132913
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-04-13 08:38:53 +02:00
Caolán McNamara 6443c79170 move ToolBoxItemId into its own header 
Change-Id: I34838bee7ad27bfd60d92c26af7eb2de508686b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128974
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2022-01-26 12:07:18 +01:00
Caolán McNamara afa35742a4 prefer more css::awt::XPopupMenu api 
Change-Id: Ib008281d63071ea79935af83cbe434be66155455
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126692
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2021-12-12 13:35:00 +01:00
Caolán McNamara 569de88e9c prefer css::awt::XPopupMenu api 
and using GetXGraphic will return a vcl unographic::XGraphic which
also supports XBitmap as well as XGraphic so we can check if
the XBitmap we're passing around supports XGraphic and use that
if it does and drop the imagewrapper in favor of doing that

Change-Id: I3bd7963b53c3f715fca4b5cfb2ddad650ca92e1d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126691
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2021-12-12 13:33:27 +01:00
Noel Grandin c4499bef94 loplugin:stringliteraldefine in framework 
Change-Id: I8bdda62c232b8f20aa6bb1e5e7ad303d6ffa47ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125809
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-11-26 09:47:52 +01:00
Noel Grandin ffd0453810 use more DECL_DLLPRIVATE_STATIC_LINK 
to avoid unnecessarily exporting symbols

Change-Id: I224848cea217977088fe0643511660a7c99b7277
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124733
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-11-05 13:59:10 +01:00
Noel Grandin 8ce81efa73 simplify framework::TitleHelper 
Every callsite (bar one) calls setOwner and connectWithUntitledNumbers after construction,
so just pass them in the constructor.
And for that lone callsite we can just nullptr as an argument.

Change-Id: If838e068bb59a407225d853a0f67983be400f2f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124426
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-10-29 14:28:54 +02:00