100 Commits
Author SHA1 Message Date
Gabor Kelemen f93ae0455c Check bridges with IWYU
Only the parts tha build on x64 arch

See tdf#42949 for motivation

Change-Id: Ifa3c5107887f5ab7837beee83d9603e8c883a7a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162961
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-02-08 15:19:14 +01:00
Gabor Kelemen 075b4f44b9 tdf#157868 Add accessible descriptions to new Dublin Core metadata boxes
that were still missing them.

See also: https://www.dublincore.org/specifications/dublin-core/dcmi-terms/#section-3

Change-Id: I7f76d2c5598aa53bc6faf6afa5f5e60788ae7ef9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162357
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-01-22 08:42:07 +01:00
Gabor Kelemen 2782fa00d3 Fix meaning of warning message
Change-Id: I6421d4f6ec5a79d7f3aea531e9e1361cd12abdc7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162355
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-01-22 08:29:46 +01:00
Gabor Kelemen 2bb79f8fea Resave with newer Glade version
Change-Id: I6b5ab915a9a8f823a71d5441fd7181014457f563
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162356
Tested-by: Jenkins
Reviewed-by: Taichi Haradaguchi  <20001722@ymail.ne.jp>
2024-01-22 08:28:32 +01:00
Gabor Kelemen df1e72b853 Use officecfg instead of SvtFilterOptions wrapper in sc
Change-Id: I8f8ff35452147fe83a772d87eb94e86b8877cac8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161590
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-01-05 19:02:00 +01:00
Gabor Kelemen e6f77135b4 Use officecfg instead of SvtFilterOptions wrapper in sfx2, sd, oox
Change-Id: I1a404fe156c9c7859c1eb19d4dff9892f4598bc9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161591
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-01-05 19:01:25 +01:00
Gabor Kelemen bae684927c Drop now unused SvtSlideSorterBarOptions class
Change-Id: I9db309b15e490c9bd03e767c192ba364a4ffe214
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161452
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-01-03 15:38:17 +01:00
Gabor Kelemen 9fc28d7ef5 Use officecfg instead of SvtSlideSorterBarOptions class
Change-Id: Ie2965f343e6df31502596c35e1d17c22bbccb142
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161451
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-01-03 00:01:55 +01:00
Gabor Kelemen 0b600862ae tdf#146619 Recheck include/ with find-unneeded-includes --noexclude
to see if some exclusions became obsolete

Change-Id: Id88351f5448511b35994c58c6cb749784da3b45e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156993
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2023-12-24 12:14:14 +01:00
Gabor Kelemen f8cd283749 Rewrite bin/find-unusedheaders.py
This script was broken, not only in the implementation
(it gives too many false positives in a suspiciously short, <1s time)
but in its approach as well: only considering stuff that is compiled
under Linux inherently leaves out other platform specific or experimental
stuff.

Rewrite it using another approach: grep for mentions of each
header in the modules or global ones in include/ everywhere.

Runtime of this script is about 15 minutes, seems to give only
a few relevant hits.

Change-Id: Ifb92f41f11ca9a2bf14eec617a469003becb78fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161234
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2023-12-24 11:50:26 +01:00
Gabor Kelemen 7f48419469 get-bugzilla-attachments-by-mimetype: GNOME Bugzilla is dead
Comment it out from the script.
Gnumeric's new bugtracking is in gitlab:
https://gitlab.gnome.org/GNOME/gnumeric/-/issues

Change-Id: I53be9c368cf02f7a36991498ac2261e05327131a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160829
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-12-16 01:24:03 +01:00
Gabor Kelemen 2c6f28f431 tdf#146619 Recheck include/[v-x]* with IWYU
Change-Id: I3cecd622aa04d842a449b4bfd6c55d0b8b96aabf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156992
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-12-12 18:51:27 +01:00
Gabor Kelemen 026be6f62f tdf#146619 Recheck include/t* with IWYU
Change-Id: I005257e458351285b1b35ffe49c8b42834a6db68
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156990
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-11-06 00:33:57 +01:00
Gabor Kelemen 9f44f9fad7 tdf#157575 Clarify labels content in Security Options dialog
Change-Id: Iba2fdf3a74bc50ddd9e7a6727a446acfb40a4bea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157564
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-10-09 11:10:36 +02:00
Gabor Kelemen 2fe996067f tdf#157588 Clarify meaning of High macro security level
Change-Id: I4647ebdba45e2598b993d7aeb06111f069a0eba8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157556
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-10-09 11:09:47 +02:00
Gabor Kelemen b3ebcb83c3 Add script to find unused config groups/keys in officecfg
Change-Id: Ic5f71ae8fd2ceab3c2480e083788d904804da213
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157523
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-10-05 14:43:43 +02:00
Gabor Kelemen 3e753f4849 tdf#146619 Recheck include/s* with IWYU
Change-Id: Ia0a6330278b044f448c9928362308aadc8fc9a20
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156989
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-10-02 21:32:00 +02:00
Gabor Kelemen a2b389d3a9 tdf#146619 Recheck include/oox with IWYU
Change-Id: I91b63fa67ca9552a4725b9b7dcb8f7217195b3ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156988
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2023-09-30 10:35:44 +02:00
Gabor Kelemen 2b153ad429 tdf#146619 Recheck include/o3tl with IWYU
Change-Id: I25833a776b4b7f2055805159583f363b860bc4cf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156987
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-09-26 16:28:17 +02:00
Gabor Kelemen e53a99c4bb tdf#105303 (related) Drop unused translation strings
Obsoleted by
commit 28b6480c6b
commit c5cff66335

found with simple script:
for i in $( grep "^\#define" sd/inc/strings.hrc | cut -d " " -f 2 ) ; do if [ $(gg -l "$i" sd | wc -l ) -eq 1 ] ; then echo "$i: appears once" ; fi; done

Change-Id: I1f07ebc275b8ee9a165c5e1f5ad1d1e68f9eaa81
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157239
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-09-26 16:26:44 +02:00
Gabor Kelemen 7d66020d29 tdf#146619 Recheck include/[e-j]* with IWYU
Change-Id: I705becd4618989ca274ca8c42eeff3bc18a4ae76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156986
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2023-09-23 10:39:02 +02:00
Gabor Kelemen 35af9aa550 tdf#146619 Recheck include/d* with IWYU
Change-Id: Ib17953b49e5035255203e33778a262211d1491f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156985
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2023-09-23 07:22:53 +02:00
Gabor Kelemen 2f85eb7a2d tdf#146619 Recheck include/c* with IWYU
Change-Id: I0cf6f675483bddf82e7347b484a874c71963bfd7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156984
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2023-09-22 09:33:13 +02:00
Gabor Kelemen 7ac978c4d1 tdf#146619 Recheck include/basegfx with IWYU
Change-Id: I08dad6ceeaa9e5470491c09f06d819c4c27ec5f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156983
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2023-09-21 08:53:31 +02:00
Gabor Kelemen 05418537bf bin/find-unneeded-includes: silence error on include/vcl/toolkit
Change-Id: Ia40717df6d6137ca5a8f6d91dd5b95a1decbaa72
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156991
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-09-19 08:20:10 +02:00
Gabor Kelemen f9f5f80c75 tdf#157101 Make Area dialog narrower
by turning off the homogeneous setting of the top button bar

Change-Id: I1e2e4f4db04c4a061c4e699a32b51997495880a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156804
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-09-12 09:46:49 +02:00
Gabor Kelemen a454ee60ef Add translator comment to clarify meaning of the Fix button
Change-Id: I9e792bb27523a2daf6afca00ad1c210e6b274573
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155087
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-08-02 01:13:07 +02:00
Gabor Kelemen c48e810f1a [API CHANGE] Drop deprecated org/openoffice/ucb/InteractionHandler.xcs file
Deprecated in 2010 by
commit af66a011a4

Change-Id: I805f9771fe3730f3e186162cab9ea192517a4f2c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152401
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-06-29 18:58:53 +02:00
Gabor Kelemen 29d91a668c [API CHANGE] Drop deprecated FormulaSyntax property
It was marked as deprecated when added in 2010
commit 81571e00b1
could not find whether it was used ever since

Change-Id: I2c14c923f07d97d1df0604b95b3c65b350248029
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152403
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-06-29 18:58:20 +02:00
Gabor Kelemen 95e5001d93 [API CHANGE] Drop obsolete Mapping config key
Obsoleted in 2010 by
commit c79b576a3d

Change-Id: Iaca64f7560d485338d9de9be19e09d69a83c0d8d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152402
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-06-29 14:28:26 +02:00
Gabor Kelemen 01f9e76ed9 [API CHANGE] Drop unused ToolboxStyle config key
Unused since 2020
commit a0eab90bd1

Change-Id: Id03396022d7481ce85356207d468f5b1201df44c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151407
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-15 22:13:17 +02:00
Gabor Kelemen 1ec0a53d6e [API CHANGE] Drop unused Dictionaries config group
Its use was removed in 2020 by
commit acb1c39053

Change-Id: I48a10ab13de9fcdb1b1c5721a9be648250166f52
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151058
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-15 22:13:02 +02:00
Gabor Kelemen d948d18393 [API CHANGE] Drop unused config key EmojiFont
Its use was removed in 2022 by
commit 5f1eb2a12b

Change-Id: Ifc7e3f645422a478571aaa9dcbcd9ebe9a811b23
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151061
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-15 22:12:41 +02:00
Gabor Kelemen d5c033e439 [API CHANGE] Drop obsolete group PersonasEntry and set PersonasList
Its use was removed in 2020 by
commit e1e9e2aa16

Change-Id: I1271c3a1d0dc9c1b294f9d93753196609a85a245
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150988
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-15 22:12:19 +02:00
Gabor Kelemen 37232295b8 [API CHANGE] Drop unused config keys VCL/LFonts/ -> SubstFontsPS SubstFontsHTML
Marked as unused since 2018
commit 33e80611c4

Change-Id: I76cc62ca4911d1c130092a85f0b89e6078ad5d65
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151500
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2023-05-11 09:54:29 +02:00
Gabor Kelemen 69d0be09ad [API CHANGE] Drop unused config group AppWindow
It was not used ever since added in 2002 by
commit 72cbd26315

Change-Id: I3be8a020174677a6e876628307b2deb311874e67
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151059
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-06 00:41:28 +02:00
Gabor Kelemen 10d74fd12a [API CHANGE] Drop unused config keys ButtonLarge, ButtonFlat
Do not seem to have been ever used since added in 2002 by
commit 72cbd26315

Change-Id: I64a437111d3c2d54e205de944421b05552e9600d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151060
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-06 00:40:30 +02:00
Gabor Kelemen 5eb3ec6cbd [API CHANGE] Drop obsolete TemplateRepositoryURL config key
Its use was removed in 2020 by
commit 9eaaf97ab3

Change-Id: I47b86a9b1bf528d611fa3a79054681bd85382bb0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150989
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-06 00:40:01 +02:00
Gabor Kelemen 0ca0cd7294 [API CHANGE] Drop unused PropertyBrowser->ExperimentalProperties config key
Seems to be unused ever since it was added in 2006 by
commit a9d03e7895

Change-Id: I26fe886d48d066146b0f925925ae61c45539dfb0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151406
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-06 00:39:19 +02:00
Gabor Kelemen a55af69bae [API CHANGE] Drop unused LogicalGraphicSize config group
This was added in 2002
commit d6da51a02d
and last touched in 2010 by
commit 9508a73182
but was never used in code

Change-Id: Ic18eb94470152bfd6e42b317923627b93256076b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151036
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-04 01:49:09 +02:00
Gabor Kelemen dc73651a9d [API CHANGE] Drop unused config key ShowOfficeUpdateDialog
Its use was removed in 2011 by
commit 83ee1bccf9

Change-Id: I995b994c47b2ea9b908867698fe72d7c13e37b0a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150991
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-04 01:41:47 +02:00
Gabor Kelemen 01ac5c55ec [API CHANGE] Drop unused ProductVersionID group
Its use was removed in 2009 by
commit fb623aa0e7

Change-Id: I5c08f8f84e1262b003dc22783c6b2ae47fa18f72
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150987
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-04 01:41:16 +02:00
Gabor Kelemen ce8a5ea8dd [API CHANGE] Drop deprecated config group GraphicSize
Deprecated in 2002 by
commit d6da51a02d

Change-Id: I265a1a03fdd9cfde4c1450f6cd0e799577ff0967
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150990
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-04 01:40:32 +02:00
Gabor Kelemen a51e53fd21 [API CHANGE] Drop empty config group Gallery
Its last key was removed in 2013 by
commit 8e7a1ad17c

Change-Id: Icd9f175ba0195227454a22f3c76ac4307ae90ec4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150992
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-04 01:39:46 +02:00
Gabor Kelemen f7a4a68fed [API CHANGE] Drop deprecated config keys...
Misc/Path/Current/Temp and Storage were deprecated by
commit 8c895561f6 (2009)
commit 3cf21a8bb9 (2004)

Change-Id: Id37650557e5c9ac791dffc9569aa1f23e9bedc89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150996
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-04 01:39:23 +02:00
Gabor Kelemen 1339324674 [API CHANGE] Drop unused Excel_Lotus, W4W, Writer groups
These seem to be unused ever since their 2002 addition in
commit 72cbd26315
and some description in sw with:
commit 7e30aa52ad

Change-Id: I8e5c76e8483aa5dbd0934f4eabc16538366b26a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150994
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-04 01:38:27 +02:00
Gabor Kelemen f111333b55 [API CHANGE] Drop deprecated Java config keys
Deprecated by
commit 095c439703 (2002)
commit d8155fb911 (2004)

Change-Id: Id37fdbee40f6d411dc4416763a1c1e79ee9ac232
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150997
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-04 01:37:31 +02:00
Gabor Kelemen 4c65a29e7f [API CHANGE] Drop empty config group ExternalApps
Its last use was removed in 2004 by
commit f5d946a558

Change-Id: Ieb2ae9c16cf55adb173fa0b5260afc83722db117
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150993
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-04 01:35:45 +02:00
Gabor Kelemen e4c59b7be3 [API CHANGE] Drop unused DialogSize group
Added in commit 72cbd263 and changed in commit f0554890
but not actually used even back then or ever since

Change-Id: Ifbe780917b86fdc0cd78d08c92d44b51707c701b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151049
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-04 01:35:22 +02:00
Gabor Kelemen 1b7c4394de [API CHANGE] Drop unused NameCounter template
Its last use was removed in 2017 by
commit 49b237c46e

Change-Id: I1ed0bdc9c01430ec432015bcbf3ec25f6920c5d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151050
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-04 01:34:43 +02:00
Gabor Kelemen 009c594a65 [API CHANGE] Drop deprecated config key CompressMode
Deprecated in 2004 by
commit 93e3a53e67

Change-Id: I90d5447eef50de3a46e7ae7716ae440219812ebb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150995
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-04 01:33:15 +02:00
Gabor Kelemen 581764d778 [API CHANGE] Drop unused config group AddXMLToStorage
Its use was removed in 2009 by
commit f87ee64d50

Change-Id: Ie9f65ac548ce9eff53156f61df40dbff839a8d8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150983
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-02 23:47:03 +02:00
Gabor Kelemen 8decea6899 [API CHANGE] Drop unused keys from the Scripting group
OfficeBasic, its use was removed in 2020 by
commit fbc909364c

ExecutePlugins, Warning, Confirmation, their use removed by
commit f36433c10a

Change-Id: Ic2bca7b8652f84a1f81141325ae520f138dbeb78
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150986
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-02 21:22:11 +02:00
Gabor Kelemen 4b6f64f55c [API CHANGE] Drop deprecated config keys of Window group
Window -> Key, Version, State, Flag, UserData

Deprecated in 2002 by
commit 9f0aea44a8

Change-Id: I1b086c1b87542e954262d09e23debbefe6068e31
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150985
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-02 21:19:42 +02:00
Gabor Kelemen e161d39ccd [API CHANGE] Drop obsolete JobDescription and Startup config groups
Obsoleted by 2004 commit 2f9e955220
and 2002 commit 3dcc79adb4

Change-Id: Ided71e52b05d99cd5b73694737cf4b4ed4c08bf8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150982
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-02 21:18:43 +02:00
Gabor Kelemen e603786daa [API CHANGE] Drop unused config group InputMethod
Its use was removed in 2019
commit 5bfa8b8d5e

Change-Id: Ibdf90d2bf65dc55e8bb535b7609c1e636f815850
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150984
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-02 21:17:12 +02:00
Gabor Kelemen 8bcf321d54 [API CHANGE] Drop TotalCacheSize ObjectCacheSize ObjectReleaseTime config keys
Obsoleted by 2018 commit c6cf2320d2

Change-Id: Ifc83b8dae06ef84d2ae276c18a395185db330cc0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150964
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-02 21:13:10 +02:00
Gabor Kelemen 5dc7f2f2c6 [API CHANGE] Drop obsolete ObjectNames group
Deprecated by 2004 commit f1e7d342bf

Change-Id: I9d3dcb47bdd4a9cc217e1a534a003e173a4aeda1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150965
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-02 21:12:24 +02:00
Gabor Kelemen b355c9b79e Make bin/includebloat.awk script output prettier
So instead of:
sum total bytes included (excluding system headers): 21793372177
1197253280 132910 9008 /home/gabor/src/core/include/rtl/ustring.hxx
825845085 90207 9155 /home/gabor/src/core/include/rtl/ustring.h

We can see something nicer:
Sum total bytes included (excluding system headers): 21.795.559.123
Total bytes	Size	   Occurrences	Filename
1.197.253.280	132.910	   9.008	/home/gabor/src/core/include/rtl/ustring.hxx
  825.845.085	 90.207	   9.155	/home/gabor/src/core/include/rtl/ustring.h

Change-Id: Iabcaadae964221ed532e7e7e97b10211e37d4857
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150613
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-25 10:42:37 +02:00
Gabor Kelemen 75ed566894 Add script to find unused using declarations
As a complementer to clang-tidy-12 --checks="-*,misc-unused-using-decls"
Pros:
- simple, fast!
- finds some more unused declarations, somehow
- works on non-linux specific parts of the code
- clang-tidy (for me) trips on files with external headers, this does not

Change-Id: If2db989114ac5c2841ed2e89ff7bd7a9e419f567
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150612
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-04-25 08:09:28 +02:00
Gabor Kelemen d7e0247ed4 Run clang-tidy with misc-unused-using-decls on modules [s-t]*
To remove unneeded using declarations.

Via the simple script:

for i in $(find $dirname -name "*cxx" -o -name "*hxx" ); do
    clang-tidy-12  --checks="-*,misc-unused-using-decls" "$i";
done

Change-Id: I596299084471b2904548d23875866f1583b00b2a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150610
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2023-04-23 13:05:21 +02:00
Gabor Kelemen 36db242816 Run clang-tidy with misc-unused-using-decls on module xmloff
To remove unneeded using declarations.

Via the simple script:

for i in $(find $dirname -name "*cxx" -o -name "*hxx" ); do
    clang-tidy-12  --checks="-*,misc-unused-using-decls" "$i";
done

Change-Id: Iccae38de41c809b39345ec6b31c9f6346e620f53
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150611
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2023-04-21 22:22:33 +02:00
Gabor Kelemen 890bf59e0a Run clang-tidy with misc-unused-using-decls on modules [d-o]*
To remove unneeded using declarations.

Via the simple script:

for i in $(find $dirname -name "*cxx" -o -name "*hxx" ); do
    clang-tidy-12  --checks="-*,misc-unused-using-decls" "$i";
done

Change-Id: Idd8aa3d3cfec456c4babb65e89af712051b4deb0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150609
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-04-20 13:14:37 +02:00
Gabor Kelemen b4b3a0d407 Run clang-tidy with misc-unused-using-decls on modules [a-c]*
To remove unneeded using declarations.

Via the simple script:

for i in $(find $dirname -name "*cxx" -o -name "*hxx" ); do
    clang-tidy-12  --checks="-*,misc-unused-using-decls" "$i";
done

Change-Id: I95871cc0ae6f22a9684bae9d14ef0475aea17abb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150608
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-04-20 08:24:33 +02:00
Gabor Kelemen b06ba49a0e Drop unused gen-iwyu-dummy-lib.awk script
missed from 079659eb7d
when the code using it was dropped

Change-Id: I7d769f8be75335079a4a24391d120505d7bd6c84
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140741
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2022-09-30 08:15:04 +02:00
Gabor Kelemen fa7da09ad4 Migration: move L10N settings as well
This is needed to keep UI language/locale settings
Without this the language settings were reset to
OS defaults in our rebranded version

Change-Id: I6c09370e0053cf5171e0ac959429ac7cef5261b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139821
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2022-09-13 17:08:08 +02:00
Gabor Kelemen da22ffb0d5 Migration: move Persona settings to new user profile
This is useful when changing product name and migrating the user profile.
Previously the persona setting was reset to default in our rebranded version.

Change-Id: Ic695b93be1ee8d19fb28131b0dc0b182df0bae83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139598
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-09-10 18:07:53 +02:00
Gabor Kelemen e39d90f591 Migration: move ToD settings to new user profile
This is useful when changing product name and migrating
the user profile.
Without this the ToD appeared in our rebranded version even if it
was turned off previously.

Change-Id: I10a9715e8208cf9d88a5ef2052fb4cf5168dae74
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139597
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-09-10 17:58:02 +02:00
Gabor Kelemen 2d466a95fc tdf#92610 Fix missing/conflicting accelerators on Header/Footer tab page
Change-Id: I54099745b1246b474d2f389b7c87abb18d944cab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137241
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-07-20 17:32:20 +02:00
Gabor Kelemen 126067992d tdf#148248 Text Color -> Font Color in AutoFilter/Standard Filter
Consistently with other places such as Formatting toolbar
and Format Cells -> Font Effects tab page

Change-Id: I7ec5733f01182b25b5d823a43a3639b21ee874e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137087
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2022-07-15 10:29:38 +02:00
Gabor Kelemen 51bfd4a310 tdf#98404 New shortcuts for Move slide commands
Use Shift+Alt+PgUp/PgDn/End/Home since these are free,
easy to remember and close to each other on a desktop keyboard

Ctrl-Alt-Arrows as suggested in comment 21 is not so good
since up/down clash with Gnome Shells switch workspace commands
so they would not "work" in Impress, but switch to the upper/lower
workspace

Change-Id: I05955c59409aa000f54d0d878a86206f009617aa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136585
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-06-29 01:49:22 +02:00
Gabor Kelemen 352284e77f tdf#68335 Increase default para spacing before/after to 56 cm
and fixed line spacing as well.
These may be set to 1584 pt in Word, but the UI incorrectly showed
even the correctly imported values as 10 cm.

Turns out this is only a UI limitation, so lift it for UX interop.
Save/reload already works fine to odt, docx, doc, rtf formats.

Change-Id: I69a772e860ad24a1b317dc041b0c55f0a9d461de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136102
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-06-19 21:48:40 +02:00
Gabor Kelemen 76f7f0c167 tdf#149351 Add a 'Turn off mouse as pen' shortcut
for UX compatibility with PP: Ctrl-A turns off 'mouse as pen' mode

Change-Id: I0379580f4034f07f044dc1079c14898f3014face
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135579
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2022-06-14 16:37:46 +02:00
Gabor Kelemen 48c6046fa9 Drop IS_EDITMODE macro that is used only once
Change-Id: I2fb5b8eb34aa18c35d3a53851ce8d92090d85590
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133982
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2022-05-11 10:35:12 +02:00
Gabor Kelemen 079659eb7d Drop --with-iwyu option
Nowadays the bin/find-unneeded-includes script is a better
solution for this problem

This essentially reverts the commits:
c716b3888e
096c7e889f
40e7eecb7e

Change-Id: I404a4b34176efaacf961605559af9de6d6cba10a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133540
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-05-04 16:48:25 +02:00
Gabor Kelemen ffcd599c4f Drop obsolete workaround for LanguageTool 1.7
Upstream patch for this issue was integrated for LT 1.8:
https://sourceforge.net/p/languagetool/bugs/105/
some 10 years ago.

It should be safe to drop this workaround now that LT 1.7
was dropped from core.

Change-Id: I4ffec2247bcb6445cfcdb1c19018bdddec712c83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133357
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-04-26 10:10:01 +02:00
Gabor Kelemen f0ba8e43da Drop unused LanguageTool extension
Do not bundle LanguageTool which is at a 10 year old version (1.7)
while upstream has a lot of new releases (now at version 5.5.x)
It is not bundled by any downstream distributions
so it makes no much sense to keep it integrated here.

Change-Id: Icd2ef151b1b8d0252ffa3db0caaba576f2783fa9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133356
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-04-26 10:08:54 +02:00
Gabor Kelemen 437b3b9d4f Drop unused CT2N extension
It is not bundled by any downstream distributions
so it makes no much sense to keep it integrated here.

Change-Id: I80180e53e050b8b3cd1b173ef01b51e8d706f295
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133355
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-04-26 10:08:30 +02:00
Gabor Kelemen dec2c5f3ca Recheck module chart2 with IWYU
See tdf#42949 for motivation

This time using the new --noexclude switch to recheck validity
of the excludelist; these were the obsolete exclusions

Change-Id: Ifdf79b30ebaf198082c2194611a2ed2b664e6f1f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133309
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-04-25 16:47:35 +02:00
Gabor Kelemen 655e5d4406 find-unneeded-includes: bail out early if no files are found with --recursive
Change-Id: I5bd726b33e4fc7068baad91ff185763274307b35
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133308
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-04-25 08:43:38 +02:00
Gabor Kelemen f775b625b4 find-unneeded-includes: add --noexclude argument
To ignore the excludelist, thereby checking if its exclusions
are still valid.
It may happen that some refactorings make an exclusion obsolete.
In this case the IWYU suggestion to remove a now-really-unnecessary
header would be ignored forever.

It makes sense to use it after a full cleanup of a module in normal mode.

Change-Id: I8216a79ea2354ab428d6ce7a56a49e5cf67056fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133307
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-04-23 16:35:03 +02:00
Gabor Kelemen fef939d8ff Recheck module chart2 with IWYU
See tdf#42949 for motivation

Change-Id: Id4cdca3eed8618c289f30913d506f8f2bd46f0bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133112
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-04-23 16:33:58 +02:00
Gabor Kelemen 2b44f94908 Recheck modules [uU]* with IWYU
See tdf#42949 for motivation

Change-Id: If710445176681de8e0a0b6c65f58ecaca19dbccf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132768
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-04-12 15:20:47 +02:00
Gabor Kelemen 52ef78f492 Recheck modules t* with IWYU
See tdf#42949 for motivation

Change-Id: I109fa07d52721fd10354de07a2ed995ffa2f27c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132369
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-04-02 23:32:08 +02:00
Gabor Kelemen 6b147d3369 Recheck sw/ cxx files with IWYU
See tdf#42949 for motivation

Change-Id: I8a8df68946297fad517b753d73e4373203a45ed6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132150
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-03-28 14:24:47 +02:00
Gabor Kelemen 84213a426a Recheck sw headers with IWYU
See tdf#42949 for motivation

Change-Id: I99558e6b6952b3f2c1ee32dd07354ff659ad9cd0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131183
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-03-10 12:05:59 +01:00
Gabor Kelemen 96e3a64125 Recheck modules sv* with IWYU
See tdf#42949 for motivation

Change-Id: I25779cbfb1aa93c31d6e12ac95e136b3bdbbc058
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130403
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-03-03 09:50:43 +01:00
Gabor Kelemen 144057a54a Recheck modules s[f-t]* with IWYU
See tdf#42949 for motivation

Change-Id: I1f520aad1b1c942ad5616d96851016fc366ac58f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130203
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-03-01 08:21:00 +01:00
Gabor Kelemen 4df97bdfac Recheck modules sd* with IWYU
See tdf#42949 for motivation

Change-Id: I97c1a0e8c7f26807b12e6062581066d09ea13086
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130114
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-02-21 14:04:45 +01:00
Gabor Kelemen ad1cc7420f find-unneeded-includes: check existence of files listed in yaml files
It might happen that some files are removed/renamed
warn about such files to adjust filter rules

Change-Id: Ib8f1c586a67310cc8be04edfcc75f655da2dbfe0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129881
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-02-15 09:28:44 +01:00
Gabor Kelemen 14001bc758 Recheck modules s[a-c]* with IWYU
See tdf#42949 for motivation

Change-Id: I867e1f7a2c44210de3281b36e22708a5d32ddb7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129476
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-02-14 15:25:30 +01:00
Gabor Kelemen 5382df1422 find-unneeded-includes: rename argument to --continue
sounds more natural than --dontstop

Change-Id: I4650f8bf97a426782828f0e088805551c5830acc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129880
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-02-14 08:31:00 +01:00
Gabor Kelemen 7b5193e2ae Recheck modules [o-r]* with IWYU
See tdf#42949 for motivation

Change-Id: I6b4b05a5e59b256653c4caf5297fffd601b45083
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128845
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-30 16:10:57 +01:00
Gabor Kelemen 67478f9d63 Recheck modules [i-l]* with IWYU
See tdf#42949 for motivation

Change-Id: I758bb27e93779e3df21c463714e49354748f446f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128715
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-27 18:52:16 +01:00
Gabor Kelemen c6620b4e53 tdf#146612 Drop confirmation question when applying new doc hyperlink
To be consistent with other tabs of the dialog where Apply does
not show a similar question

Change-Id: Id3bced8ec861b7166974da5ad223513dbfec25c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128424
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-18 23:21:06 +01:00
Gabor Kelemen e3206e6740 Recheck modules [e-f]* with IWYU
See tdf#42949 for motivation

Change-Id: I49a3ce10dee4b03f99156f5b641f69448e1d5617
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128479
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-17 01:33:35 +01:00
Gabor Kelemen b1ec326619 tdf#146703 Rework previous fix to query extension metadata
to limit its error potential by encoding only the category string

Change-Id: Ia3d3bfa6981ec46b71b500980abda9ad7f606cd1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128361
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins
2022-01-14 13:48:15 +01:00
Gabor Kelemen bc3a0205e2 Recheck modules d* with IWYU
See tdf#42949 for motivation

Change-Id: I916f42c46efa1b6cfd7744a189b79659b2867431
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128196
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-01-14 12:32:21 +01:00
Gabor Kelemen 840b4eb2f3 Recheck modules [a-c]* with IWYU
See tdf#42949 for motivation

Change-Id: I74a3c3a67c3639376e2251c3eb917fa4139dfbd0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127808
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-01-13 08:26:15 +01:00
Gabor Kelemen b957454e5e tdf#142564 Localize extension category names
Change-Id: I57ca7cb194bd325f621841edc24e3af9ef7c3b3e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128305
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-12 02:40:38 +01:00