Found with bin/find-unneeded-includes --headersfwd --recursive include/connectivity/
There were no new replacement suggestions
Change-Id: I1548849490d1bad36c46c8dca0f914dfb4960bc0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199383
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
only in headersfwd mode.
This check ran in --headers mode as well, giving contradicting advice
compared to headersfwd mode.
Apply the check only in headersfwd mode for consistency
Change-Id: Icf58bbb6c47d0a736c2da5d253fe292d6e58a427
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199381
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
Seems to be unused ever since its 2008 addition in
commit e48a6ceb3f
Drop the related image from icon themes as well.
Also drop the XHotSpot/YHotspot bitmap property, which is also unused now.
Last place "using" them in code was removed in 2025 with
commit b363e27529
"loplugin:unusedfields"
Change-Id: I44950026390f51aa4c498428041a4422d762af53
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198069
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
Tested-by: Jenkins
- replace its last config key use with officecfg call
- other keys MS_Excel/ColScale and MS_Excel/RowScale seem to be unused,
related code was removed in 2017:
commit 98c4cd372b
loplugin:unusedfields improve write-only analysis
and 2015:
commit 96d44c9b07
loplugin:unusedmethods sc
Change-Id: I36c8c6e2a99599ad15d722b096fa90718bdc9abc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198440
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
Tested-by: Jenkins
spotted while rechecking include/toolkit, some hpp headers are now
not suggested to be replaced by fw declarations incorrectly,
but to be replaced by their matching hdl files.
There is already a rule to skip these automatically, no need to keep such
in exception files
Change-Id: I5df654a9bca3aaaecb4dce444264a6464ca8f3b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198277
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
Spotted with include/i18nlangtag/languagetagicu.hxx:
iwyu wants to replace unicode/locid.h with namespace icu_78 { class Locale; }
but this is super fragile
Now this works for both this and the older example:
bin/find-unneeded-includes --headersfwd i18npool/inc/breakiterator_unicode.hxx include/i18nlangtag/languagetagicu.hxx
should give no suggestions
Change-Id: I7d534f106f45bf78f768abbb9d57389c7f413d74
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198234
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
this was skipped in previous runs, since it contains some code behind #if
After inspecting these, it seems like the removals should not cause trouble.
Change-Id: If1e3e3c7c0fc14ed6e8b51174a0e7f1220fdbc8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197496
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
this was skipped in previous runs, since it contains some code behind #if
After inspecting these, it seems like the removals should not cause trouble.
Change-Id: I8b856cbf7ded7c62634286a53f1ef41e99adb286
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197495
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
these were skipped in previous runs, since they contain some code behind #if
After inspecting these, it seems like the removals should not cause trouble.
This also shaves off some 140M input
Change-Id: Ie1f57174dd6fec3ba5b0b91eb0688acdc1a8143d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197494
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
these were skipped in previous runs, since they contain some code behind #if
After inspecting these, it seems like the removals should not cause trouble.
Change-Id: I867ffc53254057e4bae43690214a2ab7ce0caa8f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197493
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
Tested-by: Jenkins
Found after running bin/find-unneeded-includes --headersfwd include/vcl/[q-w]*
This shaves off about 100M input
Change-Id: Ib4d0af44b383d34d856a9797fe70a974b359402f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196398
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
This is a followup to commit e896bbbd55
where use of these strings was removed, now the API can go as well
The DUMMY_NO_MORE_USED strings were also picked up for translation,
this issue is gone too.
Change-Id: I28736125f68615bd1612ee013cf5f8d5b3d5c85f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197016
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
After checking all modules with
bin/find-unneeded-includes --finderrors --headers --recursive
these subdirectories seemed to need custom assumes for an
error free run of IWYU
Change-Id: I8e0553355809e49e3ec3d06aa4404e6cd7b72aff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196631
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
Add several paths to skip checking under Linux
This is preparation to integrate this script into CI,
so that it does not report error on headers that are
entirely Win/Mac/IOS/Android/... specific.
Change-Id: Ia1493b57e0e7eef70770d4a5b4b634dd82611c05
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196632
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
Found after running bin/find-unneeded-includes --headersfwd include/vcl/[d-g]*
This shaves off about 150M input
Change-Id: I2b15257451d4b392dca3e5d07f4a443ee653b04c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196395
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
- filter out two modules without relevant files
- search for files in include not in path/file.h
format, but only as file.h as seen with basctl/basctldllapi.h
Change-Id: I42192cc6d923132778ad46271c725bd7049b1bb9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193423
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
Tested-by: Jenkins
Found after running bin/find-unneeded-includes --headersfwd include/vcl/[A-Z]*
This shaves off about 100M input, not bad for such a small amount
of files checked
This time --headersfwd skips files that contain #if defs,
in hope of not breaking builds that are not checked by CI
(...except for include/vcl/BitmapTools.hxx - this was cleaned accidentally,
due to a bug in the bin/find-unneeded-includes script that is fixed
by the previous commit 930ff2b830
- but let's keep this anyway, it seems fine)
Change-Id: Ia8e49d94f6adb3cdbedbc40ffa56dbf846c9b6e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196235
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
Tested-by: Jenkins
- give warning if a header is skipped because it contains #if defs
- give an option to still check those (together with --noexclude)
Change-Id: I9e878b213300a53b6236325f2bafb280f8b0290f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196396
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
Tested-by: Jenkins
Also add text=True for good output - previously, this did not work at all
(it let include/vcl/BitmapTools.hxx checked, see it in subsequent patch)
Previously this check was placed a bit incorrectly, which made
it run only if both --headersfwd and --recursive was provided
Now it runs with simple glob patterns too, such as:
bin/find-unneeded-includes --headersfwd include/vcl/[A-Z]*
Change-Id: Ib8a5209bac553a74137e3a4ac6fdf88319b03982
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196234
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
Tested-by: Jenkins
in Impress/Draw and Calc respectively.
org.openoffice.Office.Calc/Grid/Option/SizeToGrid
org.openoffice.Office.Draw/Grid/SnapGrid/Size
org.openoffice.Office.Impress/Grid/SnapGrid/Size
Seems like ever since "initial import" these were doing nothing
useful.
Change-Id: I5cf6bb7e4c4f91e57b6dba3c9ad7e7774f05e87b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191852
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
Tested-by: Jenkins
After recent commit 851fb75779
recheck these directories in include/ again
to test drive the new --headersfwd mode of bin/find-unneeded-includes
Change-Id: I0ede437c4f9958cd98210ed1760a5b98ea8bd1ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192377
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
individual files and dirs with many files as well,
if they are related to any non-linux build, such as
Win, Mac, Emscripten, IOS, Android
Preparation for making this everybody elses problem,
but for now, only on linux builders
Change-Id: I94b0c76a8d7043538df930379e0703af7416bb3c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192750
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
to increase IWYU coverage to some silently failing corner cases
found with bin/find-unneeded-includes --finderrors mode
Change-Id: Ifd85fceb56ff60c6e33229c36a427c3987778f67
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192749
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
Spotted with include/o3tl/vector_utils.hxx
it can happen that IWYU starts to consider a header having
all correct includes, in this case it does not give a list of
proposals.
This makes the previous method of spotting obsolete exclusions
ineffective in these cases.
Start watching for the "foo.hxx has correct #includes/fwd-decls"
announcement and consider every exclusion as obsolete
Change-Id: I46dd8dd4e2765a972ceaa7aa950d92c9e0a2d1b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192747
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
There are cases when a modules certain header files need
some other include search path than the single assumeFile provides
This is visible when one runs in the --finderrors mode
and the detailed IWYU run complains like:
include/oox/export/drawingml.hxx:39:10: fatal error: 'oox/token/tokens.hxx' file not found
Solve this by introducing assumeDirs in the yaml files, which provides
a different assumeFile for headers in certain directories
Demo on vcl/inc/qt[56] and sw/source/writerfilter;
also with fixing the few identified non-self contained headers there
Change-Id: Idf7cc38fe7d96d89dabcad9d5abd65283622ab96
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192748
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
In headers only, in order to shave off even more headers from build
Put this behind a new option and skip headers that have '#if' in them, indicating
config or platform dependent code of any kind - this is fragile, so let's skip it.
Change-Id: I74777a2a2b0aef9c17fd7542f2c405f7536fe4ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192182
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
This has led to
commit 62a9df7473
"find-unneded-includes: avoid replacing includes with forward-declarations"
now the replacement of unicode/regex.h with a versioned namespace is not suggested
Change-Id: Ic30954561739591bd483382ed75a56f5901ac993
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192428
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
This is tricky because a header name is defined in a macro
and I had an exclusion for this external libs wrapper header.
But --sanitycheck does not see that, as it looks for presence of
exclusion list items.
Move the exclusion into the script, so that find-unneeded-includes
ignores it when checking the IWYU output and --sanitycheck does not
have to deal with this special rare case
Change-Id: I55d61630dd63a48d9b264df4b714dad999d1eacd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191827
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Tested-by: Jenkins
Gabor Kelemen