ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
520,958 Commits 3 Branches 3 Tags
main
Commit Graph
452 Commits
Author SHA1 Message Date
Andrea Gelmini 8ee79ac196 Fix typos 
Change-Id: Ic7a97a5219d8a0d30b1753c2502995ea4c2cd32f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210563
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
 2026-09-10 16:22:54 +02:00
Devansh Varshney eac1e807cc chart2: expose histogram bin settings in axis sidebar 
Add histogram binning controls to the axis properties sidebar.

Expose automatic, fixed-width, and fixed-count modes together with
optional underflow and overflow bins. Read the current settings from
the histogram chart type and update the corresponding model properties
when the controls change.

Signed-off-by: Devansh Varshney <varshney.devansh614@gmail.com>
Change-Id: Ia252499454a0715b1de094de05158966769ec912
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/9284
Reviewed-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.com>
Tested-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.com>
(cherry picked from commit dc0a6a31ff7719cd697220eb173f5c15935096ad)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209220
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-09-01 15:41:57 +02:00
Devansh Varshney ad77e91af6 chart2: expose histogram bin settings in axis dialog 
Add histogram binning controls to the Scale page of the primary
X-axis dialog.

Allow selecting automatic binning, fixed bin width, or a fixed
number of bins, together with optional underflow and overflow bins
and validate invalid combinations.

Signed-off-by: Devansh Varshney <varshney.devansh614@gmail.com>
Change-Id: Ia1efb0ea64249f0297f00c29f0bee8a4803ca803
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/7984
Reviewed-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.com>
Tested-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.com>
(cherry picked from commit f55a6867e1c2b67069d85611dcf25dbed25b85bd)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209216
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-09-01 14:00:30 +02:00
Julien Nabet 9d510964a9 Related tdf#140226: use StaticWhichCast (chart2 part 2) 
+ simplification of some other cases of static_cast with nWhichId

Change-Id: Ic54b0e2814c253494f69b9f3f926e349f3be035f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/204316
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2026-04-25 08:41:21 +02:00
Julien Nabet abed1869c0 Related tdf#140226: use StaticWhichCast (chart2 part 1) 
Change-Id: I28a55455bf85e98edc5226c721d5da1bc4dab862
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/204085
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2026-04-22 08:32:39 +02:00
Noel Grandin 2e063bf91b speed up SfxItemIter 
take some branches out of the hot path, which means
converting some places to for loops.

Change-Id: Idcac06f27761994e2554f723662f242a38d3778c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199853
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2026-02-21 12:38:26 +01:00
Sergey Anisimov ea2ecf0406 tdf#145614 - Convert #define to enum or constexpr 
Change-Id: Ica8f4afdbb40adb3d26bfc56f4bfc91c110001ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191983
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Hossein <hossein@libreoffice.org>
Tested-by: Jenkins
 2025-10-31 17:45:16 +01:00
Gabor Kelemen 85f88d7196 tdf#146619 Run IWYU on chart2/ 
Change-Id: I2f0920df37ba14918e1325983309f9b77c8792cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188751
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
 2025-08-18 20:19:39 +02:00
Noel Grandin 0b900b8683 use more concrete UNO classes in chart2 
Change-Id: Ia8ccb01b6ae4b586da0d6f11d0593840af4c356f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186668
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-06-18 19:52:40 +02:00
Marco Cecchetti 8870c3feb8 chart color palette for data series: dialog tab pane 
Change-Id: I0877212c715d320e954fcd8089d4f984eae16ac6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184265
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185143
Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Tested-by: Jenkins
 2025-05-20 11:37:24 +02:00
Noel Grandin 796f8ff332 Revert "use more concrete UNO in chart2" 
This reverts commit 1886ecf7ee.

because reportdesign will pass in a OReportDefinition* and not a SvNumberFormatsSupplierObj*

Change-Id: Ic0068d18a10ce24ed74bb86cfef4cb9f34e9eeb2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184437
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-04-22 15:45:50 +02:00
Caolán McNamara f74142e6d0 cid#1646564 Unchecked dynamic_cast 
and

cid#1646560 Unchecked dynamic_cast

Change-Id: I6e66128418fa2c4fdd2f0a1430e8dd17b5e5c684
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184385
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2025-04-20 22:15:20 +02:00
Tomaž Vajngerl f355ddcbf2 chart2: fold isSupported* functions into ChartType 
This moves isSupported* function from ChartTypeHelper to ChartType
where it better belongs to. We can access the concrete classes now
instead of accessing through UNO si this is possible to do.

Change-Id: Icc52a8ba0d8ab6d5907d7942a1834cc6f7093cce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182712
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Jenkins
 2025-04-14 02:48:06 +02:00
Noel Grandin 4e5ea3b1fd fold DataSeriesHelper functions into DataSeries 
Where it better belongs, and where we can do a much better implementation.

Change-Id: I370bd23ee0dfb1570d6376d21b8dac4c83591096
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184098
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-04-13 14:20:31 +02:00
Noel Grandin 1aa34c45b6 fold DataSeriesHelper functions into DataSeries 
Where it better belongs, and where we can do a much better implementation.

Change-Id: Iec0c932b40512819bd6cc10afa3e2da93fa1e1b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184069
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-04-12 19:48:26 +02:00
Noel Grandin c804e7ffd6 fold DataSeriesHelper functions into DataSeries 
This moves functions from ChartModelHelper to ChartModel
where it better belongs. We can access the concrete classes now
instead of accessing through UNO.

Change-Id: I35ea769fdbd0af75ae791931505b61c73c4eeac6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184066
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-04-12 13:15:13 +02:00
Noel Grandin 76d296f760 fold ChartModelHelper functions into ChartModel 
This moves functions from ChartModelHelper to ChartModel
where it better belongs to. We can access the concrete classes now
instead of accessing through UNO si this is possible to do.

Change-Id: I21dce8aabe8f8a956863beef7ca5cb4ec6f3b44b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183990
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-04-11 07:07:23 +02:00
Noel Grandin 1886ecf7ee use more concrete UNO in chart2 
Change-Id: Id71c919abb85039d7fdfdb334e505f293e530255
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183706
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-04-04 14:21:15 +02:00
Noel Grandin 215500ea4d merge ExplicitValueProvider interface into ChartView 
Change-Id: I4e5ef8c00b8e1b001d0f711c0c15814d316e2905
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183479
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-03-31 18:49:10 +02:00
Armin Le Grand (Collabora) ec65a00298 tdf#165491 ITEM regression: Chart needs order of events 
The Item with WhichID SCHATTR_STAT_KIND_ERROR *has* to be
handled 1st since it sets additional information about the
ErrorBarStyle at beans::XPropertySet xErrorBarProp that the
processing of the *other* Items already need access to, see
'case SCHATTR_STAT_KIND_ERROR' in
StatisticsItemConverter::ApplySpecialItem. This worked before
the change of SfxItemSet to use a std::unordered_set since
the order of Items was fix and - since SCHATTR_STAT_KIND_ERROR
had the lowest WhichID - was handled 1st. Not sure if that was
by purpose and it was known that this was necessary - there
are no comments hinting to that, so it might have worked by
coincidence before. In general it is bad style to rely on the
'order' of Items in an ItemSet - there is no order defined in
general.

Change-Id: I93e2c8e30f762e1bb83adb2b43459bbfb263a151
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182742
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
Tested-by: Jenkins
 2025-03-10 17:12:37 +01:00
Noel Grandin d0fe2b9cf9 use more concrete UNO types in some local vars 
found by a clang plugin I created.

Change-Id: I72ebc2b6fadb854a12d69a543facf2fd7e4f1e8c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181932
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-02-20 14:03:28 +01:00
Bogdan Buzea 7cdd095af4 tdf#163486: PVS: Constant expression in switch statement 
V785 Constant expression in switch statement

Added a default value for the case of uninitialized nStyle.

Change-Id: I3c73a9b293958d72a7897b5923afdd9291030db9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175901
Tested-by: Jenkins
Reviewed-by: David Gilbert <freedesktop@treblig.org>
 2025-02-09 16:58:06 +01:00
Noel Grandin f3856dfc8a loplugin:reftotemp in chart2 
Change-Id: I0ce3c76e873921f04897955b62cc9c4cb15a5a40
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176258
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-11-08 12:00:06 +01:00
Caolán McNamara 7bbe74b2be cid#1555789 COPY_INSTEAD_OF_MOVE 
and

cid#1556865 COPY_INSTEAD_OF_MOVE
cid#1556871 COPY_INSTEAD_OF_MOVE
cid#1556939 COPY_INSTEAD_OF_MOVE
cid#1556951 COPY_INSTEAD_OF_MOVE
cid#1556964 COPY_INSTEAD_OF_MOVE
cid#1556966 COPY_INSTEAD_OF_MOVE
cid#1556968 COPY_INSTEAD_OF_MOVE
cid#1556971 COPY_INSTEAD_OF_MOVE
cid#1556989 COPY_INSTEAD_OF_MOVE
cid#1557001 COPY_INSTEAD_OF_MOVE
cid#1557011 COPY_INSTEAD_OF_MOVE
cid#1557032 COPY_INSTEAD_OF_MOVE
cid#1557038 COPY_INSTEAD_OF_MOVE
cid#1557041 COPY_INSTEAD_OF_MOVE
cid#1557055 COPY_INSTEAD_OF_MOVE
cid#1557056 COPY_INSTEAD_OF_MOVE
cid#1557057 COPY_INSTEAD_OF_MOVE
cid#1557065 COPY_INSTEAD_OF_MOVE
cid#1557068 COPY_INSTEAD_OF_MOVE
cid#1557087 COPY_INSTEAD_OF_MOVE
cid#1557090 COPY_INSTEAD_OF_MOVE
cid#1557093 COPY_INSTEAD_OF_MOVE
cid#1557113 COPY_INSTEAD_OF_MOVE
cid#1557122 COPY_INSTEAD_OF_MOVE
cid#1557126 COPY_INSTEAD_OF_MOVE
cid#1557145 COPY_INSTEAD_OF_MOVE
cid#1557151 COPY_INSTEAD_OF_MOVE
cid#1557152 COPY_INSTEAD_OF_MOVE
cid#1557197 COPY_INSTEAD_OF_MOVE
cid#1557216 COPY_INSTEAD_OF_MOVE
cid#1557245 COPY_INSTEAD_OF_MOVE
cid#1557272 COPY_INSTEAD_OF_MOVE
cid#1557310 COPY_INSTEAD_OF_MOVE
cid#1557314 COPY_INSTEAD_OF_MOVE
cid#1557318 COPY_INSTEAD_OF_MOVE
cid#1557333 COPY_INSTEAD_OF_MOVE
cid#1557340 COPY_INSTEAD_OF_MOVE
cid#1557358 COPY_INSTEAD_OF_MOVE
cid#1557359 COPY_INSTEAD_OF_MOVE
cid#1557365 COPY_INSTEAD_OF_MOVE
cid#1557367 COPY_INSTEAD_OF_MOVE
cid#1557395 COPY_INSTEAD_OF_MOVE
cid#1557418 COPY_INSTEAD_OF_MOVE
cid#1557488 COPY_INSTEAD_OF_MOVE
cid#1557493 COPY_INSTEAD_OF_MOVE
cid#1557506 COPY_INSTEAD_OF_MOVE
cid#1557514 COPY_INSTEAD_OF_MOVE
cid#1557528 COPY_INSTEAD_OF_MOVE
cid#1557534 COPY_INSTEAD_OF_MOVE
cid#1557537 COPY_INSTEAD_OF_MOVE
cid#1557562 COPY_INSTEAD_OF_MOVE
cid#1557563 COPY_INSTEAD_OF_MOVE
cid#1557592 COPY_INSTEAD_OF_MOVE
cid#1557608 COPY_INSTEAD_OF_MOVE
cid#1557615 COPY_INSTEAD_OF_MOVE
cid#1557619 COPY_INSTEAD_OF_MOVE
cid#1557637 COPY_INSTEAD_OF_MOVE
cid#1557648 COPY_INSTEAD_OF_MOVE
cid#1557712 COPY_INSTEAD_OF_MOVE
cid#1557750 COPY_INSTEAD_OF_MOVE
cid#1557762 COPY_INSTEAD_OF_MOVE
cid#1557765 COPY_INSTEAD_OF_MOVE

Change-Id: I10db1910627e04a26e25836c05ad5c2707abd18b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175696
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
 2024-10-27 20:19:12 +01:00
Caolán McNamara 2bafc7384b cid#1545605 COPY_INSTEAD_OF_MOVE 
and

cid#1545841 COPY_INSTEAD_OF_MOVE
cid#1554682 COPY_INSTEAD_OF_MOVE
cid#1554686 COPY_INSTEAD_OF_MOVE
cid#1554715 COPY_INSTEAD_OF_MOVE
cid#1554750 COPY_INSTEAD_OF_MOVE
cid#1554759 COPY_INSTEAD_OF_MOVE
cid#1554770 COPY_INSTEAD_OF_MOVE
cid#1554779 COPY_INSTEAD_OF_MOVE
cid#1554794 COPY_INSTEAD_OF_MOVE
cid#1554800 COPY_INSTEAD_OF_MOVE
cid#1554826 COPY_INSTEAD_OF_MOVE
cid#1554836 COPY_INSTEAD_OF_MOVE
cid#1554862 COPY_INSTEAD_OF_MOVE
cid#1554865 COPY_INSTEAD_OF_MOVE
cid#1554872 COPY_INSTEAD_OF_MOVE
cid#1554883 COPY_INSTEAD_OF_MOVE
cid#1554906 COPY_INSTEAD_OF_MOVE
cid#1554921 COPY_INSTEAD_OF_MOVE
cid#1554926 COPY_INSTEAD_OF_MOVE
cid#1554946 COPY_INSTEAD_OF_MOVE
cid#1554956 COPY_INSTEAD_OF_MOVE
cid#1554970 COPY_INSTEAD_OF_MOVE
cid#1554986 COPY_INSTEAD_OF_MOVE
cid#1554991 COPY_INSTEAD_OF_MOVE
cid#1555013 COPY_INSTEAD_OF_MOVE
cid#1555037 COPY_INSTEAD_OF_MOVE
cid#1555050 COPY_INSTEAD_OF_MOVE
cid#1555057 COPY_INSTEAD_OF_MOVE
cid#1555066 COPY_INSTEAD_OF_MOVE
cid#1555067 COPY_INSTEAD_OF_MOVE
cid#1555083 COPY_INSTEAD_OF_MOVE
cid#1555097 COPY_INSTEAD_OF_MOVE
cid#1555135 COPY_INSTEAD_OF_MOVE
cid#1555140 COPY_INSTEAD_OF_MOVE
cid#1555146 COPY_INSTEAD_OF_MOVE
cid#1555148 COPY_INSTEAD_OF_MOVE
cid#1555149 COPY_INSTEAD_OF_MOVE
cid#1555155 COPY_INSTEAD_OF_MOVE
cid#1555157 COPY_INSTEAD_OF_MOVE
cid#1555168 COPY_INSTEAD_OF_MOVE
cid#1555195 COPY_INSTEAD_OF_MOVE
cid#1555196 COPY_INSTEAD_OF_MOVE
cid#1555237 COPY_INSTEAD_OF_MOVE

Change-Id: I90531c19c28dca77fe99c72efdfc0972c311da98
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175377
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-10-22 11:56:02 +02:00
Noel Grandin 726ac1d0c6 checkForUniqueItem should take a reference parameter 
Change-Id: Ibd9638f9716c4ce8db7ee5e652dc2f207617e7de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170162
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-07-09 08:04:11 +02:00
Gabor Kelemen e3ca92bcfd Drop unneeded 'using' instances 
found with bin/find-unused-using.sh

Change-Id: I647f493ee313e79e7a9967960ea089b729de59a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167637
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Tested-by: Jenkins
 2024-05-16 08:35:11 +02:00
Noel Grandin 1de066d04f loplugin:ostr in chart2 
Change-Id: I2985b6793a776639214a25bf9732c000b9026bfc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167236
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2024-05-07 08:46:21 +02:00
Rafał Dobrakowski 102622a07d tdf#146619 Remove unused #includes from C/C++ files 
'chart2' module was cleaned.

Change-Id: Ib4cdb3c8a21d0ed47f4970894d416327df5e68a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164864
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
 2024-03-27 09:20:54 +01:00
Armin Le Grand (allotropia) d053413402 ITEM: Remove InvalidateAllItems() 
I checked if this is used, but it can be replaced
using Clear() -> all. This prevents that the whole
array of Items in an ItemSet gets set to
INVALID_POOL_ITEM.

I also checked if INVALID_POOL_ITEM/IsInvalidItem
is needed at all representing SfxItemState::DONTCARE
but it is and still will need to be set for individual
Items.

At last checked if SfxItemState::UNKNOWN and
::DISABLED really need to be separate states, but
indeed there are some rare cases that need that.

To make things more consistent I also renamed
SfxItemState::DONTCARE to SfxItemState::INVALID
to better match Set/IsInvalid calls at ItemSet.

The build showed a missing UT and led to a problem
due to the hand-made ItemSet-like SearchAttrItemList.
The state 'invalid' seems to be used as 'unused'
marker. It should be changed to use SfxPoolItemHolder
and not need that. For now, set by using an own loop
to set to that state.

Change-Id: Ifc51aad60570569a1e37d3084a5e307eed47d06c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165035
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
 2024-03-21 21:39:57 +01:00
Justin Luth a77403d11a tdf#146756 pie chart2 import: use manualLayout Width for pie chart labels 
... and use a compatible 1/5 width if not specified.

This patch depends on the previous oox patch
(commit 301e27cbeb)
which actually reads the width into the model.

Fixes a 7.2 regression from
commit b006834239
author Tünde Tóth on Wed Dec 16 18:26:26 2020 +0100
    tdf#138777 pie chart: improve long data label width

and is basically a re-write of 7.1's
commit 20da1a5dd3
author Tünde Tóth <toth.tunde@nisz.hu>	on Fri Oct 09 09:24:18 2020 +0200
    tdf#134978 Chart OOXML Import: fix pie chart label custom position

This is very risky, but then ANYTHING changing chart2 is risky.
There were a lot of changes made in 7.1,
and they all invited regressions.
However, our chart implementation is not in a good state,
and certainly is not very interoperable,
so it is worth taking the risk.

Anything dealing with manualLayout at this point
should have originated as a pptx,
so forcing a compatible max width should be fairly safe.

It probably isn't actually all that risky after all.

largely copied code from
commit 4223ff2be6
Author: Balazs Varga on Wed Jan 15 16:31:35 2020 +0100
    tdf#48436 Chart: add CustomLabelPosition UNO API property

Fortunately this all goes away after a round-trip
since custom label placement is lost on export to OOXML,
and that really helps to reduce the risk.

make CppunitTest_chart2_import CPPUNIT_TEST_NAME=testTdf146487

Change-Id: I9722fc6c759c15ac3924780e6fc124f02fba07e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162590
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2024-01-30 10:40:43 +01:00
Armin Le Grand (allotropia) 4790ef5cb5 ITEM: Cleanup some Pool stuff with Defaults 
Sorted out some methods at ItemPool which process
Defaults to make more clear what is going on and
what which method is doing.

Change-Id: I2568d3e03d0a56a14b6fe4e04521e1a8e22c000b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162643
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
 2024-01-27 19:02:54 +01:00
Mike Kaganski 0fa827dbb2 Drop std::as_const from css::uno::Sequence iterations 
Obsoleted by commit 2484de6728 (Remove
non-const Sequence::begin()/end() in internal code, 2021-10-15) and
commit fb3c04bd19 (Drop non-const
Sequence::operator[] in internal code, 2021-11-05).

Change-Id: Idbafef5d34c0d4771cbbf75b9db9712e504164cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162640
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2024-01-27 12:43:48 +01:00
Noel Grandin 40cec25c21 unique_ptr to optional in chart2 
Change-Id: I642f6f1fb7df9f0a7525155b22a99344a02d9cf8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160839
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-12-17 10:33:52 +01:00
Noel Grandin df9499d520 use more getFastProperty in chart2 
Change-Id: Ia6511f7de33023e1e1e9e8a31ba262c7b989350c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160832
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-12-15 21:03:55 +01:00
Stephan Bergmann bd6fb0cd3e Extended loplugin:ostr: Rewrite some O[U]StringLiteral -> O[U]String 
...in include files.  This is a mix of automatic rewriting in include files and
manual fixups (mostly addressing loplugin:redundantfcast) in source files that
include those.

Change-Id: I1f3cc1e67b9cabd2e9d61a4d9e9a01e587ea35cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158337
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2023-10-23 11:04:42 +02:00
Stephan Bergmann 27aea4de84 Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: chart2 
Change-Id: Ifcb57548a594cbbaf70df8d9da17cf94a96667db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158146
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2023-10-19 14:05:52 +02:00
Noel Grandin 0193b284e8 new loplugin:constexprliteral 
OUStringLiteral should be declared constexpr, to enforce
that it is initialised at compile-time and not runtime.

This seems to make a different at least on Visual Studio

Change-Id: I1698f5fa22ddb480347c2f4d444530c2e0e88d92
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153499
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-06-26 13:12:31 +02:00
Noel Grandin 67cf6e0463 use more get/setFastPropertyValue in chart2 
Change-Id: I4979cf5dab8b35ba35a46808cef76dc3f81c59b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149725
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-03-29 19:02:34 +00:00
Noel Grandin 99463a6f7f use more get/setFastPropertyValue in chart2 
Change-Id: I1471309e200c8eec21844658b873f817565f9604
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149693
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-03-29 19:02:25 +00:00
Noel Grandin 6d4917db0e expand out ChartModelHelper::findDiagram 
since it just calls findFirstChartDiagram

Change-Id: I21eb9a747127ad54f3b5875074a7bf7ffbf79e4d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149681
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-03-29 09:56:07 +00:00
Noel Grandin 5e482317a0 use more concrete types in chart2 
Change-Id: Ifd3bce5fc22371559203da673ca98913bc742c21
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149674
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-03-29 08:44:44 +00:00
Noel Grandin 90baab0f50 use more concrete types in chart2 
Change-Id: I067e9424a77fb1d835f2847bba3c3f2cda3430f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149652
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-03-28 19:52:51 +00:00
Noel Grandin 6f59baf135 use more concrete type in chart2 
Change-Id: If67a4f0fe75554e14c3030c68374607b76d5b840
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149336
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-03-22 19:58:38 +00:00
Noel Grandin 949c73f9c3 use more concrete types in chart2 
Change-Id: I70042284e4549b3eef67866a35741b06305d720f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149229
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-03-22 05:57:16 +00:00
Noel Grandin df12a23157 move getVertical/setVertical inside chart2::Diagram 
Change-Id: Ide512e20fea94b1d7d038290d1c833f1d8cf42ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149164
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-03-21 08:44:53 +00:00
Noel Grandin 70595c0291 move setDimension/getDimension inside chart2::Diagram 
Change-Id: If52f92e152011ead81a1b25f30ba15124e6a8e75
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149151
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-03-20 17:54:39 +00:00
Noel Grandin 514d2c7d20 move attachSeriesToAxis inside chart2::Diagram 
Change-Id: I3559fe9b9f0830c32a44c23b0b4d1a3683bafbd8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149135
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-03-20 10:50:47 +00:00
Noel Grandin 6a4bcb83f6 move getChartTypeOfSeries inside chart2::Diagram 
Change-Id: I496b180c1e7d6641760251186357d2b11f4434ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149089
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-03-20 05:40:32 +00:00
Noel Grandin d14a83bf98 move getCorrectedMissingValueTreatment inside chart2::Diagram 
and also switch to using getFastPropertyValue

Change-Id: I0c6617841a364ccb8e1c7b624e1ef6fde28426d0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148928
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-03-16 09:36:35 +00:00