cid#1555789 COPY_INSTEAD_OF_MOVE

and cid#1556865 COPY_INSTEAD_OF_MOVE cid#1556871 COPY_INSTEAD_OF_MOVE cid#1556939 COPY_INSTEAD_OF_MOVE cid#1556951 COPY_INSTEAD_OF_MOVE cid#1556964 COPY_INSTEAD_OF_MOVE cid#1556966 COPY_INSTEAD_OF_MOVE cid#1556968 COPY_INSTEAD_OF_MOVE cid#1556971 COPY_INSTEAD_OF_MOVE cid#1556989 COPY_INSTEAD_OF_MOVE cid#1557001 COPY_INSTEAD_OF_MOVE cid#1557011 COPY_INSTEAD_OF_MOVE cid#1557032 COPY_INSTEAD_OF_MOVE cid#1557038 COPY_INSTEAD_OF_MOVE cid#1557041 COPY_INSTEAD_OF_MOVE cid#1557055 COPY_INSTEAD_OF_MOVE cid#1557056 COPY_INSTEAD_OF_MOVE cid#1557057 COPY_INSTEAD_OF_MOVE cid#1557065 COPY_INSTEAD_OF_MOVE cid#1557068 COPY_INSTEAD_OF_MOVE cid#1557087 COPY_INSTEAD_OF_MOVE cid#1557090 COPY_INSTEAD_OF_MOVE cid#1557093 COPY_INSTEAD_OF_MOVE cid#1557113 COPY_INSTEAD_OF_MOVE cid#1557122 COPY_INSTEAD_OF_MOVE cid#1557126 COPY_INSTEAD_OF_MOVE cid#1557145 COPY_INSTEAD_OF_MOVE cid#1557151 COPY_INSTEAD_OF_MOVE cid#1557152 COPY_INSTEAD_OF_MOVE cid#1557197 COPY_INSTEAD_OF_MOVE cid#1557216 COPY_INSTEAD_OF_MOVE cid#1557245 COPY_INSTEAD_OF_MOVE cid#1557272 COPY_INSTEAD_OF_MOVE cid#1557310 COPY_INSTEAD_OF_MOVE cid#1557314 COPY_INSTEAD_OF_MOVE cid#1557318 COPY_INSTEAD_OF_MOVE cid#1557333 COPY_INSTEAD_OF_MOVE cid#1557340 COPY_INSTEAD_OF_MOVE cid#1557358 COPY_INSTEAD_OF_MOVE cid#1557359 COPY_INSTEAD_OF_MOVE cid#1557365 COPY_INSTEAD_OF_MOVE cid#1557367 COPY_INSTEAD_OF_MOVE cid#1557395 COPY_INSTEAD_OF_MOVE cid#1557418 COPY_INSTEAD_OF_MOVE cid#1557488 COPY_INSTEAD_OF_MOVE cid#1557493 COPY_INSTEAD_OF_MOVE cid#1557506 COPY_INSTEAD_OF_MOVE cid#1557514 COPY_INSTEAD_OF_MOVE cid#1557528 COPY_INSTEAD_OF_MOVE cid#1557534 COPY_INSTEAD_OF_MOVE cid#1557537 COPY_INSTEAD_OF_MOVE cid#1557562 COPY_INSTEAD_OF_MOVE cid#1557563 COPY_INSTEAD_OF_MOVE cid#1557592 COPY_INSTEAD_OF_MOVE cid#1557608 COPY_INSTEAD_OF_MOVE cid#1557615 COPY_INSTEAD_OF_MOVE cid#1557619 COPY_INSTEAD_OF_MOVE cid#1557637 COPY_INSTEAD_OF_MOVE cid#1557648 COPY_INSTEAD_OF_MOVE cid#1557712 COPY_INSTEAD_OF_MOVE cid#1557750 COPY_INSTEAD_OF_MOVE cid#1557762 COPY_INSTEAD_OF_MOVE cid#1557765 COPY_INSTEAD_OF_MOVE Change-Id: I10db1910627e04a26e25836c05ad5c2707abd18b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175696 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-27 20:19:12 +01:00
parent 4c9f9736cd
commit 7bbe74b2be
57 changed files with 70 additions and 77 deletions
@@ -151,7 +151,7 @@ AccessibleBrowseBox::getAccessibleAtPoint( const awt::Point& rPoint )

            if (xCurrChildComp.is()
                && VCLUnoHelper::ConvertToVCLRect(xCurrChildComp->getBounds()).Contains(aPoint))
-                xChild = xCurrChild;
+                xChild = std::move(xCurrChild);
        }
    }
    return xChild;
@@ -671,10 +671,7 @@ Locale AccessibleDialogWindow::getLocale(  )
    return Application::GetSettings().GetLanguageTag().getLocale();
 }

-
 // XAccessibleComponent
-
-
 Reference< XAccessible > AccessibleDialogWindow::getAccessibleAtPoint( const awt::Point& rPoint )
 {
    OExternalLockGuard aGuard( this );
@@ -692,7 +689,7 @@ Reference< XAccessible > AccessibleDialogWindow::getAccessibleAtPoint( const awt
                Point aPos = VCLUnoHelper::ConvertToVCLPoint(rPoint);
                if ( aRect.Contains( aPos ) )
                {
-                    xChild = xAcc;
+                    xChild = std::move(xAcc);
                    break;
                }
            }
@@ -702,7 +699,6 @@ Reference< XAccessible > AccessibleDialogWindow::getAccessibleAtPoint( const awt
    return xChild;
 }

-
 void AccessibleDialogWindow::grabFocus(  )
 {
    OExternalLockGuard aGuard( this );
@@ -711,7 +707,6 @@ void AccessibleDialogWindow::grabFocus(  )
        m_pDialogWindow->GrabFocus();
 }

-
 sal_Int32 AccessibleDialogWindow::getForeground(  )
 {
    OExternalLockGuard aGuard( this );
@@ -483,7 +483,7 @@ bool TextLabelItemConverter::ApplySpecialItem( sal_uInt16 nWhichId, const SfxIte
                    GetPropertySet()->getPropertyValue(u"Symbol"_ustr) >>= aSymbol;
                    if (aSymbol.Graphic != xGraphic)
                    {
-                        aSymbol.Graphic = xGraphic;
+                        aSymbol.Graphic = std::move(xGraphic);
                        GetPropertySet()->setPropertyValue(u"Symbol"_ustr, uno::Any(aSymbol));
                        bChanged = true;
                    }
@@ -133,7 +133,7 @@ void lcl_addSequenceToDataSource(
        xDataSource->getDataSequences());
    aSequences.realloc( aSequences.getLength() + 1 );
    auto pSequences = aSequences.getArray();
-    pSequences[ aSequences.getLength() - 1 ] = xLSeq;
+    pSequences[ aSequences.getLength() - 1 ] = std::move(xLSeq);
    xSink->setData( aSequences );
 }

@@ -455,7 +455,7 @@ void OSQLParseTreeIterator::traverseOneTableName( OSQLTables& _rTables,const OSQ
    // get the object representing this table/query
    OSQLTable aTable = impl_locateRecordSource( aComposedName );
    if ( aTable.is() )
-        _rTables[ aTableRange ] = aTable;
+        _rTables[ aTableRange ] = std::move(aTable);
 }

 void OSQLParseTreeIterator::impl_fillJoinConditions(const OSQLParseNode* i_pJoinCondition)
@@ -1398,7 +1398,7 @@ bool ODatabaseModelImpl::hasTrustedScriptingSignature(
        {
            task::DocumentMacroConfirmationRequest aRequest;
            aRequest.DocumentURL = m_sDocFileLocation;
-            aRequest.DocumentStorage = xStorage;
+            aRequest.DocumentStorage = std::move(xStorage);
            aRequest.DocumentSignatureInformation = aInfo;
            aRequest.DocumentVersion = aODFVersion;
            aRequest.Classification = task::InteractionClassification_QUERY;
@@ -74,7 +74,7 @@ void OSubComponent::release() noexcept
            if (xParent.is())
            {
                MutexGuard aGuard( rBHelper.rMutex );
-                m_xParent = xParent;
+                m_xParent = std::move(xParent);
            }

            // destroy the object if xHoldAlive decrement the refcount to 0
@@ -148,7 +148,7 @@ check(dp_misc::DescriptionInfoset const & infoset) {
                    minimalVersionOpenOfficeOrg));
        }
        if (!sat) {
-            unsatisfiedRange[unsat++] = e;
+            unsatisfiedRange[unsat++] = std::move(e);
        }
    }
    unsatisfied.realloc(unsat);
@@ -1431,7 +1431,7 @@ void SAL_CALL OCommonEmbeddedObject::storeAsEntry( const uno::Reference< embed::
    }

    m_bWaitSaveCompleted = true;
-    m_xNewObjectStorage = xSubStorage;
+    m_xNewObjectStorage = std::move(xSubStorage);
    m_xNewParentStorage = xStorage;
    m_aNewEntryName = sEntName;
    m_aNewDocMediaDescriptor = GetValuableArgs_Impl( lArguments, true );
@@ -142,7 +142,7 @@ bool OwnView_Impl::CreateModelFromURL( const OUString& aFileURL )
                    xCloseable->addCloseListener( uno::Reference< util::XCloseListener >(this) );

                    ::osl::MutexGuard aGuard( m_aMutex );
-                    m_xModel = xModel;
+                    m_xModel = std::move(xModel);
                    bResult = true;
                }
            }
@@ -225,7 +225,7 @@ namespace pcr
                    if( xStringResourceResolver.is() &&
                        xStringResourceResolver->getLocales().hasElements() )
                    {
-                        xRet = xStringResourceResolver;
+                        xRet = std::move(xStringResourceResolver);
                    }
                }
                catch(const UnknownPropertyException&)
@@ -310,7 +310,7 @@ namespace pcr

        m_xComponent.set( xIntrospectionAccess->queryAdapter( cppu::UnoType<XPropertySet>::get() ), UNO_QUERY_THROW );
        // now that we survived so far, remember m_xComponentIntrospectionAccess
-        m_xComponentIntrospectionAccess = xIntrospectionAccess;
+        m_xComponentIntrospectionAccess = std::move(xIntrospectionAccess);
        m_xPropertyState.set(m_xComponent, css::uno::UNO_QUERY);

        m_bPropertyMapInitialized = false;
@@ -85,7 +85,7 @@ namespace pcr
        OSL_ENSURE( m_aPropertyListeners.getLength() == 0, "PropertyHandler::inspect: derived classes are expected to forward the removePropertyChangeListener call to their base class (me)!" );

        // remember the new component, and give derived classes the chance to react on it
-        m_xComponent = xNewComponent;
+        m_xComponent = std::move(xNewComponent);
        onNewComponent();

        // add the listeners, again
@@ -853,7 +853,7 @@ bool UpdateHandler::showWarning( const OUString &rWarningText,
    aDescriptor.Type              = awt::WindowClass_MODALTOP;
    aDescriptor.WindowServiceName = "warningbox";
    aDescriptor.ParentIndex       = -1;
-    aDescriptor.Parent            = xPeer;
+    aDescriptor.Parent            = std::move(xPeer);
    aDescriptor.Bounds            = awt::Rectangle( 10, 10, 250, 150 );
    aDescriptor.WindowAttributes  = nWindowAttributes;

@@ -997,7 +997,7 @@ bool PDFExport::Export( const OUString& rFile, const Sequence< PropertyValue >&
            aContext.SignContact = sSignContact;
            aContext.SignReason = sSignReason;
            aContext.SignPassword = sSignPassword;
-            aContext.SignCertificate = aSignCertificate;
+            aContext.SignCertificate = std::move(aSignCertificate);
            aContext.SignTSA = sSignTSA;
            aContext.UseReferenceXObject = bUseReferenceXObject;

@@ -319,7 +319,7 @@ void StatusIndicatorFactory::implts_makeParentVisibleIfAllowed()
    if (xFrame.is())
        xParentWindow = xFrame->getContainerWindow();
    else
-        xParentWindow = xPluggWindow;
+        xParentWindow = std::move(xPluggWindow);

    // don't disturb user in case he put the loading document into the background!
    // Suppress any setVisible() or toFront() call in case the initial show was
@@ -477,7 +477,7 @@ void StatusIndicatorFactory::impl_showProgress()
    }

    std::scoped_lock g(m_mutex);
-    m_xProgress = xProgress;
+    m_xProgress = std::move(xProgress);
 }

 void StatusIndicatorFactory::impl_hideProgress()
@@ -135,7 +135,7 @@ void TagWindowAsModified::impl_update (const css::uno::Reference< css::frame::XF
        // Note: frame was set as member outside ! we have to refresh connections
        // regarding window and model only here.
        m_xWindow = std::move(pWindow);
-        m_xModel  = xModel;
+        m_xModel  = std::move(xModel);
    }

    m_xModel->addModifyListener (this);
@@ -1165,7 +1165,7 @@ css::uno::Reference< css::frame::XFrame > SAL_CALL XFrameImpl::findFrame( const
               )
            {
                if (xParent->getName() == sTargetFrameName)
-                    xTarget = xParent;
+                    xTarget = std::move(xParent);
                else
                {
                    sal_Int32 nRightFlags  = nSearchFlags & ~css::frame::FrameSearchFlag::CHILDREN;
@@ -818,7 +818,7 @@ void ImageManagerImpl::replaceImages(
        ConfigurationEvent aReplaceEvent;
        aReplaceEvent.aInfo           <<= nImageType;
        aReplaceEvent.Accessor        <<= xOwner;
-        aReplaceEvent.Source          = xOwner;
+        aReplaceEvent.Source          = std::move(xOwner);
        aReplaceEvent.ResourceURL     = m_aResourceString;
        aReplaceEvent.ReplacedElement = Any();
        aReplaceEvent.Element         <<= uno::Reference< XNameAccess >(pReplacedImages);
@@ -1062,7 +1062,7 @@ void ImageManagerImpl::reload()
                ConfigurationEvent aRemoveEvent;
                aRemoveEvent.aInfo           <<= static_cast<sal_uInt16>(i);
                aRemoveEvent.Accessor        <<= xOwner;
-                aRemoveEvent.Source          = xOwner;
+                aRemoveEvent.Source          = std::move(xOwner);
                aRemoveEvent.ResourceURL     = m_aResourceString;
                aRemoveEvent.Element         <<= uno::Reference< XNameAccess >( pRemovedImages );
                implts_notifyContainerListener( aRemoveEvent, NotifyOp_Remove );
@@ -1313,7 +1313,7 @@ void SAL_CALL ModuleUIConfigurationManager::removeSettings( const OUString& Reso

                aEvent.ResourceURL = ResourceURL;
                aEvent.Accessor <<= xThis;
-                aEvent.Source = xIfac;
+                aEvent.Source = std::move(xIfac);
                aEvent.Element <<= xRemovedSettings;
                aEvent.ReplacedElement <<= pDefaultDataSettings->xSettings;

@@ -1328,7 +1328,7 @@ void SAL_CALL ModuleUIConfigurationManager::removeSettings( const OUString& Reso

                aEvent.ResourceURL = ResourceURL;
                aEvent.Accessor <<= xThis;
-                aEvent.Source = xIfac;
+                aEvent.Source = std::move(xIfac);
                aEvent.Element <<= xRemovedSettings;

                aGuard.clear();
@@ -660,7 +660,7 @@ void UIConfigurationManager::impl_Initialize()

            m_aUIElements[i].nElementType = i;
            m_aUIElements[i].bModified = false;
-            m_aUIElements[i].xStorage = xElementTypeStorage;
+            m_aUIElements[i].xStorage = std::move(xElementTypeStorage);
        }
    }
    else
@@ -86,7 +86,7 @@ static void ReadThroughDic( const OUString &rMainURL, ConvDicXMLImport &rImport

    // prepare ParserInputSource
    xml::sax::InputSource aParserInput;
-    aParserInput.aInputStream = xIn;
+    aParserInput.aInputStream = std::move(xIn);

    // finally, parser the stream
    try
@@ -399,7 +399,7 @@ void DataLabelConverter::convertFromModel( const Reference< XDataSeries >& rxDat
                        xCustomLabel->setString( pRun->getText() );
                        xCustomLabel->setFieldType( DataPointCustomLabelFieldType::DataPointCustomLabelFieldType_TEXT );
                    }
-                    aSequenceRange[ nPos++ ] = xCustomLabel;
+                    aSequenceRange[ nPos++ ] = std::move(xCustomLabel);
                }

                if( nParagraphs > 1 && nPos < nSequenceSize )
@@ -407,7 +407,7 @@ void DataLabelConverter::convertFromModel( const Reference< XDataSeries >& rxDat
                    css::uno::Reference< XDataPointCustomLabelField > xCustomLabel = DataPointCustomLabelField::create( xContext );
                    xCustomLabel->setFieldType( DataPointCustomLabelFieldType::DataPointCustomLabelFieldType_NEWLINE );
                    xCustomLabel->setString(u"\n"_ustr);
-                    aSequenceRange[ nPos++ ] = xCustomLabel;
+                    aSequenceRange[ nPos++ ] = std::move(xCustomLabel);
                }
            }

@@ -84,7 +84,7 @@ ContextHandlerRef GraphicShapeContext::onCreateContext( sal_Int32 aElementToken,
            Reference<XInputStream> xMediaStream = lcl_GetMediaStream(path, getFilter());
            if (xMediaStream.is())
            {
-                mpShapePtr->getGraphicProperties().m_xMediaStream = xMediaStream;
+                mpShapePtr->getGraphicProperties().m_xMediaStream = std::move(xMediaStream);
                mpShapePtr->getGraphicProperties().m_sMediaPackageURL = lcl_GetMediaReference(path);
            }
        }
@@ -323,7 +323,7 @@ BlipContext::BlipContext(ContextHandler2Helper const & rParent, const AttributeL
        auto xGraphic = aGraphic.GetXGraphic();
        mrBlipProps.mxFillGraphic = xGraphic;
        if (mpBlipFill)
-            mpBlipFill->mxGraphic = xGraphic;
+            mpBlipFill->mxGraphic = std::move(xGraphic);
    }
 }

@@ -4383,7 +4383,7 @@ void SAL_CALL OStorage::setPropertyValue( const OUString& aPropertyName, const u
                throw lang::IllegalArgumentException( THROW_WHERE, uno::Reference< uno::XInterface >(), 0 );
            }

-            m_pImpl->m_xNewRelInfoStream = xInRelStream;
+            m_pImpl->m_xNewRelInfoStream = std::move(xInRelStream);
            m_pImpl->m_aRelInfo = uno::Sequence< uno::Sequence< beans::StringPair > >();
            m_pImpl->m_nRelInfoStatus = RELINFO_CHANGED_STREAM;
            m_pImpl->m_bBroadcastModified = true;
@@ -407,7 +407,7 @@ PyRef PyUNOStruct_new (
    if (self == nullptr)
        return PyRef(); // == error
    self->members = new PyUNOInternals;
-    self->members->xInvocation = xInvocation;
+    self->members->xInvocation = std::move(xInvocation);
    self->members->wrappedObject = targetInterface;
    return PyRef( reinterpret_cast<PyObject*>(self), SAL_NO_ACQUIRE );

@@ -125,7 +125,7 @@ void SAL_CALL OFunctions::replaceByIndex( ::sal_Int32 Index, const uno::Any& Ele
        TFunctions::iterator aPos = m_aFunctions.begin();
        ::std::advance(aPos,Index);
        aOldElement <<= *aPos;
-        *aPos = xFunction;
+        *aPos = std::move(xFunction);
    }

    container::ContainerEvent aEvent(static_cast<container::XContainer*>(this), uno::Any(Index), Element, aOldElement);
@@ -128,7 +128,7 @@ void SAL_CALL OGroups::replaceByIndex( ::sal_Int32 Index, const uno::Any& Elemen
        TGroups::iterator aPos = m_aGroups.begin();
        ::std::advance(aPos,Index);
        aOldElement <<= *aPos;
-        *aPos = xGroup;
+        *aPos = std::move(xGroup);
    }

    container::ContainerEvent aEvent(static_cast<container::XContainer*>(this), uno::Any(Index), Element, aOldElement);
@@ -1769,7 +1769,7 @@ bool XclExpChSerErrorBar::Convert( XclExpChSourceLink& rValueLink, sal_uInt16& r
                        OUString aCurrRole;
                        if( aValueProp.GetProperty( aCurrRole, EXC_CHPROP_ROLE ) && (aCurrRole == aRole) )
                        {
-                            xValueSeq = xTmpValueSeq;
+                            xValueSeq = std::move(xTmpValueSeq);
                            break;
                        }
                    }
@@ -621,7 +621,7 @@ ScVbaApplication::getActiveSheet()
            xWorkbook->getActiveSheet();
        if ( xWorksheet.is() )
        {
-            result = xWorksheet;
+            result = std::move(xWorksheet);
        }
    }

@@ -98,7 +98,7 @@ ProviderCache::getAllProviders()
            Reference<provider::XScriptProvider> xScriptProvider = rDetail.second.provider;
            if ( xScriptProvider.is() )
            {
-                pproviders[ providerIndex++ ] = xScriptProvider;
+                pproviders[ providerIndex++ ] = std::move(xScriptProvider);
            }
            else
            {
@@ -106,7 +106,7 @@ ProviderCache::getAllProviders()
                try
                {
                    xScriptProvider = createProvider(rDetail.second);
-                    pproviders[ providerIndex++ ] = xScriptProvider;
+                    pproviders[ providerIndex++ ] = std::move(xScriptProvider);
                }
                catch ( const Exception& )
                {
@@ -158,7 +158,7 @@ ProviderCache::populateCache()
                {
                    serviceName = *pName;
                    ProviderDetails details;
-                    details.factory = factory;
+                    details.factory = std::move(factory);
                    m_hProviderDetailsCache[ serviceName ] = std::move(details);
                }
            }
@@ -715,7 +715,7 @@ void PresenterAccessible::AccessibleObject::SetWindow (
        mxContentWindow->removeWindowListener(this);
    }

-    mxContentWindow = xContentWindow;
+    mxContentWindow = std::move(xContentWindow);
    mxBorderWindow.set(rxBorderWindow, UNO_QUERY);

    if (mxContentWindow.is())
@@ -108,7 +108,7 @@ namespace sd
                        Reference< XShape > xTarget( pTarget->getUnoShape(), UNO_QUERY );
                        if( xSource.is() && xTarget.is() )
                        {
-                            maShapeMap[xSource] = xTarget;
+                            maShapeMap[xSource] = std::move(xTarget);
                        }
                    }
                }
@@ -706,7 +706,7 @@ void AnimationExporter::exportNode( SvStream& rStrm, Reference< XAnimationNode >
                        {
                            if ( xChildNode->getType() == AnimationNodeType::AUDIO )
                            {
-                                xAudioNode = xChildNode;
+                                xAudioNode = std::move(xChildNode);
                                nAudioGroup = mnCurrentGroup;
                            }
                            else
@@ -306,7 +306,7 @@ bool SdGRFFilter::Export()
                            uno::Any aSelection( pDrawController->getSelection() );
                            uno::Reference< lang::XComponent > xSelection;
                            if ( aSelection >>= xSelection )
-                                xSource = xSelection;
+                                xSource = std::move(xSelection);
                        }
                    }
                    xExporter->setSourceDocument( xSource );
@@ -324,7 +324,7 @@ uno::Reference< css::uno::XInterface > SAL_CALL SdUnoSearchReplaceShape::findNex
                    // get next shape on our page
                    uno::Reference< drawing::XShape > xFound2( GetNextShape( mpPage, xCurrentShape ) );
                    if( xFound2.is() && (xFound2.get() != xCurrentShape.get()) )
-                        xCurrentShape = xFound2;
+                        xCurrentShape = std::move(xFound2);
                    else
                        xCurrentShape = nullptr;

@@ -106,7 +106,7 @@ void PageCollector::CollectMasterPages( const Reference< XModel >& rxModel, std:
            if ( aIter == rMasterPageList.end() )
            {
                MasterPageEntity aMasterPageEntity;
-                aMasterPageEntity.xMasterPage = xMasterPage;
+                aMasterPageEntity.xMasterPage = std::move(xMasterPage);
                aMasterPageEntity.bUsed = false;
                rMasterPageList.push_back( aMasterPageEntity );
            }
@@ -4743,7 +4743,7 @@ OUString SfxMedium::SwitchDocumentToTempFile()
                    SetPhysicalName_Impl( OUString() );
                    SetName( aOrigURL );
                    GetMedium_Impl();
-                    pImpl->xStorage = xStorage;
+                    pImpl->xStorage = std::move(xStorage);
                }
            }
        }
@@ -3233,7 +3233,7 @@ void SfxBaseModel::impl_store(  const   OUString&                   sURL
    if ( bCopyTo )
    {
        // restore DocumentProperties if a copy was created
-        m_pData->m_xDocumentProperties = xOldDocProps;
+        m_pData->m_xDocumentProperties = std::move(xOldDocProps);
    }

    Reference < task::XInteractionHandler > xHandler;
@@ -208,7 +208,7 @@ namespace slideshow::internal
                        if( xTargetShape.is() )
                        {
                            // override target shape with parent-supplied
-                            aTarget.mxRef = xTargetShape;
+                            aTarget.mxRef = std::move(xTargetShape);
                            aTarget.mnParagraphIndex = nParagraphIndex;
                        }
                        else
@@ -445,7 +445,7 @@ Reference< security::XPolicy > const & AccessController::getPolicy()
        MutexGuard guard( m_aMutex );
        if (! m_xPolicy.is())
        {
-            m_xPolicy = xPolicy;
+            m_xPolicy = std::move(xPolicy);
        }
    }
    return m_xPolicy;
@@ -526,7 +526,7 @@ void SAL_CALL OServiceManagerWrapper::setPropertyValue(
        }

        MutexGuard aGuard( m_aMutex );
-        m_xContext = xContext;
+        m_xContext = std::move(xContext);

    }
    else
@@ -91,7 +91,7 @@ bool GenDocumentLockFile::CreateOwnLockFile()
        ::ucbhelper::Content aTargetContent( GetURL(), xEnv, comphelper::getProcessComponentContext() );

        ucb::InsertCommandArgument aInsertArg;
-        aInsertArg.Data = xInput;
+        aInsertArg.Data = std::move(xInput);
        aInsertArg.ReplaceExisting = false;
        uno::Any aCmdArg;
        aCmdArg <<= aInsertArg;
@@ -1786,7 +1786,7 @@ namespace svxform
                    Reference< XNameContainer > xContainer = xFormsSupp->getXForms();
                    if ( xContainer.is() )
                    {
-                        m_xDataContainer = xContainer;
+                        m_xDataContainer = std::move(xContainer);
                        const Sequence< OUString > aNameList = m_xDataContainer->getElementNames();
                        for ( const OUString& rName : aNameList )
                        {
@@ -2311,7 +2311,7 @@ namespace svxform
                    Reference< css::xml::dom::XNode > xNewNode =
                        m_xUIHelper->renameNode( m_pItemNode->m_xNode, m_xNameED->get_text() );
                    m_xUIHelper->setNodeValue( xNewNode, m_xDefaultED->get_text() );
-                    m_pItemNode->m_xNode = xNewNode;
+                    m_pItemNode->m_xNode = std::move(xNewNode);
                }
            }
            catch ( Exception const & )
@@ -2979,7 +2979,7 @@ namespace svxform
                                m_xBindLB->append_text(sEntry);

                                if ( !m_xTempBinding.is() )
-                                    m_xTempBinding = xPropSet;
+                                    m_xTempBinding = std::move(xPropSet);
                            }
                        }
                    }
@@ -115,8 +115,8 @@ bool SvxGalleryItem::PutValue( const css::uno::Any& rVal, sal_uInt8 /* nMemberId

    m_nType = nType;
    m_aURL = aURL;
-    m_xDrawing = xDrawing;
-    m_xGraphic = xGraphic;
+    m_xDrawing = std::move(xDrawing);
+    m_xGraphic = std::move(xGraphic);

    return true;
 }
@@ -311,7 +311,7 @@ void SwHTMLWriter::OutForm( bool bTag_On, const SwStartNode *pStartNd )
        {
            // A form should be opened in the table/area which isn't completely
            // inside the table. Then we must also now open the form.
-            xNewFormComps = xCurrentFormComps;
+            xNewFormComps = std::move(xCurrentFormComps);
        }
    }

@@ -329,7 +329,7 @@ void SwHTMLWriter::OutForm( bool bTag_On, const SwStartNode *pStartNd )
        //!!!nWarn = 1; // Control will be assigned to wrong form
    }

-    mxFormComps = xNewFormComps;
+    mxFormComps = std::move(xNewFormComps);

    OutForm( true, mxFormComps );
    uno::Reference< beans::XPropertySet >  xTmp;
@@ -6089,7 +6089,7 @@ void SwContentTree::EditEntry(const weld::TreeIter& rEntry, EditEntryMode nMode)
                    Reference< XIndexAccess> xIdxAcc(xModel->getDocumentIndexes());
                    Reference< XNameAccess >xLocalNameAccess(xIdxAcc, UNO_QUERY);
                    if(EditEntryMode::RENAME == nMode)
-                        xNameAccess = xLocalNameAccess;
+                        xNameAccess = std::move(xLocalNameAccess);
                    else if(xLocalNameAccess.is() && xLocalNameAccess->hasByName(pBase->GetTOXName()))
                    {
                        Any aIdx = xLocalNameAccess->getByName(pBase->GetTOXName());
@@ -9530,7 +9530,7 @@ void  DomainMapper_Impl::ImportGraphic(const writerfilter::Reference<Properties>
        {
            // Remember this object is anchored to the current paragraph.
            AnchoredObjectInfo aInfo;
-            aInfo.m_xAnchoredObject = xTextContent;
+            aInfo.m_xAnchoredObject = std::move(xTextContent);
            if (m_pGraphicImport)
            {
                // We still have the graphic import around, remember the original margin, so later
@@ -9549,7 +9549,7 @@ void  DomainMapper_Impl::ImportGraphic(const writerfilter::Reference<Properties>
            {
                // Remember this object is anchored to the current paragraph.
                AnchoredObjectInfo aInfo;
-                aInfo.m_xAnchoredObject = xTextContent;
+                aInfo.m_xAnchoredObject = std::move(xTextContent);
                aInfo.m_xRedlineForInline = m_aRedlines.top().back();
                m_aTextAppendStack.top().m_aAnchoredObjects.push_back(aInfo);
            }
@@ -211,19 +211,17 @@ void OOXMLDocumentImpl::importSubStreamRelations(const OOXMLStream::Pointer_t& p

        if(xRelation.is())
        {
-            mxCustomXmlProsDom = xRelation;
+            mxCustomXmlProsDom = std::move(xRelation);
        }
    }
    else if(OOXMLStream::EMBEDDINGS == nType)
    {
-        mxEmbeddings = xcpInputStream;
+        mxEmbeddings = std::move(xcpInputStream);
    }
    else if(OOXMLStream::CHARTS == nType)
    {
        importSubStreamRelations(cStream, OOXMLStream::EMBEDDINGS);
    }
-
-
 }

 void OOXMLDocumentImpl::setXNoteId(const sal_Int32 nId)
@@ -112,7 +112,7 @@ public:
        Reference< T > xElement;
        if ( ! ( aElement >>= xElement ) )
            throw IllegalArgumentException();
-        things[ aName ] = xElement;
+        things[ aName ] = std::move(xElement);
    }
    virtual void SAL_CALL removeByName( const OUString& aName ) override
    {
@@ -1392,7 +1392,7 @@ void HierarchyContent::insert( sal_Int32 nNameClashResolve,
    // Identifier changed?
    bool bNewId = ( xId->getContentIdentifier()
                            != m_xIdentifier->getContentIdentifier() );
-    m_xIdentifier = xId;
+    m_xIdentifier = std::move(xId);

    if ( !storeData() )
    {
@@ -875,7 +875,7 @@ bool HierarchyEntry::first( iterator & it )
                OSL_ENSURE( xHierNameAccess.is(),
                            "HierarchyEntry::first - No hier. name access!" );

-                it.dir = xHierNameAccess;
+                it.dir = std::move(xHierNameAccess);

                it.officeDirs = m_xOfficeInstDirs;
            }
@@ -154,7 +154,7 @@ OUString DefaultFontConfiguration::tryLocale( const OUString& rBcp47, const OUSt
                {
                    Any aAny = m_xConfigAccess->getByName( it->second.aConfigLocaleString );
                    if( aAny >>= xNode )
-                        it->second.xAccess = xNode;
+                        it->second.xAccess = std::move(xNode);
                }
            }
            catch (const NoSuchElementException&)
@@ -2204,7 +2204,7 @@ TransferableDataHelper TransferableDataHelper::CreateFromPrimarySelection()
                   if( xTransferable.is() )
                   {
                           aRet = TransferableDataHelper( xTransferable );
-                           aRet.mxClipboard = xSelection;
+                           aRet.mxClipboard = std::move(xSelection);
                   }
               }
           catch( const css::uno::Exception& )
@@ -1039,7 +1039,7 @@ static void lcl_setErrorBarSequence ( const uno::Reference< chart2::XChartDocume
        xDataSource->getDataSequences());

    aSequences.realloc( aSequences.getLength() + 1 );
-    aSequences.getArray()[ aSequences.getLength() - 1 ] = xLabelSeq;
+    aSequences.getArray()[ aSequences.getLength() - 1 ] = std::move(xLabelSeq);
    xDataSink->setData( aSequences );

 }
@@ -1517,11 +1517,11 @@ OUString SdXMLExport::ImpCreatePresPageStyleName( const Reference<XDrawPage>& xD
            if( xPropSet2.is() )
                xPropSet = PropertySetMerger_CreateInstance( xPropSet1, xPropSet2 );
            else
-                xPropSet = xPropSet1;
+                xPropSet = std::move(xPropSet1);
        }
        else
        {
-            xPropSet = xPropSet1;
+            xPropSet = std::move(xPropSet1);
        }

        const rtl::Reference< SvXMLExportPropertyMapper > aMapperRef( GetPresPagePropsMapper() );