ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
510,133 Commits 3 Branches 3 Tags
c4c93d1a3ebfcf40bdfda28c1b269a1efc014895
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Christopher Sherlock c4c93d1a3e vcl: pdfwriter_impl1.cxx and pdfwriter_impl2.cxx from gdi/ to pdf/ directory 
Update clang plugin.

Change-Id: I0d862e8c08ef829d4f452108fec6176532af3ecb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190712
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2025-09-29 09:36:45 +02:00
Christopher Sherlock 5d20f6a4ae iwyu: remove file that was removed some time ago 
Change-Id: Id935f1e568eac29f3096d893e9bf342d949e8716
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191140
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
 2025-09-18 21:57:23 +02:00
Christopher Sherlock 924c559c7d vcl: convert define statements to constexpr variables 
Change-Id: Ic56e4dbc933117aadb73b558b0e236322b4a7106
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174730
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-09-17 23:04:37 +02:00
Christopher Sherlock 09ac4fb3e1 vcl: pdfwriter.cxx from gdi/ to pdf/ directory 
Change-Id: Ib0a1f1793441313f5b9e2f4de51f7d5096b1230d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190711
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
 2025-09-17 09:29:21 +02:00
Christopher Sherlock 251ed5de09 vcl: pdfobjectcopier.cxx from gdi/ to pdf/ directory 
Change-Id: I654c9650323307f8436399dab18ac621977112df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190710
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
 2025-09-17 09:29:08 +02:00
Christopher Sherlock bbc20e3ac2 vcl: remove unnecessary variable 
Change-Id: I68b1a198c884100c9e9d5d8aeab8952fde533d62
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189602
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
 2025-09-17 09:28:20 +02:00
Christopher Sherlock b24d9ab858 vcl: move pdfextoutdevdata.cxx from gdi to pdf directory 
Change-Id: I59126f48075b78be82ac00bf8d6bb3055b98ba31
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190708
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
 2025-09-16 09:08:40 +02:00
Christopher Sherlock 0308304366 vcl: flatten OutputDevice::GetBitmap() 
We don't need to use the bClipped variable - instead, we return the
clipped bitmap if possible. If clipping wasn't possible, then it just
falls back to the code that would have run anyway.

Change-Id: Ia4c1e567d7fcfc19916aec515aee942e9d42bb15
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189601
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
 2025-09-16 09:01:17 +02:00
Christopher Sherlock c9321bab19 vcl: streamline assignment of bClipped 
This clarifies the variable. The variable is reused, but the first use
is to detect whether the area *should* be clipped. The second use of the
variable determines if the area *has been* clipped. Obviously, it makes
no sense to say that the area has been clipped (true) before we actually
do the clipping, so we should be setting it to false at the start of the
if statement. Then when the clipping succeeds then we can say that it
was successful.

This also removes the need to set the variable in several else
statements and we only have to set the variable to true once the
clipping succeeds.

In the next patch, I will also remove the need for the second
modification of the bClipped variable as we can just return the bitmap -
but it is far more clear what I'm doing with this patch.

Change-Id: If8e217975a7a1fa7efff8fb3607040e3269495e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189600
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-09-16 08:59:16 +02:00
Christopher Sherlock 0f78e4b7e9 vcl: move pdfbuildin_fonts.cxx from gdi to pdf directory 
Change-Id: I11bec794bb237b967702c516e18b8ebfc95fba2e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190701
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-09-11 09:25:29 +02:00
Christopher Sherlock c5f4ff057e vcl: statement on next line to prevent confusion 
Change-Id: I5d02749d2bbcb17bfb3a72d5f370ac2256e400d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189785
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-09-10 08:46:19 +02:00
Christopher Sherlock 29113a6c63 vcl: move variables closer to first use in AnimationRenderer::draw() 
Change-Id: I66844a3a7f7d7e1b8496ac73fabc1a44f5c93b30
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182061
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-09-09 10:52:27 +02:00
Christopher Sherlock 168b24b76a vcl: flatten AnimationRenderer::draw() 
Change-Id: I05b717cefe1686b65bf26d17adbc45e2a4bee8e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182060
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-09-02 07:48:19 +02:00
Christopher Sherlock 33f050624e vcl: flatten AnimationRenderer::draw() 
Change-Id: Ie5b3c969e6fa13eda526ee3123f7160e844711c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182059
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-09-02 07:47:14 +02:00
Christopher Sherlock 6ef6e31e32 vcl: flatten OutputDevice::DrawGradient() 
Change-Id: I1042b3750025277b4c24d57fdd7751685e69dfce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189703
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
 2025-09-02 07:44:35 +02:00
Christopher Sherlock 1fd581290c vcl: rename parameters in OutputDevice::DrawDeviceAlphaBitmapSlowPath() 
Whilst we are about it, make rBmpRect a const reference.

Change-Id: If95d31c1d0b7204f6c7681c613429f1d317ec7a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188810
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-09-01 15:06:53 +02:00
Christopher Sherlock 78c26e59e3 vcl: flatten OutputDevice::DrawGradient() 
Change-Id: Ic622cf6a87ed253266e2edd1ea5c6363b9f480d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189701
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-08-28 14:01:50 +02:00
Christopher Sherlock bf348b395f vcl: flatten OutputDevice::DrawGradient() 
Change-Id: Ie534864d8bb32621a65eb638f5ee50e5e013f358
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189700
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
 2025-08-28 13:59:53 +02:00
Christopher Sherlock 98e54efc20 vcl: make aTradContext const 
Change-Id: I345bedc249068208b4b52b19e0e53e02677b0de1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188809
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
 2025-08-24 22:34:50 +02:00
Christopher Sherlock 2a3039e3d0 vcl: flatten OutputDevice::AttemptOLEFontScaleFix() 
Change-Id: Iac7dfec9622e60f0dc2ac0082ee8935077e3b5ef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189697
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
 2025-08-18 07:58:04 +02:00
Christopher Sherlock 45e1e63cce vcl: make destination rect param const in DrawDeviceAlphaBitmapSlowPath() 
Change-Id: I3e8811a56abd20ab5b3eed72347c43be7d4de00d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188808
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-08-16 09:30:18 +02:00
Christopher Sherlock 9e172b671a vcl: flatten OutputDevice::DrawGradient() 
Change-Id: Id365088129fe808703e77f304d9f28cb5d2dd444
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189699
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-08-15 22:33:31 +02:00
Christopher Sherlock d17a8c8ee6 vcl: make variables const in OutputDevice::AttemptOLEFontScaleFix() 
Change-Id: Ifdfebf3244f07e4353c8510d7644f4ec02b2f9a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189696
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-08-15 22:28:04 +02:00
Christopher Sherlock 790d17beb8 vcl: flatten OutputDevice::DrawHatch() 
Change-Id: Ie615a93c4f81130cdea280f9ee1160b5db754791
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189611
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-08-15 22:27:42 +02:00
Christopher Sherlock b914d1853e vcl: flatten OutputDevice::DrawEPS(() 
Change-Id: I023a773b25998405f4bd7693b93d33eddfcd06a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189606
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-08-15 10:06:38 +02:00
Christopher Sherlock 186a020f5e vcl: flatten OutputDevice::DrawHatch() 
Change-Id: I674ce8cde19486e99609b052a7c47078df3f6d39
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189610
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-08-15 10:05:11 +02:00
Christopher Sherlock d57d5ac146 vcl: flatten OutputDevice::ImplClearAllFontData() 
Change-Id: Icf3018a62e8844d8b148382289e162dc8b082057
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189607
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-08-15 08:12:00 +02:00
Christopher Sherlock 6d964225e7 vcl: remove unnecessary, confusing variables 
Change-Id: I2bd079e02500be114eb0c4dde2f349cf179f8fd3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188807
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-08-15 07:22:23 +02:00
Christopher Sherlock 26ab75625a vcl: no need to cast away rImage constness 
Image::Draw() is a const function, but wasn't marked as such. I have now
made it const, so this means I can remove the const_cast.

Change-Id: Ie2a8746affd56e0d80e50d3f9edd372cdb3ff491
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189419
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-08-12 16:15:27 +02:00
Christopher Sherlock d0a5366b82 vcl: flatten OutputDevice::DrawBitmap() 
Change-Id: I868ffb1c575576d90fa423500efe722512764efc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189251
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
 2025-08-11 09:45:01 +02:00
Christopher Sherlock 7b93ad1ff2 vcl: flatten OutputDevice::DrawBitmap() 
Change-Id: I3f646c9fe89b7d3f4527c0c5f857764586db6e6a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189250
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-08-11 09:36:51 +02:00
Christopher Sherlock 4a13377043 vcl: move bitmap readers into lcl_BlendBitmapWithAlpha() 
Change-Id: Ie0bdba4a43823822a4b25ad37986718222f5c7e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188804
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-08-11 08:20:39 +02:00
Christopher Sherlock bdafaec3a6 vcl: clarify what sort of bitmap we are looking at 
Change-Id: I83ab4cf2cf96fc78a254010d07de59acb0c70f70
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188803
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-08-09 18:08:07 +02:00
Christopher Sherlock 18720bd36a vcl: make nResAlpha const 
Change-Id: I3f18534b4edbc7cbaff5b7aa15467f338ace4cef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188802
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-08-09 09:31:12 +02:00
Christopher Sherlock 10599fd334 vcl: rename to lcl_AlphaBlendColors() and remove temp variable 
Change-Id: Ib19394303d26bddf683db23d76288fdeb25f9cf4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188801
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-08-08 15:55:35 +02:00
Christopher Sherlock e68ae6bbda vcl: lcl_AlphaBlend() simplify to mix a color with another with an alpha value 
Change-Id: I72725af813935bf2788618ef9f34eeef2ad1bbf2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188800
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-08-08 09:24:03 +02:00
Christopher Sherlock a143ed3bee vcl: make aSrcCol const 
Change-Id: I3d13edcb773e147788295cbe61b904b0d27d0baa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188799
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-08-07 15:41:35 +02:00
Christopher Sherlock 47a8ba44e6 vcl: rename parameters of lcl_BlendBitmapWithAlpha() 
Change-Id: I2daff5bf4ab3c07b8f8b656999ba1afe0f9c6f4e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188798
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-08-05 15:52:06 +02:00
Christopher Sherlock 8c19a807f6 vcl: rename parameters of lcl_AlphaBlend 
Change-Id: Id8911eed9bcc9171fdb3cd057809c752505a8420
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188797
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-08-04 19:55:03 +02:00
Christopher Sherlock 157a0d5d84 vcl: assign after declaration of BitmapColor 
Change-Id: If851792eaf12ba08d30cbc7fe529d2a81aeac64b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188796
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-08-03 19:52:17 +02:00
Christopher Sherlock ce72458a44 vcl: make CheckColor and AlphaBlend use lcl as prefix in name 
Change-Id: I4fd29f17c7236ddec95a822c8166a4b258d94a7e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188795
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-08-02 20:49:09 +02:00
Christopher Sherlock 0de1d5e85e Make function that blends bitmaps be local 
Change-Id: I81dc7474b603e3fb1eca2d7606f71999b2f87749
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188459
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-07-29 13:12:12 +02:00
Christopher Sherlock bf248da3aa vcl: use std::accumulate() for Animation::GetSizeBytes() 
Change-Id: Iaa27d472cc86dbc22b6fe06da0a1f0af1e8cf324
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182048
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-04-17 14:18:01 +02:00
Christopher Sherlock 77bfb60031 vcl: split off IdleFormatter to own source files 
Change-Id: I9f463ed77fbabd6158ce3eb2b045e12fdb0705c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179712
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-04-17 10:52:28 +02:00
Chris Sherlock 921e6117bc vcl: make BitmapDarkenBlendFilter variables constant 
Change-Id: Ib147be577caef168f8089883bf64ad7718a801b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173744
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-04-14 09:26:28 +02:00
Chris Sherlock bb75bdc570 vcl: remove unnecessary includes in calendar.cxx 
Change-Id: Ie8ed143472d79d5fa1b6a415c01efb2f9cc5069b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184125
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-04-14 08:31:37 +02:00
Christopher Sherlock a9caf1506b vcl: flatten StartExtHelp() and EndExtHelp() in Help 
Change-Id: If061ec9e47f89b473ee582ff1f6b6a8d97cbafa9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182062
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-04-07 10:45:00 +02:00
Christopher Sherlock e262ddf89c vcl: flatten ImplFindPartRect() 
Change-Id: I6d6c08355c675f29471e2fcd835ccee3d7cffc48
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179368
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-03-04 16:08:30 +01:00
Chris Sherlock a43320a3ad vcl: make BitmapDarkenBlendFilter use BitmapFilter 
Change-Id: I2ec47793fa094e452f30f9628c121772db578656
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173743
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Jenkins
 2025-03-02 13:15:53 +01:00
Christopher Sherlock 27d027e570 tdf#97228 move include file BitmapDuoToneFilter to vcl/inc/bitmap 
Followup to commit 47272b465 - file was moved to vcl/inc but should have
been moved to vcl/inc/bitmap

Change-Id: Iaff0a5095f6826b52fc51a5f62d98276e37cc348
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182392
Reviewed-by: Hossein   <hossein@libreoffice.org>
Tested-by: Jenkins
 2025-03-01 21:26:58 +01:00
Christopher Sherlock 9d35ad8ee8 vcl: extract ScrollBar hit test functions 
ImplHitTestBtn1(), ImplHitTestBtn2(), ImplHitTestPageUp(),
ImplHitTestPageDown() and ImplHitTestThumb() extracted and used.

Extracted IsHorizontal() and GetScrollbarRegion() to reduce code
duplication (also makes things arguably more clear - thanks to Michael
Weghorn for pointing this out in review).

Change-Id: Ibc9e584ab046046f2e6f1cd3056b8213973e3254
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179242
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
 2025-02-28 09:55:15 +01:00
Christopher Sherlock 91ce2860cc vcl: fix modelines in vcl/source/control/fmtfield.cxx 
Change-Id: I547d4c993f1c1ab6d71dde68d82fc159d1254e28
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181688
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-02-28 09:54:54 +01:00
Christopher Sherlock e4f7dd7593 vcl: simplify Animation::Invert() 
Regardless of whether all the frames are inverted, the animation bitmap
will always be inverted. Thus, we can invert the bitmap first, and then
start inverting all the frames. This simplifies matters because we can
just exit the function with a false return if the invert fails on any
animation frame.

Secondly, this allows us to convert to a for range loop.

Change-Id: Ifa8152e9903bfc53634b67c8933b50915e7a194f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182050
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
 2025-02-27 02:40:33 +01:00
Christopher Sherlock 08d940d3b7 tdf#74702 vcl: make OutputDevice classes aware of animation capability 
Not all OutputDevice classes can animate. In fact, the only class that
can do this currently is WindowOutputDevice, everything else is a static
image.

Rather than check what type of class is being used, I'm introducing
CanAnimate().

Change-Id: I56339214e388aee2e7a564cf10a3f92629f0a6ae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182049
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
 2025-02-27 02:39:24 +01:00
Christopher Sherlock 1d98bf6caa vcl: remove commented out code 
The original code was from 2001, in commit aed8f7e445:

    // in der Detailsview muss das Invalidieren intelligenter erfolgen
    //if( !(nWinBits & WB_DETAILS ))
        pView->Invalidate( INVALIDATE_NOCHILDREN );

This was later translated in commit 25d571fff3.

The reason for the comment is now lost in the mists of time...

Change-Id: I91ea3d2e918ee73ed8d017ca15c6cbbeb00e791f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179208
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
 2025-02-26 17:30:06 +01:00
Christopher Sherlock 8b998ed161 vcl: move FormattedField to own file 
Change-Id: I00e0734ff06c307377e04e2b4d61c637616068b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179184
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
 2025-02-25 08:53:46 +01:00
Chris Sherlock e014935a64 vcl: make control/calendar.cxx variables const 
Change-Id: Icb517aaf92cc6563d01827e7bc608e8b6b7930da
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174729
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-02-25 08:42:27 +01:00
Christopher Sherlock 2068c08a9d vcl: remove i_ prefix and use recommend variable prefixes 
Change-Id: I14d4880784873efbff6746e0bc3737f19e9b9bca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182028
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-02-24 10:08:28 +01:00
Christopher Sherlock 1218e023fd vcl: menubtn.[hc]xx -> MenuButton.[hc]xx 
Change-Id: I0b037261c753df6cd7efc2ee605abc02304c226c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179238
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-02-18 09:52:23 +01:00
Christopher Sherlock 56390eefb1 vcl: flatten Slider:ImplInitSettings() 
Change-Id: I8ca52cc3efc80084c0a30e554437dac5ddee925e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179327
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-02-18 09:45:55 +01:00
Christopher Sherlock b666efedd6 vcl: nType -> eType 
Change-Id: I3e55e6173494f660febc296ec342ab223e5cdec1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178227
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
 2025-02-18 09:44:52 +01:00
Christopher Sherlock de018733fc vcl: remove unnecessary includes from combobox.cxx 
Change-Id: I2c76c67dd6660dc8e9979755eade14d06ad6b000
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178214
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-02-18 09:36:45 +01:00
Christopher Sherlock e4a2fa75e3 vcl: rename DDInfo to DragDropInfo 
Change-Id: I190a3ccea226c7a23eb553a1698d5959b8353b84
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178506
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
 2025-02-18 09:33:55 +01:00
Christopher Sherlock 12b74fa368 vcl: declare variable in for loop 
Change-Id: Ifc2fac7afe552c3dfa0007d4999a5b981c9417fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178944
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-02-18 09:31:18 +01:00
Christopher Sherlock ac07c380ac vcl: rename local functions in spinfld.cxx 
Change-Id: Ifa4a8d7c0e660c125733fa28912eef147fa4aa81
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179378
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
 2025-02-18 09:29:01 +01:00
Christopher Sherlock 67a25eb13f vcl: flatten TabControl::ImplInitSettings() 
Change-Id: I3ca648e45e6d0c22cc195abc3a6a2a858dbae38e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179449
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
 2025-02-18 09:27:59 +01:00
Christopher Sherlock 0f53e4237d vcl: add comments for Window::GetBorder() 
Change-Id: I8113aa5c047bd96c6400044a9dfa34e5381fb001
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181788
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
 2025-02-18 09:24:46 +01:00
Christopher Sherlock 8d01f7a927 vcl: move TextLine to own header file 
Change-Id: I0e7097cc4a020d945a90e732539a0b5773bccf11
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179711
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
 2025-02-17 09:00:13 +01:00
Christopher Sherlock b01c3dc872 vcl: initialize DDInfo members in definition 
Change-Id: I2af2264bca5217b3d96d1abfd3278fec4a1bbf3b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178505
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
 2025-02-17 08:45:19 +01:00
Christopher Sherlock 67d0f364bb vcl: _rStyle -> rStyle 
Change-Id: Icefcd78be0f9a30a3a714e9bc04b8e7a1b6f425e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179145
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
 2025-02-17 08:42:06 +01:00
Christopher Sherlock 90b2fd0212 vcl: fix modelines in vcl/source/control/hyperlabel.cxx 
Change-Id: Idf755506ce2dbe19427dcc042d502e09f8f6357a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181689
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-02-17 08:38:47 +01:00
Christopher Sherlock db83a93b73 vcl: remove unnecessary parentheses 
Change-Id: I76612bb87e4fc95219e95da72357ee123fb273ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179194
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
 2025-02-17 08:38:06 +01:00
Christopher Sherlock 3b4793b366 vcl: document BitmapFilter 
Change-Id: I68cbb0a6b9050c89050afd1906d6fd948f9bff45
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180822
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
 2025-02-14 12:38:15 +01:00
Christopher Sherlock 4159d6238e vcl: remove using namespace from edit.cxx 
Change-Id: Iaf57c25c658686e980171ffd3314f69096421ff7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178504
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
 2025-02-13 20:41:57 +01:00
Christopher Sherlock 95609ed613 vcl: make variables const in combobox.cxx 
Change-Id: Icb94a3341c1eb02f74d18dda7b3af1d83ef30f67
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178212
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-02-10 08:25:15 +01:00
Christopher Sherlock e554da3b29 vcl: OV_DRAWGRID is not ever set anywhere 
Change-Id: I239cf124ebdccc0b9e811e403f763d0c45b640a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179207
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-02-10 08:19:23 +01:00
Christopher Sherlock 8a3a2ab67d vcl: move ImplInit into Slider constructor 
Change-Id: I70a990079443aa0bc3480c8f98235f67ce043611
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179326
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-02-10 08:18:00 +01:00
Christopher Sherlock 58cc936ec7 vcl: remove SpinButton::ImplInit() 
Change-Id: I865d1c46e210c92fa9e4e5cdb4d5272640ce41c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179363
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
 2025-02-10 08:17:10 +01:00
Chris Sherlock 988d09d170 vcl: flatten control/calendar.cxx functions 
Change-Id: I9ed6ca251e40f050ec872c70d3310d330c705e22
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174728
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-02-09 18:07:06 +01:00
Christopher Sherlock 9d8444e165 vcl: remove unnecessary headers from tabctrl.cxx 
Change-Id: I92214814a486209eb07f7398e4ceece890ec1845
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179448
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-02-08 11:46:03 +01:00
Christopher Sherlock f07092c3ea vcl: remove unnecessary headers in throbber.cxx 
Change-Id: Ie9fc341bdcc71b57d8bfae12d84a5100f1f029c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179665
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-02-08 11:45:44 +01:00
Christopher Sherlock 1ac1da97a1 vcl: remove unnecessary incldues in hyperlabel.cxx 
Change-Id: I214a9368523a521f2115b9e22b547325fbbae57f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179192
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-02-08 09:42:43 +01:00
Christopher Sherlock 3d26b7363a vcl: nStyle -> eStyle 
Change-Id: Iae6c45830ccbfdf1841099270572ecb9fd7c8109
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178226
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-02-08 08:13:27 +01:00
Christopher Sherlock 3d85419747 vcl: ImplCalcPos() -> lcl_CalcPos() 
Change-Id: Idbfd93d8d8faf12c516fd34642ef8ca33c14d189
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179144
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-02-08 08:11:00 +01:00
Christopher Sherlock 332af14e82 vcl: remove using namespace from fmtfield.cxx 
Change-Id: I43e4c6c34d76d97e5073167fee8af25fd887bde3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179183
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-02-08 08:10:40 +01:00
Christopher Sherlock 9d76dc9bfe vcl: remove using namespaces from field.cxx 
Change-Id: Ie5e8463184171e4660aecc3395d6e85cb30dcc2e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178942
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-02-08 08:10:21 +01:00
Christopher Sherlock aa1e2fc959 vcl: rename enum variable prefixes 
Change-Id: I1177e876d3959da2e9349c1cd4441a612951199e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178211
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-02-03 17:26:37 +01:00
Christopher Sherlock a838bac7b7 vcl: aType -> eType 
Change-Id: Iceca9108d9cba3c3f5680ebb78926f430b29f73a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178210
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-02-03 08:47:02 +01:00
Christopher Sherlock 6ec3ff63df vcl: remove unnecessary includes in ctrl.cxx 
Change-Id: I62f7ab6b3e3bcc1fcf1994a142e0d444344d76c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178225
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-02-03 08:46:24 +01:00
Christopher Sherlock 1dd3ab8842 vcl: remove unnecessary includes in fmtfield.cxxx 
Change-Id: I8b08a8ca072040c5ebf9c667d618ffb0d0b21c71
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179182
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-02-03 08:46:05 +01:00
Christopher Sherlock 01f48ef201 vcl: remove implInit() from HyperLabel 
Change-Id: I45d1f519f812529f0913d4a4453201a59d984163
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179191
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-02-03 08:45:47 +01:00
Christopher Sherlock ea047987b5 vcl: ignore readability commit 
Change-Id: I4ba970c5b3f35ccd7863bd751ef76d90d2e36947
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178347
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-02-02 07:25:33 +01:00
Christopher Sherlock 1a60a7e953 vcl: remove unnecessary headers in edit.cxx 
Change-Id: I7da22e688d579e050918f7749707c1cb6bba47e6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178503
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-02-02 07:24:55 +01:00
Christopher Sherlock 1664473342 vcl: remove unnecessary comments 
Change-Id: I38f26fea85b3af7e52db81863c967bd689ee059a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179206
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-02-02 07:24:20 +01:00
Christopher Sherlock 5823e25c92 vcl: simplify ImplCalcPos() 
Change-Id: Ie7ea3b4f88c6740cb00b01c739f943d2e8011204
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179143
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-02-02 07:23:52 +01:00
Chris Sherlock 1b6fbba88b vcl: make calendar.cxx more readable 
Change-Id: I9fe1549417ffcb0f788ca941216dfd4a103544e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174726
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-02-02 07:22:50 +01:00
Christopher Sherlock 0397476059 vcl: remove unnecessary includes from field.hxx 
Change-Id: I33ef533895f089bb5dfb78424fc407e568f9165f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178941
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-02-02 07:14:09 +01:00
Chris Sherlock 10d8402957 vcl: move variables closer to first use in BitmapColorQuantizationFilter 
Change-Id: I8a539718ef0eedfea9fadb2bd5ec321bcb8f108e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173703
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-01-23 10:56:42 +01:00
Christopher Sherlock f8bf05b294 vcl: don't initialize variable and then immediately clobber it in for loop 
As pointed out by Mike Kaganski in
https://gerrit.libreoffice.org/c/core/+/177805 we are setting the loop
counter to 0 and then immediately reinitializing it to 1 in the for
loop.

As this is not necessary, just declaring the variable initially without
initializing it.

Change-Id: Ia91cd6c46a62786dc14c459f1b44daecd758ec90
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180567
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
 2025-01-22 17:37:49 +01:00
Chris Sherlock 340f0965e6 vcl: move variables closer to first use in BitmapColorizeFilter 
Change-Id: I3f08511689a2118713f2b75436459501e51ed893
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173702
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-01-20 09:40:22 +01:00