Caolán McNamara
0f2d897059
check the class of a nested user type found by name in SbiImage::Load
...
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Change-Id: Ic9215a25384e07e6c082efbeb3b79dc4b56d158c
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/13657
Reviewed-by: Noel Grandin <noel.grandin@collabora.com >
Tested-by: Jenkins CPCI <releng@collaboraoffice.com >
(cherry picked from commit 48162866845dd588ec0a85a9e9e93ed4477d7771)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211727
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org >
2026-10-05 08:56:53 +02:00
Caolán McNamara
0e705d4a0b
keep each string of a Basic image string pool inside the pool
...
an image with string offsets outside its pool is not loaded
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Change-Id: I55360ac5f348929f29514982fcf74c7ddb93961e
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/13652
Reviewed-by: Noel Grandin <noel.grandin@collabora.com >
Tested-by: Jenkins CPCI <releng@collaboraoffice.com >
(cherry picked from commit fc0c18c508cd34bc8a17d534193de8992acdade0)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211625
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org >
2026-10-02 09:53:03 +02:00
Caolán McNamara
b94e7a82c7
don't preload a password protected library of a document
...
Preloading it when the library container is created recursed. It gets
loaded along with the document's Basic project instead.
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Change-Id: I14b24d93dacdbf856bc9ef5d3e6fa1a885666100
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/13616
Tested-by: Jenkins CPCI <releng@collaboraoffice.com >
Reviewed-by: Noel Grandin <noel.grandin@collabora.com >
(cherry picked from commit ef186208097f9525e3e376fb8e677c643498f02f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211598
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org >
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org >
2026-10-01 14:36:21 +02:00
Caolán McNamara
a1fa358d47
don't create the document BasicManager on save to check module sizes
...
Creating it loads every Basic library of the document. Only an
existing BasicManager can have loaded the password protected
modules that the size check looks at.
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Change-Id: I1a66c4738d9a91cda785f0603c6f4fd6e6549802
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/13628
Reviewed-by: Noel Grandin <noel.grandin@collabora.com >
(cherry picked from commit 35fb01a50f47698e9b059b75c2a3b88699579fac)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211524
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org >
2026-09-30 14:41:13 +02:00
Caolán McNamara
362360f3fe
check the class of a loaded SbxArray and its elements
...
like the other SBX loaders already do
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Change-Id: Id7989d2b4023c17a29a0fc92b03b574968484b78
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/13617
Tested-by: Jenkins CPCI <releng@collaboraoffice.com >
Reviewed-by: Noel Grandin <noel.grandin@collabora.com >
(cherry picked from commit 1ccef9f52d3132b6917a76f64a697ad0795e5f9f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211531
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org >
2026-09-29 08:46:08 +02:00
Caolán McNamara
2399c6b9e5
clear the old value before loading an old format SbxVariable
...
as the newer format already does
The old format path set the new type without clearing an existing value
first, so the new type bogusly redefined whatever the union still held.
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Change-Id: I70d02026d24443ab353be37c0a57685b4e7ac969
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/13600
Reviewed-by: Noel Grandin <noel.grandin@collabora.com >
Tested-by: Jenkins CPCI <releng@collaboraoffice.com >
(cherry picked from commit 27d9427be60d57d3054c01c8806c81b89bd3872d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211530
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org >
Tested-by: Jenkins
2026-09-29 08:46:04 +02:00
Jan Luethi
a942eb4878
tdf#145614 Convert #define to constexpr
...
Change-Id: I156a1a231cab8277462eddbc044f4b3378f73448
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211386
Reviewed-by: Hossein <hossein@libreoffice.org >
Tested-by: Jenkins
2026-09-24 21:59:48 +02:00
Andrea Gelmini
6a1480506d
Fix typos
...
Change-Id: I9d99aba8500ea31628e4b883974bb60181407647
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210562
Tested-by: Julien Nabet <serval2412@yahoo.fr >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2026-09-10 22:08:01 +02:00
DrRobotto
319ac1ac8f
cid#1700598 - Guard the element probe against empty arrays
...
Change-Id: I7c887abae0aa4c830aac54ce3e9cee0d890757b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210333
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de >
Tested-by: Jenkins
2026-09-05 08:53:02 +02:00
Andreas Heinisch
44eaeaf2cd
tdf#173360 - On...GoSub must return to the line following
...
The GoSub flag (0x8000) was cleared before being tested, so PushGosub
never returned to the following line when returning using a Return
statement.
Change-Id: Ic1e6977d48a34c52ed9c24c5be0d9acfa3eb7552
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210395
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de >
Tested-by: Jenkins
2026-09-02 17:52:41 +02:00
Xisco Fauli
cf1dcdfe51
cid#1700598: Out-of-bounds access
...
Change-Id: I0ef83251296a5fa6bd8d60b3cb32473a9191852e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210280
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org >
2026-08-31 16:06:42 +02:00
Andrea Gelmini
5e260045bc
Fix typos in code and comments
...
Change-Id: I47802ff4d8e27e738fde2b5ccb92a7765332eb51
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210151
Tested-by: Julien Nabet <serval2412@yahoo.fr >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2026-08-29 16:19:03 +02:00
Andrea Gelmini
7dcc068124
Fix typos
...
Change-Id: I170af8cd8bcbc969631ee603f20efcf40b68e517
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210038
Tested-by: Julien Nabet <serval2412@yahoo.fr >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2026-08-27 15:00:22 +02:00
Andrea Gelmini
892dcd7597
Fix typos
...
Change-Id: I9351b0b67805f2e8b9994aa95f75b2aadba15aa2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209883
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2026-08-25 10:36:52 +02:00
DrRobotto
3f3b83a961
tdf#102381 - Add additional information about a missing parameter
...
Pass over an omitted argument as a missing parameter instead of a
numeric zero, so that optional parameters, their default values and the
basic function IsMissing() behave accordingly.
Change-Id: I7c4a65dfb1791f8aa900cc9eddd3007422dc41a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209457
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de >
2026-08-23 11:29:28 +02:00
Andrea Gelmini
335726898d
Fix typos
...
Change-Id: Idab619de99649c2fb0a1920844cb07e5ede9691c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209474
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Julien Nabet <serval2412@yahoo.fr >
2026-08-22 10:25:17 +02:00
Andrea Gelmini
12051c954c
Fix typos
...
Change-Id: I73c907ed17d513e9d07859bbb6bf1f149a0d7828
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209377
Tested-by: Julien Nabet <serval2412@yahoo.fr >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2026-08-20 18:54:20 +02:00
Mike Kaganski
e59e33f064
tdf#171370: a char must stringify to itself
...
Regression after commit 2143c0a694
(Simplify getter/setter implementations, 2025-06-03): sal_Unicode is
std::integral, and took the generic numeric path.
Co-authored-by: Andreas Heinisch <andreas.heinisch@yahoo.de >
Signed-off-by: Mike Kaganski <mike.kaganski@collabora.com >
Change-Id: I0c12590c06536f4d2efefcbe09657fff454ed2a4
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/8798
Tested-by: Jenkins CPCI <releng@collaboraoffice.com >
Reviewed-by: Miklos Vajna <vmiklos@collabora.com >
(cherry picked from commit e725c25d6cb8c9cd1af08f70f6fea541df121b1d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209264
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org >
Tested-by: Jenkins
2026-08-19 08:36:23 +02:00
Andreas Heinisch
0f8dcc20df
tdf#146873 - Inspect elements when they are non-fixed
...
For instance, when they were created using Split(), since they may have
been reassigned to a different type.
Change-Id: Ib562dad0156fac267982a224395559713831042c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209107
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de >
Tested-by: Jenkins
2026-08-18 09:06:57 +02:00
Niko Myllymäki
0709a6c543
tdf#147132 Flatten Basic function implementations in methods1.cxx
...
Change-Id: I21eea12876303ef132f4c1922e501db987f352c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209030
Reviewed-by: Neil Roberts <nroberts@libreoffice.org >
Tested-by: Jenkins
2026-08-17 12:32:35 +02:00
Marios
92f880f952
tdf#147132 Flatten basic function SbRtl_CSng
...
Change-Id: I9f82d6d8f0e69193b036cdebd6b8099e7798959b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208834
Reviewed-by: Neil Roberts <nroberts@libreoffice.org >
Tested-by: Jenkins
2026-08-17 10:21:04 +02:00
ApurvR20
097919db22
tdf#154285 Check argument count in SbRtl_Fix
...
Change-Id: I0b067eb0e90f3824cafc7df22eefd30ac6d0bef4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209005
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org >
2026-08-11 08:39:53 +02:00
Andrea Gelmini
00cb1a2abf
Fix typo
...
Change-Id: I32ce286d8196423f6994272d2865820e96a9c0c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208508
Tested-by: Julien Nabet <serval2412@yahoo.fr >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2026-07-26 09:43:27 +02:00
Neil Roberts
f213860e49
basic/sbxmod: Combine two impls of CutLines into helper method
...
Previously there were two copies of a function called CutLines which
were used to remove a method from a string containing BASIC source code.
These have both been replaced with a helper method on SbModule that
returns the source without the given method.
Change-Id: I70c4a4ffe40085bd090ee6823c46154c057468e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/207062
Tested-by: Jenkins
Reviewed-by: Neil Roberts <nroberts@libreoffice.org >
2026-07-22 15:59:07 +02:00
Neil Roberts
0b7d925276
sbutil/searchEOL: Fix mixed endings with first one \r
...
Fixes the case when the string to be searched contains mixed ending
types and the first one is “\r”. Previously it would have searched for
the “\n” first and skipped over the “\r”.
Change-Id: I945087f2b93d92e73781c07b9b3cdaf9064d1122
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/207061
Tested-by: Jenkins
Reviewed-by: Neil Roberts <nroberts@libreoffice.org >
2026-07-22 15:59:00 +02:00
Neil Roberts
af830cc577
Move searchEOL from basicide to a general basic utility
...
Moves the searchEOL function from basicide to a general purpose utility
function in the basic module. This also adds some unit tests for it.
Change-Id: I8f446990654415a994b7964dd62706f3204d817a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/207060
Tested-by: Jenkins
Reviewed-by: Neil Roberts <nroberts@libreoffice.org >
2026-07-22 15:58:49 +02:00
Neil Roberts
9b60447481
Make SbMethod::GetLineRange const
...
This method doesn’t modify any state so I don’t think there’s any reason
not to make it const.
Change-Id: I51748ce2d95b2967ae76b9c5015a49df99d7fa07
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/207059
Reviewed-by: Neil Roberts <nroberts@libreoffice.org >
Tested-by: Jenkins
2026-07-22 15:58:39 +02:00
Marios
d84a82ad7a
tdf#147132 Flatten basic function SbRtl_CDbl
...
Change-Id: I875d48e4f55f1d70aaf279542efeeb5297c450f8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208199
Reviewed-by: Neil Roberts <nroberts@libreoffice.org >
Tested-by: Jenkins
2026-07-22 10:10:28 +02:00
ApurvR20
54b3494de7
tdf#147132 : Flatten Basic function implementations
...
Flatten implementation of SbRtl_Weekday in basic/source/runtime/methods1.cxx.
Change-Id: I17931cfecc24be9c114daa9c6c221e6c00a4e3aa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208256
Tested-by: Jenkins
Reviewed-by: Neil Roberts <nroberts@libreoffice.org >
2026-07-20 09:38:38 +02:00
Sapphire
e08f567f1d
tdf#147132 flatten basic function implementations
...
Change-Id: I66e82085eaa303eabaee268bd5b46a41d66a361a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/204326
Tested-by: Jenkins
Reviewed-by: Neil Roberts <nroberts@libreoffice.org >
2026-07-10 17:15:07 +02:00
Furkan Ahmet Kara
7f2472b873
tdf#154285 Check argument count in BASIC SGN function
...
Change-Id: Ic20ceed1d736ea2436bc4dd37cfd242efcec79b4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/206268
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org >
2026-07-04 07:17:42 +02:00
Mike Kaganski
c64fc39bf3
Use NameContainer's owner as event source
...
The owner is set since commit 0f3f371028
(NameContainer need not be an UNO object itself, 2024-12-01), and is
the same object that was used to set event source. Drop the redundancy.
Signed-off-by: Mike Kaganski <mike.kaganski@collabora.com >
Change-Id: Ie6d50696781395136349ad8084653e624437533d
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/5026
Tested-by: Jenkins CPCI <releng@collaboraoffice.com >
Reviewed-by: Miklos Vajna <vmiklos@collabora.com >
(cherry picked from commit 6a5646b1abcdc9e61cf9b5ca42d65280bc520b39)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/207165
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org >
2026-06-23 17:21:33 +02:00
Mike Kaganski
6601fe8419
cool#15956: keep insertion order in NameContainer's getElementNames
...
This is required to keep content of Basic/script-lc.xml and each
Basic/<lib>/script-lb.xml byte-identical on round-trip, which is
necessary for signatures to stay valid; this broke after commit
ea2a974386 (Simplify NameContainer,
2024-12-01).
Signed-off-by: Mike Kaganski <mike.kaganski@collabora.com >
Change-Id: Ib30b701dce8bbcb919c88f5b66f5134150ded575
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/5025
Tested-by: Jenkins CPCI <releng@collaboraoffice.com >
Reviewed-by: Miklos Vajna <vmiklos@collabora.com >
(cherry picked from commit bfe67bc782cf89e944324042c8e53c42f4b6421b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/207164
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org >
Tested-by: Jenkins
2026-06-23 16:48:18 +02:00
Michael Weghorn
f26084217a
weld: Move weld::Button to own header/Rename weld.hxx
...
In the past, weld.hxx used to contain the class
definitions for weld::Widget and all subclasses.
By now, weld::Widget and almost all subclasses have
been moved to separate headers, to make it easier
to keep the overview and to avoid having to
recompile ~all UI code when one class changes.
By now, only weld::Button is left in weld.hxx.
Rename the header to Button.hxx.
Drop weld.hxx includes and instead add Button.hxx
includes (or weld::Button forward declarations) where
weld::Button is used.
(Don't simply replace all weld.hxx includes with
Button.hxx ones, since many of them were for the
use of other widgets that have since been moved
to their own headers.)
Add further includes where needed now that the
(direct or transitive) includes of weld.hxx were removed.
Change-Id: I8ea6201446a418d5e38b46337059dcd517ee29d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205937
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de >
Tested-by: Jenkins
2026-06-05 07:58:07 +02:00
Xisco Fauli
8a91868e21
drop JSDialog machinery
...
It's no longer needed and not used internally
Change-Id: Iecb0d1055fd6c61d0c34ffb8afc670ab9d5fe899
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205908
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org >
2026-06-02 20:15:18 +02:00
AsmatZahra-code
d5e4e449d2
return early on invalid input to avoid calculating discarded value
...
Change-Id: I7391c4f24c39c9c8215225ba08054a33096801ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205585
Reviewed-by: Neil Roberts <nroberts@libreoffice.org >
Tested-by: Jenkins
2026-05-28 10:45:28 +02:00
Furkan Ahmet Kara
49d827b374
tdf#147132: Flatten Basic function implementations in methods1.cxx
...
Change-Id: I1107266b6a7b33ee3a9a0d69d850bf5b4c203692
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/204798
Tested-by: Jenkins
Reviewed-by: Neil Roberts <nroberts@libreoffice.org >
2026-05-28 10:11:35 +02:00
Michael Weghorn
336f70f966
weld: Move weld::Label to own header
...
Move the class out of weld.hxx into its own header, in
order to make it easier to keep an overview and to avoid
having to recompile ~all UI code when the class is
modified.
Change-Id: Ide86f35543468a88288a068cc9f89eaf381ac52f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205763
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de >
2026-05-27 22:24:37 +02:00
Mo Amr
f801e19c64
tdf#131818 basic: remove VBA optional array test blocks
...
Remove blocks since these now throw errors and are covered by the compiler-check unit test.
Change-Id: I6eef9a2b3a3934ee79f0278af5508c43f8b17c8f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205571
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de >
2026-05-26 18:00:09 +02:00
alohapeakina
d21d64fc84
tdf#147132 Flatten basic function implementations
...
Change-Id: I517d188ec029b7ec6e6921f437a8915f8a6c9562
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205376
Tested-by: Jenkins
Reviewed-by: Neil Roberts <nroberts@libreoffice.org >
2026-05-20 09:38:28 +02:00
Neil Roberts
e2af4c9f81
basic: Add unit test asserting that array arguments can’t have size
...
Adds a short unit test to assert that if you try to put a size inside
the brackets for the declaration of an array argument to a subroutine
then the compiler will report an error.
See this comment for an example of how it would be easy to break this
behaviour:
https://gerrit.libreoffice.org/c/core/+/203437/comment/749269bd_f55ea943/
Change-Id: I048234c7cf5a13e2ab2b71885ea1c0455566decf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205369
Tested-by: Jenkins
Reviewed-by: Neil Roberts <nroberts@libreoffice.org >
2026-05-19 20:23:21 +02:00
Mo Amr
2dfb9be63e
tdf#131818 BASIC: Fix optional array parameters in VBA
...
Update parser to reject optional array parameters in VBA mode.
Change-Id: Ibf5c47d9d6e0e272f4d21ed18ccba769e542aac3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203437
Tested-by: Jenkins
Reviewed-by: Neil Roberts <nroberts@libreoffice.org >
2026-05-19 12:46:53 +02:00
Andreas Heinisch
faea8cc858
Move bug fix to the end of the regular function tests to be consistent with other tests for missing/optional parameters
...
Change-Id: I6ee663e594f9c4421532c865a0aed5b5db52597b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205143
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de >
Tested-by: Jenkins
2026-05-13 18:56:10 +02:00
Andreas Heinisch
d6954bfec1
tdf#143706 - Mark skipped named optional parameters as missing/empty
...
When calling a Basic procedure using a named argument (for example,
foo(y:=10)), optional skipped parameters were not correctly marked as
missing, causing the function IsMissing() to return incorrect results.
Change-Id: I90a9910165ec00a24deba86f7b3397dbc0720c93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205034
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de >
2026-05-12 22:40:13 +02:00
Arnaud VERSINI
c9d878efcb
[basic] Use more constexpr
...
Change-Id: I79fc5736f0468e4e4c05188a2504d836de0a9781
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/204721
Tested-by: Jenkins
Reviewed-by: Arnaud Versini <arnaud.versini@pm.me >
2026-05-04 12:37:10 +02:00
bl4ze4447
c15d89a0a6
tdf#166673 Fix Space(-1) behaviour
...
Change-Id: I3ea3a538dec449f752ca17122091b410221b7fe7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203225
Tested-by: Jenkins
Reviewed-by: Neil Roberts <nroberts@libreoffice.org >
2026-04-22 17:46:30 +02:00
Noel Grandin
e77b23fa1c
Fraction->double in MapMode
...
Change-Id: I865fe1c2b0377eebda6f9f19e163928cbe7c9056
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202631
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2026-03-26 13:23:37 +01:00
Alain Romedenne
fbc86dc555
Improve CallByName unit test
...
- add method call tests
- check for return values: array or not
cf. https://bugs.documentfoundation.org/show_bug.cgi?id=138155
https://bugs.documentfoundation.org/show_bug.cgi?id=149151
Change-Id: I15f8214ef68e059ecf48bd606a0754adc845aae9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199286
Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org >
Tested-by: Jenkins
2026-03-23 16:22:34 +01:00
Simon Chenery
356e1beec2
tdf#154285 Check too many arguments to BASIC FILELEN function
...
Change-Id: I21704e84bed54ad4295d52d82eb4a92ff70a3abc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201298
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com >
2026-03-10 07:47:06 +01:00
Noel Grandin
4b10710e09
loplugin:passstuffbyref
...
Change-Id: I559d246b25c99e5cb7a28ba94e04a2acedd3e720
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200943
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2026-03-04 19:22:19 +01:00