Improve CallByName unit test

- add method call tests
- check for return values: array or not

cf. https://bugs.documentfoundation.org/show_bug.cgi?id=138155
    https://bugs.documentfoundation.org/show_bug.cgi?id=149151

Change-Id: I15f8214ef68e059ecf48bd606a0754adc845aae9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199286
Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
Tested-by: Jenkins
This commit is contained in:
Alain Romedenne
2026-03-23 16:22:34 +01:00
parent ad90f5a797
commit fbc86dc555
+20 -7
View File
@@ -7,6 +7,8 @@
Option Explicit
Sub DEV : MsgBox doUnitTest : End Sub
Function doUnitTest() As String
TestUtil.TestInit
verify_CallByName
@@ -15,6 +17,8 @@ End Function
Sub verify_CallByName()
Const _Get = 2, _Let = 4, _Method = 1, _Set = 8
Dim c As New Collection
Dim THIS_MODULE As Object : THIS_MODULE = TestModule ' cf. basic/qa/cppunit/basic_coverage.cxx
On Error GoTo errorHandler
@@ -23,21 +27,30 @@ Sub verify_CallByName()
TestUtil.AssertEqual(CallByName(TestUtil, "passCount", _Get), 1, "CallByName(TestUtil, ""passCount"", _Get")
TestUtil.AssertEqual(CallByName(TestUtil, "GetResult", _Method), "OK", "CallByName(TestUtil, ""GetResult"", _Method")
' Collection instances
Dim c As New Collection
c.Add(100, "1st") : c.Add(101)
TestUtil.AssertEqual(CallByName(c,"Count", _Get), 2, "CallByName(c,""Count"", _Get)")
c.Remove(2)
c.Add(100, "1st")
c.Add(Array(7,8,9))
TestUtil.AssertEqual(CallByName(c,"Count", _Get),2, "CallByName(c,""Count"", _Get)")
c.Remove(2) ' remove 2nd item, 1 item left
' Let's check CallByName argument names
TestUtil.AssertEqual(CallByName(callType:=_Get, object:=c, procName:="Count"), 1, _
"CallByName(callType:=_Get, object:=c, procName:=""Count"")")
_tdf138155_:
TestUtil.AssertEqual(CallByName(THIS_MODULE,"setArray", _Method)(3), "fox…", _
"CallByName(THIS_MODULE,""setArray"", _Method)")
' ClassModule instances or UNO services are 'CallByNamable' objects too!
' see https://help.libreoffice.org/7.4/en-US/text/sbasic/shared/CallByName.html?DbPAR=BASIC#bm_id3150669
' for more _Let and _Set examples
Exit Sub
errorHandler:
TestUtil.ReportErrorHandler("verify_CallByName", Err, Error$, Erl)
Resume Next
End Sub
End Sub
Function setArray() ' as String[]
setArray = Split("The quick brown fox…", " ")
End Function