ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

tdf#131818 basic: remove VBA optional array test blocks

Browse Source 
Remove blocks since these now throw errors and are covered by the compiler-check unit test.

Change-Id: I6eef9a2b3a3934ee79f0278af5508c43f8b17c8f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205571
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
This commit is contained in:
Mo Amr
2026-05-26 18:00:09 +02:00
committed by Andreas Heinisch
parent c9df26ea09
commit f801e19c64
2 changed files with 0 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files
basic/qa/vba_tests/ismissing.vb
-29
View File
@@ -95,35 +95,6 @@ Sub verify_testIsMissingVba()
TestUtil.AssertEqual(TestOptObjectByRefByVal(, cB), IsMissingA, "TestOptObjectByRefByVal(, B)")
TestUtil.AssertEqual(TestOptObjectByRefByVal(cA, cB), IsMissingNone, "TestOptObjectByRefByVal(A, B)")
' optionals with array datatypes
Dim aA(0 To 1) As Integer
aA(0) = 123
aA(1) = 456
Dim aB(0 To 1) As Variant
aB(0) = 123.4
aB(1) = 567.8
' TODO - New bug report? Scanner initializes variable not as an array
' TestUtil.AssertEqual(TestOptArray(), IsMissingAB, "TestOptArray()")
' TestUtil.AssertEqual(TestOptArray(aA), IsMissingB, "TestOptArray(A)")
' TestUtil.AssertEqual(TestOptArray(, aB), IsMissingA, "TestOptArray(, B)")
' TestUtil.AssertEqual(TestOptArray(aA, aB), IsMissingNone, "TestOptArray(A, B)")
' optionals with array datatypes (ByRef and ByVal)
' TODO - New bug report? Scanner initializes variable not as an array
' TestUtil.AssertEqual(TestOptArrayByRefByVal(), IsMissingAB, "TestOptArrayByRefByVal()")
' TestUtil.AssertEqual(TestOptArrayByRefByVal(aA), IsMissingB, "TestOptArrayByRefByVal(A)")
' TestUtil.AssertEqual(TestOptArrayByRefByVal(, aB), IsMissingA, "TestOptArrayByRefByVal(, B)")
' TestUtil.AssertEqual(TestOptArrayByRefByVal(aA, aB), IsMissingNone, "TestOptArrayByRefByVal(A, B)")
' tdf#143706 - optionals with named arguments (:= syntax)
' Without the fix in place, this test would have failed with:
' - Expected: 0 (IsMissingA)
' - Actual : -1 (IsMissingNone)
TestUtil.AssertEqual(TestOptVariant(B := 456), IsMissingA, "TestOptVariant(B := 456)")
TestUtil.AssertEqual(TestOptVariant(A := 123), IsMissingNone, "TestOptVariant(A := 123)")
TestUtil.AssertEqual(TestOptVariant(A := 123, B := 456), IsMissingNone, "TestOptVariant(A := 123, B := 456)")
TestUtil.AssertEqual(TestOptVariant(B := 456, A := 123), IsMissingNone, "TestOptVariant(B := 456, A := 123)")
Exit Sub
errorHandler:
TestUtil.ReportErrorHandler("verify_testIsMissingVba", Err, Error$, Erl)
basic/qa/vba_tests/optional_paramters.vb
-26
View File
@@ -88,32 +88,6 @@ Sub verify_testOptionalsVba()
TestUtil.AssertEqualApprox(TestOptObjectByRefByVal(, cB), 691.2, 1E-5, "TestOptObjectByRefByVal(, B)")
TestUtil.AssertEqualApprox(TestOptObjectByRefByVal(cA, cB), 1270.2, 1E-5, "TestOptObjectByRefByVal(A, B)")
' optionals with array datatypes
Dim aA(0 To 1) As Integer
aA(0) = 123
aA(1) = 456
Dim aB(0 To 1) As Variant
aB(0) = 123.4
aB(1) = 567.8
' TODO - New bug report? Scanner initializes variable not as an array
' TestUtil.AssertEqual(TestOptArray(), 0, "TestOptArray()")
' TestUtil.AssertEqual(TestOptArray(aA), 579, "TestOptArray(A)")
' TestUtil.AssertEqualApprox(TestOptArray(, aB), 691.2, 1E-5, "TestOptArray(, B)")
' TestUtil.AssertEqualApprox(TestOptArray(aA, aB), 1270.2, 1E-5, "TestOptArray(A, B)")
' optionals with array datatypes (ByRef and ByVal)
' TODO - New bug report? Scanner initializes variable not as an array
' TestUtil.AssertEqual(TestOptArrayByRefByVal(), 0, "TestOptArrayByRefByVal()")
' TestUtil.AssertEqual(TestOptArrayByRefByVal(aA), 579, "TestOptArrayByRefByVal(A)")
' TestUtil.AssertEqualApprox(TestOptArrayByRefByVal(, aB), 691.2, 1E-5, "TestOptArrayByRefByVal(, B)")
' TestUtil.AssertEqualApprox(TestOptArrayByRefByVal(aA, aB), 1270.2, 1E-5, "TestOptArrayByRefByVal(A, B)")
' tdf#143707 - check correct initialization of default value for optionals
' Without the fix in place, this test would have failed with
' - Expected: 123
' - Actual : 123%
TestUtil.AssertEqual(TestOptVariantInit(), 123, "TestOptVariantInit()")
Exit Sub
errorHandler:
TestUtil.ReportErrorHandler("verify_testOptionalsVba", Err, Error$, Erl)