ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
518,703 Commits 3 Branches 3 Tags
54b3494de710e3732283879bc91b5dd300e93f3d
Commit Graph
5331 Commits
Author SHA1 Message Date
ApurvR20 54b3494de7 tdf#147132 : Flatten Basic function implementations 
Flatten implementation of SbRtl_Weekday in basic/source/runtime/methods1.cxx.

Change-Id: I17931cfecc24be9c114daa9c6c221e6c00a4e3aa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208256
Tested-by: Jenkins
Reviewed-by: Neil Roberts <nroberts@libreoffice.org>
 2026-07-20 09:38:38 +02:00
Sapphire e08f567f1d tdf#147132 flatten basic function implementations 
Change-Id: I66e82085eaa303eabaee268bd5b46a41d66a361a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/204326
Tested-by: Jenkins
Reviewed-by: Neil Roberts <nroberts@libreoffice.org>
 2026-07-10 17:15:07 +02:00
Furkan Ahmet Kara 7f2472b873 tdf#154285 Check argument count in BASIC SGN function 
Change-Id: Ic20ceed1d736ea2436bc4dd37cfd242efcec79b4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/206268
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
 2026-07-04 07:17:42 +02:00
Mike Kaganski c64fc39bf3 Use NameContainer's owner as event source 
The owner is set since commit 0f3f371028
(NameContainer need not be an UNO object itself, 2024-12-01), and is
the same object that was used to set event source. Drop the redundancy.

Signed-off-by: Mike Kaganski <mike.kaganski@collabora.com>
Change-Id: Ie6d50696781395136349ad8084653e624437533d
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/5026
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
(cherry picked from commit 6a5646b1abcdc9e61cf9b5ca42d65280bc520b39)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/207165
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-06-23 17:21:33 +02:00
Mike Kaganski 6601fe8419 cool#15956: keep insertion order in NameContainer's getElementNames 
This is required to keep content of Basic/script-lc.xml and each
Basic/<lib>/script-lb.xml byte-identical on round-trip, which is
necessary for signatures to stay valid; this broke after commit
ea2a974386 (Simplify NameContainer,
2024-12-01).

Signed-off-by: Mike Kaganski <mike.kaganski@collabora.com>
Change-Id: Ib30b701dce8bbcb919c88f5b66f5134150ded575
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/5025
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
(cherry picked from commit bfe67bc782cf89e944324042c8e53c42f4b6421b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/207164
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
 2026-06-23 16:48:18 +02:00
Michael Weghorn f26084217a weld: Move weld::Button to own header/Rename weld.hxx 
In the past, weld.hxx used to contain the class
definitions for weld::Widget and all subclasses.

By now, weld::Widget and almost all subclasses have
been moved to separate headers, to make it easier
to keep the overview and to avoid having to
recompile ~all UI code when one class changes.

By now, only weld::Button is left in weld.hxx.
Rename the header to Button.hxx.
Drop weld.hxx includes and instead add Button.hxx
includes (or weld::Button forward declarations) where
weld::Button is used.
(Don't simply replace all weld.hxx includes with
Button.hxx ones, since many of them were for the
use of other widgets that have since been moved
to their own headers.)

Add further includes where needed now that the
(direct or transitive) includes of weld.hxx were removed.

Change-Id: I8ea6201446a418d5e38b46337059dcd517ee29d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205937
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
 2026-06-05 07:58:07 +02:00
Xisco Fauli 8a91868e21 drop JSDialog machinery 
It's no longer needed and not used internally

Change-Id: Iecb0d1055fd6c61d0c34ffb8afc670ab9d5fe899
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205908
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-06-02 20:15:18 +02:00
AsmatZahra-code d5e4e449d2 return early on invalid input to avoid calculating discarded value 
Change-Id: I7391c4f24c39c9c8215225ba08054a33096801ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205585
Reviewed-by: Neil Roberts <nroberts@libreoffice.org>
Tested-by: Jenkins
 2026-05-28 10:45:28 +02:00
Furkan Ahmet Kara 49d827b374 tdf#147132: Flatten Basic function implementations in methods1.cxx 
Change-Id: I1107266b6a7b33ee3a9a0d69d850bf5b4c203692
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/204798
Tested-by: Jenkins
Reviewed-by: Neil Roberts <nroberts@libreoffice.org>
 2026-05-28 10:11:35 +02:00
Michael Weghorn 336f70f966 weld: Move weld::Label to own header 
Move the class out of weld.hxx into its own header, in
order to make it easier to keep an overview and to avoid
having to recompile ~all UI code when the class is
modified.

Change-Id: Ide86f35543468a88288a068cc9f89eaf381ac52f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205763
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2026-05-27 22:24:37 +02:00
Mo Amr f801e19c64 tdf#131818 basic: remove VBA optional array test blocks 
Remove blocks since these now throw errors and are covered by the compiler-check unit test.

Change-Id: I6eef9a2b3a3934ee79f0278af5508c43f8b17c8f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205571
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
 2026-05-26 18:00:09 +02:00
alohapeakina d21d64fc84 tdf#147132 Flatten basic function implementations 
Change-Id: I517d188ec029b7ec6e6921f437a8915f8a6c9562
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205376
Tested-by: Jenkins
Reviewed-by: Neil Roberts <nroberts@libreoffice.org>
 2026-05-20 09:38:28 +02:00
Neil Roberts e2af4c9f81 basic: Add unit test asserting that array arguments can’t have size 
Adds a short unit test to assert that if you try to put a size inside
the brackets for the declaration of an array argument to a subroutine
then the compiler will report an error.

See this comment for an example of how it would be easy to break this
behaviour:

https://gerrit.libreoffice.org/c/core/+/203437/comment/749269bd_f55ea943/

Change-Id: I048234c7cf5a13e2ab2b71885ea1c0455566decf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205369
Tested-by: Jenkins
Reviewed-by: Neil Roberts <nroberts@libreoffice.org>
 2026-05-19 20:23:21 +02:00
Mo Amr 2dfb9be63e tdf#131818 BASIC: Fix optional array parameters in VBA 
Update parser to reject optional array parameters in VBA mode.

Change-Id: Ibf5c47d9d6e0e272f4d21ed18ccba769e542aac3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203437
Tested-by: Jenkins
Reviewed-by: Neil Roberts <nroberts@libreoffice.org>
 2026-05-19 12:46:53 +02:00
Andreas Heinisch faea8cc858 Move bug fix to the end of the regular function tests to be consistent with other tests for missing/optional parameters 
Change-Id: I6ee663e594f9c4421532c865a0aed5b5db52597b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205143
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Tested-by: Jenkins
 2026-05-13 18:56:10 +02:00
Andreas Heinisch d6954bfec1 tdf#143706 - Mark skipped named optional parameters as missing/empty 
When calling a Basic procedure using a named argument (for example,
foo(y:=10)), optional skipped parameters were not correctly marked as
missing, causing the function IsMissing() to return incorrect results.

Change-Id: I90a9910165ec00a24deba86f7b3397dbc0720c93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205034
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
 2026-05-12 22:40:13 +02:00
Arnaud VERSINI c9d878efcb [basic] Use more constexpr 
Change-Id: I79fc5736f0468e4e4c05188a2504d836de0a9781
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/204721
Tested-by: Jenkins
Reviewed-by: Arnaud Versini <arnaud.versini@pm.me>
 2026-05-04 12:37:10 +02:00
bl4ze4447 c15d89a0a6 tdf#166673 Fix Space(-1) behaviour 
Change-Id: I3ea3a538dec449f752ca17122091b410221b7fe7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203225
Tested-by: Jenkins
Reviewed-by: Neil Roberts <nroberts@libreoffice.org>
 2026-04-22 17:46:30 +02:00
Noel Grandin e77b23fa1c Fraction->double in MapMode 
Change-Id: I865fe1c2b0377eebda6f9f19e163928cbe7c9056
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202631
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2026-03-26 13:23:37 +01:00
Alain Romedenne fbc86dc555 Improve CallByName unit test 
- add method call tests
- check for return values: array or not

cf. https://bugs.documentfoundation.org/show_bug.cgi?id=138155
    https://bugs.documentfoundation.org/show_bug.cgi?id=149151

Change-Id: I15f8214ef68e059ecf48bd606a0754adc845aae9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199286
Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
Tested-by: Jenkins
 2026-03-23 16:22:34 +01:00
Simon Chenery 356e1beec2 tdf#154285 Check too many arguments to BASIC FILELEN function 
Change-Id: I21704e84bed54ad4295d52d82eb4a92ff70a3abc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201298
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2026-03-10 07:47:06 +01:00
Noel Grandin 4b10710e09 loplugin:passstuffbyref 
Change-Id: I559d246b25c99e5cb7a28ba94e04a2acedd3e720
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200943
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2026-03-04 19:22:19 +01:00
Noel Grandin d235ca3589 SvStream::ReadUniOrByteString should not need to specify encoding 
Instead, rely on the stream being set into the correct encoding
during stream initialisation.

Change-Id: I5b015f12f141a89b176c5a22aeecc4336f0b8f13
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200460
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2026-02-27 07:48:47 +01:00
Mike Kaganski 55b9d8607b "CharSet" -> "Encoding" in SvStream 
Use the correct term. E.g., Unicode charset has different encodings
like UTF-8 and UTF-16, and we mean encoding here.

Change-Id: I65e90b31cda6e39fdb1584b492e6e0b9821865a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200285
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2026-02-25 10:33:55 +01:00
madhura 1edf6b9819 tdf#168520 Rename test_tdf149714 to descriptive name 
Rename test_tdf149714.cxx to test_tdf149714_bits_per_pixel.cxx
to provide a human-readable hint about the purpose of the test.

Also update CppunitTest_basic_macros.mk accordingly.

Change-Id: Iba5db7ebed9bc1aeafe1b365243e1e0ca8216070
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199692
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
 2026-02-20 07:46:33 +01:00
Aya Jamal a5c1165b4a tdf#168520 Rename testTdf134576 to 
testTdf134576_resume_next_in_for_each

Change-Id: Ieb4418449b41f3f05db556140c0c5ae144d5bab9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199231
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
 2026-02-12 07:54:52 +01:00
Michael Weghorn fbcfd00fb7 weld: Move weld::Dialog to own header/source 
Move the class out of weld.hxx into its own header and source
file, in order to make it easier to keep an overview and to avoid
having to recompile ~all UI code when the class is
modified.

Change-Id: Ic47dac553fc065c5c9cddbf31e33012314dbe43d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199073
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2026-02-11 07:32:57 +01:00
Michael Weghorn ab3635b2f3 weld: Move weld::MessageDialog to own header 
Move the class out of weld.hxx into its own header, in
order to make it easier to keep an overview and to avoid
having to recompile ~all UI code when the class is
modified.

Change-Id: I5b23b02151c75bb49831a2bbf8d515eb0b54415e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199068
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
 2026-02-11 07:32:45 +01:00
shark eebf036039 tdf#147132 Flatten Basic function implementations 
Change-Id: Iae6ec1b9cd524d666dd1076c61fe8d5af2a2189e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198249
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
 2026-02-07 12:33:45 +01:00
Gabor Kelemen 0bdcfc2900 tdf#146619 Use more forward declarations in include/unotools/ 
This shaves off some 40M of input

Change-Id: I12e10deb87ceea1f7a23f3de4ea624befe187c3f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198238
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
Tested-by: Jenkins
 2026-02-05 17:35:46 +01:00
Gabor Kelemen 495fa42afa tdf#146619 Use more forward declarations in include/vcl/weld/ 
after recent split of these headers

This shaves off another 150M input

Change-Id: Ia4e42781cdc6fd6e795c9fb55c6c24dd641b8f0d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197339
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
Tested-by: Jenkins
 2026-01-31 11:06:42 +01:00
Gabor Kelemen f8dad0daf9 tdf#146619 Use more forward declarations in include/vcl/svapp.hxx 
this was skipped in previous runs, since it contains some code behind #if

After inspecting these, it seems like the removals should not cause trouble.

Change-Id: If1e3e3c7c0fc14ed6e8b51174a0e7f1220fdbc8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197496
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
 2026-01-25 13:31:57 +01:00
kelvin add78db05f tdf#145759 - basic: Replace buffer size magic number with constant 
Replace magic number 1024 with DEFAULT_STREAM_BUFFER_SIZE in basmgr.cxx
to make the code more readable and maintainable. The constant clearly
indicates the purpose of this buffer size value.

Change-Id: Ic307c55e2eac563200951c373a0ca545db0a9e7b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193382
Reviewed-by: Hossein <hossein@libreoffice.org>
Tested-by: Jenkins
 2026-01-24 00:03:04 +01:00
Stephan Bergmann 56a43e0966 Silence spurious -Werror=array-bounds= 
seen at least with recent GCC 16 trunk,

> In member function ‘virtual void SbModule::SetParent(SbxObject*)’,
>     inlined from ‘virtual SbxVariable* SbModule::Find(const rtl::OUString&, SbxClassType)’ at basic/source/classes/sbxmod.cxx:653:36:
> basic/source/classes/sbxmod.cxx:671:13: error: array subscript ‘SbModule[0]’ is partly outside array bounds of ‘unsigned char [152]’ [-Werror=array-bounds=]
>   671 |     pParent = p;
>       |     ~~~~~~~~^~~
> basic/source/classes/sbxmod.cxx: In member function ‘virtual SbxVariable* SbModule::Find(const rtl::OUString&, SbxClassType)’:
> basic/source/classes/sbxmod.cxx:651:55: note: object of size 152 allocated by ‘operator new’
>   651 |                     pRes = new SbxVariable( SbxOBJECT );
>       |                                                       ^

Change-Id: I0823b28063b6e224f9cc28aee55fd21e2f21aa1a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197833
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
 2026-01-22 22:48:32 +01:00
Simon Chenery 58da9d878d tdf#154285 Check too many arguments to BASIC INT function 
Change-Id: Ia0d71efc326fcfad13bc8edc9d15d5ef491db265
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197702
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
 2026-01-21 08:25:45 +01:00
Gabor Kelemen 47fe1cce1b tdf#146619 Use more forward declarations in include/vcl/[h-p]* 
Found after running bin/find-unneeded-includes --headersfwd include/vcl/[n-p]*

Change-Id: If6436f3ef8300693c3869c2521e2fa2aa8a4edc8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196397
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
 2026-01-14 10:19:31 +01:00
Gabor Kelemen b63115f3fa tdf#146619 Use more forward declarations in include/vcl/[d-g]* 
Found after running bin/find-unneeded-includes --headersfwd include/vcl/[d-g]*

This shaves off about 150M input

Change-Id: I2b15257451d4b392dca3e5d07f4a443ee653b04c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196395
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
 2026-01-11 21:38:37 +01:00
Michael Weghorn ffc8326e99 weld: Move weld::Entry to own header/source 
Move the class out of weld.hxx into its own header and source
file, in order to make it easier to keep an overview and to avoid
having to recompile ~all UI code when the class is
modified.

Change-Id: I27033905fe8be1c3646c8cf08799c9bf53eeb471
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196448
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2026-01-04 15:03:39 +01:00
Tejas Shukla 0ba7e16543 tdf#147132 Flatten Basic function implementations 
Change-Id: I076e21eb71a636093b51280356d5fc2e58d327ae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196245
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2025-12-28 11:42:04 +01:00
Mike Kaganski 8e23c94043 Drop a convenience function used only once 
Change-Id: If49b4dc658e953e86d87a76300a9517d6bb896b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196042
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2025-12-21 14:44:22 +01:00
Simon Chenery 74d678191a tdf#168771 Convert enum to enum class in methods1.cxx 
Change-Id: I7f9894db5ce74ca507ad05967a08dd7fab6ad33d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195608
Tested-by: Jenkins
Reviewed-by: David Gilbert <freedesktop@treblig.org>
 2025-12-20 17:30:10 +01:00
Michael Weghorn 5454b7ed94 weld: Move weld::DialogController and subclasses to own header/source 
This is also in preparation of moving weld::Builder to
its own header.

Change-Id: Icb65ee85376d17e1abead2c6339f78b129112d0a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195841
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
 2025-12-18 19:44:41 +01:00
Michael Weghorn 5b16b3acc6 weld: Move weld.hxx and weldutils.hxx to new include/vcl/weld subdir 
This is in preparation of moving code out of weld.hxx
to separate headers/source files, in order to make it
easier to keep an overview and to avoid having to
recompile ~all UI code when anything changes.

Also move weldutils.cxx to a new vcl/source/weld
directory.

Change-Id: Ia75b42f21e560dd248307282a522f186a64cd742
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195777
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-12-17 18:20:13 +01:00
Vaibhav Singh a47949fece tdf#154285 Check upper bound of arguments in implChr function 
Change-Id: I081ff9874b4fc00ff791cb5ae9ce5a27a6d6778c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195731
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
 2025-12-17 11:50:04 +01:00
Vaibhav Singh 0e6c78dcd6 tdf#154285 Check upper bound of arguments in SbRtl_CreateObject 
function

Change-Id: I64ada278c0ba8d178f62f28c4e4e9911ce3f5d1b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195732
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
 2025-12-17 09:27:11 +01:00
Mike Kaganski 7b04ef05cd Drop some uses Sequence::getConstArray 
Similar to commit b280efcb9b
(Drop some uses Sequence::getConstArray, 2025-12-07).

Change-Id: Ieac325a660fe64e8172c5ed139380caa3d26a73c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195200
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2025-12-08 10:00:21 +01:00
Simon Chenery 01d31536b5 tdf#154285 Check too many arguments to BASIC EXP function 
Change-Id: I9963267c9b910a2a2346e27e7c8cb4220c0ab964
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195205
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
 2025-12-08 05:16:29 +01:00
Daniel Lee ee97942b8f tdf#168520: Rename test testTdf103104 and testTdf136032 
to testTdf103104_accept_dot_after_line_continuation and
testTdf136032_end_scan_on_comma to make it easier to
understand what they are testing

Change-Id: I339c187ec73c9f8a0af15770ab2a14366359ccb3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195181
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
 2025-12-07 07:39:17 +01:00
Stephan Bergmann 1fc95f3bfa !HAVE_FEATURE_SCRIPTING apparently needs SbiRuntime::isVBAEnabled now 
...after 76aafa18b7 "tdf#162711 - VBASupport
requires banker’s rounding for integer conversions", as linking started to fail
with

> wasm-ld: error: /home/sberg/lo-wasm-upstream/core/instdir/program/libsblo.a(sbxint.o): undefined symbol: SbiRuntime::isVBAEnabled()

Change-Id: I579f300390eabfefd5f02c277771d5f8c937105c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194734
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
 2025-11-28 00:12:07 +01:00
Andreas Heinisch 76aafa18b7 tdf#162711 - VBASupport requires banker’s rounding for integer conversions 
Change-Id: Ife3f7aae3ba094fe83a5eda6b3d50d9358cc1184
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194286
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
 2025-11-24 20:42:41 +01:00