ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
511,913 Commits 3 Branches 3 Tags
38b239c8bcf9031cec68678460e94de3dc23a6e4
Commit Graph
8271 Commits
Author SHA1 Message Date
Nicu 0f627ec0f0 tdf#163738 Use insert() to add multiple values in containers instead of 
a loop

Signed-off-by: Nicu <nicu.coscodan2003@gmail.com>
Change-Id: I484cabfe59e5896e9163120666191e6404647fce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194805
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
 2025-11-29 10:21:50 +01:00
siddhisalunkhe1998 ec0fcce54a tdf#145614 convert string literals into o3tl::enumarray 
groups all FRAME_PROPNAMEs related to Enum class FramePropHandle
into o3tl::enumarray

this patch is continuation of -
https://gerrit.libreoffice.org/c/core/+/192468

Change-Id: I96b1e0f90c2d2735ae73bafc729e4c0183c6795b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193657
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
 2025-11-12 17:02:23 +01:00
Olivier Hallot 032e8a378a tdf#159505 HelpId to menu Window doc list (core) 
Core part.

Change-Id: I17418cb0fd9548bf26634b0d13d6ce70348e7d4a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193829
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Jenkins
 2025-11-12 15:03:30 +01:00
Michael Weghorn be04a19fa2 tdf#169318 tdf#127201 extension mgr: Open via new UNO command 
Introduce a new UNO command, ".uno:ExtensionManager",
which is used to open the "Extensions" dialog from the
menu, notebookbar and using the keyboard shortcut
(Ctrl+Alt+E) instead of specifying the service name
"service:com.sun.star.deployment.ui.PackageManagerDialog"
in their configuration directly.

In a first step, handle the new UNO command in
SfxApplication::MiscExec_Impl by creating an
instance of the service by its name and executing the dialog
using the css::task::XJobExecutor interface without any
additional changes.
This matches what the previous way of triggering
the dialog would have done, i.e. no user-observable
behavior is intended yet.

This prepares for further changes in upcoming
commits, in particular passing a parent for
the dialog.

As documented in icon-themes/README.md, make sure to
have icons with the expected names, which is e.g.
used in the "Tabbed Compact" UI variant of the Notebookbar.
(Link to the already existing icons.)

Change-Id: I4b381b5f0b7cddd9f0aa9abd9b88c1c4364ab824
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193580
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2025-11-10 23:10:32 +01:00
Gabor Kelemen fd2e467ba3 tdf#146619 Run IWYU in fw decl mode on include/[a-c]* 
After recent commit 851fb75779
recheck these directories in include/ again
to test drive the new --headersfwd mode of bin/find-unneeded-includes

Change-Id: I0ede437c4f9958cd98210ed1760a5b98ea8bd1ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192377
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
 2025-11-08 09:37:19 +01:00
Mike Kaganski d46175b4ff Move variables where they are used 
Change-Id: I4db201fad61e690000b78049c47b5457cf795658
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193165
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2025-10-30 05:16:55 +01:00
Mike Kaganski a8216f500c tdf#168314: check if xGraphic is empty, not Any 
Regression after commit 9d6e1594a2
(Deduplicate and unify using vcl::GetBitmap, 2024-11-08).

An Any with an empty graphic is not itself empty; such an any caused
the outer check to succeed, and therefore its 'else' branch never
executed, when it ought to.

Change-Id: I97115c7f7dbab4ec54b5e999e4b47ecdc8874e47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193161
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2025-10-29 19:46:08 +01:00
siddhi e9f18286c6 tdf#145614 convert #define statements to enum class 
Replaced #define statements with an enum class FramePropHandle in
properties.h, updated frame.cxx to use this enum class.

Change-Id: Ib7f1eff43ec4196176de8a6af80a7dd9c0a1b2ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192468
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
 2025-10-24 16:03:53 +02:00
Neil Roberts ea8767fe50 tdf#138234 Focus the frame before executing toolbar action 
If a toolbar is floating then when a button is clicked on it the toolbar
window will end up taking focus. This is kind of confusing if the button
does an action such as inserting a table row. In that case you want the
cursor to be visible in the document and to be able to immediately start
typing in the new row.

Note that despite the description in the bug report I think this is a
general problem on all platforms and with all toolbar buttons. For
example the cursor “disappears” in the same surprising way if you press
the button to insert a footnote.

To fix the problem this patch just makes it pass the focus to the
toolbar’s frame before dispatching the command. This is similar to what
is already done in the code for the font toolbar to handle when a new
font is selected.

Change-Id: Ifd941fb4ae295c57d465f4c8ff798913ce4a14c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192649
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-10-20 20:45:55 +02:00
Neil Roberts de5bdb5aa9 generictoolbarcontroller: Flatten the early-return checks in execute 
Instead of having a bunch of nested if statements in order to initialise
xDispatch while the solar mutex is locked along with a check for whether
the initialise happened after the lock is released, there are now just
early returns on failures. This should make it a bit easier to add an
extra step for the success case while holding the mutex in a subsequent
patch.

Change-Id: I731a800598a8e31b2b18ee29b6354c5440a430dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192648
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-10-20 20:45:44 +02:00
Mike Kaganski 0b39b230b8 tdf#139866: mark menu items that don't have icons 
Avoids the console noise and the overhead associated with needless
image loading attempts.

There are some menu items added from code, that are not handled by
the patch: e.g., .uno:ToolbarLock.

Change-Id: If94cad97207e46125083c56882c284e0993f43f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192638
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2025-10-19 11:19:06 +02:00
Gabor Kelemen a20e7520c3 Sanity check all IwyuFilter files 
This should not complain anymore:

for i in $(ls -1 */*yaml) ; do mod=$(echo "$i" | cut -d '/' -f1 ) ; bin/find-unneeded-includes --sanitycheck "$mod"; done

Change-Id: I5c4b99f5cb58c6f696b127c81edd6d323104cd7a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191829
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
 2025-10-14 19:44:19 +02:00
Gabor Kelemen e505e066b5 Drop IWYU exclusions about css shortcut 
At least IWYU 0.24 no longer gives a warning if sal/types.h
is included only for the css alias

Few other places were excluded because an enum type used some
base type from sal/types.h

Now there is no false warning about those instances either, so drop them too

Change-Id: Ib2fac8fe2c7022c28194514e828c773385217ddd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191564
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
 2025-10-02 15:55:20 +02:00
Justin Luth 6e382304e3 tdf#152751: silence autorecovery-provoked 'Invalid file URL' 
Clearly if no file is specified,
we don't need to attempt to erase 'nothing'.

Change-Id: I6fe1110eeb9ff409037168e4421ef55253ea8766
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191639
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
 2025-09-29 21:06:51 +02:00
Gabor Kelemen 4ba94c18b2 bin/find-unneeded-includes: add exception for URE header 
cppuhelper/interfacecontainer.hxx, so that these can be
removed from per-module yaml files

Change-Id: Id5650dab557921f9e51794b95f41e5a3c21c9689
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191337
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
 2025-09-24 23:16:15 +02:00
Neil Roberts 713732b0a2 Add a unit test for the accelerator configurations 
This is meant to test the problems described in the following commits:

96491f3f84
7da5034706

Change-Id: I2f79e8812de6f70d270eefb01aa7e2940c87166a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191173
Tested-by: Jenkins
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2025-09-24 20:28:13 +02:00
Gabor Kelemen c1cb3276e7 bin/find-unneeded-includes: add exception for URE headers as well 
so that these can be removed from per-module yaml files

Change-Id: I8bf8da64b51072ccd926e3555c7c8da89f29e648
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191003
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2025-09-24 12:09:52 +02:00
Aung 8ce2cf3973 tdf#41777 Add window size and position for each document 
-Extend ViewDataSupplier to work with window state for supported
 applications like sw, sc, sd
-Extend sm DocumentPropertySupplier to work with window state
-Add OldWindowState string member to SfxViewShell inherited
 classes for sw, sc and sd
-Add OldWindowState string member to SmDocShell class for sm

 Imported window state is stored in the model shells
 or the ViewShells if available. This data is accessed by services
 like ViewDataSupplier and DocumentPropertySupplier used by
 persistentwindowstate.cxx. It is needed to store the window state
 data since frame is not available to get to resize
 and reposition by the time importing document has finished.

-Add windowstatehelper header and source files in the framework
 module for getting/exporting the size and position of
 windows. Also add associated file and library to make files for
 exporting/using these helper methods across different modules.

-Modify impl_searchRecycleTarget method in loadenv.cxx

 New frames are created for saved documents when launched from
 the start center. This is to apply their own window state
 separately from the backing window.
 New docs and templates still recycle the backing window frame.

-Make the backing window close afterwards after the new frame has
 been created and the document gets loaded successfully
 (modified in loadenv.cxx)



Change-Id: Ia5ad606e744621f267dae6cd468b0c430b2ebf1d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185189
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
 2025-09-24 06:44:43 +02:00
Neil Roberts b55a3b23b9 Enable the AcceleratorsConfiguration JUnitTest 
The test now runs successfully and it has some useful tests.

Change-Id: If0653ee16ef18ad3c69ec4f710b5b95ca95bb32d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191220
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-09-21 13:09:48 +02:00
Neil Roberts a215aea6e8 AcceleratorsConfigurationTest: Use new-style service specification 
The Global and Module AcceleratorConfigurations are supposed to use the
new-style service specification where their argument is specified during
construction instead of using XInitialization. This was causing the test
to seg fault if it’s enabled. I think the service might have been
upgraded to the new style in 8f3cec9d7a.

Change-Id: I1fe7fa67561f6e0a0e594e5112796d14f4ce4c77
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191218
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-09-21 13:09:18 +02:00
Neil Roberts 7da5034706 AcceleratorConfiguration: Don’t ignore changes that don’t have a command 
The XCUBasedAcceleratorConfiguraton reloads the configuration for a key
when a change notification on that key is received. However if the
change event was triggered by deleting a key then the change path
doesn’t contain a command and the code was ignoring it. The
reloadChanged function seems to already almost be designed to handle the
case when there is no command in the configuration. In that case it
deletes the key which seems like the right thing to do. However, when a
new key is assigned an event first gets fired for the key with no
locale, so the code needs to additionally handle that case now.

I don’t think this has any practical implications unless it’s possible
to have two instances of an XCUBasedAcceleratorConfiguration for the
same module open at the same time. However, this patch alone can work as
an alternative way to fix the problem described in
96491f3f84 because it would cause the
deleted key from the module config to also be deleted in the global
config.

It looks like the check for sPath was added in
7492878a15.

Change-Id: Ia90a1932e3169ca28157482c3035aba7efae012a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190972
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-09-19 10:57:15 +02:00
Neil Roberts 96491f3f84 AcceleratorConfiguration: Don’t reload config for irrelevant module 
The XCUBasedAcceleratorConfiguration-s get registered as config change
listeners in ModuleAcceleratorConfiguration::fillCache and
GlobalAcceleratorConfiguration::fillCache. The reloadChanged method then
finds the appropriate config based on the path of the change event.
However, the code didn’t do anything to check whether the config is
actually the one being managed by this accelerator configuration. That
meant for example that if a key was changed in the module configuration
then the global configuration would get notified and it would end up
replacing its configuration for that key with the module one. It would
also end up in the accelerator configuration for modules for any other
documents that happen to be open.

One way to manifest this bug is as follows:

• Create a new text document
• Tools → Customize
• Select the keyboard tab
• Select F7 in the list of keys
• Type “word count” in the search box
• Press “assign”
• Press OK
• Tools → Customize again
• Select F7 in the list of keys
• Press “delete”
• Press OK

Now look at the tools menu. Notice that F7 is still assigned to the word
count option. This is because the key has been copied into the global
configuration. The delete only deleted it from the module configuration.

Note that the messed up configuration is only stored in the read cache
so it doesn’t end up getting saved. If you restart LibreOffice then the
expected behaviour is restored.

This problem might have been added in e9e75d722d. It looks like before
that it might have been adding separate listeners for global and module
configs. Ie, connectToResourse has either PresetHandler::E_MODULES or
PresetHandle::E_GLOBAL.

Change-Id: Iac8f50f3668eaadc9a62f562d5923b93cc3d0721
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190971
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-09-19 09:40:29 +02:00
Neil Roberts 4be9be2219 tdf#144560 Remove old key from command when setting new one 
The accelerator cache maintains a 1:1 mapping for key→command and a
1:n mapping for command→keys. When a new command is set for a key it was
previously only updating the key→command map and then adding the key to
the command→keys map. It never removed the key from the command→keys map
for the old command. When the menus are eventually updated, it looks up
whether each item has a shortcut based on the item’s command. Because
the old command was never removed, this ended up making it display the
same key binding on multiple menu items.

Change-Id: I6d75834f4c49b1f5c105ec40cb27b8e73006152d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190928
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-09-14 21:14:06 +02:00
Noel Grandin 6d0e5ddede remove BitmapEx 
all use-sites have been converted to Bitmap

Change-Id: I1a8842217a266eef100bd387ab013b004e532256
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190618
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-09-05 19:45:45 +02:00
Caolán McNamara a91ceefcad cid#1660530 silence Data race condition 
rejig this so coverity is satisfied

Change-Id: Iad58f680b6f6fe879866c0162a88a3439af2c3f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190445
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2025-09-01 09:17:48 +02:00
Caolán McNamara d929702e83 cid#1665188 Variable copied when it could be moved 
and

cid#1665187 Variable copied when it could be moved
cid#1665186 Variable copied when it could be moved
cid#1665184 Variable copied when it could be moved

Change-Id: If36872293c53263ad2a42b06463c9b50c243068d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190441
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
 2025-08-31 22:23:21 +02:00
Noel Grandin d5df923644 BitmapEx->Bitmap in framework 
now that Bitmap supports transparency

Change-Id: I70cac13970f657770c5b739010bae8b17f4faed0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190421
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-08-31 07:38:07 +02:00
Noel Grandin c0afb3514f add new Bitmap constructors 
to move the logic of constructing a new Bitmap from an existing Bitmap and an AlphaMask,
into vcl, where it can later be optimised

Change-Id: I2af1c6d1a35d968abdd07546448f7e211772e70b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190366
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-08-29 17:53:22 +02:00
Noel Grandin 0c567fbc49 BitmapEx->Bitmap in Image 
now that Bitmap supports transparency

Change-Id: Id8fa4a216d52d56560746d7e063badded72c58c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190315
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-08-28 10:21:22 +02:00
Noel Grandin 36a4d7daa6 BitmapEx->Bitmap in various 
places where we are constructing a Graphic by first
converting to BitmapEx, which is unnecessary, rather pass a
Bitmap to Graphic.

Change-Id: I386f68e7f5bc6ef9509352187dbe9a0774defaac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190307
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-08-28 08:00:13 +02:00
Noel Grandin 65a99e6b33 BitmapEx->Bitmap in ImageList 
now that Bitmap supports transparency

Change-Id: If30f5fbc801cd576a13ee6f969085021d3ba7d6d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190304
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-08-28 07:59:48 +02:00
Noel Grandin e6211a4b3b BitmapEx->Bitmap in various 
now that Bitmap supports transparency

Change-Id: If946687832cf30db70db9749e5aeed38ab1490c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190149
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-08-25 12:59:18 +02:00
Caolán McNamara d0829662d5 add a constructor to TStorageInfo 
Change-Id: I74cd5c9a82976e5cfb31fe622db543e8133bfee1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189863
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
 2025-08-18 18:02:15 +02:00
Caolán McNamara 72e538b9bd tainted_data_return is deprecated 
in favour of taint_source, lets drop them all first

Change-Id: I9c4e5c143fcbd6de9491360c993a8ea1b89a726e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189820
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2025-08-17 15:33:16 +02:00
Caolán McNamara 2d7fa2ba4e rework StorageHolder::openPath a little 
convince myself that cid#1660530 Data race condition is bogus

Change-Id: I02a7ad95d7649757aa073f3a7c45144e60d177d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189412
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2025-08-12 15:42:34 +02:00
Caolán McNamara 16bd75a56c cid#1659785 Variable copied when it could be moved 
and

cid#1659793 Variable copied when it could be moved
cid#1659830 Variable copied when it could be moved
cid#1659841 Variable copied when it could be moved
cid#1659856 Variable copied when it could be moved
cid#1659863 Variable copied when it could be moved
cid#1659864 Variable copied when it could be moved
cid#1659865 Variable copied when it could be moved
cid#1659903 Variable copied when it could be moved
cid#1659909 Variable copied when it could be moved
cid#1659917 Variable copied when it could be moved
cid#1659924 Variable copied when it could be moved
cid#1659929 Variable copied when it could be moved
cid#1659930 Variable copied when it could be moved
cid#1659932 Variable copied when it could be moved
cid#1660056 Variable copied when it could be moved
cid#1660112 Variable copied when it could be moved
cid#1660169 Variable copied when it could be moved

Change-Id: I623009beb8e4a61b2253a17f356576bd3ac3f06c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189402
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2025-08-12 15:37:59 +02:00
Caolán McNamara d02fde021c cid#1659748 Variable copied when it could be moved 
and

cid#1659754 Variable copied when it could be moved
cid#1659755 Variable copied when it could be moved
cid#1659756 Variable copied when it could be moved
cid#1659766 Variable copied when it could be moved
cid#1659767 Variable copied when it could be moved
cid#1659769 Variable copied when it could be moved
cid#1659770 Variable copied when it could be moved
cid#1659777 Variable copied when it could be moved
cid#1659787 Variable copied when it could be moved
cid#1659790 Variable copied when it could be moved
cid#1659793 Variable copied when it could be moved
cid#1659802 Variable copied when it could be moved
cid#1659818 Variable copied when it could be moved
cid#1659822 Variable copied when it could be moved
cid#1659824 Variable copied when it could be moved
cid#1659825 Variable copied when it could be moved
cid#1659826 Variable copied when it could be moved
cid#1659842 Variable copied when it could be moved
cid#1659849 Variable copied when it could be moved
cid#1659850 Variable copied when it could be moved

Change-Id: I70729aaf6e229518a9a50ac18311286ab5b05b53
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189348
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
 2025-08-11 13:16:28 +02:00
Noel Grandin 8126025906 BitmapEx->Bitmap in various icons 
now that Bitmap can handle transparency

Change-Id: I00ea1e086af3266b1ebfd7e668c49a3abd97a131
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189272
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-08-10 08:51:20 +02:00
Caolán McNamara 5568801a46 cid#1556634 Variable copied when it could be moved 
cid#1659641 Variable copied when it could be moved
cid#1659647 Variable copied when it could be moved
cid#1659650 Variable copied when it could be moved
cid#1659663 Variable copied when it could be moved
cid#1659685 Variable copied when it could be moved
cid#1659698 Variable copied when it could be moved
cid#1659703 Variable copied when it could be moved
cid#1659705 Variable copied when it could be moved

Change-Id: If0d399dcce73d47be105ac4b1c342bcc010c56c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189181
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2025-08-09 00:45:51 +02:00
Caolán McNamara fc6d103827 cid#1662042 Variable copied when it could be moved 
and

cid#1662041 Variable copied when it could be moved
cid#1662040 Variable copied when it could be moved
cid#1662038 Variable copied when it could be moved
cid#1660211 Variable copied when it could be moved
cid#1660147 Variable copied when it could be moved
cid#1660117 Variable copied when it could be moved
cid#1660071 Variable copied when it could be moved
cid#1660046 Variable copied when it could be moved
cid#1660046 Variable copied when it could be moved
cid#1659985 Variable copied when it could be moved

Change-Id: I34627585e593f9de6bfa195ee0617848d9ed6135
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189157
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
 2025-08-08 12:35:37 +02:00
Caolán McNamara b1ec05b4b1 cid#1662031 Variable copied when it could be moved 
and

cid#1660225 Variable copied when it could be moved
cid#1660211 Variable copied when it could be moved
cid#1660185 Variable copied when it could be moved
cid#1660173 Variable copied when it could be moved
cid#1660168 Variable copied when it could be moved
cid#1660166 Variable copied when it could be moved
cid#1660165 Variable copied when it could be moved
cid#1660163 Variable copied when it could be moved
cid#1660152 Variable copied when it could be moved
cid#1660149 Variable copied when it could be moved
cid#1660147 Variable copied when it could be moved
cid#1660145 Variable copied when it could be moved
cid#1660142 Variable copied when it could be moved
cid#1660140 Variable copied when it could be moved
cid#1660137 Variable copied when it could be moved
cid#1660136 Variable copied when it could be moved
cid#1660135 Variable copied when it could be moved
cid#1660128 Variable copied when it could be moved
cid#1660124 Variable copied when it could be moved
cid#1660122 Variable copied when it could be moved
cid#1660117 Variable copied when it could be moved
cid#1660114 Variable copied when it could be moved
cid#1660110 Variable copied when it could be moved
cid#1660109 Variable copied when it could be moved
cid#1660105 Variable copied when it could be moved
cid#1660104 Variable copied when it could be moved
cid#1660102 Variable copied when it could be moved
cid#1660100 Variable copied when it could be moved
cid#1660098 Variable copied when it could be moved
cid#1660080 Variable copied when it could be moved
cid#1660079 Variable copied when it could be moved
cid#1660078 Variable copied when it could be moved
cid#1660075 Variable copied when it could be moved
cid#1660071 Variable copied when it could be moved
cid#1660070 Variable copied when it could be moved
cid#1660064 Variable copied when it could be moved
cid#1660063 Variable copied when it could be moved
cid#1660060 Variable copied when it could be moved
cid#1660058 Variable copied when it could be moved
cid#1660053 Variable copied when it could be moved
cid#1660050 Variable copied when it could be moved
cid#1660049 Variable copied when it could be moved
cid#1660046 Variable copied when it could be moved
cid#1660042 Variable copied when it could be moved
cid#1660028 Variable copied when it could be moved
cid#1660023 Variable copied when it could be moved
cid#1660022 Variable copied when it could be moved
cid#1660021 Variable copied when it could be moved
cid#1660020 Variable copied when it could be moved
cid#1660017 Variable copied when it could be moved
cid#1660013 Variable copied when it could be moved
cid#1660005 Variable copied when it could be moved
cid#1660003 Variable copied when it could be moved
cid#1659999 Variable copied when it could be moved
cid#1659998 Variable copied when it could be moved
cid#1659995 Variable copied when it could be moved
cid#1659993 Variable copied when it could be moved
cid#1659989 Variable copied when it could be moved
cid#1659988 Variable copied when it could be moved

Change-Id: I2a30c8a2ac8785050d49b98635b0b406535b185a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189056
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
 2025-08-07 20:51:26 +02:00
Caolán McNamara d356341535 cid#1660220 Variable copied when it could be moved 
and

cid#1660211 Variable copied when it could be moved
cid#1660204 Variable copied when it could be moved
cid#1660195 Variable copied when it could be moved
cid#1660194 Variable copied when it could be moved
cid#1660193 Variable copied when it could be moved
cid#1660191 Variable copied when it could be moved
cid#1660188 Variable copied when it could be moved
cid#1660187 Variable copied when it could be moved

Change-Id: Ifcb179f73723e2d43144e242fa9c1b5ac332cd4f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188965
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2025-08-05 22:12:32 +02:00
Caolán McNamara c2e99a2502 cid#1555615 Variable copied when it could be moved 
and

cid#1555637 Variable copied when it could be moved
cid#1555640 Variable copied when it could be moved
cid#1555863 Variable copied when it could be moved
cid#1556471 Variable copied when it could be moved
cid#1556634 Variable copied when it could be moved
cid#1556731 Variable copied when it could be moved
cid#1556751 Variable copied when it could be moved
cid#1556807 Variable copied when it could be moved
cid#1557366 Variable copied when it could be moved
cid#1558026 Variable copied when it could be moved

Change-Id: I187cb364877d35acd843d8391e5b376437ec96f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188935
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
 2025-08-05 12:05:04 +02:00
Noel Grandin 62d1a50659 BitmapEx->Bitmap in Image 
Now that Bitmap can handle transparency

Change-Id: Ic97b5fea315edfb8a5c9c5adb306a8b4f1c97f5b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188822
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-08-02 18:34:08 +02:00
Caolán McNamara 8f73de67cf cid#1660488 Variable copied when it could be moved 
and

cid#1660483 Variable copied when it could be moved
cid#1660480 Variable copied when it could be moved
cid#1660473 Variable copied when it could be moved
cid#1660472 Variable copied when it could be moved
cid#1660471 Variable copied when it could be moved
cid#1660468 Variable copied when it could be moved
cid#1660464 Variable copied when it could be moved
cid#1660463 Variable copied when it could be moved
cid#1660462 Variable copied when it could be moved

Change-Id: I6380e6a6c2a63a5d6f2052264c54f250703e77fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188825
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2025-08-02 17:39:55 +02:00
Caolán McNamara 004f16ca45 cid#1660859 Variable copied when it could be moved 
and

cid#1660535 Variable copied when it could be moved
cid#1660533 Variable copied when it could be moved
cid#1660519 Variable copied when it could be moved
cid#1660518 Variable copied when it could be moved
cid#1660516 Variable copied when it could be moved
cid#1660504 Variable copied when it could be moved
cid#1660497 Variable copied when it could be moved
cid#1660493 Variable copied when it could be moved
cid#1660490 Variable copied when it could be moved
cid#1660489 Variable copied when it could be moved

Change-Id: I44be3d401c56fd6d5183dcd1ee6f8efef52b305e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188821
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
 2025-08-02 16:20:00 +02:00
Noel Grandin e2b2eec732 BitmapEx->Bitmap in AddonsOptions 
now that Bitmap can handle transparency

Change-Id: Iaa82c9596c27409b1361bd430f2d6b7eaf4eefd3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188817
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-08-02 13:33:13 +02:00
Caolán McNamara 4725db2575 cid#1659599 Variable copied when it could be moved 
and

cid#1659624 Variable copied when it could be moved
cid#1659632 Variable copied when it could be moved
cid#1659637 Variable copied when it could be moved
cid#1659656 Variable copied when it could be moved
cid#1659662 Variable copied when it could be moved

Change-Id: I20179a4ff699af546694b8a4796ab2f0cfae1903
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188708
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
 2025-08-01 17:29:00 +02:00
Caolán McNamara c959f426ce cid#1659610 Variable copied when it could be moved 
Change-Id: I7d8369d837065fd442c31dba80707d29024aae8d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188497
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2025-07-29 00:22:06 +02:00
Noel Grandin f5b1d36135 loplugin:finalclasses 
Change-Id: I6f82fe09f5ae863eb2c2c0ee1c8a0703ffc5107b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188214
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-07-23 15:00:44 +02:00