Neil Roberts
7da5034706
The XCUBasedAcceleratorConfiguraton reloads the configuration for a key when a change notification on that key is received. However if the change event was triggered by deleting a key then the change path doesn’t contain a command and the code was ignoring it. The reloadChanged function seems to already almost be designed to handle the case when there is no command in the configuration. In that case it deletes the key which seems like the right thing to do. However, when a new key is assigned an event first gets fired for the key with no locale, so the code needs to additionally handle that case now. I don’t think this has any practical implications unless it’s possible to have two instances of an XCUBasedAcceleratorConfiguration for the same module open at the same time. However, this patch alone can work as an alternative way to fix the problem described in96491f3f84because it would cause the deleted key from the module config to also be deleted in the global config. It looks like the check for sPath was added in7492878a15. Change-Id: Ia90a1932e3169ca28157482c3035aba7efae012a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190972 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
UNO Framework
Toolbars, menus, UNO stuff, including accelerators and interaction, etc.