found by converting tdf34406-1.odp to pptx and running officeotron on the output
INFO - Validating part "/ppt/slides/slide4.xml" using schema "29500T/pml.xsd" ...
ERROR - (slides/slide4.xml:2 col:24,296) cvc-datatype-valid.1.2.3:
'-4900000' is not a valid value of union type 'ST_PositiveFixedPercentage'.
The import data in content.xml looks like:
<style:style style:name="ce8" style:family="table-cell">
<style:graphic-properties draw:fill="solid" draw:fill-color="#808080"
draw:opacity="-4900%"
where the opacity value is wildly out of range. So validate on input.
Change-Id: I1d9146a3f38f975a5e229f63e17fca6fb435439b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194950
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
(cherry picked from commit 80c58f15baf79f19b954b1199cbca9c2f3dcf8bf)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194952
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Cfr. patch
https://gerrit.libreoffice.org/c/core/+/184662
Dialogs can either be stored in a library
or created from scratch.
When run in non-modal mode, the closing of
a stored dialog with the window Close
top-right cross was done by LO correctly
in LO <= release 25.2.
Since 25.8, both dialog created from scratch
or stored in a library need a coded
XTopWindowListener to have the job done.
Since above-mentioned patch, SF activated
a listener for on-the-fly dialogs only.
Change-Id: I6fca927d2a2cea321eba5303d4ff3037f15b5841
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194949
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
Tested-by: Jenkins
Change the test name in drawinglayer\qa\unit\vclmetafileprocessor2d.cxx
from testTdf136957 to the more descriptive
tdf136957_draw_impress_dotted_line. Change the test name in
drawinglayer\qa\unit\vclpixelprocessor2d.cxx from testTdf139000 to the
more descriptive tdf139000_draw_clipped_gradient.
Change-Id: Ibef5d2819fc8de0c124b8fc79c17923c3a5ed8aa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194936
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
GetOutputWidthPixel() and GetOutputHeightPixel() both return a value of
type tools::Long, representing an offset width and height in pixels.
Since aSquare and aCandidateSquare multiply these values, it seems
reasonable to use sal_uInt64 here just in case of larger displays.
Change-Id: Idacf8e7c43e884b72699ee1d521d1e0dbf4715a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194942
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
Replaces the old explicit template instantiation with the
modern SfxItemSet::makeFixedSfxItemSet helper function.
This simplifies the syntax and enables auto type deduction.
Change-Id: I23102ca679756f6e2b1caca182469fdaacd501a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194927
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
"Protect against manual changes" seems not the same as read-only when
it comes to removing table of contents. For example, .uno:RemoveTableOf
removes a table of content regardless of the "Protect against manual
changes" setting. This patch changes the current behavior of displaying
the read-only content write-protected info message to not displaying
the message and allowing table of content deletion/cutting
when the entire table of content is included in a selection.
Change-Id: I4a14f0b1a17afbaacf211d7ddbe14f613761ebc5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194753
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Jenkins
When the current cursor is positioned in a fly frame, call
ExtendedSelectAll so content not visible in the frame is also
selected.
Change-Id: I27f77b43eec692331d70016abe35cbeb1650846e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194377
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Jenkins
This has 2 parts:
1) Send the status of the UNO command in the LOK case. This allows a LOK
client to call getPartInfo(), when a non-standard redline render mode
is activated, similar to how the Impress case can use .uno:NotesMode
to react to the enter/leave of notes editing mode.
2) Implement getPartInfo() for Writer, which allows core to expose the
current "mode" (0 for standard, 2 for 'omit delete'). Ignore the part
number, since Writer only has 1 part in the LOK API, but expose our
current mode there.
With this, a suitable LOK client can repaint tiles when
.uno:RedlineRenderMode is dispatched to "enter" or "leave" this "omit
delete" redline render mode.
Change-Id: I5115bfd6e72ac5117a16f55e8f370be92e774f7e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194929
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
I removed this catch block in
commit 0e8c798a7f
Author: Noel Grandin <noel.grandin@collabora.co.uk>
Date: Thu Nov 27 10:06:53 2025 +0200
avoid some unnecessary exception throw/catch as control flow
which is wrong, it was introduced as
commit a951d70609
Author: Michael Stahl <mstahl@redhat.com>
Date: Mon Jan 11 17:16:24 2016 +0100
oox: getEntryName() could throw a WrongStateException
let's guard against that.
Change-Id: I32c46e62f3ec1f8e742aba765ef190701d36b52b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194922
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
and others where host binaries cannot be run by the builder.
xmloff is part of the cross-toolset and that needs chart2api – and for
make to know about the char2api library, it needs to load the chart2
module's makefiles.
(since 1bd04a5413 )
Change-Id: I3b5446313d3660fac553c003c0876bffe0690f05
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194915
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
solenv/gbuild/Package.mk:83: *** depend(s) on package python3 which does not exist.. Stop.
It needs to depend on something that works with both internal and
external python, namely the python executable/command.
Change-Id: I4aee621ccc65261a1f7d4af7d1a303bd6d5f34d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194921
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
* Update translations from branch 'master'
to 8f9ce10af051a64873489fc574abf8ec44a1d86d
- update translations for master/26.2
and force-fix errors using pocheck
Change-Id: Ib9b4ed3531b838d4d4ea4d6e5df1f9f63ddbbd10
ODsnTypeCollection::TypeIterator
C++20 automatically generates operator!= when operator== is available.
This operator was a trivial negation and is safe to remove.
Signed-off-by: Gilma Sebastian <sebastiangilma9@gmail.com>
Change-Id: I492b6162dc451ab0966e81e937632957506c1a7a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194848
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
The fake loop was used only to allow early exit, and the flow had
to go thwough Window::LeaveWait in the end. Use of the ScopeGuard
streamlines the flow.
Change-Id: I244035c0f641b8c82c0d5ce2c9cf2fb443bbca6d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194901
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
And same for SwTableBoxFormula and SwTableFormula.
The formula string is a bit scary, "sum <1020213664:1020214688>"
seems to refer to SwTableBox* 0x3ccf39a0 and SwTableBox* 0x3ccf3da0.
SwTableField is similar, but it's a field, although it inherits from the
same SwTableFormula, so the code between the cell property and the field
is nicely shared.
Change-Id: I10d21198eb65630c98e9a666924924cd58a7840d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194902
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Enhancement request for special handling for situations when a user
has scrolled/moved the view so that the cursor is no longer visible.
To handle this, recency navigation should check if the cursor is in
the view and if not, then scroll/move the view to make the cursor
visible without any manipulation of the back/forward stack.
Change-Id: Iaaa2b09108649ed12183dcc75b9bb03a7915458c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194147
Tested-by: Jenkins
Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org>
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
* Update helpcontent2 from branch 'master'
to 8be5f8965932d7667adce9123ca1fe448c346ccc
- tdf#169785 Update View and Appearance help pages
+ Remove screenshot from the View page
+ Update how to get
+ remove outdated guide page on icon size, redirect to Appearance page
Change-Id: I57e3ade2d13303b5abdb703f4707f4856ec631ce
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/194895
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
So far a non-standard redline render mode was only available via the LOK
API. Now this UNO command allows to toggle between standard (default)
and ~omit deletes (kind of hide redlines, but only influence the
painting, not the layout).
Dispatching 2 times can be used to turn this on and off, i.e. toggle
works. Also the necessary invalidate is performed, so the content is
repainted with the new view option.
Change-Id: Id303b432179bf503e8073585868a65a314847d47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194884
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
Noel Grandin