which simplifies O[U]String expressions like
A = A + foo
into
A += foo
mostly because then they get spotted by other string plugins.
Change-Id: I2b81b701144acdf18743b52cb0befa7f90fd9528
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194191
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Commit 29dbaea278 (Use comphelper::dispatchCommand
in LokChartHelper::Dispatch, 2025-07-10) added some LOK-related UNO commands to
ControllerCommandDispatch::updateCommandAvailability. But since these commands
do not get respective m_aCommandArguments there, their state update events have
empty state, making their controls show some default values, when queried in
desktop case.
Make the commands LOK-only in updateCommandAvailability, as intended. Possibly
at some point, we could generalize updateCommandAvailability somehow to list
all the properties of selection; but for now, keep it simple.
Change-Id: I151deb1582c537471296255cf6b8630565419d12
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190941
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Define statements in ChartResourceGroups.hxx have
been replaced with an enum class. Two wrapper functions
were created to simplify code. The .cxx file has been
updated to use this enum. Other formatting changes
made to satisfy clang.
Change-Id: Ib7d095ce4fb3fbf433dcb9693f23958601dc89e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190604
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
and
cid#1659706 Variable copied when it could be moved
cid#1659716 Variable copied when it could be moved
cid#1659727 Variable copied when it could be moved
cid#1659735 Variable copied when it could be moved
cid#1659739 Variable copied when it could be moved
cid#1659740 Variable copied when it could be moved
cid#1659746 Variable copied when it could be moved
Change-Id: I981c42ebad50670d7704d5377b97917c966ee7da
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189262
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
before
commit f355ddcbf2
Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Date: Sun Apr 13 11:36:05 2025 +0900
chart2: fold isSupported* functions into ChartType
ChartTypeHelper::isSupportingAxisPositioning,
ChartTypeHelper::isSupportingBaseValue and
ChartTypeHelper::isSupportingBaseValue
checked if xChartType was not nullptr inside them
TODO: add UItest for it.
Change-Id: I908d41ccc88208ab57576bd6369590556aafcce5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189171
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
and
cid#1660225 Variable copied when it could be moved
cid#1660211 Variable copied when it could be moved
cid#1660185 Variable copied when it could be moved
cid#1660173 Variable copied when it could be moved
cid#1660168 Variable copied when it could be moved
cid#1660166 Variable copied when it could be moved
cid#1660165 Variable copied when it could be moved
cid#1660163 Variable copied when it could be moved
cid#1660152 Variable copied when it could be moved
cid#1660149 Variable copied when it could be moved
cid#1660147 Variable copied when it could be moved
cid#1660145 Variable copied when it could be moved
cid#1660142 Variable copied when it could be moved
cid#1660140 Variable copied when it could be moved
cid#1660137 Variable copied when it could be moved
cid#1660136 Variable copied when it could be moved
cid#1660135 Variable copied when it could be moved
cid#1660128 Variable copied when it could be moved
cid#1660124 Variable copied when it could be moved
cid#1660122 Variable copied when it could be moved
cid#1660117 Variable copied when it could be moved
cid#1660114 Variable copied when it could be moved
cid#1660110 Variable copied when it could be moved
cid#1660109 Variable copied when it could be moved
cid#1660105 Variable copied when it could be moved
cid#1660104 Variable copied when it could be moved
cid#1660102 Variable copied when it could be moved
cid#1660100 Variable copied when it could be moved
cid#1660098 Variable copied when it could be moved
cid#1660080 Variable copied when it could be moved
cid#1660079 Variable copied when it could be moved
cid#1660078 Variable copied when it could be moved
cid#1660075 Variable copied when it could be moved
cid#1660071 Variable copied when it could be moved
cid#1660070 Variable copied when it could be moved
cid#1660064 Variable copied when it could be moved
cid#1660063 Variable copied when it could be moved
cid#1660060 Variable copied when it could be moved
cid#1660058 Variable copied when it could be moved
cid#1660053 Variable copied when it could be moved
cid#1660050 Variable copied when it could be moved
cid#1660049 Variable copied when it could be moved
cid#1660046 Variable copied when it could be moved
cid#1660042 Variable copied when it could be moved
cid#1660028 Variable copied when it could be moved
cid#1660023 Variable copied when it could be moved
cid#1660022 Variable copied when it could be moved
cid#1660021 Variable copied when it could be moved
cid#1660020 Variable copied when it could be moved
cid#1660017 Variable copied when it could be moved
cid#1660013 Variable copied when it could be moved
cid#1660005 Variable copied when it could be moved
cid#1660003 Variable copied when it could be moved
cid#1659999 Variable copied when it could be moved
cid#1659998 Variable copied when it could be moved
cid#1659995 Variable copied when it could be moved
cid#1659993 Variable copied when it could be moved
cid#1659989 Variable copied when it could be moved
cid#1659988 Variable copied when it could be moved
Change-Id: I2a30c8a2ac8785050d49b98635b0b406535b185a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189056
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
and
cid#1660372 Variable copied when it could be moved
cid#1660369 Variable copied when it could be moved
cid#1660364 Variable copied when it could be moved
cid#1660358 Variable copied when it could be moved
cid#1660355 Variable copied when it could be moved
cid#1660353 Variable copied when it could be moved
cid#1660352 Variable copied when it could be moved
cid#1660351 Variable copied when it could be moved
Change-Id: I82e651e8d18a4461e81c7b0eb85c4ff6ec0e963a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188849
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
... instead of the more generic weld::Container for
these widgets defined as "GtkBox" objects in the .ui file
(chart2/uiconfig/ui/chartdatadialog.ui).
This change is done as part of checking that none
of the widgets on which the weld::Container methods
are called is a weld::ScrolledWindow, which will soon
no longer subclass weld::Container.
Change-Id: I97220960531ac61eb2ddeb367c309212c8544d23
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188755
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
as part of the project of removing BitmapEx in favour of Bitmap, now that we can store RGBA data in Bitmap.
This mostly just moves the Bitmap->BitmapEx from inside OutputDevice to the various call sites,
from where I can make further improvements.
Change-Id: Id5366c1eb5ebca98fee7c974737552f4a09a5c2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188341
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Return a reference to the concrete DNDListenerContainer
instance instead of one to the abstract
css::datatransfer::dnd::XDropTarget interface in
Window::GetDropTarget.
This allows to drop Window::GetDragGestureRecognizer
which was returning a reference to the
css::datatransfer::dnd::XDragGestureRecognizer interface
for the exact same object, so can now use
Window::GetDropTarget directly instead, which drops the
need to query for the other interface.
DNDEventDispatcher was already assuming that a
DNDListenerContainer object was returned and
casting to that, which is no longer needed now.
Change-Id: Ib7ea7cdb0650ba2410b112774f475b4799901538
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188271
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
By now, the accessible is known to always be an OAccessible,
so return that more specific type instead of a Reference to
the abstract XAccessible interface.
Change-Id: I60f6b2d6465abfcb04d4ee7d3a26bce69fccded3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188182
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
By now, the accessible is known to always be an OAccessible,
so return that more specific type instead of a Reference to
the abstract XAccessible interface.
Change-Id: Ie8f5318fb35d2fdeb59ac97452e2e27971c6b5a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188180
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
and just have a single pool for the EditEngine machinery.
I cannot find a reason for a separat pool anymore, probably
it was a thing from the distant past.
This also shaves 5% off the load time of tdf#162126 because
we no longer have to spend losts of time re-creating SfxItemSets
because they belong to different pools.
Change-Id: I837045809dc292548b10e2cf5173d2a29b0879a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187969
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
The TriStateEnabled struct implements logic to loop
through the three different TriState states for a
weld::Toggleable.
In practice, it is only used for weld::CheckButton
objects, and (while not instantly clear from the API)
TRISTATE_INDET isn't actually supported
by all weld::Toggleable subclasses.
Switch the param to TriStateEnabled::ButtonToggled
from weld::Toggleable& to weld::CheckButton& and
rename to CheckButtonToggled to make clearer this
is only for CheckButton.
As a consequence, adjust callers that were passing
just a weld::Toggleable& to pass a CheckButton&
(to the same underlying object) to adhere to the
new method signature.
This is one step towards making the inconsistent state
specific to weld::CheckButton, i.e. (re)move it from
weld::Toggleable and other subclasses.
Change-Id: I843c1c7075f91c0b81605ecb5d7e54621b9074c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187992
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
... and rename to `m_rParameter` accordingly.
This makes clear this is always non-null and
allows to drop a corresponding null check in
SchAttribTabDlg::PageCreated.
Change-Id: I82f18d7db7b026f31ed6e93b71fecda0f3c7fe89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187861
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This change aims to avoid special-casing when dispatching commands from
LokChartHelper. It builds upon I883c6a6905e78da0c083323b5ef641fa27f133b4
and I2bc8cecfc4f38d66121d9a39313b37a51d7f0aff.
Before this patch, commands passed through LokChartHelper were directly
dispatched using ChartController::dispatch, instead of finding correct
dispatcher using queryDispatch. That required ChartController::dispatch
to handle the commands that it wasn't intended to handle; e.g., commit
9126cde8cb (When chart is active pass
uno:ChangeTheme through to its parent frame, 2024-01-29) added that
special processing.
Now we can use the normal queryDispatch mechanism to find the correct
dispather, and revert the mentioned change.
Change-Id: I5c3231690f8a7a2bb7b83ced90f18866f9b2deb3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187368
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
ChartController::impl_getAvailableCommands had almost the same list as
what was stored in ControllerCommandDispatch::m_aCommandAvailability.
That required to keep these lists in sync, prone to overlooks.
This change makes ChartController::impl_getAvailableCommands only hold
those commands that should not appear in ControllerCommandDispatch. At
the moment, those are only forwarded commands and ChartElementSelector,
that may need to be handled in ControllerCommandDispatch. LOK-specific
commands may be added here later.
Change-Id: I82bbfbd6a69bbaaebcc91d8f29b6c22ddf2f8ae6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187448
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Check m_aCommandAvailability.contains to decide if we need to call
fireStatusEventForURLImpl for the given command. This also avoids
an extra event for .uno:StatusBarVisible (explicitly handled below).
Change-Id: If5a74e0631759bd2ace0aebc60670b70bf43aa08
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187444
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
In commit c6b95527d2 (INTEGRATION: CWS
chart2mst3 (1.15.4); FILE MERGED, 2007-05-22), it was implemented to
check that the target frame name is not empty and is equal to "_self".
The "not empty" check was redundant as implemented; and was dropped
in commit 33fe5b57ea (Drop a redundant
check, 2025-07-04). But it looks like the original implementation
intended to do something different, namely check if the target frame
name is *either* empty, *or* "_self": see documentation for _self in
offapi/com/sun/star/frame/XFrame.idl (and implementation in various
places, like framework/source/dispatch/dispatchprovider.cxx).
This is fixed here. CommandDispatchContainer::getDispatchesForURLs
is fixed as well.
Change-Id: I9ed6981edeca16661f07e41b87b114a8e16d69ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187442
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
... after commit 36b5f0ebf4 (Flatten
CommandDispatchContainer::getDispatchForURL a bit, 2025-07-04),
which broke its logic (everything after the 'if xModel' needs to
be also checked in case when nested checks fail).
Change-Id: I608b53f993d60d9d0c873e951a1cb53106eeaeec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187441
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Noel Grandin