ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

cid#1555415 Variable copied when it could be moved

Browse Source 
and

cid#1659706 Variable copied when it could be moved
cid#1659716 Variable copied when it could be moved
cid#1659727 Variable copied when it could be moved
cid#1659735 Variable copied when it could be moved
cid#1659739 Variable copied when it could be moved
cid#1659740 Variable copied when it could be moved
cid#1659746 Variable copied when it could be moved

Change-Id: I981c42ebad50670d7704d5377b97917c966ee7da
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189262
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
This commit is contained in:
Caolán McNamara
2025-08-09 19:40:43 +02:00
parent 56c55dceea
commit 270f80c3f2
10 changed files with 13 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
chart2/source/controller/main/ShapeController.cxx
+1 -2
View File
@@ -359,8 +359,7 @@ void ShapeController::executeDispatch_TransformDialog()
SvxAbstractDialogFactory* pFact = SvxAbstractDialogFactory::Create();
ScopedVclPtr< SfxAbstractTabDialog > pDlg(
pFact->CreateCaptionDialog(pChartWindow, pDrawViewWrapper));
const WhichRangesContainer aRange = pDlg->GetInputRanges( *aAttr.GetPool() );
SfxItemSet aCombAttr( *aAttr.GetPool(), aRange );
SfxItemSet aCombAttr(*aAttr.GetPool(), pDlg->GetInputRanges(*aAttr.GetPool()));
aCombAttr.Put( aAttr );
aCombAttr.Put( aGeoAttr );
pDlg->SetInputSet( &aCombAttr );
oox/inc/drawingml/scene3dhelper.hxx
+1 -1
View File
@@ -47,7 +47,7 @@ public:
@param [in] rRotZ the shape rotation inclusive camera z-rotation as calculated by
setExtrusionProperties()
@param [in, out] rPropertyMap the map, that was already filled by setExtrusionProperties()*/
void setLightingProperties(const oox::drawingml::Shape3DPropertiesPtr p3DProperties,
void setLightingProperties(const oox::drawingml::Shape3DPropertiesPtr& p3DProperties,
const double& rRotZ, oox::PropertyMap& rPropertyMap);
/** Puts the material properties of the 3D-shape into the property map
oox/source/drawingml/scene3dhelper.cxx
+1 -1
View File
@@ -875,7 +875,7 @@ void lcl_tweakLightRig(std::vector<basegfx::B3DVector>& rLightDirVec, PrstLightR
} // end anonymous namespace
void Scene3DHelper::setLightingProperties(const oox::drawingml::Shape3DPropertiesPtr p3DProperties,
void Scene3DHelper::setLightingProperties(const oox::drawingml::Shape3DPropertiesPtr& p3DProperties,
const double& rfRotZ, oox::PropertyMap& rPropertyMap)
{
if (!p3DProperties || !(*p3DProperties).mnLightRigType.has_value())
sc/source/filter/oox/worksheetsettings.cxx
+1 -1
View File
@@ -160,7 +160,7 @@ void WorksheetSettings::importProtectedRange( const AttributeList& rAttribs )
aProt.maRangeList = xRangeList.release();
}
}
maSheetProt.maEnhancedProtections.push_back( aProt);
maSheetProt.maEnhancedProtections.push_back(std::move(aProt));
}
void WorksheetSettings::importChartProtection( const AttributeList& rAttribs )
sd/source/core/CustomAnimationPreset.cxx
+1 -1
View File
@@ -359,7 +359,7 @@ void CustomAnimationPresets::importPresets( const Reference< XMultiServiceFactor
CustomAnimationPresetPtr pEffect = getEffectDescriptor( rEffectName );
if( pEffect )
{
aEffectsList.push_back( pEffect );
aEffectsList.push_back(std::move(pEffect));
}
#if OSL_DEBUG_LEVEL >= 2
else
sd/source/ui/dlg/RemoteDialogClientBox.cxx
+1 -2
View File
@@ -82,8 +82,7 @@ ClientBoxEntry* ClientBox::GetActiveEntry()
void ClientBox::addEntry( const std::shared_ptr<ClientInfo>& pClientInfo )
{
TClientBoxEntry xEntry = std::make_shared<ClientBoxEntry>(this, pClientInfo);
m_vEntries.push_back(xEntry);
m_vEntries.push_back(std::make_shared<ClientBoxEntry>(this, pClientInfo));
}
void ClientBox::setActive(ClientBoxEntry* pClientEntry)
sfx2/source/bastyp/fltfnc.cxx
+1 -1
View File
@@ -512,7 +512,7 @@ ErrCode SfxFilterMatcher::DetectFilter( SfxMedium& rMedium, std::shared_ptr<cons
if ( nErr == ERRCODE_IO_PENDING )
{
rpFilter = pFilter;
rpFilter = std::move(pFilter);
return nErr;
}
sfx2/source/view/lokhelper.cxx
+1 -1
View File
@@ -859,7 +859,7 @@ std::vector<std::string> SfxLokHelper::extractCertificates(const std::string& rC
break;
}
aRet.push_back(aNext);
aRet.push_back(std::move(aNext));
}
return aRet;
}
ucb/source/ucp/cmis/cmis_content.cxx
+2 -2
View File
@@ -463,7 +463,7 @@ namespace cmis
{
if ( nullptr == m_pObjectType.get( ) && m_bTransient )
{
const std::string typeId = m_bIsFolder ? "cmis:folder" : "cmis:document";
const std::string_view typeId = m_bIsFolder ? "cmis:folder" : "cmis:document";
// The type to create needs to be fetched from the possible children types
// defined in the parent folder. Then, we'll pick up the first one we find matching
// cmis:folder or cmis:document (depending what we need to create).
@@ -505,7 +505,7 @@ namespace cmis
}
if ( !bTypeRestricted )
m_pObjectType = getSession( xEnv )->getType( typeId );
m_pObjectType = getSession( xEnv )->getType(std::string(typeId));
}
return m_pObjectType;
}
unoxml/source/rdf/librdf_repository.cxx
+3 -2
View File
@@ -1429,7 +1429,7 @@ librdf_Repository::queryConstruct(const OUString & i_rQuery)
std::scoped_lock g(m_aMutex);
const OString query(
OUStringToOString(i_rQuery, RTL_TEXTENCODING_UTF8) );
const std::shared_ptr<librdf_query> pQuery(
std::shared_ptr<librdf_query> pQuery(
librdf_new_query(m_pWorld.get(), s_sparql, nullptr,
reinterpret_cast<const unsigned char*> (query.getStr()), nullptr),
safe_librdf_free_query);
@@ -1456,7 +1456,8 @@ librdf_Repository::queryConstruct(const OUString & i_rQuery)
}
return new librdf_GraphResult(this, m_aMutex, std::move(pStream),
std::shared_ptr<librdf_node>(), pQuery);
std::shared_ptr<librdf_node>(),
std::move(pQuery));
}
sal_Bool SAL_CALL