ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
520,958 Commits 3 Branches 3 Tags
main
Commit Graph
77 Commits
Author SHA1 Message Date
Andrea Gelmini 1178fa58a1 Fix typos 
Change-Id: I9a4a964c5a4316c140d03b266ad46c504d918e6d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210050
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
 2026-08-27 20:33:32 +02:00
Andrea Gelmini 853b62cd50 Fix typos 
Change-Id: Ia6f67b5a6c196580f63beef43a6ab6723b02fd0e

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209761
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2026-08-25 15:43:38 +02:00
Gabor Kelemen b63115f3fa tdf#146619 Use more forward declarations in include/vcl/[d-g]* 
Found after running bin/find-unneeded-includes --headersfwd include/vcl/[d-g]*

This shaves off about 150M input

Change-Id: I2b15257451d4b392dca3e5d07f4a443ee653b04c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196395
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
 2026-01-11 21:38:37 +01:00
Noel Grandin e00f6e0b9d loplugin:ostr in lotuswordpro 
Change-Id: Ifea660ab9e0663312f9013670c27d3feda314d81
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167427
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-05-10 09:51:45 +02:00
Rafał Dobrakowski c8b8a2c2cb tdf#141908 - CppUnittests: replace usage of sal_Int32 with colors 
Conversion of hex/dec colour notation
(example entry Color( 255, 255, 255), Color(0xFFFFFF) - COL_WHITE)
For the other available colour definitions.

Change-Id: I9eed0cd64adcbc8d25e1c22143a000906a457586
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163729
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
 2024-03-14 02:33:03 +01:00
Mike Kaganski a01a642ebb UnoApiTest::loadFromURL -> UnoApiTest::loadFromFile 
The old name was misleading (it doesn't take an URL, but a filename);
also, now it's easier to grep for it - doesn't get mixed with
vcl::graphic::loadFromURL.

Change-Id: Ib88d2194200a6a54d2326971e0306ba39f0c7025
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161578
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2024-01-03 07:51:28 +01:00
Caolán McNamara ffdee63185 ofz#57800 Timeout 
Change-Id: I14b4906ce61b3d8a86cb9a766986c49e0b0e6abc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150171
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2023-04-10 10:40:01 +02:00
Xisco Fauli 8c018651a0 CppunitTest_lotuswordpro_import_test: inherit from UnoApiTest 
Change-Id: I6287ea3b0ed24a8dca002b95d59120ce302fc2c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142100
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2022-11-01 12:33:55 +01:00
Andrea Gelmini df31e72e58 Fix typos 
Change-Id: I62b11b80e4d3d2a8bd4c461804f39d8da6a58066
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137298
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2022-07-21 16:16:44 +02:00
Bartosz Kosiorek a0bcd1d187 tdf33787 lotuswordpro: fix increments of ordered bullets 
With previous implementation there was an bug which causing missing
incrementing ordered bullets. For example:

        A. Lettered bullet uppercase 1 (A. )
        A. Lettered bullet uppercase 2 (B. )
        A. Lettered bullet uppercase 3 (C. )

This patch is fixing that, and increments is working correctly:

        A. Lettered bullet uppercase 1 (A. )
        B. Lettered bullet uppercase 2 (B. )
        C. Lettered bullet uppercase 3 (C. )

It is also make sure that nested and skipped bullets are working correctly:

        1) Numbered bullet w/ bracket one (1) )
           Skipped bullet
        2) Numbered bullet w/ bracket two (2) )
            a) Lettered bullet w/ bracket lowercase 1 (a) )
            b) Lettered bullet w/ bracket lowercase 2 (b) )

Change-Id: I1d1ad9ee549039077b418756efefb10bacfa1ddd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137112
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
 2022-07-21 09:11:31 +02:00
Mike Kaganski 7ba7c1128f Prepare for removal of non-const operator[] from Sequence in lotuswordpro 
Change-Id: Id71f7a16d5ba0b47676d11136ef327205c370aab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124375
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2021-10-30 17:39:15 +02:00
Caolán McNamara bd555ee0eb ofz#26357 Infinite loop 
Change-Id: I914d5c8e53e226567f48b084b1cdb55721a58359
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121182
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2021-08-28 10:52:00 +02:00
Caolán McNamara 82a5d94b47 ofz#37660: searching in wrong parent for table 
Change-Id: Ifa1b70fa0ccc706cec52b318cdfba59f5da2b4d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121124
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2021-08-27 09:27:55 +02:00
Caolán McNamara b67f42c4c2 ofz#35646 Indirect-leak 
Change-Id: Ie79d9c49b6beef04ab111a63166abc7f093ad36b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121041
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2021-08-26 09:56:08 +02:00
Moaz a9a350c13d tdf#139734 Remove redundant asserts after MacrosTest::loadFromDesktop 
MacrosTest::loadFromDesktop itself asserts on its return value.
Thus, the additional checks in unit tests are redundant, and only create
noise unrelated to the tested functionality.

Change-Id: If616001b296afdde38f5a23ececee3d44b4a395d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111290
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2021-02-25 07:50:29 +01:00
Caolán McNamara 117ecc9870 fix coverity parse errors 
Change-Id: I4884bfb67a061b865e8cf38b2fea6de0cb1bc3d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109057
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2021-01-10 21:01:05 +01:00
Stephan Bergmann 042033f1e6 loplugin:stringviewparam: operator + 
Change-Id: I044dd21b63d7eb03224675584fa143009c6b6008
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108418
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2020-12-29 16:42:33 +01:00
Stephan Bergmann a3d0091d18 New loplugin:stringliteralvar 
See the comment at the top of compilerplugins/clang/stringliteralvar.cxx for
details.

(Turned some affected variables in included files into inline variables, to
avoid GCC warnings about unused variables.)

Change-Id: Ie77219e6adfdaaceaa8b4e590b08971f2f04c83a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108239
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2020-12-26 14:51:15 +01:00
Gabor Kelemen 0124ed6c9c tdf#42949 Fix IWYU warnings in lotuswordpro/*/*cxx 
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I9b0ba9f0c334b0eccb0f38a3313c60a63eaf7647
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95644
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2020-06-08 14:57:44 +02:00
Michael Stahl 1ca7e41fa8 workaround GCC 9.2.1 -Og -Werror=maybe-uninitialized 
vcl/unx/generic/gdi/salbmp.cxx:727:32: error: ‘pixmapHandle’ may be used uninitialized in this function [-Werror=maybe-uninitialized]

vcl/unx/gtk3/gtk3gtkinst.cxx:7336:16: error: ‘eRet’ may be used uninitialized in this function [-Werror=maybe-uninitialized]

etc.

One looks like it might occur in practice.

Change-Id: I09af7d36b134b31cb7bd8047b5c73f4a49c9d9b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89351
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
 2020-02-24 19:23:38 +01:00
Xisco Fauli af14b2096e use color instead of int 
Change-Id: I7a837b61af666b6e13519df43255ff309d54f170
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88123
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
 2020-02-10 10:16:44 +01:00
Caolán McNamara c13c136da5 ofz#20504 Indirect-leak 
lets assume a table should be only assigned to one container

Change-Id: I4e33bc3dab37c20ac2337b12ae4ee4efe84cb5aa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88215
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2020-02-08 17:57:22 +01:00
Caolán McNamara 08695569fd ofz#20517 null-dereference 
Change-Id: I443869f848925911ed46e2f547f0dc652b1ff290
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88214
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2020-02-07 20:48:51 +01:00
Miklos Vajna 75a7932bb4 test: move component context from subclasses to BootstrapFixture 
To avoid duplication.

Change-Id: I0ee7c26d5d55bd868ead04c77e7f4ef2582f90e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88138
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2020-02-07 09:13:50 +01:00
Xisco Fauli fe50330369 LWP: add unittest for char/para properties 
Change-Id: I2ef37845a2b7de189667a6ce81e7d061b1b15eb8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87987
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2020-02-05 16:11:04 +01:00
Xisco Fauli 5a989074cd tdf#129993: Add unittest 
Change-Id: I30b0583a3e38f0f8a06a7711c9413101dc87cc21
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87861
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2020-02-04 17:11:49 +01:00
Caolán McNamara 35e43ce1b1 ofz#20507 infinite table conversion 
Change-Id: I779ab29d93491a296156fcc14557755754c2afdf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87924
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2020-02-04 12:30:00 +01:00
Caolán McNamara f51c36c107 Revert "ofz#20267 Indirect-leak" 
This reverts commit ae01adf074.

Reason for revert: intermittent failures

Change-Id: I2212154e2c6ca210a2ff19cf73c0578c146dd46d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87679
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2020-01-29 12:35:45 +01:00
Caolán McNamara ae01adf074 ofz#20267 Indirect-leak 
Change-Id: I32e4d12e83573eaaaf3a393d8a2d5ba10ccb93ae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87631
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2020-01-28 21:36:19 +01:00
Caolán McNamara 0453eb32b9 Resolves: tdf#130093 some lwp file not loading 
Change-Id: I2be53792f0fadcf1ca0e99c8f9fab7305d0fcddd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87100
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2020-01-20 21:54:35 +01:00
Caolán McNamara 25c0988b87 ofz#8095 avoid recurse to death 
Change-Id: I0acb0f68f64bb95a4510a330d463badd2cf8a84a
Reviewed-on: https://gerrit.libreoffice.org/53663
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-04-30 17:40:47 +02:00
Caolán McNamara 4df294a2ea ofz#7109 infinite regress 
Change-Id: Iac0bd81c9b0e3ac6b005bb0065895ca1b4ca4233
Reviewed-on: https://gerrit.libreoffice.org/51826
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-03-25 16:30:41 +02:00
Caolán McNamara bee825957a ofz#7043 already registered 
Change-Id: Ic94891c82944d04fe3391c0bd0731a6e3e4373e0
Reviewed-on: https://gerrit.libreoffice.org/51691
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-03-21 13:21:11 +01:00
Caolán McNamara 22fc8c634c ofz#6208 Indirect-leak 
Change-Id: I8d6761bd951cc1ddd4a45eabb26428bc40c2271a
Reviewed-on: https://gerrit.libreoffice.org/49600
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-02-12 21:36:39 +01:00
Caolán McNamara e68faf7d42 ofz#866 crash in LwpFormulaInfo::ReadArguments 
Change-Id: Id301c21c8a4a0556b6326b621171aa62bd939d8d
 2017-03-14 20:41:32 +00:00
Caolán McNamara 175458c4cd avoid recursive register style 
Change-Id: I090cec1f311be5e5a34e208d066925b294310e43
 2017-03-02 13:36:38 +00:00
Caolán McNamara b18d49e09a fftester: subtable is a subtable of itself 
Change-Id: I9de983e3c9436ab3a37d3482b0f18f04c7cdaaca
 2016-05-09 11:00:43 +01:00
Caolán McNamara 4e509d80ee fftester: fail on double parse of the same table 
Change-Id: I3e462cdc8812d0ac55d9896d2b04ace34a6c4670
 2016-05-08 17:30:47 +01:00
Caolán McNamara 19dde56de6 fftester: double use of XFTable, ref this up 
Change-Id: I8e0c2319b2f43b66686fbce372c5df63c75b343a
 2016-05-05 20:31:17 +01:00
Caolán McNamara 617bbc9da9 pCont can be null 
Change-Id: I7af6c5f4a14e330924a1ea12ebb6328884b8a565
 2016-04-09 15:40:26 +01:00
Caolán McNamara b7bf06d5d6 foundry may be null 
Change-Id: I39359389a42e35e0131db1d0451fbd5531843f75
 2016-04-08 09:29:54 +01:00
Caolán McNamara a4bc9a4319 currentlayout may be null 
Change-Id: I1e53482e722b82f052434f45e37a2fbdb2ea6ffc
 2016-04-04 10:40:01 +01:00
Caolán McNamara c9a04aed44 hold bullet para by reference 
Change-Id: I58025ea906426a7db4079042fa38954f1a3d076b
 2016-04-04 09:39:37 +01:00
Caolán McNamara 9814cf713c subtable corruption is possible 
Change-Id: Ifbf4312df583724a22328491bea3b6e05b82418f
 2016-04-03 21:39:47 +01:00
Caolán McNamara 9e0004f2cc recurse protection for XFConvert 
Change-Id: Ib6008d4b07159acad26c7baeb775702119c12e3b
 2016-03-15 09:23:15 +00:00
Caolán McNamara bcecf9b13b tweat ExtMargins with same recurse protection as Margins 
Change-Id: I24640971ea6ca89878043966293492a991f01008
 2016-03-11 10:39:24 +00:00
Stephan Bergmann 60b1c95cc4 Extract Directories from BootstrapFixtureBase 
(as some tests derive from the latter only for the Directories part, not for the
setUp/tearDown overrides: those tests will be cleaned up next)

Change-Id: Ib6b78eea868b8bc21d4cc6e8fd9e1d025deca05f
Reviewed-on: https://gerrit.libreoffice.org/23078
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2016-03-10 08:04:40 +00:00
Caolán McNamara f16ceae46d avoid infinite regress in busted documents 
Change-Id: I639617e41cd9a9a51a3dd3efa32ac1cf2991b9d2
 2016-03-08 12:10:18 +00:00
Caolán McNamara 0c9c5911b6 lwp: fix infinite recurse 
Change-Id: Ibd17c0f68a9bac92e591fd2c998de45a84b372aa
 2016-03-07 09:26:40 +00:00
Noel Grandin 70f87284c6 improve defaultparams loplugin 
to catch calling params with defaults like "= OUSString()"

Change-Id: Iad060e318ed492c22f8be44e326174fe6d28fff9
Reviewed-on: https://gerrit.libreoffice.org/22932
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-03-07 05:57:17 +00:00