ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
520,958 Commits 3 Branches 3 Tags
main
Commit Graph
201 Commits
Author SHA1 Message Date
Gabor Kelemen 8215006a9d tdf#146619 Use more forward declarations in include/ucbhelper/ 
Change-Id: I233162bb69e95c4b128e8189d1eb490a67c19ffa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198236
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
 2026-01-31 20:55:03 +01:00
Andrea Gelmini 50159dbedc Harmonize "an URL" -> "a URL" 
Change-Id: I17ae188e1dfca3a0d3b9b666a8407b1b7c862a9b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198367
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2026-01-29 17:23:22 +01:00
Gabor Kelemen c244774744 tdf#146619 Run IWYU again on include/u* 
Change-Id: Iaa4b507049ae33fb300a86075b69534bb0588c17
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193918
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
Tested-by: Jenkins
 2025-11-30 18:26:00 +01:00
Noel Grandin a1da8b21e3 SimpleCertificateValidationRequest is unused 
since
    commit 9413f2b39c
    Author: Michael Stahl <michael.stahl@allotropia.de>
    Date:   Fri Jun 21 16:23:24 2024 +0200
    ucb: cmis: remove CertValidationHandler

Change-Id: Iee66db682081ddcb7da9a6276acf3261a637f315
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180341
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-01-16 14:16:33 +01:00
Gabor Kelemen 72df5a6fdf Drop unneeded forward declarations from include/ 
test drive the new bin/find-unneeded-includes --fwdecl mode

Change-Id: I507fa2b172ec9e348d1d91066ea241f02187b5ed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179321
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2025-01-03 09:32:27 +01:00
Mike Kaganski e512091e89 Simplify InteractionContinuation and derivatives 
Change-Id: Ib7294cc09255f7563ae14488ab7fb56d02092dc4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178117
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2024-12-09 05:26:24 +01:00
Noel Grandin 327c5dd146 loplugin:passstuffbyref in ucbhelper 
Change-Id: I70f0774ec2f38c0ba250aee7999d72eaa4a82673
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176110
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2024-11-06 12:34:26 +01:00
Noel Grandin 5c4fac1e9f loplugin:unusedmethods 
Change-Id: I6ba4b4046190b701d4a15c6fa90b6009ecf4ab1c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175014
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-10-16 15:52:02 +02:00
Noel Grandin da8a36b4f4 CID#1607066:Data race condition (MISSING_LOCK) 
which means we need to push knowledge
about the locking down into ucbhelper::Result
since the implementation classes there
want to call back into the parent.

and also

CID#1607968:Data race condition (MISSING_LOCK)
CID#1606657:Data race condition (MISSING_LOCK)
CID#1607112:Data race condition (MISSING_LOCK)
CID#1608365:Data race condition (MISSING_LOCK)
CID#1607159:Data race condition (MISSING_LOCK)
CID#1607018:Data race condition (MISSING_LOCK)
CID#1607421:Data race condition (MISSING_LOCK)
CID#1607766:Data race condition (MISSING_LOCK)
CID#1606872:Data race condition (MISSING_LOCK)
CID#1608523:Data race condition (MISSING_LOCK
CID#1607191:Data race condition (MISSING_LOCK)
CID#1608345:Data race condition (MISSING_LOCK)
CID#1608577:(#1 of 1):Data race condition (MISSING_LOCK)
CID#1607210:Data race condition (MISSING_LOCK)
CID#1607132:Data race condition (MISSING_LOCK)
CID#1608256:Data race condition (MISSING_LOCK)
CID#1607482:Data race condition (MISSING_LOCK)
CID#1607935:Data race condition (MISSING_LOCK)
CID#1608070:Data race condition (MISSING_LOCK)
CID#1607901:Data race condition (MISSING_LOCK)
CID#1608013:Data race condition (MISSING_LOCK)
CID#1607506:Data race condition (MISSING_LOCK)
CID#1607526:Data race condition (MISSING_LOCK)
CID#1607044:Data race condition (MISSING_LOCK)
CID#1607708:Data race condition (MISSING_LOCK)
CID#1608041:Data race condition (MISSING_LOCK)
CID#1608207:Data race condition (MISSING_LOCK)
CID#1608028:Data race condition (MISSING_LOCK)
CID#1608168:Data race condition (MISSING_LOCK)
CID#1607561:Data race condition (MISSING_LOCK)

CID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)
CID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)
CID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)
CID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)
CID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)
CID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)
CID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)
CID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)
CID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)
CID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)

Change-Id: Ifbe908a4a86ab8c5fa1c4ed3b6f9466508e4900e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174204
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-09-30 18:24:30 +02:00
Caolán McNamara 2d4aa7861c cid#1608362 Double unlock 
and

cid#1608276 Double lock

Change-Id: I64529c0b9e9b4df2ee51a024522f82051ccea25d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170824
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-07-22 09:35:00 +02:00
Stephan Bergmann 1c387bbf2f Fix UBSan build's RTTI needs 
...after 3ba92b5f1e "hide more symbols" had caused
CppunitTest_ucb_webdav_core to fail with

> DynamicLibraryManagerException: "Failed to load dynamic library: workdir/LinkTarget/CppunitTest/libtest_ucb_webdav_core.so
> workdir/LinkTarget/CppunitTest/libtest_ucb_webdav_core.so: undefined symbol: _ZTIN9ucbhelper16PropertyValueSetE"

etc.

Change-Id: I54832b1c7a9850e536bfcab076f15465b170a065
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163690
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
 2024-02-21 15:18:19 +01:00
Noel Grandin 3ba92b5f1e hide more symbols 
using the bin/find-can-be-private-symbols.py script
to find classes with large numbers of exported symbols
that can hidden.

before
exported       = 58104
imported       = 30810
unused_exports = 35433

after
exported       = 55094
imported       = 31073
unused_exports = 32423

Change-Id: Idd0a70ee3740afd5ca1a86771e0e2ff8090d102d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163456
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-02-19 09:09:06 +01:00
Noel Grandin 033aaeec9e use more UNLESS_MERGELIBS 
Change-Id: I351a9127fb26369d8f598b6d6519d7e490fa476b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163190
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-02-12 20:25:54 +01:00
Gabor Kelemen 2c6f28f431 tdf#146619 Recheck include/[v-x]* with IWYU 
Change-Id: I3cecd622aa04d842a449b4bfd6c55d0b8b96aabf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156992
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
 2023-12-12 18:51:27 +01:00
Noel Grandin 59280a9ce5 tdf#158321 No error message when file doesn't exist 
Revert "reduce allocations in InterceptedInteraction"

This reverts commit e3c961e6a3.

Change-Id: I26ba0acaa088dff1800ccd69513056f821bd4d7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159762
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-11-23 12:07:09 +01:00
Noel Grandin 48e4a871d9 loplugin:unusedmethods 
Change-Id: I1e125bbd388953491b3f869641484fea737d39ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159423
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-11-15 06:56:06 +01:00
Gabor Kelemen 026be6f62f tdf#146619 Recheck include/t* with IWYU 
Change-Id: I005257e458351285b1b35ffe49c8b42834a6db68
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156990
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
 2023-11-06 00:33:57 +01:00
Stephan Bergmann bd6fb0cd3e Extended loplugin:ostr: Rewrite some O[U]StringLiteral -> O[U]String 
...in include files.  This is a mix of automatic rewriting in include files and
manual fixups (mostly addressing loplugin:redundantfcast) in source files that
include those.

Change-Id: I1f3cc1e67b9cabd2e9d61a4d9e9a01e587ea35cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158337
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2023-10-23 11:04:42 +02:00
Noel Grandin 6056a0e320 loplugin:unusedmethods 
Change-Id: I27782fb4b912d8b0d5f19cbe296c2a3b98b2bfd7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157818
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-10-12 16:11:29 +02:00
Stephan Bergmann 6d1b241ab7 Drop o3tl::span, can use C++20 std::span directly now 
Change-Id: Ic21ff7bf48f07f7277979d52e99d2c5c268de83f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157825
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2023-10-11 21:53:13 +02:00
Noel Grandin e3c961e6a3 reduce allocations in InterceptedInteraction 
the list of intercepted interactions is static per sub-class, so just
pass up a o3tl::span at constructor time.

Change-Id: Ib45c5a3338e0eb3848486dfc707052f07492eb61
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157480
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-10-02 13:07:00 +02:00
Michael Stahl f88af95552 ucbhelper,ucb,desktop: InternetProxyServer is problematic 
It turns out that every single client of InternetProxyDecider simply
concatenates the 2 members of InternetProxyServer into a single string
and passes it on to curl_easy_setopt(CURLOPT_PROXY), which will happily
take a URL including scheme and everything.

It turns out that the awful GetUnixSystemProxy() tries to cut off the
scheme in a terrible way, but GetPACProxy() does no such thing and
WINHTTP_PROXY_INFO::lpszProxy may or may not contain scheme in its
entries; fix this to only separate the port and leave the rest alone.

So why do we need a InternetProxyServer struct?  Because officecfg has
separate entries that correspond to its members, and so
InternetProxyDecider gets separate events on its listener interface when
any of them changes, which is easiest to handle if it stores these
separately.

So just return a concatenated URL with or without scheme in getProxy().

Change-Id: I43c696471c8bec90667b5930fa00975adb432fe1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155840
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-08-18 18:33:27 +02:00
Noel Grandin b4a5e6f025 osl::Mutex->std::mutex in ucbhelper::FdInputStream 
Change-Id: I10482c3a5f9848f45463837d5d8982476b3910a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147340
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-02-20 17:45:49 +00:00
Andras Timar cc584681ca set visibility of classes in mergelib+asan case 
Change-Id: I2eb80d0b3002f174deea0d8657cb0cdbdec5be8f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147144
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
 2023-02-16 09:49:56 +00:00
Noel Grandin eea6b27762 clang-tidy modernize-pass-by-value in ucbhelper 
Change-Id: I9f73760a800bee5a810add9ee0ebed3a778ddd8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136475
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-06-27 13:40:26 +02:00
Noel Grandin e6ad419ac9 simplify construction 
Change-Id: Ib8a28575fe813a909ce5429732a60ae77f92b6ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134269
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-05-14 08:41:17 +02:00
Noel Grandin 8960dae3a2 no need to hold OInterfaceContainerHelper4 by unique_ptr 
when empty, it is only a single pointer big anyway

Change-Id: I3e45dd705c4bef3799435617db1a4192d62860e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128403
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-14 09:45:31 +01:00
Noel Grandin a22772c439 osl::Mutex->std::mutex in ucbhelper::PropertyValueSet 
Change-Id: Ie4d3392e26a24ff3ffd9869809bb48bee7fcc2bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127067
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-12-18 18:18:56 +01:00
Noel Grandin 580b522714 osl::Mutex->std::mutex in ResultSetImplHelper 
Change-Id: I7567369120593579740e23668d3426a25377a105
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127068
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-12-18 18:18:32 +01:00
Noel Grandin 60bff7546f loplugin:stringliteraldefine in ucbhelper 
Change-Id: I5fb7ffed1e29ff494e09cf048bee9ceb0f8262c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125870
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-11-27 12:45:31 +01:00
Noel Grandin 0ff2a432f7 loplugin:moveparam in ucbhelper 
Change-Id: Id6b03af5ecd662ce2e390bb76819cfe5d2ec05ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123336
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-10-10 18:23:20 +02:00
Noel Grandin 6d200d8e73 loplugin:moveparam in ucbhelper 
Change-Id: I1b9cc0366fb8e9b2525a56816ae4f76737a31b73
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123184
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-10-06 21:17:18 +02:00
Stephan Bergmann 10d29c390d throw() -> noexcept, part 2/3: Automatic loplugin:noexcept rewrite 
Change-Id: I076f16d0536b534abf0ced4d76051eadb4c0e033
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114949
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2021-05-02 17:02:28 +02:00
Noel 9a61e9a335 loplugin:refcounting in fpicker 
Change-Id: Ia14d2a874d559c4438a33c8a46ec6076802cd637
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111285
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-02-23 07:30:05 +01:00
Philipp Hofer 01baeab998 tdf#123936 Formatting files in module include with clang-format 
Change-Id: I0507dd797cd5a35e0ae14f4b69ee4e172d08a71a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105681
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Jenkins
 2020-11-21 13:19:17 +01:00
Andrea Gelmini 0be225fb60 Fix typos 
Change-Id: Ideee477b0c8f0d472a607ed69ba51351d87f61bc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101010
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
 2020-08-19 22:07:44 +02:00
Noel Grandin 3f9940c2e0 loplugin:unusedmethods 
Change-Id: I2dd10873be73256a3689233c7b1e37bde8f685ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100820
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-08-16 15:26:37 +02:00
Julien Nabet 7211f0d15d Expand XSERVICEINFO_COMMOM_IMPL macro which is now used only once 
Change-Id: I32de3f604cbb6863e29c0a63b599920a988c8389
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100463
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2020-08-11 10:52:13 +02:00
Gabor Kelemen 32090b018d tdf#42949 Fix IWYU warnings in include/[t-x]*/*hxx 
Recheck after 7-0 branchoff

Also drop the now unused file include/vcl/field.hxx

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I9e54c82f50d1e02a0f99858939cac999fc66f7de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99261
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2020-08-03 10:23:10 +02:00
Noel Grandin 15f44cb6fb expand out an UNO macro 
to make the ongoing convert-to-UNO-constructor work easier

Change-Id: I99596561832b10538505cf4dfdabaf11d6e4d7cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98664
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-07-13 18:33:07 +02:00
Noel Grandin 47cd34a60f use more compact namespace syntax in /include 
excluding the UDK headers of course

Change-Id: Iac7ab83d60265f7d362c860776f1de9d5e444ec0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93268
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-05-03 09:21:51 +02:00
Noel Grandin 0115964362 make more classes private in mergedlibs mode 
Change-Id: I486922d0652f26fa7ee56f5fe308e19fe5ff137e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90856
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-03-23 12:05:36 +01:00
Andrea Gelmini 5bb1aa4dd7 Fix typo 
Change-Id: I77fc4fe10f08f3ad4eac6d2aebf546dcc709bcf9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88826
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2020-03-18 22:13:13 +01:00
Noel Grandin 12a8fa0d65 Revert "loplugin:constfields in ucbhelper" 
This reverts commit 64035391eb.

Change-Id: Icfde3e984f9ebf93a423d101aee385182f65dea5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90518
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-03-15 16:28:14 +01:00
Noel Grandin 6be9ae8aa1 inline some acquire/release calls 
because these are all on the hot path, and in the best case, with
enough inlining, the compiler can skip the call altogether and just
do a locked CMPXHG instruction

Change-Id: I099d6385f602e40e1767f9f1002b7514ecf436e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88775
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-02-17 08:59:01 +01:00
Noel Grandin d7b0b2b505 move some headers inside ucbhelper 
Change-Id: Iccd80aa4e631abe002837ca61248e136de9a62eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87866
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-02-04 06:21:41 +01:00
Mehmet Emin Başoğlu 3433036808 tdf#124176: Use pragma once instead of include guards 
Change-Id: I045ce53c74bfb24be77537986fb5a8fcad3ed173
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87401
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
 2020-01-26 20:10:59 +01:00
Noel Grandin f656547d4d remove some useless comment lines 
which merely announce that the next declaration is a class

Change-Id: Ifdb1398bcd99816b13e0b3769b46d0562bfbc1dc
Reviewed-on: https://gerrit.libreoffice.org/84229
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-12-03 12:46:27 +01:00
Noel Grandin 4b795d15cd loplugin:finalclasses in ucbhelper 
Change-Id: I52140333b274952d71afa13ba2d8edfcdf2b1425
Reviewed-on: https://gerrit.libreoffice.org/81767
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-31 07:02:41 +01:00
Noel Grandin cf1b5ae4c5 use cppu::WeakImplHelper in CommandProcessorInfo 
Change-Id: Ifbb2d50b1d88f0bceed38bddd23858a54b8527dc
Reviewed-on: https://gerrit.libreoffice.org/80403
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-08 14:23:08 +02:00