Julien Nabet
fe341d29d1
Fix typo in code: DELIMETER->DELIMITER in hwpfilter
...
Change-Id: I55f1ff646e065ae32ca3ff9a5c3c2fc9b9eae7db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211493
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Jenkins
2026-09-27 17:04:29 +02:00
Caolán McNamara
a019d1a06f
hwp: take the picture link target from inside the follow block
...
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Change-Id: Ifdd88a7949289d1f43e96eb4ecc05720e15d1f57
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/12752
Tested-by: Jenkins CPCI <releng@collaboraoffice.com >
Reviewed-by: Noel Grandin <noel.grandin@collabora.com >
(cherry picked from commit b47d2063f457d9c85e1b5bc9a76c47fad77de52c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211319
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org >
Tested-by: Jenkins
2026-09-22 22:01:26 +02:00
Andrea Gelmini
9d84af48a8
Fix typos
...
Change-Id: Ibfe0cacf5c01753b4920280624876f6c9d951e0d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210163
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2026-08-28 16:33:11 +02:00
Andrea Gelmini
6b53b650cd
Fix typos
...
Change-Id: I5dc0e6346374b1de7e748ce8b0efd84e22d015e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209936
Tested-by: Julien Nabet <serval2412@yahoo.fr >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2026-08-25 14:34:13 +02:00
Andrea Gelmini
93e4167640
Fix typos
...
Change-Id: I9ed001f746fb7717e3e48c34f41b42cb0539bd3e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209897
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Julien Nabet <serval2412@yahoo.fr >
2026-08-25 14:32:32 +02:00
Andrea Gelmini
82869b1d51
Fix typos
...
Change-Id: I08c6affc57806e8c36e8f188bc47b4cb61d6b794
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209938
Tested-by: Julien Nabet <serval2412@yahoo.fr >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2026-08-25 11:49:53 +02:00
Andrea Gelmini
08a814d780
Fix typos
...
Change-Id: I9ceb9a32f86c8fde3eb53533e3de8c0905973630
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209939
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Julien Nabet <serval2412@yahoo.fr >
2026-08-25 11:22:43 +02:00
Andrea Gelmini
4f134f4de1
Fix typos
...
Change-Id: I0c03b72585a5d54411f911fbb1fd47b59b7c1746
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209937
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Jenkins
2026-08-25 10:57:34 +02:00
ApurvR20
935a2f96a4
tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro
...
Additionally, change the comment to use std:size() as to not show up in
search.
Change-Id: Ibcb34e7423c439e6a6736c7a5333eab3a5351f60
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208153
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org >
Tested-by: Jenkins
2026-07-22 10:43:56 +02:00
JanayeJackson
ca26d67c9f
tdf#147021 Update SAL_N_ELEMENTS to std::size() in hbox.cxx
...
Change-Id: I1b7f888ae98fde05706c64e692def8b18af07a79
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205466
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org >
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org >
Tested-by: Jenkins
2026-05-22 18:35:27 +02:00
Jan Luethi
a10b0c9f0b
tdf#143148: Use pragma once instead of include guards
...
Change-Id: I68057118c8408ff5abf952ffad7fcf742032a181
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201728
Tested-by: Jenkins
Reviewed-by: David Gilbert <freedesktop@treblig.org >
2026-04-26 16:26:17 +02:00
Caolán McNamara
329b93b90a
fix std::unique_ptr conversion
...
an issue since:
commit 13ec3a1d80https://gerrit.collaboraoffice.com/c/core/+/720
Reviewed-by: Michael Stahl <michael.stahl@collabora.com >
Tested-by: Jenkins CPCI <releng@collaboraoffice.com >
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203580
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org >
2026-04-15 12:39:52 +02:00
Julien Nabet
d3685e6de0
Related tdf#171474: allocation-size-too-big in HWPStyle::Read()
...
Change-Id: I28e30f8aaa10b783bfebede933e2fe9931da1b0e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203235
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Jenkins
2026-04-05 13:48:04 +02:00
Caolán McNamara
5bd6ce333a
ofz#481418344 Timeout
...
Change-Id: I12d5cc145e3d2cf156d2b1d30b50d9d9d25a25e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200730
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2026-03-02 09:11:53 +01:00
Gabor Kelemen
0bdcfc2900
tdf#146619 Use more forward declarations in include/unotools/
...
This shaves off some 40M of input
Change-Id: I12e10deb87ceea1f7a23f3de4ea624befe187c3f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198238
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com >
Tested-by: Jenkins
2026-02-05 17:35:46 +01:00
Mike Kaganski
7f198b27f4
Drop class utl::MediaDescriptor, and use comphelper::SequenceAsHashMap
...
utl::MediaDescriptor was just a SequenceAsHashMap with a few added
methods. It made it more difficult to assign a SequenceAsHashMap to
MediaDescriptor, without real upsides. In many places, the class was
used not as media descriptor, but just as helper to create sequences.
This change puts the string constants and the former methods into a
namespace utl::MediaDescriptor.
It would be also good to drop comphelper::NamedValueCollection, which
is basically a twin of comphelper::SequenceAsHashMap (TODO).
Change-Id: Ia9b69c5a2ad153ecc654944c419c1880252ed86e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195163
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com >
2025-12-06 18:18:32 +01:00
Caolán McNamara
d4a39e1120
ofz#465488771 Integer-overflow
...
Change-Id: I1d10fc57e2a9a48d3aa65bd7c3592f5888ec09f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194943
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-12-03 11:11:41 +01:00
Mike Kaganski
fa0efd2899
Drop comphelper::newArray_null, and use new (std::nothrow) directly
...
That is clearer, and even shorter.
Change-Id: I293e588e91be0265a9898038318f3b0a99bc3767
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194738
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com >
2025-11-28 06:46:41 +01:00
Simon Chenery
fb5f892ef1
tdf#147021 avoid use of SAL_N_ELEMENTS macro in fontmap.cxx
...
Also replace for loop using FontMapTab with a range-based for loop.
Change-Id: I1a8f132a0a162636f805f1cd5c6bd0b95bb0a6ae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191927
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org >
Code-Style: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org >
2025-11-25 13:02:48 +01:00
Caolán McNamara
abf9bc2ea9
ofz#461057465 Integer-overflow
...
Change-Id: I6b3468997a127de1c1fcc927f0c2c21718984f10
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194071
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-11-16 18:46:31 +01:00
Julien Nabet
f83594ac18
Revert "[-Werror=stringop-truncation] with gcc 15"
...
This reverts commit e6870e7003https://gerrit.libreoffice.org/c/core/+/192970
Tested-by: Julien Nabet <serval2412@yahoo.fr >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2025-10-25 14:54:02 +02:00
Julien Nabet
e6870e7003
[-Werror=stringop-truncation] with gcc 15
...
Change-Id: I0dfaace18b0dc19ca1e2c6f11fcddb42e85ab761
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192969
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2025-10-25 14:44:06 +02:00
codemaestro
a91ce74ddc
tdf#163691: Use std::copy() instead of memcpy()
...
Change-Id: Ic1d849400c01276b8b9cf09d370f0aed635b71dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192606
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org >
2025-10-22 18:02:54 +02:00
Caolán McNamara
a9fe7eaa65
ofz#446998337 Timeout, paragraph parsing triggers self parse reenter
...
Change-Id: I4e1aab441a366c3987b6ab8003d98727f5b20fa8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192234
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-10-12 13:22:25 +02:00
Caolán McNamara
6fc58fb3a4
cid#1660346 Variable copied when it could be moved
...
and
cid#1660344 Variable copied when it could be moved
cid#1660343 Variable copied when it could be moved
cid#1660341 Variable copied when it could be moved
cid#1660339 Variable copied when it could be moved
cid#1660337 Variable copied when it could be moved
cid#1660335 Variable copied when it could be moved
cid#1660334 Variable copied when it could be moved
Change-Id: I3758a4228d5e848750b4ef37296b4d38b5d3e31c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188850
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-08-03 12:18:26 +02:00
Stephan Bergmann
0e44a3a894
Some bogus warnings still hit with recent GCC trunk
...
...towards GCC 16
Change-Id: I6d6acf7ba9373f94dfbd7aef6ad2ff44e1932791
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188461
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com >
2025-07-28 15:32:05 +02:00
Stephan Bergmann
294858f8ff
Some bugus warnings still hit with GCC 15
...
...at least with gcc-15.1.1-2.fc42.x86_64, when doing optimizing LO builds
Change-Id: I5df92c8503a88727d31f8e1920a2cd744d3ab790
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188258
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com >
2025-07-24 10:17:31 +02:00
Caolán McNamara
f6be328e0a
const up HWPDOFuncTbl
...
Change-Id: Iabc84aa1524d9fa2cce8bda389d004ece4a174b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188094
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-07-21 00:25:13 +02:00
Caolán McNamara
b80cd12449
const up some more pieces
...
Change-Id: Ib85b8b4b3a2d00e7ef0ecb354fba0b862d60abdd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187749
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-07-12 01:16:21 +02:00
Simon Chenery
7b9e27da20
tdf#147021 avoid use of SAL_N_ELEMENTS macro
...
Refactor getMathMLEntity() to use std::string_view
and OUString for string handling, so that there is less
string conversion when calling this function.
Use std::find_if to find formula in array instead of a loop.
Change-Id: I0ed98d33e62f6bc730ac750f4fd545d2f07145fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182065
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org >
2025-03-12 01:41:16 +01:00
Akshay Kumar Dubey
30ea093fd6
tdf#143148 Use pragma once instead of include guards
...
Change-Id: Ia1d2686020bdf8aae38f487e2468953cd0a389c7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180109
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org >
2025-01-11 19:36:53 +01:00
Akshay Kumar Dubey
c56556448a
tdf#143148 Use pragma once instead of include guards
...
Change-Id: I2dc10e68da2bd573615f7c36e6261d8db209bfc4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180050
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org >
Tested-by: Jenkins
2025-01-10 13:01:58 +01:00
Bogdan Buzea
d33b24d62f
tdf#152299 - Remove unused define(s) from C/C++ files
...
Change-Id: I9b27cfb715f6cd0a9b6ea21da9cb24fc8d8ec739
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177050
Tested-by: Julien Nabet <serval2412@yahoo.fr >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2024-11-23 15:18:31 +01:00
Noel Grandin
cf14352cd8
no need to heap allocate these
...
Change-Id: I28127f5943a80aca1689d5982cd1f6e6e11eb2c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175863
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2024-11-01 07:27:27 +01:00
folandidi
33ca469ee6
tdf#143148: Use pragma once instead of include guards
...
Change-Id: I798ffbdf9acd44ba45cebc0a5c41249fd53c49bf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175035
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org >
Tested-by: Jenkins
2024-10-22 14:06:42 +02:00
Xisco Fauli
9c4a485194
tdf#163486: PVS: redundant nullptr check
...
V668 There is no sense in testing the 'indxc' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error.
V668 There is no sense in testing the 'indxr' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error.
V668 There is no sense in testing the 'ipiv' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error.
Change-Id: Ifecd9ef5b831e5b312bb428e4d4f72c03cc29b7b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175106
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org >
Tested-by: Jenkins
2024-10-18 08:50:31 +02:00
Caolán McNamara
8950ecd071
an exit on a failed hwpfilter import is an atypical solution
...
Change-Id: Iefe31df20ca3e7e91175e00d1f15ff6c851ec536
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174659
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2024-10-08 13:15:50 +02:00
Caolán McNamara
698fd3fc03
cid#1632260 COPY_INSTEAD_OF_MOVE
...
Change-Id: Ia9012f78b5ea0acb29cfd50807b5ca09331261e6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174658
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2024-10-08 11:49:10 +02:00
Caolán McNamara
c30fa95c5d
cid#1607313 silence Overflowed return value
...
and
cid#1608099 Overflowed constant
Change-Id: I10e08c1184bb6630b849c3e24a0c9b26302fd18a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173896
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2024-09-25 15:37:40 +02:00
Caolán McNamara
c8b5ac2a54
cid#1607586 Overflowed return value
...
and
cid#1608074 Overflowed return value
cid#1607598 Overflowed return value
Change-Id: Ib884c10083c01578a7a0926d5f2f3c2d1f7501c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173833
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2024-09-24 13:27:26 +02:00
Noel Grandin
66cf208718
use more concrete UNO types in various
...
Change-Id: Ia28cffdeae8ced2e19dcf695ee5c3417d4f97d64
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173698
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2024-09-20 12:46:10 +02:00
Caolán McNamara
b6d8c6e6fe
cid#1607476 Overflowed return value
...
Change-Id: I38c72db66e47b0e09a53413457f167159c599202
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173524
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2024-09-17 15:16:29 +02:00
Caolán McNamara
a2634d526e
cid#1616925 Unintended sign extension
...
Change-Id: Ifdcd817fe8b10a8eee6a8fabf767fdc1b311f800
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172516
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2024-08-28 13:13:43 +02:00
Caolán McNamara
833d842e09
cid#1202814 Overflowed return value
...
Change-Id: I9f87efa1eabd3ed2bb4fdfcc66de405841d5fcc2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172308
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2024-08-23 13:01:09 +02:00
Caolán McNamara
fda349ab8e
ofz#69246 Integer-overflow
...
WTMM takes/returns a double anyway, so just promote earlier
Change-Id: I055fa7e7b155abfd15ef51335b34c2e6cfa8a209
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168043
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2024-05-26 15:41:47 +02:00
Noel Grandin
11c66ea0f4
loplugin:ostr in hwpfilter
...
Change-Id: If99a50251332e89e09ad97bb74178c4651cde44e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167377
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2024-05-09 13:29:23 +02:00
Caolán McNamara
3cc6384e41
WaE: C6011 Dereferencing NULL pointer warnings
...
Change-Id: Ibca9433761e7a7f97383991429cf0d575b4ba3d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167018
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2024-05-03 09:16:48 +02:00
Mike Kaganski
4695d84b78
Use more o3tl::convert
...
Change-Id: Ia525e051b53dd6082f2f11ff884677c8b8c6a20c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166051
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com >
2024-04-13 18:48:38 +02:00
Stephan Bergmann
6b7245f512
A number of bogus GCC 13 warnings still hit with recent GCC 14 trunk
...
Change-Id: I0ec7743cd79429591fcfc3eb9715ff36d06fc00b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165765
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de >
2024-04-04 07:06:17 +02:00
Stephan Bergmann
9adcf67c9b
Drop C/C++ DEBUG macro
...
...(that was defined iff OSL_DEBUG_LEVEL >= 2) and replace its uses with
OSL_DEBUG_LEVEL directly
Change-Id: I807c15a02cc8ced9852287df0afb4808761d19d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165067
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de >
2024-03-21 16:30:59 +01:00
Julien Nabet