33 Commits
Author SHA1 Message Date
ApurvR20 8ceb3ebcc6 tdf#74702 Replace instance of OUTDEV_WINDOW in ndole
Change-Id: I9d4a9ebf886614be3e446678b08aa915caa75d86
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211895
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
2026-10-07 09:42:01 +02:00
ApurvR20 df52af4eea tdf#90341 Use std::span to clean up excessive const_cast
Changed implementation in EnhancedCustomShapeGeometry from pointer to
std::span, leading to removal of const_cast.

Change-Id: Ic2d768202991eba674275aa4ffe78478f8f6dd27
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210515
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
2026-09-29 10:15:59 +02:00
ApurvR20 c8e8114c11 tdf#170667 Add space after DrawObject string in sw
Change-Id: I77d367ef7f836ddf10fdbf65a319493dc453a7e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211483
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2026-09-27 10:56:21 +02:00
ApurvR20 f894152072 tdf#155630 De-duplicate code
Found the duplicated code by PMD analyser.

Change-Id: I5c9858cca37c65fdedca109fa0f26be2baaf87a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210482
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
2026-09-26 15:27:46 +02:00
ApurvR20 2a64f606b5 tdf#140226 Use StaticWhichCast
Change-Id: I551d97a7d0c18bc2778cd4374d9be2543fc47af8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210684
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
2026-09-26 09:20:30 +02:00
ApurvR20 1bbdd21a9d tdf#164490 Use stronger typed SwClient
Change-Id: I5a0104038656ad037feab3b2bb7c939afdb62a9c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211229
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
2026-09-24 23:27:29 +02:00
ApurvR20 d1473c1738 tdf#146150 Update test to use dispatch command instead of numerical ID
Change-Id: Ib160576a2a8167cd1cc2cc619b7dd1cbed994a1e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211033
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
2026-09-24 22:18:05 +02:00
ApurvR20 f4ce2515f8 tdf#153109 Replace ranged loop by ranges::any_of
Change-Id: I3223b8d86cde66070342602606de71170cacbe64
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210519
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2026-09-07 07:31:09 +02:00
ApurvR20 2003620e38 tdf#145759 Replace 1.414214 with M_SQRT2
Change-Id: Ieb478c27c5709b4a170eef3ab77dda6964bbee40
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210391
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2026-09-02 10:59:41 +02:00
ApurvR20 4a5e024882 tdf#157665 Implement three-way operator in contentindex.hxx
Change-Id: Id7a4ca3ff7d5d3bcd1e54758a80f7eb5385e3f50
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210321
Reviewed-by: Hossein <hossein@libreoffice.org>
Tested-by: Jenkins
2026-09-02 09:26:47 +02:00
ApurvR20 768fbeab30 tdf#170685 Removed noisy instances of Scaddress in opencl-test-1
Used sed utility to remove the relevant instances.
All instances were of format GetValue(ScAddress(a,b,c)).

Change-Id: Id0905e2c87e5df5ff1a7bfbb19ef75ba6b82c138
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210120
Reviewed-by: Hossein <hossein@libreoffice.org>
Tested-by: Jenkins
2026-08-28 23:02:37 +02:00
ApurvR20 79d1e583fb tdf#173254 Removed 'using namespace' in lokclipboard
Change-Id: I490f84aa8a4e33600ff3c03e213c5ed5321fedd2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210117
Reviewed-by: Hossein <hossein@libreoffice.org>
Tested-by: Jenkins
2026-08-27 13:33:57 +02:00
ApurvR20 9d4d2c85fa tdf#42982 Improve UNO API error reporting
Provide a descriptive error in RuntimeException in instancelocker.cxx

Change-Id: I7b0579a51fa0f0423df43dadd1aa0a010ac1f420
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209481
Reviewed-by: Hossein <hossein@libreoffice.org>
Tested-by: Jenkins
2026-08-27 13:33:16 +02:00
ApurvR20 2c5bbfa3e6 tdf#145614 Convert #define to enum class and o3tl::typed_flags
Converted #define to enum class and o3tl::typed_flags to handle bitwise
operations in the code.

Added a zero flag to PortionAttribute as previous implementation was
comparing with integer value of zero.

Change-Id: I5dc1b06c4c5cb7d59f3dcf9e8b86561280974ef6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208879
Reviewed-by: Hossein <hossein@libreoffice.org>
Tested-by: Jenkins
2026-08-26 23:26:13 +02:00
ApurvR20 20f8db461b tdf#169155 Use o3tl::enumarray to simplify data arrays
Replaced #define by enum classes in syslocaleoptions.cxx

Change-Id: Ie7dc9b514a037e4c4ae7c4ae8e59fe5809786de9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209507
Reviewed-by: Hossein <hossein@libreoffice.org>
Tested-by: Jenkins
2026-08-26 07:44:43 +02:00
ApurvR20 5cfac95032 tdf#153294 Use erase_if to simplify loops in viscrs.cxx
Change-Id: I992ccec4487aff99e97ae6f2211852b11615741a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209002
Reviewed-by: Hossein <hossein@libreoffice.org>
Tested-by: Jenkins
2026-08-24 09:58:55 +02:00
ApurvR20 03fe896604 tdf#170269 Use C++20 ranges any_of instead of looping over a range
Change-Id: I3bbc07605e4f00c845d37152cbb0286279994880
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209001
Reviewed-by: Hossein <hossein@libreoffice.org>
Tested-by: Jenkins
2026-08-24 09:25:11 +02:00
ApurvR20 510f4c48a5 tdf#170270 Replace copy_if by ranges::copy_if
Change-Id: Ifed54b1b00c25b4a74ae8c4b71b0f746ea8a1e1e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209535
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2026-08-23 15:09:34 +02:00
ApurvR20 43954c426c tdf#168520 Rename testTdf118150 to testTdf118150ChartWidthXlsx
Change-Id: I61ad9daac20fbc1570b1c7bc8fc899309eb14d02
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209463
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
2026-08-21 20:41:16 +02:00
ApurvR20 ccba2e008f tdf#171853 Replace lastIndexOf by endsWith in pkgcontent.cxx
Change-Id: I9b1e840af20b80a946b7a79f141e505cc7aa4838
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209441
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2026-08-21 12:21:07 +02:00
ApurvR20 301ff1c0e1 tdf#158237 Use C++20 contains() instead of find() and end()
Change-Id: Ie7c127cf0e762bebf48e208114981afefe8f287f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209280
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2026-08-19 11:31:47 +02:00
ApurvR20 bfb4eff4ea tdf#114441 Replace sal_uLong by size_t in doccomp.cxx
GetLineCount() returns size_t, so change the data type for relevant
variables. Also change the max values for preceding and other_preceding,
from ULONG_MAX to SIZE_MAX.

Change-Id: I973ce68808dd77efb7326d4177499d0fe1e5d764
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208745
Reviewed-by: Hossein <hossein@libreoffice.org>
Tested-by: Jenkins
2026-08-16 00:40:22 +02:00
ApurvR20 56c50b7817 tdf#158068 Replaced string literals by custom O(U)StringLiterals
Change-Id: Ib5d5fb41e4b8efabf2e019a51b3ae40d5abde1ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209054
Reviewed-by: Hossein <hossein@libreoffice.org>
Tested-by: Jenkins
2026-08-11 11:30:50 +02:00
ApurvR20 084633bb66 tdf#146619 Remove unused #includes from sw/source/core/doc
Removed or replaced unused includes found by include-what-you-use (IWYU)

Change-Id: Ibf4e969c140341e807dfc33a9ddee1ad8a49683a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208974
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
2026-08-11 11:26:15 +02:00
ApurvR20 097919db22 tdf#154285 Check argument count in SbRtl_Fix
Change-Id: I0b067eb0e90f3824cafc7df22eefd30ac6d0bef4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209005
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2026-08-11 08:39:53 +02:00
ApurvR20 073aa89187 tdf#158067 Replace OUStringLiteral by OuString u".."_ustr
Change-Id: Ie727aba87b32ca33eeca9aa3807a2383dbffe5f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209050
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2026-08-11 08:37:57 +02:00
ApurvR20 7566e557de tdf#157664 Drop operator !=, where respective operator == is defined
Removed definition and implementation of operator != from pam.hxx
and pam.cxx

Change-Id: If0aee1b3b7f5f8f9aa6ec568c90e2f13a3dd09d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209017
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
2026-08-10 14:55:11 +02:00
ApurvR20 4ecf6da064 tdf#146479 Use basegfx fTools for converting the angle unit
Change-Id: I281042d10fc6464d6245494a6bd00b473e57e297
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208923
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2026-08-03 11:32:28 +02:00
ApurvR20 855b66846b tdf#163738 : use insert function instead of for loop
Change-Id: Id107b224c7182e3706f5265e91a1c35d956d9848
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208284
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
2026-07-23 11:11:56 +02:00
ApurvR20 935a2f96a4 tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro
Additionally, change the comment to use std:size() as to not show up in
search.

Change-Id: Ibcb34e7423c439e6a6736c7a5333eab3a5351f60
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208153
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
2026-07-22 10:43:56 +02:00
ApurvR20 5571e8981d tdf#145538 : Use range based for loop in vbacontentcontrollistentry.cxx
Replace traditional style loop with range based loop

Change-Id: I98062781e4301c274ca9d16be18a0c08bf11e322
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208132
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2026-07-20 10:20:17 +02:00
ApurvR20 54b3494de7 tdf#147132 : Flatten Basic function implementations
Flatten implementation of SbRtl_Weekday in basic/source/runtime/methods1.cxx.

Change-Id: I17931cfecc24be9c114daa9c6c221e6c00a4e3aa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208256
Tested-by: Jenkins
Reviewed-by: Neil Roberts <nroberts@libreoffice.org>
2026-07-20 09:38:38 +02:00
ApurvR20 3ee90bca13 tdf#143148: Use pragma once instead of include guards
Change-Id: If630c4e4c66cebb05751bd857ec948fc6f2a5a6c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208035
Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>
Tested-by: Jenkins
2026-07-14 13:34:07 +02:00