Commit the results of running
for a in `git ls-files "*.ui"`; do bin/ui-rules-enforcer.py $a; done
Change-Id: I7a97f75773b9e5750dcce848d730960a8561916b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211850
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
In the same way that
Change-Id: I188f812f2d03fa8cbd97ffaaab3081094809887e
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Thu Oct 1 10:29:15 2026 +0200
chart2: Port "Chart Type" dialog from ValueSet to weld::IconView
had done for the "Chart Type" dialog, also port the chart
sidebar from using the custom ValueSet widget to weld::IconView.
This helps to be more consistent with other platform/toolkit
widgets and reduces custom logic.
It can be triggered like this:
* start Writer
* insert a chart using "Insert" -> "Chart..."
* while the chart is still selected, open the "Properties"
sidebar deck
Change-Id: I858dda4b9d5bf62291ee3b0c76b13ee92221f9e6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211660
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Switch the order in which the widgets in the .ui file
are defined so that the order better matches the visual appearance
and logical order, which makes sure that tab focus order with the
Qt-based VCL plugins is correct as well when using native Qt
widgets (SAL_VCL_QT_USE_WELDED_WIDGETS=1), where
focus order is (by default) based on widget creation order.
See
commit 02692566ad
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Thu Oct 24 17:43:35 2024 +0200
tdf#130857 optnewdictionarydialog.ui: Define focusable widgets in order
for more background.
The dialog can e.g. be triggered like this:
* start Writer
* insert a chart using "Insert" -> "Chart..."
* right-click on one of the bars in the chart to open
the context menu
* activate the "Chart Type..." menu item
The Python script mentioned in the commit message of
commit 327679b2fb
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Wed Jul 8 15:50:59 2026 +0200
tdf#130857 Define widgets in Calc "General" options page in order
was used to reorder the GtkGrid children automatically.
Change-Id: Iafe15ceba9e7c8b7651114e538b9ca20915c2367
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211659
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Port the widget to select the chart subtype in the "Chart Type"
dialog from using a ValueSet widget to using weld::IconView.
This helps to be more consistent with other platform/toolkit
widgets and reduces custom logic.
Adjust indices used to account for the fact that
weld::IconView indices are 0-based while the ValueSet ones
are 1-based.
The dialog can be triggered like this:
* start Writer
* insert a chart using "Insert" -> "Chart..."
* right-click on one of the bars in the chart to open
the context menu
* activate the "Chart Type..." menu item
The chart sidebar (ChartTypePanel) will also be ported
in an upcoming commit.
Change-Id: I188f812f2d03fa8cbd97ffaaab3081094809887e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211658
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
If the selected range is too small when Insert->Chart is used then most
of the controls in the “Data Series” tab are disabled. Additionally,
nothing was updating the “Range for %VALUETYPE” label defined in the UI
file so it would be left with this stub visible in the UI. This patch
makes the default label instead just be “Range”. The previous string is
now defined in strings.hrc instead of reading from the label value when
creating the dialog so that it can be updated when a valid range is
selected.
Change-Id: Ib926383825f32042dc0c6d33a115d139a50c5aa6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211102
Tested-by: Jenkins
Reviewed-by: Neil Roberts <nroberts@libreoffice.org>
Qt plugin automatically orders buttons for each platform based on
the button's role, which we derive from the Gtk .ui file's
action-widget response code. But to do that conversion from response
code to Qt button role, we need a standard response.
Without a standard response, the button has no role, and gets ordered
to the right of OK/Cancel buttons on Mac. With the correct role, it
is correctly placed far-left along with the Help button.
Change-Id: I16d3126d4999649e7aa6e72ec5e7b1a25f48c2a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210223
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Reviewed-by: Dan Williams <dcbw@libreoffice.org>
Tested-by: Jenkins
A correlation circle plot reads the ends of its range differently from every
other chart type: the last two columns are the dimensions its points are placed
against and the columns before them are the features. One range holds the lot,
so nothing about the entry gives that away, and a reader who does not already
know it has no way to work it out.
Display a information label under the range input saying the last two
columns of it are component dimensions and the columns before that are
features.
Change-Id: Ib7d27aad189f12be188f61b1fc317dd1e718b803
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/8105
Tested-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.com>
Reviewed-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.com>
(cherry picked from commit 2cbf62e18df956ed23c77932cd5e38424e7baa1f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210470
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
The word “outline” in LibreOffice can refer to either the lines of the
shape of something or an overview of something. When the string is quite
short it’s difficult for translators to know which meaning is intended.
There seems to be quite a lot of cases where the translators have got
this wrong. In order to help them this patch adds translator comments to
a bunch of the strings to explain which meaning should be used.
Change-Id: I4b75cc829128633bc9382817fc574d55a09af8a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209037
Tested-by: Jenkins
Reviewed-by: Neil Roberts <nroberts@libreoffice.org>
The dialog can be triggered like this:
* start Calc
* "Insert" -> "Chart..."
* for "Choose a Chart Type", choose "Line"
* for "Line type", select "Stepped"
* press the "Properties..." button
Change-Id: I0bbef11445f7cf184e46b955dd32fcd8fbb474f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208548
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Set the mnemonic widget, which e.g. makes the Orca screen
reader announce what the combo box is about ("Line Type")
when it receives focus with the gtk3 or qt6 vcl plugins on Linux.
For qt6 and the use of native Qt widgets
(SAL_VCL_QT_USE_WELDED_WIDGETS=1) this also fixes
that the labels text was previously shown as a literal
"Line &Type".
Change-Id: I2e699a10bdec27663b38a92d4091e647a6b7c49e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208497
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
The dialog can be triggered like this:
* start Calc
* "Insert" -> "Chart..."
* for "Choose a Chart Type", choose "Line"
* for "Line type", select "Smooth"
* press the "Properties..." button
Change-Id: I4bad77d57fb6f33dea653ad48f6dd0e32a8085c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208495
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This is used for the "Data Series" tab page of the
the dialog that can be triggered like this:
* start Calc
* "Insert" -> "Chart"
* confirm with "Finish"
* with chart still selected, press the context menu key
(or click with right mouse button) to open the context menu
* select the "Data Ranges..." context menu entry
Change-Id: I15ebfe1eac3a83f5e0a2ee03d0548c8bc0e499f0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208487
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This is used for the "Data Range" tab page of the
the dialog that can be triggered like this:
* start Calc
* "Insert" -> "Chart"
* confirm with "Finish"
* with chart still selected, press the context menu key
(or click with right mouse button) to open the context menu
* select the "Data Ranges..." context menu entry
Change-Id: Ia5f78fdf141eeb0e35cfe5dab990d73e991fe885
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208486
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
The dialog can be triggered like this:
* start Calc
* "Insert" -> "Chart"
* confirm with "Finish"
* with chart still selected, press the context menu key
(or click with right mouse button) to open the context menu
* select the "Data Ranges..." context menu entry
Change-Id: I339bbd6d64344eeb33449fc829f06fe9041e0282
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208485
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This UI file is used for the "Alignment" tab
of the chart dialog for the X/Y Axis title that can be
triggered like this:
* start Writer
* "Insert" -> "Chart"
* right-click underneath the legend to open context menu
* select the "Insert Titles..." context menu entry
* type "TITLE" for the "X axis" field and confirm with OK
* select the new "TITLE" title of the X axis
* right-click on it to open the context menu
* select the "Format Title..." context menu entry
to trigger the "X Axis Title" dialog
Change-Id: I92826df1c9f2e719ff147a09ae2d3d005e9529ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/204218
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This UI file is used for the "Label" tab
of the chart dialog for the X/Y Axis that can be
triggered like this:
* start Writer
* "Insert" -> "Chart"
* double-click on the Y axis to open the "Y Axis" dialog
Change-Id: I7e563c0163d946ebecd059db4ff6b2a0fbc6abb8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/204216
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This UI file is used for the "Scale" tab
of the chart dialog for the X/Y Axis that can be
triggered like this:
* start Writer
* "Insert" -> "Chart"
* double-click on the Y axis to open the "Y Axis" dialog
Change-Id: I2c3f538aea3b3d94e2079952e80a32803cc6e0e6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/204215
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
This UI file is used for the "Positioning" tab
of the chart dialog for the X/Y Axis that can be
triggered like this:
* start Writer
* "Insert" -> "Chart"
* double-click on the Y axis to open the "Y Axis" dialog
Change-Id: I77e466e454d8fe74f04af32723795aa54d44a5cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/204214
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
This UI file is used for the "Position" tab page
in the chart "Legend" dialog that can be triggered
like this:
* start Writer
* "Insert" -> "Chart"
* double-click on the legend to open the "Legend" dialog
Change-Id: Iba5aa5d09cda6bc318cbb5627a9074dba7ad5729
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/204212
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Instead of hard-coding a size based on the icon size
for the icon views in ChartColorPalettes, rather let
the toolkit allocate a proper size.
Tweak some properties in the .ui file to achieve
proper auto-sizing.
Maybe, hard-coding the size was done because before
commit 478b712ea1
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Thu Aug 7 09:45:15 2025 +0200
tdf#167658 vcl: Honor GtkIconView::columns + calc size
, the vcl implementation didn't take the column count
set in the .ui file into account when the original
code was was introduced in
commit a26c93a630
Date: Sun Aug 10 22:33:37 2025 +0200
chart color palettes: switch from drawingarea to IconView
.
In any case, it seems unnecessary now, and not hard-coding
the size e.g. results in all rows being visible at once
when using the gen vcl plugin for the following dialog,
instead of showing only part of them and using a scrollbar
despite there being plenty of space below the icon view.
Steps to trigger a dialog using this:
* start Writer
* "Insert" -> "Chart"
* double-click on a bar in the chart to open the
"Data Series" dialog.
* switch to the "Color Palette" tab
Now, all rows are shown at once for both, the gtk3
and the gen vcl plugins.
The code is also used in the chart palette popup
that can be triggered like this (and whose .ui
file is also tweaked in this commit a bit):
* start Writer
* "Insert" -> "Chart"
* click on a bar in the chart
* switch to the "Properties" sidebar deck
* in the "Colors" section, click on the arrow
of the button to open the popup
This commit also prepares for supporting the
dialog mentioned above with native Qt widgets
in an upcoming commit.
Change-Id: Ibf1cb597bc93f29033ab76432ca08af0b029cc0d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/204209
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
The below patch added `sidebargradients.ui` and it seems like this
file was based off `sidebarcellappearance.ui` as some widgets had
the exact same contexts as in `sidebarcellappearance.ui`. This broke
the builds due to duplication of `msgctxt` in the `.pot` translation
files.
https://gerrit.libreoffice.org/c/core/+/192043
I90b4f5368a552eb9ba399337a39e79455ea99fe6
Change-Id: I0f8e24aa52a2a77b87b2b685d22d7474736927af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200053
Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
Tested-by: Jenkins
However, manually remove automatically inserted
<property name="can-focus">False</property>
for some GtkToolButton objects, to avoid potentially
unwanted side effects.
The dialog can be triggered like this:
* start Writer
* "Insert" -> "Chart"
* "View" -> "Data Table..."
Change-Id: I141c52522802068657c751ebed0b782a3f2efa4b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199132
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Switch the order in which the widgets in the .ui file
are defined so that the order better matches the visual appearance
and logical order, which makes sure that tab focus order with the
Qt-based VCL plugins is correct as well when using native Qt
widgets (SAL_VCL_QT_USE_WELDED_WIDGETS=1), where
focus order is (by default) based on widget creation order.
See
commit 02692566ad
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Thu Oct 24 17:43:35 2024 +0200
tdf#130857 optnewdictionarydialog.ui: Define focusable widgets in order
for more background.
The dialog can be triggered like this:
* start Writer
* "Insert" -> "Chart"
* "Insert" -> "Data Labels..."
Change-Id: Iebcfd35ed75719831cad445d25c9dbebc1a7fb4e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199129
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
The dialog can be triggered like this:
* start Writer
* "Insert" -> "Chart"
* right-click on the background of the chart and select
the "Insert Titles" context menu entry
Change-Id: I58a686bd3cd1de3ba37b82f2ed3db493ee849649
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197463
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
The dialog can be triggered as follows:
* start Writer
* "Insert" -> "Chart"
* right-click on one of the bars in the bar chart
and select the "Chart Type" context entry
Change-Id: I88cf741808cf21a69554bed7652ee135b0e604f8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197461
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Introduce a new UNO command, ".uno:ExtensionManager",
which is used to open the "Extensions" dialog from the
menu, notebookbar and using the keyboard shortcut
(Ctrl+Alt+E) instead of specifying the service name
"service:com.sun.star.deployment.ui.PackageManagerDialog"
in their configuration directly.
In a first step, handle the new UNO command in
SfxApplication::MiscExec_Impl by creating an
instance of the service by its name and executing the dialog
using the css::task::XJobExecutor interface without any
additional changes.
This matches what the previous way of triggering
the dialog would have done, i.e. no user-observable
behavior is intended yet.
This prepares for further changes in upcoming
commits, in particular passing a parent for
the dialog.
As documented in icon-themes/README.md, make sure to
have icons with the expected names, which is e.g.
used in the "Tabbed Compact" UI variant of the Notebookbar.
(Link to the already existing icons.)
Change-Id: I4b381b5f0b7cddd9f0aa9abd9b88c1c4364ab824
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193580
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
... in line with previous commit
Change-Id: Ib2b0d83b1a40b121660ffe04baf3eeb0bebe0da1
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Wed Nov 5 17:44:57 2025 +0100
gtk3: Require GTK >= 3.24
that makes it a requirement in code.
Change-Id: Ib2b9e6da2a834b0d9ddddd6b8a64142b8b5de153
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193478
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Avoids the console noise and the overhead associated with needless
image loading attempts.
There are some menu items added from code, that are not handled by
the patch: e.g., .uno:ToolbarLock.
Change-Id: If94cad97207e46125083c56882c284e0993f43f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192638
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
... for chart color palette popup.
Set the GtkLabel's "mnemonic-widget" instead of manually
setting the a11y label-for and labelled-by relations.
Setting the mnemonic widget results in the a11y relations
getting set as well, so there is no need to do that
manually, and setting the mnemonic widget also
allows moving the focus to the widget by using the
corresponding keyboard shortcut
Sample steps to trigger this color palette popup:
* start Writer
* click the "Insert Chart" toolbar item to insert
a chart
* click on a bar in the chart
* open the sidebar and switch to the "Properties" deck
* click the button in the "Colors" section
Change-Id: Ic09da1c203d7e4bbee9cc99675943481723e2394
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190370
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
commit a26c93a630
Date: Sun Aug 10 22:33:37 2025 +0200
chart color palettes: switch from drawingarea to IconView
had switched to using weld::IconView for the color
palettes and introduced explicitly setting the label-for
and labelled-by accessible relations for the GtkFrame's
internal label child and the GtkIconView.
However, since the text of the GtkFrame's label is already
used as the accessible name for the frame and that one is the
parent "panel" of the IconView, screen readers already announce
the accessible name of the parent when the IconView receives
focus.
For gtk3, this would result in the label text/accessible name
getting announced twice now, e.g. "Colorful Colorful, list with
N items".
Similarly, NVDA on Windows would say "Colorful option pane, Colorful
list".
Stop explicitly setting the a11y relations to have it announced
only once.
An alternative solution could be to stop using a GtkFrame and
using a simple GtkLabel, then setting the GtkIconView as its
mnemonic widget.
Sample steps to see the corresponding dialog page:
* start Writer
* click the "Insert Chart" toolbar item to insert
a chart
* double-click on a bar in the chart
* switch to the "Color Palette" tab page
Change-Id: If3a2beac193f05e13cc0fb1b30d6d0486c8433e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190369
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Fix the chart type dialog and chart sidebar .ui files so that the
'number of lines' entry for columns-and-lines is not overlapping with the
'composite size' entry for of-pie (which doesn't cause a problem with gtk,
but does cause a problem with vcl=gen).
Change-Id: I90db47623b9b5699457e814c914690dc1e7f4bf4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187885
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
The dialog can be triggered from Writer as follows:
* "Insert" -> "Chart"
* Hover over the X Axis until an "X Axis" tooltip appears
* double-click
Change-Id: Iaabca9238dd5009a7134f2561f7f47a099ab2db0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187860
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Michael Weghorn