The `Tools > Options > Calc > Calculate` dialog tab page had a lot
of controls on the left half and very few on the right. This looked
unbalanced, since a lot of empty space was left on the right half.
Moving 'Iterative References' frame to the right side fixes this as
it covers quite a lot of that empty space making both halves less
unbalanced.
Change-Id: I98d484f71553cbdb5448ec13125329b4ce396871
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198331
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Most of the work is done in two helper functions MarkCheckedMembers
and UpdateVisibleMembers. The first one goes over all the visible
members in the autofilter dropdown and marks them in the internal
representation maMembers. Then the second one updates the visible
members in the dropdown based on user action i.e. search, or lock
check/uncheck.
Change-Id: I0f96eb2cfadf0934c6319ec6a239346a8d5483bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201098
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
When the search string doesn't match any entry in the autofilter,
nothing is shown, but as the user presses backspace one character at a
time, at some point the search string matches some entries. But if those
entries are dates, they are shown as disabled, which is a bug.
Change-Id: I78efae6c8c312072c155757d596a0dce25dd9cb2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201585
Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
Tested-by: Jenkins
This is for consistency. `SearchEditTimeoutHdl` also calls this
function and it passes the search text in lowercase, whereas
`LockCheckedHdl` passes the text as is depending on the internal
`.lowercase(...)` call. Since we only need the lowercase version of
the search text, we might as well make it consistent.
Change-Id: I84d165747bc9a91c5f7b75ef48509a1f9b2d5982
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201096
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
We have an iterator over the checked entries, MarkCheckedMembers maps
the visible & checked entries to maMembers (the internal vector of
members).
Change-Id: Ic5d882d8f65b886a9c8b81c1e53b7817383dfbf6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201095
Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
Tested-by: Jenkins
This is part of the fix, the reason why it exists as a separate commit
is to make it easy to review. This patch only moves code by one
indentation level & having it with the "fix" would make the "fix" hard
to review.
Change-Id: I62338c41f4a056157d071cb5b3b7f3ba00deb46b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201094
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
JSWidget::set_buildable_name isn't handled on the online side, it has
an assert(false) which is reached because of changes introduced in
commit f04247351a
Change-Id: Ie4942d0f38e2c8bbb784b0f7132f3c6da0d89bc6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200610
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
The below patch added `sidebargradients.ui` and it seems like this
file was based off `sidebarcellappearance.ui` as some widgets had
the exact same contexts as in `sidebarcellappearance.ui`. This broke
the builds due to duplication of `msgctxt` in the `.pot` translation
files.
https://gerrit.libreoffice.org/c/core/+/192043
I90b4f5368a552eb9ba399337a39e79455ea99fe6
Change-Id: I0f8e24aa52a2a77b87b2b685d22d7474736927af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200053
Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
Tested-by: Jenkins
UI Theming are disabled by default so when the user enables it in the
Appearance dialog, we need to call `ColorConfig_Impl::SetupTheme()`
using an `EditableColorConfig` wrapper because `SetupTheme` loads the
colors from the registry into the static `ThemeColors` object which
is then used to query the newly loaded colors in various parts of the
application (where the widget drawing happens).
This automatically happens when the user presses on `Apply` as that
calls `SvxAppearanceTabPage::Reset` which creates a new instance of
`EditableColorConfig` which indirectly calls `SetupTheme`.
But when the user presses `Ok` directly, `SvxAppearanceTabPage::Reset`
isn't called, thus the restart dialog shows up with unreadable
buttons as the color of the buttons changed (because of how color
loading is implemented) but the button text being the same as the
last theme (because `SetupTheme` wasn't called). Therefore we call
`SetupTheme` to make sure that this case doesn't happen.
Change-Id: I3939d5ccca36905e3416b10b55c6e7be09efe7e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197700
Tested-by: Jenkins
Reviewed-by: Sahil Gautam <sahil.gautam@collabora.com>
`mbMarked` is enough to determine which autofilter entries
are checked and should be locked when lock is toggled.
Change-Id: I1c85e07d69340a131a9e3b7d31def29aa6c6daaa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195063
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
autofilter represents multiple instances of an entry as a single entry
in the filter popup for obvious reasons, so we need not loop over all
the entries to find other instances of the current entry.
Change-Id: I72b2c7bd141615ac0c50927dfa7784f9b569e9ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195060
Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
Tested-by: Jenkins
14396a5361 extended
.uno:OpenHyperlinkOnCursor to open all the hyperlinks in the current
cell if not in edit mode (to make hyperlinks keyboard accessible), but
i forgot to add `SID_OPEN_HYPERLINK` entry to `ScDocShell::GetState()`
which caused this bug.
now we check for both the cases if the cell has hyperlink(s) or not
and disable the slot if it doesn't so that we don't re-run the logic
in the execute function unneccessary.
Change-Id: I378996d776903ab53d6370d19ace9d3c730f3e85
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188620
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@collabora.com>
buttons such as duplicate slides and insert new slide belong to the
insert tab and the layout dropdown button belogs to the layout tab. this
patch doesn't add back layout dropdown button as the sidebar already
provides that functionality and we plan to later add preview dropdowns
for such controls.
Change-Id: Idef33133e2699bbfd913e303a4d92591f5a22c16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187369
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Sahil Gautam <sahil.gautam@collabora.com>
Reviewed-by: Sahil Gautam <sahil.gautam@collabora.com>
Sahil Gautam