ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
520,958 Commits 3 Branches 3 Tags
main
Commit Graph
83 Commits
Author SHA1 Message Date
Andrea Gelmini 7ec662d6e2 Fix typos 
Change-Id: Ib1b4ee06e762b4cc4a7240b4ead79be2f70b6233

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209776
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2026-08-24 09:17:48 +02:00
Noel Grandin deb736a4f3 no need to use Sequence here 
Change-Id: I88b24d4703d6a1dcbe6a90936a01eb9f893e386a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184118
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-04-13 17:11:51 +02:00
Noel Grandin 76d296f760 fold ChartModelHelper functions into ChartModel 
This moves functions from ChartModelHelper to ChartModel
where it better belongs to. We can access the concrete classes now
instead of accessing through UNO si this is possible to do.

Change-Id: I21dce8aabe8f8a956863beef7ca5cb4ec6f3b44b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183990
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-04-11 07:07:23 +02:00
Noel Grandin d0fe2b9cf9 use more concrete UNO types in some local vars 
found by a clang plugin I created.

Change-Id: I72ebc2b6fadb854a12d69a543facf2fd7e4f1e8c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181932
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-02-20 14:03:28 +01:00
Noel Grandin 1de066d04f loplugin:ostr in chart2 
Change-Id: I2985b6793a776639214a25bf9732c000b9026bfc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167236
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2024-05-07 08:46:21 +02:00
Rafał Dobrakowski 102622a07d tdf#146619 Remove unused #includes from C/C++ files 
'chart2' module was cleaned.

Change-Id: Ib4cdb3c8a21d0ed47f4970894d416327df5e68a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164864
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
 2024-03-27 09:20:54 +01:00
Noel Grandin 6d4917db0e expand out ChartModelHelper::findDiagram 
since it just calls findFirstChartDiagram

Change-Id: I21eb9a747127ad54f3b5875074a7bf7ffbf79e4d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149681
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-03-29 09:56:07 +00:00
Noel Grandin fd299d209d move getDataSeries inside chart2::Diagram 
Change-Id: Ie60d288dba9c8d006de03c80d3cfc7bf8f108782
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149085
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-03-19 12:55:30 +00:00
Noel Grandin 183c3d58fb move getCategories/setCategories inside chart2::Diagram 
Change-Id: I7c6b4e92bb131cc3c6b5b4eedb3304128b8bd988
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149082
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-03-18 13:30:03 +00:00
Stephan Bergmann 91ba9654ba Move tools/diagnose_ex.h to comphelper/diagnose_ex.hxx 
...so that its TOOLS_WARN_EXCEPTION can be used in
comphelper/source/misc/logging.cxx in a follow-up commit.  (And while at it,
rename from diangose_ex.h to the more appropriate diagnose_ex.hxx.  The
comphelper module is sufficiently low-level for this immediate use case, so use
that at least for now; o3tl might be even more suitable but doesn't have a
Library until now.  Also, for the immediate use case it would have sufficed to
only break DbgGetCaughtException, exceptionToString, TOOLS_WARN_EXCEPTION,
TOOLS_WARN_EXCEPTION_IF, and TOOLS_INFO_EXCEPTION out of
include/tools/diagnose_ex.h into an additional new
include/comphelper/diagnose_ex.hxx, but its probably easier overall to just move
the complete include file as is.)

Change-Id: I9f3222d4ccf1a9ac29d7eb9ba1530d53e2affaee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138451
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-08-18 17:10:19 +02:00
Gabor Kelemen fef939d8ff Recheck module chart2 with IWYU 
See tdf#42949 for motivation

Change-Id: Id4cdca3eed8618c289f30913d506f8f2bd46f0bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133112
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
 2022-04-23 16:33:58 +02:00
Noel Grandin 2cbf83e208 loplugin:unusedmethods 
Change-Id: I58c60262ca543bafb4db4433dbb98b195f7571ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130063
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-17 14:51:23 +01:00
Noel Grandin 6e800111d6 use more concrete types in chart2, DataSource 
Change-Id: I513491e8d39ee79edf8521d279bd32031cf22a93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129687
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-09 07:32:09 +01:00
Noel Grandin b314b5a061 use more concrete types in chart2, DataSeries 
Change-Id: I80bc8961832a20c29b31f7618b9d2609f15ab3c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129642
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-08 08:52:11 +01:00
Noel Grandin 372f590220 crashtesting ooo#20372 
this reverts parts of the "use more concrete types in chart2,
LabeledDataSequence" commits, since writer uses it's own implementation
of the XLabeledDataSequence UNO interface

Change-Id: Icc2c5e9a38f789cddd9fbca63301397ce759fbff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129587
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-07 11:21:24 +01:00
Noel Grandin ccbd2b0c66 use more concrete types in chart2, LabeledDataSequence 
Change-Id: Iecc22ad488fff7d0536ffa37f4cde7da460c2c7d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129458
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-04 14:40:10 +01:00
Noel Grandin f90ac900a9 use more concrete types in chart2, DataSource 
Change-Id: If5001a8a8fc1103a8d662429d3077c7ce81cc2b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129457
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-04 12:22:31 +01:00
Noel Grandin fc03ef1e02 use more concrete types in chart2, LabeledDataSequence 
Change-Id: I88d5b7e045814cbd40750ebe927e6a76d5a463d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129456
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-04 12:20:00 +01:00
Noel Grandin 47bbacb2b1 use more concrete types in chart2, DataSeries 
Change-Id: Ib07ed6ec3321dc617cfec872d16683cf5de60907
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129181
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-31 10:39:29 +01:00
Noel Grandin 8c558549b7 use more concrete types in chart2, ChartModel 
Change-Id: I0f1c50448f6ab744e40d8744340685f59f139261
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129109
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-28 18:08:59 +01:00
Noel Grandin 39f452953e use more concrete types in chart2, Diagram 
Change-Id: I40cd39d0878dc56e4e86e05149c9744cb563d745
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128942
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-25 20:23:08 +01:00
Noel Grandin 4fbec819fc use more concrete types in chart2, ChartModel 
Change-Id: I86b7fa98a6d4a269637ac042a9bb99b41ab90b0c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128870
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-24 17:43:25 +01:00
Noel Grandin 379a9e76ef use more concrete types in chart2, ChartModel 
Change-Id: I621cc667d914ddfbfc84a9dd5a71bc76d411954b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128847
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-24 14:09:15 +01:00
Noel Grandin 58766f997d remove css::chart::XChartTypeTemplate 
these are purely internal interfaces, they cannot be used
from outside chart2.

Change-Id: Ib89e98e8099c34a530951bd85236fced216aff18
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128784
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-22 20:26:06 +01:00
Noel Grandin f0f87108ab use more concrete types in chart2, Diagram 
Change-Id: I870f6d9fa4c0b51cf7c887199079fdbabbca1fec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128597
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-19 13:46:01 +01:00
Mike Kaganski 5b0ae3b59c Prepare for removal of non-const operator[] from Sequence in chart2 
Change-Id: I71e0b458c4dd2a85e36a485e3efa72b1077b0e54
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124346
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2021-10-29 11:07:27 +02:00
Mike Kaganski 8a017d25a6 Avoid COW overhead using css::uno::Sequence 
The scenarios are:

1. Calling sequence's begin() and end() in pairs to pass to algorithms
   (both calls use getArray(), which does the COW checks)
2. In addition to #1, calling end() again when checking result of find
   algorithms, and/or begin() to calculate result's distance
3. Using non-const sequences in range-based for loops, which internally
   do #1
4. Assigning sequence to another sequence variable, and then modifying
   one of them

In many cases, the sequences could be made const, or treated as const
for the purposes of the algorithms (using std::as_const, std::cbegin,
and std::cend). Where algorithm modifies the sequence, it was changed
to only call getArray() once. For that, css::uno::toNonConstRange was
introduced, which returns a struct (sublclass of std::pair) with two
iterators [begin, end], that are calculated using one call to begin()
and one call to getLength().

To handle #4, css::uno::Sequence::swap was introduced, that swaps the
internal pointer to uno_Sequence. So when a local Sequence variable
should be assigned to another variable, and the latter will be modified
further, it's now possible to use swap instead, so the two sequences
are kept independent.

The modified places were found by temporarily removing non-const end().

Change-Id: I8fe2787f200eecb70744e8b77fbdf7a49653f628
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123542
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2021-10-14 06:00:49 +02:00
Julien Nabet 5895be734d Simplify Sequences initializations (chart2)(part1) 
Change-Id: I97ddde9659f337932b4165b794a769b83882126d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116802
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2021-06-08 10:25:12 +02:00
Gabor Kelemen 7bdbb50a50 tdf#42949 Fix new IWYU warnings in directories c* 
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Iac1e7802dbe1efa01c2befdd10406231788d4fc1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105315
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2020-11-06 08:18:45 +01:00
Noel Grandin a2fc883173 use more std::container::insert instead of std::copy 
which is both more compact code, and more efficient, since the insert
method can do smarter resizing

Change-Id: I17f226660f87cdf002edccc29b4af8fd59a25f91
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96948
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-06-24 08:43:55 +02:00
Noel Grandin 337a9a454c use for-range on Sequence in chart2 
Change-Id: Ief02e5d5284b0cbad26b04c0a282dccfee577b90
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94398
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-05-18 11:28:50 +02:00
Mike Kaganski da3922951b Use range-based for loop 
Change-Id: I2ee332ffeb9004535882a7859f1821624ef5efa6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92017
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2020-04-11 11:07:29 +02:00
Arkadiy Illarionov 1eb8859813 Use hasElements to check Sequence emptiness in chart2..connectivity 
Similar to clang-tidy readability-container-size-empty

Change-Id: I41824e8a4ef38d6a35a0ac4421cffcbcd17308e1
Reviewed-on: https://gerrit.libreoffice.org/71802
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-06-10 10:55:57 +02:00
Gabor Kelemen 6b74c41a31 tdf#42949 Fix IWYU warnings in chart2/source/tools/*cxx 
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I804895a4dd2d98707f0d1bbbc9bb78782b07a397
Reviewed-on: https://gerrit.libreoffice.org/61505
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
 2018-10-09 12:34:54 +02:00
Gabor Kelemen 47db30bdb3 tdf#42949 Fix IWYU warnings in chart2/source/inc/[d-l]*hxx 
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Try harder to use fw declarations, and a few newly analyzed files

Change-Id: I50299e9115ced60468c7bc5e63013addbaec48c0
Reviewed-on: https://gerrit.libreoffice.org/58618
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
 2018-08-08 17:20:58 +02:00
Noel Grandin 48fbfe38f6 use more DBG_UNHANDLED_EXCEPTION 
so we get nice logs of the exception dynamic type for UNO exceptions.

Change-Id: Ic0b10dc14d354a2c9a0591b3a51d2f1640d54bdb
Reviewed-on: https://gerrit.libreoffice.org/52465
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-04-09 08:46:34 +02:00
Julien Nabet ba7191ed0d Use for-range loops in chart2 (part1) 
Change-Id: I9310a6dc79d47f9058df8a3b463667389af1b2cb
Reviewed-on: https://gerrit.libreoffice.org/50672
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2018-03-03 19:20:53 +01:00
Mike Kaganski 4e144751f1 loplugin:unusedindex 
Change-Id: I256a807dd2a4c81126b5a76f3d472e31b8224146
Reviewed-on: https://gerrit.libreoffice.org/46652
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-18 07:36:32 +01:00
Noel Grandin c4abbb6e10 inline ASSERT_EXCEPTION macro in chart2 
Change-Id: I6bdcde5fd416531e2cdd3c9ec160833f1022247c
Reviewed-on: https://gerrit.libreoffice.org/44246
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-03 13:03:13 +01:00
Stephan Bergmann d63b706dad loplugin:includeform: chart2 
Change-Id: I5b455c684e7cd689d5160135246f3400363c7d40
 2017-10-23 22:46:12 +02:00
Julien Nabet b5bef1f7d5 Typos 
Change-Id: I13020539fe121151e884a90d72d47788fb3ae65c
Reviewed-on: https://gerrit.libreoffice.org/35436
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2017-03-19 18:50:33 +00:00
Tor Lillqvist 6de3688cc6 Drop :: prefix from std in c*/ 
Change-Id: If078cda95fa6ccd37270a5e9d81cfa0b84e71155
Reviewed-on: https://gerrit.libreoffice.org/34324
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
 2017-02-15 23:01:23 +00:00
Noel Grandin 83721f4365 makeAny->Any in basctl..chart2 
Change-Id: Ief1cdffbfc59ab4e35ac945d020772ff84c50d61
Reviewed-on: https://gerrit.libreoffice.org/33867
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-03 08:50:50 +00:00
Jochen Nitschke 194d4a02b9 chart2: remove unused ContainerHelper.hxx includes 
remove using namespace ::chart::ContainerHelper;
to match other uses

Change-Id: I343086a6b7d70c84499b209680973431c7317219
Reviewed-on: https://gerrit.libreoffice.org/27184
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jenkins <ci@libreoffice.org>
 2016-07-13 12:58:55 +00:00
Noel Grandin 43b4903db3 teach stylepolice plugin about ref-counted-pointer naming 
Change-Id: I6e91d22fc1826038c05ddb6fc065563c6a250752
Reviewed-on: https://gerrit.libreoffice.org/24459
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-28 09:31:16 +00:00
Noel Grandin 8353667d35 com::sun::star->css in chart2 
Change-Id: I04320d32d6d5c54e461cfabef58645f8b772bc69
 2016-03-14 13:43:38 +02:00
David Ostrovsky adfa772549 Add missing includes 
These include were needed to compile on Windows, MSVC 14.0 with
clang-cl.

Change-Id: I4ca5cec8314920e90fcca6fa69ec4df87d680f29
Reviewed-on: https://gerrit.libreoffice.org/23044
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2016-03-09 07:53:56 +00:00
Noel Grandin f69585c354 loplugin:unuseddefaultparams in chart2 
Change-Id: I03a3580fdbd1f6cf08af329b07edcfe09ecbb9aa
 2016-03-02 07:57:38 +02:00
Noel Grandin c5458af905 loplugin:unusedfields in chart2 
Change-Id: I8203f84ad8b138932c990032e17ea5d2daf384bb
 2015-12-23 09:38:46 +02:00
Noel Grandin 2554efabb6 use comphelper::containerToSequence 
in chart2, we remove a local equivalent of the method

Change-Id: I25129a3d1ea1dd724eb9cd38a57be37a78b3d100
 2015-11-19 09:33:29 +02:00