ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

lsan: fix leak of FormulaToken instances

Browse Source 
found when running CppunitTest_sc_spreadsheet_functions_test under
ASAN with detect_leaks=1

The AddToken method will call Clone() on our behalf, so the
extra Clone call here resulted in a leak.

Change-Id: I5463e2b89a71c46096ef3f9806fc33f0e523e5e7
(cherry-picked from commit I5463e2b89a71c46096ef3f9806fc33f0e523e5e7)
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/2166
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I9a2bd6dfac42fe203099ae23c1def3fce063d5a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205022
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
This commit is contained in:
Noel Grandin
2026-05-10 13:59:01 +02:00
committed by Julien Nabet
parent 25c08179be
commit de6b35394b
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sc/source/core/tool/interpr1.cxx
+1 -1
View File
@@ -9945,7 +9945,7 @@ ScTokenArray ScInterpreter::checkPushTokens(const ScTokenArray& rTokens, short n
if (aIterResult.GetIndex() > nEndPos)
break;
aTempTokens.AddToken(*t->Clone());
aTempTokens.AddToken(*t);
}
return aTempTokens;
}