From de6b35394bed92fd8184a276ad0dac82de7b4eaf Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Tue, 5 May 2026 11:18:02 +0200 Subject: [PATCH] lsan: fix leak of FormulaToken instances found when running CppunitTest_sc_spreadsheet_functions_test under ASAN with detect_leaks=1 The AddToken method will call Clone() on our behalf, so the extra Clone call here resulted in a leak. Change-Id: I5463e2b89a71c46096ef3f9806fc33f0e523e5e7 (cherry-picked from commit I5463e2b89a71c46096ef3f9806fc33f0e523e5e7) Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/2166 Tested-by: Jenkins CPCI Reviewed-by: Miklos Vajna Change-Id: I9a2bd6dfac42fe203099ae23c1def3fce063d5a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205022 Tested-by: Jenkins Reviewed-by: Julien Nabet --- sc/source/core/tool/interpr1.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx index 708c80171215..f9be75f35535 100644 --- a/sc/source/core/tool/interpr1.cxx +++ b/sc/source/core/tool/interpr1.cxx @@ -9945,7 +9945,7 @@ ScTokenArray ScInterpreter::checkPushTokens(const ScTokenArray& rTokens, short n if (aIterResult.GetIndex() > nEndPos) break; - aTempTokens.AddToken(*t->Clone()); + aTempTokens.AddToken(*t); } return aTempTokens; }