ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

tdf#172093 editeng: Fix freeze in character transliteration

Browse Source 
Deletes some experimental YRS code that was causing an infinite loop in
drawing the selection after character transliteration. This code was
originally part of a patch meant to correct peer cursors after inserts
and deletes. Unfortunately, the implementation for transliteration was
incorrect and leaves the selection in an invalid state.

Regression from commit 0ff4c66190
  Author: Michael Stahl <michael.stahl@allotropia.de>
  Date:   Fri Feb 14 18:03:16 2025 +0100
  LOCRDT editeng,sw: yrs peer cursors for editengine

Change-Id: I2b8cd9d501b8262dfc07b808beda7a3767f9455c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208174
Tested-by: Jenkins
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
(cherry picked from commit e1be5499a1)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208500
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
This commit is contained in:
Jonathan Clark
2026-07-28 10:10:12 +02:00
committed by Xisco Fauli
parent 91961ca23e
commit c4af787616
1 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
editeng/source/editeng/impedit4.cxx
-5
View File
@@ -3241,16 +3241,11 @@ short ImpEditEngine::ReplaceTextOnly(
DBG_ASSERT( (nCurrentPos+1) < pNode->Len(), "TransliterateText - String smaller than expected!" );
GetEditDoc().RemoveChars( EditPaM( pNode, nCurrentPos+1 ), -nDiff);
ESelection const deleted{maEditDoc.GetPos(pNode), nCurrentPos+1, maEditDoc.GetPos(pNode), nCurrentPos-nDiff};
UpdateSelectionsDelete(deleted);
}
else
{
DBG_ASSERT( nDiff == 1, "TransliterateText - Diff other than expected! But should work..." );
GetEditDoc().InsertText( EditPaM( pNode, nCurrentPos ), OUStringChar(rNewText[n]) );
ESelection const inserted{maEditDoc.GetPos(pNode), nCurrentPos, maEditDoc.GetPos(pNode), nCurrentPos+nDiff};
UpdateSelectionsInsert(inserted);
}
nDiffs = sal::static_int_cast< short >(nDiffs + nDiff);
}