tdf#120703 PVS: V519 variable is assigned values twice successively

V519 The 'aNewTextBoundingBox.Y2' variable is assigned values twice
     successively. Perhaps this is a mistake. Check lines: 409, 411.

I have tried to check if that could possibly be a typo, and X1 was meant,
but it seems to be not the case here (doing that, or putting anything to
X1 instead of 0, just displaces the notes in the presenter console wrong
vertically).

Change-Id: Ie686b69bddc193568c1b5c0d18b9b7bf547313d1
Reviewed-on: https://gerrit.libreoffice.org/62410
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
This commit is contained in:
Mike Kaganski
2018-10-27 11:43:24 +02:00
parent 6ef1eac703
commit bb702103f2
@@ -406,7 +406,6 @@ void PresenterNotesView::Layout()
mxToolBarWindow->setPosSize(0, aWindowBox.Height - nToolBarHeight,
sal_Int32(aToolBarSize.Width + 0.5), nToolBarHeight,
awt::PosSize::POSSIZE);
aNewTextBoundingBox.Y2 -= nToolBarHeight;
mnSeparatorYLocation = aWindowBox.Height - nToolBarHeight - gnSpaceBelowSeparator;
aNewTextBoundingBox.Y2 = mnSeparatorYLocation - gnSpaceAboveSeparator;
// Place the close button.