From bb702103f210cd344d8e700ece27f3708aab8eaf Mon Sep 17 00:00:00 2001 From: Mike Kaganski Date: Sat, 27 Oct 2018 10:41:39 +0200 Subject: [PATCH] tdf#120703 PVS: V519 variable is assigned values twice successively V519 The 'aNewTextBoundingBox.Y2' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 409, 411. I have tried to check if that could possibly be a typo, and X1 was meant, but it seems to be not the case here (doing that, or putting anything to X1 instead of 0, just displaces the notes in the presenter console wrong vertically). Change-Id: Ie686b69bddc193568c1b5c0d18b9b7bf547313d1 Reviewed-on: https://gerrit.libreoffice.org/62410 Tested-by: Jenkins Reviewed-by: Mike Kaganski --- sdext/source/presenter/PresenterNotesView.cxx | 1 - 1 file changed, 1 deletion(-) diff --git a/sdext/source/presenter/PresenterNotesView.cxx b/sdext/source/presenter/PresenterNotesView.cxx index 20c1525d7565..900340b56fab 100644 --- a/sdext/source/presenter/PresenterNotesView.cxx +++ b/sdext/source/presenter/PresenterNotesView.cxx @@ -406,7 +406,6 @@ void PresenterNotesView::Layout() mxToolBarWindow->setPosSize(0, aWindowBox.Height - nToolBarHeight, sal_Int32(aToolBarSize.Width + 0.5), nToolBarHeight, awt::PosSize::POSSIZE); - aNewTextBoundingBox.Y2 -= nToolBarHeight; mnSeparatorYLocation = aWindowBox.Height - nToolBarHeight - gnSpaceBelowSeparator; aNewTextBoundingBox.Y2 = mnSeparatorYLocation - gnSpaceAboveSeparator; // Place the close button.