ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

starmath a11y: Stop declaring support for non-existing services

Browse Source 
The services that
SmGraphicAccessible::getSupportedServiceNames
claims support for don't actually exist. Stop
implementing XServiceInfo after all.

For the AccessibleContext service, such a one
existed recently until

    Change-Id: I77584db1a6452ee3bf0a9fd7188271e4c658ed07
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Wed Sep 2 10:31:59 2026 +0200

        [API CHANGE] a11y: Drop com.sun.star.accessibility.AccessibleContext

, but that one would have had to be reported as
"com.sun.star.accessibility.AccessibleContext",
not "css::accessibility::AccessibleContext", so
it was already incorrect before the service
was dropped in the above commit.

Change-Id: Iad0df2b057c2dd4f138cbb0dbc67dc0a7982d37b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210410
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
This commit is contained in:
Michael Weghorn
2026-09-03 09:22:57 +02:00
parent 753c9c6689
commit 386a406ae7
2 changed files with 1 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
starmath/source/accessibility.cxx
-21
View File
@@ -550,25 +550,4 @@ sal_Bool SAL_CALL SmGraphicAccessible::scrollSubstringTo( sal_Int32, sal_Int32,
return false;
}
OUString SAL_CALL SmGraphicAccessible::getImplementationName()
{
return u"SmGraphicAccessible"_ustr;
}
sal_Bool SAL_CALL SmGraphicAccessible::supportsService(
const OUString& rServiceName )
{
return cppu::supportsService(this, rServiceName);
}
Sequence< OUString > SAL_CALL SmGraphicAccessible::getSupportedServiceNames()
{
return {
u"css::accessibility::Accessible"_ustr,
u"css::accessibility::AccessibleComponent"_ustr,
u"css::accessibility::AccessibleContext"_ustr,
u"css::accessibility::AccessibleText"_ustr
};
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
starmath/source/accessibility.hxx
+1 -7
View File
@@ -22,7 +22,6 @@
#include <com/sun/star/accessibility/AccessibleScrollType.hpp>
#include <com/sun/star/accessibility/XAccessible.hpp>
#include <com/sun/star/accessibility/XAccessibleText.hpp>
#include <com/sun/star/lang/XServiceInfo.hpp>
#include <com/sun/star/uno/Reference.h>
#include <comphelper/OAccessible.hxx>
#include <cppuhelper/implbase.hxx>
@@ -36,7 +35,7 @@ namespace accessibility { class AccessibleTextHelper; }
// class used for accessibility in the graphic-window
class SmGraphicAccessible final
: public cppu::ImplInheritanceHelper<comphelper::OAccessible, css::lang::XServiceInfo,
: public cppu::ImplInheritanceHelper<comphelper::OAccessible,
css::accessibility::XAccessibleText>
{
OUString aAccName;
@@ -99,11 +98,6 @@ public:
virtual css::accessibility::TextSegment SAL_CALL getTextBehindIndex( sal_Int32 nIndex, sal_Int16 aTextType ) override;
virtual sal_Bool SAL_CALL copyText( sal_Int32 nStartIndex, sal_Int32 nEndIndex ) override;
virtual sal_Bool SAL_CALL scrollSubstringTo( sal_Int32 nStartIndex, sal_Int32 nEndIndex, css::accessibility::AccessibleScrollType aScrollType) override;
// XServiceInfo
virtual OUString SAL_CALL getImplementationName( ) override;
virtual sal_Bool SAL_CALL supportsService( const OUString& ServiceName ) override;
virtual css::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames( ) override;
};
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */