From 386a406ae7e2c2869a0e1a5b4367d441fd93affc Mon Sep 17 00:00:00 2001 From: Michael Weghorn Date: Wed, 2 Sep 2026 10:57:29 +0200 Subject: [PATCH] starmath a11y: Stop declaring support for non-existing services The services that SmGraphicAccessible::getSupportedServiceNames claims support for don't actually exist. Stop implementing XServiceInfo after all. For the AccessibleContext service, such a one existed recently until Change-Id: I77584db1a6452ee3bf0a9fd7188271e4c658ed07 Author: Michael Weghorn Date: Wed Sep 2 10:31:59 2026 +0200 [API CHANGE] a11y: Drop com.sun.star.accessibility.AccessibleContext , but that one would have had to be reported as "com.sun.star.accessibility.AccessibleContext", not "css::accessibility::AccessibleContext", so it was already incorrect before the service was dropped in the above commit. Change-Id: Iad0df2b057c2dd4f138cbb0dbc67dc0a7982d37b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210410 Reviewed-by: Michael Weghorn Tested-by: Jenkins --- starmath/source/accessibility.cxx | 21 --------------------- starmath/source/accessibility.hxx | 8 +------- 2 files changed, 1 insertion(+), 28 deletions(-) diff --git a/starmath/source/accessibility.cxx b/starmath/source/accessibility.cxx index 56bd52666b36..2fac8c4dfac5 100644 --- a/starmath/source/accessibility.cxx +++ b/starmath/source/accessibility.cxx @@ -550,25 +550,4 @@ sal_Bool SAL_CALL SmGraphicAccessible::scrollSubstringTo( sal_Int32, sal_Int32, return false; } -OUString SAL_CALL SmGraphicAccessible::getImplementationName() -{ - return u"SmGraphicAccessible"_ustr; -} - -sal_Bool SAL_CALL SmGraphicAccessible::supportsService( - const OUString& rServiceName ) -{ - return cppu::supportsService(this, rServiceName); -} - -Sequence< OUString > SAL_CALL SmGraphicAccessible::getSupportedServiceNames() -{ - return { - u"css::accessibility::Accessible"_ustr, - u"css::accessibility::AccessibleComponent"_ustr, - u"css::accessibility::AccessibleContext"_ustr, - u"css::accessibility::AccessibleText"_ustr - }; -} - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/starmath/source/accessibility.hxx b/starmath/source/accessibility.hxx index 1cab5d116a3f..5aeab0a0c2bd 100644 --- a/starmath/source/accessibility.hxx +++ b/starmath/source/accessibility.hxx @@ -22,7 +22,6 @@ #include #include #include -#include #include #include #include @@ -36,7 +35,7 @@ namespace accessibility { class AccessibleTextHelper; } // class used for accessibility in the graphic-window class SmGraphicAccessible final - : public cppu::ImplInheritanceHelper { OUString aAccName; @@ -99,11 +98,6 @@ public: virtual css::accessibility::TextSegment SAL_CALL getTextBehindIndex( sal_Int32 nIndex, sal_Int16 aTextType ) override; virtual sal_Bool SAL_CALL copyText( sal_Int32 nStartIndex, sal_Int32 nEndIndex ) override; virtual sal_Bool SAL_CALL scrollSubstringTo( sal_Int32 nStartIndex, sal_Int32 nEndIndex, css::accessibility::AccessibleScrollType aScrollType) override; - - // XServiceInfo - virtual OUString SAL_CALL getImplementationName( ) override; - virtual sal_Bool SAL_CALL supportsService( const OUString& ServiceName ) override; - virtual css::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames( ) override; }; /* vim:set shiftwidth=4 softtabstop=4 expandtab: */