Armin Le Grand (collabora)
f70a118b03
Moved creation of Undo/Redo actions for geometry changes directly to the methods addDiagramNode/removeDiagramNode of class DiagramHelper so that not every caller has to do that again. Removed from DiagramDialog where that was done before. Extended DiagramDataState which is used for SdrUndoDiagramModelData with needed Model information. After using SdrModel/XShape data as part of the DiagramModel it is necessary to also keep that info when geometry gets changed. Also the current transformation of the group hosting the Diagram is needed. Also the end state of change in SdrUndoDiagramModelData is now late-evaluated to get the changed state. This is needed in redo, so evaluating this if undo is used is the thing to do. Added a general mechanism to apply locks to the SdrObjects, see applyLocksToDiagramObjects. It currently sets MoveProtect, ResizeProtect and DeleteProtect. These get un-set when the Diagram is reverted to a simple SdrObjGroup to not hinder further editing. There is currently no ToFront/ToBack lock or others which may be needed. In principle all geometric changes to objects of the Diagram need to be blocked. Also still missing is that the BackgroundObject has no LineAttributes, or better is not allowed to have these due to mso only offering a FillStyle for that object. Not sure yet how to do that. Added a mechanism to automatically delete the buffered original data when attributes change, see ItemSetInformationChange. This is triggered by AttributeProperties::ItemSetChanged, but needs to be prevented during import (which also changes Items). Added support to delete the SubSelected object if it is a TextFrame. This leads to geometry change and re-layout and also creates a Undo action now. Attribute access to SubSelection is done in SdrEditView::MergeAttrFromMarked/SetAttrToMarked so that attributes can now be changed like for regular objects. Also some methods in SdrMarkView had to be adapted to work with the SubSelected object. Extended Diagram SubSelection to make tab/ShiftTab work, including from where the Diagram is entered. Also made direct MouseKlick work. Added simplifications to work with Diagram stuff, some tooling directly at SdrObject. Due to UnitTests I reverted the decision to have all SdrObjects in the Diagram 'flat' without Groups. That would be easier and is what the import of MSO visualizationm replacement often uses, but not what a reLayout creates. Those complaining tests are the pptx ones that have no replacement graphics (no drawing*.xml) and have to be re-layouted using our mechanism as existing so far. So keep groups again for now. Price is that all stuff handling SubSelections has to use SdrObjListIter instead of SdrObjList. That makes it somewhat more complicated, but work on a virtually flat hierarchy of SubObjects in any case - maybe safer for the future. Also looked at that Locking oif SdrObjects again also due to a test. I wanted to use the extended/newer stuff, but applying it made the office crash. After some debugging I found that in SdrObjList::RemoveObject the remove is *cancelled* when SdrObject::IsDeleteProtect is set for that object. Unfortunately that remove is due to moving the object to another target list, so it should happen. This is probably a relict of very old stuff, to prevent object delettion that way (!). For now I use the fact that this happens during import. Change-Id: Ied2263928106e2cb02047e2e9a55c680384b2932 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201497 Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Tested-by: Jenkins
LibreOffice
LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.
A quick overview of the LibreOffice code structure.
Overview
You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs and Developers Guide. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.
The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.
The Build Chain and Runtime Baselines
These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:
- Windows:
- Runtime: Windows 10
- Build: wsl-as-helper + Visual Studio 2022
- macOS:
- Runtime: 11
- Build: 13 or later + Xcode 14.3 or later (using latest version available for a given version of macOS)
- Linux:
- Runtime: RHEL 9 or CentOS 9 and comparable
- Build: either GCC 12; or Clang 18 with libstdc++ 11
- iOS (only for LibreOfficeKit):
- Runtime: 14.5 (only support for newer i devices == 64 bit)
- Build: Xcode 12.5 and iPhone SDK 14.5
- Android:
- Build: NDK 27 and SDK 30.0.3
- Emscripten / WASM:
- Runtime: a browser with SharedMemory support (threads + atomics)
- Build: Qt 5.15 with Qt supported Emscripten 1.39.8
- See README.wasm
Java is required for building many parts of LibreOffice. In TDF Wiki article Development/Java, the exact modules that depend on Java are listed.
The baseline for Java is Java Development Kit (JDK) Version 17 or later.
The baseline for Python is version 3.11. It follows the version available in SUSE Linux Enterprise Desktop and the Maintenance Support version of Red Hat Enterprise Linux.
If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 18. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.
You can find the TDF configure switches in the distro-configs/ directory.
To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.
For more information see the build instructions for your platform in the TDF wiki.
The Important Bits of Code
Each module should have a README.md file inside it which has some
degree of documentation for that module; patches are most welcome to
improve those. We have those turned into a web page here:
However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:
| Module | Description |
|---|---|
| sal/ | this provides a simple System Abstraction Layer |
| tools/ | this provides basic internal types: Rectangle, Color etc. |
| vcl/ | this is the widget toolkit library and one rendering abstraction |
| framework/ | UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files |
| sfx2/ | legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc. |
| svx/ | drawing model related helper code, including much of Draw/Impress |
Then applications
| Module | Description |
|---|---|
| desktop/ | this is where the main() for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop |
| sw/ | Writer |
| sc/ | Calc |
| sd/ | Draw / Impress |
There are several other libraries that are helpful from a graphical perspective:
| Module | Description |
|---|---|
| basegfx/ | algorithms and data-types for graphics as used in the canvas |
| canvas/ | new (UNO) canvas rendering model with various backends |
| cppcanvas/ | C++ helper classes for using the UNO canvas |
| drawinglayer/ | View code to render drawable objects and break them down into primitives we can render more easily. |
Rules for #include Directives (C/C++)
Use the "..." form if and only if the included file is found next to the
including file. Otherwise, use the <...> form. (For further details, see the
mail Re: C[++]: Normalizing include syntax ("" vs
<>).)
The UNO API include files should consistently use double quotes, for the benefit of external users of this API.
loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.
Finding Out More
Beyond this, you can read the README.md files, send us patches, ask
on the mailing list libreoffice@lists.freedesktop.org (no subscription
required) or poke people on IRC #libreoffice-dev on irc.libera.chat -
we're a friendly and generally helpful mob. We know the code can be
hard to get into at first, and so there are no silly questions.
SAST Tools
PVS-Studio - static analyzer for C, C++, C#, and Java code.