ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
Files
dfdee8ff8afeaabb8471bb73bc13fa2563dc0a65
odfstudio/include/vcl
T
History
Michael Weghorn 6a023bacb9 Return std::unique_ptr in Application::CreateMessageDialog 
The caller of Application::CreateMessageDialog owns the
returned message dialog.

So far, it was returned by a plain weld::MessageDialog*.

Return a unique_ptr instead, to make clear the ownership
semantics. (Also adjust SalInstance::CreateMessageDialog
accordingly, which is called by Application::CreateMessageDialog
and implements the actual logic to create a message dialog.)

Adjust callers where needed.
Most callers were already using a smart pointer for the
returned message dialog anyway.

Change-Id: I7c06bb24b611bd67f5af89800adb13bf22dcc6fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211013
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
2026-09-16 10:35:19 +02:00
..
accessibility
a11y: Drop misleading mention of XServiceInfo in AccessibleBrowseBoxTableBase
2026-09-03 09:22:41 +02:00
animate
tdf#146619 Use more forward declarations in include/vcl/[a-o]
2026-01-22 09:42:36 +01:00
bitmap
tdf#143148 use #pragma once in slideshow and bitmap
2026-01-12 15:56:36 +01:00
filter
cool#16122 export to pdf produces bad PANTONE element
2026-09-14 20:21:00 +02:00
font
tdf#152206: Add FontVariationAxis and GetVariationAxes API
2026-05-11 23:20:39 +02:00
graphic
tdf#156931 add import support for JPEG XL image format
2026-08-26 11:43:32 +02:00
notebookbar
vcl: Drop NotebookBar::{m_pViewShell,m_rDisposeLink}
2026-07-21 07:10:55 +02:00
opengl
vcl: Use std::list to manage OpenGLContexts in ImplSVGDIData
2026-03-24 21:39:56 +01:00
outdev
tdf#103680: Implement GetOpenTypeMathConstant in outdev
2026-07-22 12:41:11 +02:00
pdf
tdf#146619 Use more forward declarations in include/vcl/[h-p]*
2026-01-14 10:19:31 +01:00
printer
tdf#156230: Deprecate and stop using PDFAsStandardPrintJobFormat
2023-07-30 20:44:15 +02:00
qt
qt: Include <sal/config.h>, arrange includes more consistently
2026-03-27 04:35:24 +01:00
rendercontext
vcl: Encapsulate coordinate mapping state to CoordinateMapper
2026-06-09 17:26:43 +02:00
skia
tdf#156361 use slow blending path if alpha mask blending is diabled
2023-07-20 19:58:35 +02:00
test
tdf#146619 Use more forward declarations in include/vcl/[q-w]*
2026-01-18 00:33:10 +01:00
toolkit
Fix typos
2026-08-29 16:20:13 +02:00
uitest
uitest: Move IconViewUIObject::get_state logic to base
2026-06-01 08:53:09 +02:00
weld
Resolves tdf#173189 - Preselect entry in col/row width/height dialogs
2026-08-23 09:38:22 +02:00
abstdlg.hxx
Fix typos
2026-09-03 08:51:42 +02:00
abstdlgimpl.hxx
tdf#146619 Run IWYU again on include/vcl
2026-01-03 17:32:04 +01:00
accessibletableprovider.hxx
vcl a11y: Return OAccessible in 2 IAccessibleTableProvider methods
2026-06-19 18:11:49 +02:00
alpha.hxx
tdf#146619 Use more forward declarations in include/vcl/[a-o]
2026-01-22 09:42:36 +01:00
BinaryDataContainer.hxx
tdf#146619 Use more forward declarations in include/vcl/[A-Z]*
2026-01-05 11:10:28 +01:00
BinaryDataContainerTools.hxx
tdf#146619 Use more forward declarations in include/vcl/[A-Z]*
2026-01-05 11:10:28 +01:00
bitmap.hxx
tdf#172937: let's compare colors instead of index of colors
2026-07-30 08:22:14 +02:00
BitmapAccessMode.hxx
tdf#143148 use #pragma once in slideshow and bitmap
2026-01-12 15:56:36 +01:00
BitmapBuffer.hxx
tdf#143148 use #pragma once in slideshow and bitmap
2026-01-12 15:56:36 +01:00
BitmapColor.hxx
tdf#143148 use #pragma once in slideshow and bitmap
2026-01-12 15:56:36 +01:00
BitmapInfoAccess.hxx
loplugin:unusedmethods
2026-05-22 09:32:38 +02:00
BitmapPalette.hxx
tdf#146619 Use more forward declarations in include/vcl/[A-Z]*
2026-01-05 11:10:28 +01:00
BitmapReadAccess.hxx
tdf#146619 Use more forward declarations in include/vcl/[A-Z]*
2026-01-05 11:10:28 +01:00
bitmaps.hlst
Move constants for app icons from sfx2-internal to global vcl header
2026-03-13 07:37:57 +01:00
BitmapTools.hxx
Fix typos
2026-09-03 08:51:42 +02:00
BitmapWriteAccess.hxx
tdf#146619 Use more forward declarations in include/vcl/[A-Z]*
2026-01-05 11:10:28 +01:00
builder.hxx
vcl: Drop SvTabListBox::m_eRole and logic to set it in VclBuilder
2026-06-17 08:30:16 +02:00
builderbase.hxx
loplugin:unusedmethods
2026-05-22 09:32:38 +02:00
builderfactory.hxx
…
builderpage.hxx
weld: Move weld::Button to own header/Rename weld.hxx
2026-06-05 07:58:07 +02:00
cairo.hxx
ofz; Integer-overflow
2026-03-16 09:33:11 +01:00
CairoFormats.hxx
remove alpha device from OutputDevice
2025-07-21 10:49:25 +02:00
canvastools.hxx
tdf#124987 sw: Fixed off-by-one error in draw obj anchor clipping rect
2026-05-13 11:02:41 +02:00
checksum.hxx
tdf#146619 Recheck include/[v-x]* with IWYU
2023-12-12 18:51:27 +01:00
ColorDialog.hxx
tdf#146619 Use more forward declarations in include/vcl/[A-Z]*
2026-01-05 11:10:28 +01:00
ColorMask.hxx
loplugin:unusedmethods
2025-02-05 18:29:16 +01:00
commandevent.hxx
tdf#146619 Use more forward declarations in include/vcl/[a-c]*
2026-01-06 10:02:26 +01:00
commandinfoprovider.hxx
tdf#146619 Use more forward declarations in include/vcl/[a-c]*
2026-01-06 10:02:26 +01:00
ctrl.hxx
tdf#146619 Use more forward declarations in include/vcl/[a-c]*
2026-01-06 10:02:26 +01:00
cursor.hxx
Related: tdf#143449 rework vcl::Cursor drawing to measure the affected area
2026-02-16 00:24:18 +01:00
cvtgrf.hxx
tdf#146619 Use more forward declarations in include/vcl/[a-c]*
2026-01-06 10:02:26 +01:00
decoview.hxx
loplugin:constantparam
2024-10-01 11:17:11 +02:00
DesktopType.hxx
vcl: Use enum class instead of string to identify desktop environment
2026-03-17 10:08:05 +01:00
dialoghelper.hxx
…
dibtools.hxx
tdf#146619 Use more forward declarations in include/vcl/[d-g]*
2026-01-11 21:38:37 +01:00
dllapi.h
replace VCL_DLLPRIVATE with SAL_DLLPRIVATE
2024-03-14 14:31:37 +01:00
dndhelp.hxx
drop some more COVERITY stuff
2025-10-12 18:17:31 +02:00
dndlistenercontainer.hxx
Fix drag&drop with multiselection from extensions
2026-01-13 21:38:04 +01:00
dockingarea.hxx
…
dockwin.hxx
vcl: nType -> eType
2025-02-18 09:44:52 +01:00
DocWindow.hxx
…
dropcache.hxx
add version to coverity workaround
2025-08-10 11:50:02 +02:00
embeddedfontsmanager.hxx
tdf#172647: Respect when building embedded font URL
2026-07-14 00:16:00 +02:00
EnumContext.hxx
Chart Font sidebar panel
2025-05-08 08:31:36 +02:00
errinf.hxx
Drop unneeded forward declarations from include/
2025-01-03 09:32:27 +01:00
event.hxx
tdf#146619 Use more forward declarations in include/vcl/outdev.hxx
2026-01-23 21:27:08 +01:00
evntpost.hxx
…
exceptiontypes.hxx
…
extoutdevdata.hxx
…
fieldvalues.hxx
tdf#146619 Use more forward declarations in include/vcl/[d-g]*
2026-01-11 21:38:37 +01:00
fileregistration.hxx
…
FilterConfigItem.hxx
pdf-dialog general-tab: set_sensitive if config not read-only
2023-09-30 11:56:49 +02:00
fntstyle.hxx
Document some core enums that correspond to externally visible data
2025-06-09 15:02:09 +02:00
font.hxx
vcl: Rename Font::Set/GetAverageFontWidth to Set/GetFontWidth
2026-07-14 00:16:59 +02:00
fontcapabilities.hxx
…
fontcharmap.hxx
loplugin:unusedmethods
2026-02-24 18:01:04 +01:00
formatter.hxx
vcl: Merge Formatter::{Impl,}SetValue
2026-04-22 18:05:01 +02:00
formpdfexport.hxx
vcl: move PDFWriter into vcl::pdf namespace
2025-10-23 06:53:27 +02:00
gdimetafiletools.hxx
…
gdimtf.hxx
Fraction->double in GDIMetaFile
2026-03-23 07:06:06 +01:00
GestureEventPan.hxx
…
GestureEventRotate.hxx
…
GestureEventZoom.hxx
…
gfxlink.hxx
Fix typos
2026-09-10 20:50:11 +02:00
glyphitem.hxx
tdf#146619 Recheck include/[v-x]* with IWYU
2023-12-12 18:51:27 +01:00
glyphitemcache.hxx
tdf#146619 Use more forward declarations in include/vcl/[a-o]
2026-01-22 09:42:36 +01:00
gradient.hxx
tdf#146619 Use more forward declarations in include/vcl/[d-g]*
2026-01-11 21:38:37 +01:00
graph.hxx
oox: cache color change transform results during OOXML import
2026-05-02 21:31:13 +02:00
GraphicAttributes.hxx
Document some core enums that correspond to externally visible data
2025-06-09 15:02:09 +02:00
GraphicExternalLink.hxx
…
graphicfilter.hxx
Fix typos
2026-09-10 20:50:11 +02:00
GraphicLoader.hxx
tdf#146619 Use more forward declarations in include/vcl/[A-Z]*
2026-01-05 11:10:28 +01:00
GraphicNativeMetadata.hxx
tdf#146619 Use more forward declarations in include/vcl/[A-Z]*
2026-01-05 11:10:28 +01:00
GraphicNativeTransform.hxx
…
GraphicObject.hxx
tdf#146619 Use more forward declarations in include/vcl/[a-o]
2026-01-22 09:42:36 +01:00
graphictools.hxx
use more UNLESS_MERGELIBS
2024-02-12 20:25:54 +01:00
hatch.hxx
tdf#146619 Use more forward declarations in include/vcl/[h-p]*
2026-01-14 10:19:31 +01:00
headbar.hxx
vcl: Pass Window::Draw outdev param by ref
2026-05-20 00:38:47 +02:00
help.hxx
dubious to enable/disable help button based on IsContextHelpEnabled
2024-08-14 11:04:51 +02:00
hexcolorcontrol.hxx
weld: Pass weld::TextWidget& in text change callback/handler
2026-07-10 18:17:27 +02:00
htmltransferable.hxx
reduce symbol visibility in vcl
2024-03-14 19:17:08 +01:00
i18nhelp.hxx
tdf#141415 reduce time spent loading language data
2025-03-22 17:26:53 +01:00
IContext.hxx
…
IconThemeInfo.hxx
tdf#146619 Use more forward declarations in include/vcl/[A-Z]*
2026-01-05 11:10:28 +01:00
IDialogRenderable.hxx
Add windowId to "notifyCursorInvalidation".
2026-02-26 07:05:37 +01:00
idle.hxx
…
idletask.hxx
idletask: Wait with a condition_variable when not on the main thread
2025-11-19 20:18:33 +01:00
image.hxx
tdf#146619 Use more forward declarations in include/vcl/[h-p]*
2026-01-14 10:19:31 +01:00
ImageTree.hxx
BitmapEx->Bitmap in ImageTree
2025-08-06 20:29:26 +02:00
imap.hxx
Fraction->double in ImageMap
2026-03-23 09:39:43 +01:00
imapcirc.hxx
Fraction->double in ImageMap
2026-03-23 09:39:43 +01:00
imapobj.hxx
tdf#143148 use pragma once instead of include guards
2024-01-29 10:30:01 +01:00
imappoly.hxx
Fraction->double in ImageMap
2026-03-23 09:39:43 +01:00
imaprect.hxx
Fraction->double in ImageMap
2026-03-23 09:39:43 +01:00
inetimg.hxx
tdf#146619 Use more forward declarations in include/vcl/[h-p]*
2026-01-14 10:19:31 +01:00
inputctx.hxx
tdf#143148 use pragma once instead of include guards
2024-01-29 10:30:01 +01:00
inputtypes.hxx
…
InterimItemWindow.hxx
vcl: Drop unused nLOKWindowId param for Application::CreateInterimBuilder etc.
2026-06-05 07:58:53 +02:00
introwin.hxx
vcl: Merge IntroWindow::ImplInitIntroWindowData into ctor
2025-11-21 15:53:39 +01:00
ITiledRenderable.hxx
cool#12762: Calc Online: Implement doc_getPrintRanges for document load.
2026-02-27 10:01:11 +01:00
jobset.hxx
tdf#143148 use pragma once instead of include guards
2024-01-29 10:30:01 +01:00
kernarray.hxx
convert KernArray from sal_Int32 to double
2024-10-31 12:10:52 +01:00
keycod.hxx
tdf#143148 use pragma once instead of include guards
2024-01-29 10:30:01 +01:00
keycodes.hxx
tdf#143148 use pragma once instead of include guards
2024-01-29 10:30:01 +01:00
layout.hxx
vcl: Drop vcl::Window::DumpAsPropertyTree
2026-06-05 08:00:44 +02:00
lineinfo.hxx
tdf#146619 Use more forward declarations in include/vcl/[h-p]*
2026-01-14 10:19:31 +01:00
locktoplevels.hxx
…
lok.hxx
tdf#146619 Use more forward declarations in include/vcl/[h-p]*
2026-01-14 10:19:31 +01:00
mapmod.hxx
Fraction->double in MapMode
2026-03-26 13:23:37 +01:00
menu.hxx
vcl: Drop now unused Menu::DumpAsPropertyTree
2026-06-05 08:00:04 +02:00
menubarupdateicon.hxx
missing includes
2026-02-06 14:46:46 +01:00
metaact.hxx
vcl: Rename Font::Set/GetAverageFontWidth to Set/GetFontWidth
2026-07-14 00:16:59 +02:00
metaactiontypes.hxx
…
metric.hxx
tdf#36709 sw: Writer layout for font-relative first-line indent
2024-11-13 09:35:20 +01:00
mnemonic.hxx
…
mtfxmldump.hxx
Simplify XmlTestTools::dumpAndParse for default dumper case
2025-12-11 15:56:00 +01:00
naturalsort.hxx
…
NotebookbarContextControl.hxx
…
oldprintadaptor.hxx
…
outdev.hxx
tdf#103680: Implement GetOpenTypeMathConstant in outdev
2026-07-22 12:41:11 +02:00
pdfextoutdevdata.hxx
Fix "is build"->"is built"
2026-02-09 12:06:38 +01:00
pdfread.hxx
cool#16022 pass PDF password through to the version downgrade on import
2026-07-27 15:47:20 +02:00
pdfwriter.hxx
loplugin:unusedmethods
2026-06-29 10:16:53 +02:00
Platform.hxx
vcl/qt: enable Qt6 plugin for Mac
2026-07-15 16:51:07 +02:00
print.hxx
loplugin:unusedmethods
2026-05-22 09:32:38 +02:00
PrinterSupport.hxx
…
prntypes.hxx
…
ptrstyle.hxx
…
QueueInfo.hxx
tdf#146619 Use more forward declarations in include/vcl/[A-Z]*
2026-01-05 11:10:28 +01:00
quickselectionengine.hxx
…
RawBitmap.hxx
tdf#146619 Use more forward declarations in include/vcl/[A-Z]*
2026-01-05 11:10:28 +01:00
region.hxx
reduce symbol visibility in vcl
2024-03-14 19:17:08 +01:00
roadmapwizardmachine.hxx
vcl: Move RoadmapWizardMachine to own source file
2025-05-18 20:38:44 +02:00
salctype.hxx
tdf#156931 add import support for JPEG XL image format
2026-08-26 11:43:32 +02:00
salgtype.hxx
tdf#146619 Recheck include/[v-x]* with IWYU
2023-12-12 18:51:27 +01:00
salnativewidgets.hxx
Fix typos
2026-09-03 08:51:42 +02:00
Scanline.hxx
tdf#146619 Run IWYU again on include/vcl
2025-11-30 23:08:20 +01:00
scheduler.hxx
cool#11064 vcl lok: fold the scheduler info into the anyinput callback
2025-02-19 14:22:39 +01:00
scrollable.hxx
tdf#146619 Use more forward declarations in include/vcl/[q-w]*
2026-01-18 00:33:10 +01:00
seleng.hxx
tdf#146619 Use more forward declarations in include/vcl/[q-w]*
2026-01-18 00:33:10 +01:00
settings.hxx
Related tdf#121174 - Make module-specific colos non-configurable
2026-06-30 10:04:33 +02:00
sound.hxx
…
specialchars.hxx
…
split.hxx
tdf#146619 Use more forward declarations in include/vcl/[q-w]*
2026-01-18 00:33:10 +01:00
splitwin.hxx
…
status.hxx
Drop unneeded forward declarations from include/ even harder
2025-01-06 09:28:27 +01:00
stdtext.hxx
vcl: Deduplicate logic to get msg dialog title for VclMessageType
2026-03-12 07:33:16 +01:00
svapp.hxx
Return std::unique_ptr in Application::CreateMessageDialog
2026-09-16 10:35:19 +02:00
svmain.hxx
vcl: osx: clean up macOS nested ImplSVMain() hacks
2026-04-08 15:25:34 +02:00
syschild.hxx
Drop unneeded forward declarations from include/ even harder
2025-01-06 09:28:27 +01:00
sysdata.hxx
vcl: No longer make frame and widget in SystemEnvData UNX-only
2026-03-13 07:43:19 +01:00
syswin.hxx
vcl: Merge the two SystemWindow::GetWindowState variants
2026-07-19 19:30:51 +02:00
tabctrl.hxx
vcl: Drop vcl::Window::DumpAsPropertyTree
2026-06-05 08:00:44 +02:00
tabpage.hxx
vcl: Pass Window::Draw outdev param by ref
2026-05-20 00:38:47 +02:00
tabs.hrc
tdf#173043 Add translator comments to strings containing “outline”
2026-08-09 12:12:44 +02:00
task.hxx
drop some more COVERITY stuff
2025-10-20 15:05:25 +02:00
taskpanelist.hxx
tdf#146619 Use more forward declarations in include/vcl/[q-w]*
2026-01-18 00:33:10 +01:00
TaskStopwatch.hxx
loplugin:unusedmethods
2026-04-30 08:54:45 +02:00
textdata.hxx
…
texteng.hxx
tdf#146619 Use more forward declarations in include/vcl/[q-w]*
2026-01-18 00:33:10 +01:00
textfilter.hxx
loplugin:ostr in vcl
2024-05-10 18:44:00 +02:00
textrectinfo.hxx
…
textview.hxx
tdf#146619 Use more forward declarations in include/vcl/[q-w]*
2026-01-18 00:33:10 +01:00
themecolors.hxx
Related tdf#121174 - Make module-specific colos non-configurable
2026-06-30 10:04:33 +02:00
threadex.hxx
tdf#146619 Recheck include/[v-x]* with IWYU
2023-12-12 18:51:27 +01:00
timer.hxx
…
toolbox.hxx
vcl: Drop vcl::Window::DumpAsPropertyTree
2026-06-05 08:00:44 +02:00
toolboxid.hxx
tdf#146619 Recheck include/[v-x]* with IWYU
2023-12-12 18:51:27 +01:00
Toolkit.hxx
vcl: Get Toolkit from SalInstance, not SystemEnvData
2026-03-13 07:40:38 +01:00
transfer.hxx
vcl: Use ref to concrete DNDListenerContainer
2026-04-28 15:54:02 +02:00
txtattr.hxx
tdf#97228: Remove unused TextAttribProtect
2025-05-26 10:27:23 +02:00
TypeSerializer.hxx
tdf#146619 Use more forward declarations in include/vcl/[A-Z]*
2026-01-05 11:10:28 +01:00
unohelp2.hxx
tdf#146619 Use more forward declarations in include/vcl/[q-w]*
2026-01-18 00:33:10 +01:00
unohelp.hxx
tdf#146619 Use more forward declarations in include/vcl/[q-w]*
2026-01-18 00:33:10 +01:00
UserResourceScanner.hxx
tdf#146619 Use more forward declarations in include/vcl/[A-Z]*
2026-01-05 11:10:28 +01:00
vclenum.hxx
vcl: standardize Reset dialog button response code
2026-09-08 13:42:17 +02:00
vclevent.hxx
Drop unneeded forward declarations from include/
2025-01-03 09:32:27 +01:00
vcllayout.hxx
tdf#146619 Use more forward declarations in include/vcl/[q-w]*
2026-01-18 00:33:10 +01:00
vclmain.hxx
…
vclptr.hxx
use more ScopedVclPtr<VirtualDevice> in create_virtual_device
2026-02-23 17:30:22 +01:00
vclreferencebase.hxx
…
vectorgraphicdata.hxx
tdf#146619 Use more forward declarations in include/vcl/[a-o]
2026-01-22 09:42:36 +01:00
VectorGraphicSearch.hxx
tdf#146619 Use more forward declarations in include/vcl/[A-Z]*
2026-01-05 11:10:28 +01:00
virdev.hxx
Fraction->double in SetOutputSizePixelScaleOffsetAndLOKBuffer
2026-03-23 07:05:42 +01:00
wall.hxx
tdf#146619 Use more forward declarations in include/vcl/[a-o]
2026-01-22 09:42:36 +01:00
widgetbuilder.hxx
tdf#130857 vcl: Preselect combobox entry marked as active in .ui file
2026-04-04 23:45:07 +02:00
window.hxx
vcl: Rename Y-axis origin methods to Get/SetDeviceOriginY
2026-07-07 14:22:05 +02:00
WindowPosSize.hxx
tdf#146619 Recheck include/[v-x]* with IWYU
2023-12-12 18:51:27 +01:00
windowstate.hxx
vcl: Make WindowData ctor taking string explicit
2026-07-15 14:46:06 +02:00
winscheduler.hxx
…
wintypes.hxx
jsdialog: support for LinkButton as an independent widget
2024-05-03 07:13:22 +02:00
wizardmachine.hxx
weld: Move weld::Button to own header/Rename weld.hxx
2026-06-05 07:58:07 +02:00
wmf.hxx
…
wmfexternal.hxx
tdf#146619 Use more forward declarations in include/vcl/[q-w]*
2026-01-18 00:33:10 +01:00
wrkwin.hxx
vcl: nType -> eType
2025-02-18 09:44:52 +01:00
xtextedt.hxx
Drop i18nutil::SearchOptions
2023-06-28 11:06:54 +02:00