drop some more COVERITY stuff

Change-Id: Ieb15457e53a1cb68e71aea6be20a72e35f367588
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192701
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

include/vcl/task.hxx

@@ -75,7 +75,7 @@ protected:
 public:
     Task( const char *pDebugName );
     Task( const Task& rTask );
-    virtual ~Task() COVERITY_NOEXCEPT_FALSE;
+    virtual ~Task();
     Task& operator=( const Task& rTask );
 
     void            SetPriority(TaskPriority ePriority);

sc/inc/colorscale.hxx

@@ -61,7 +61,7 @@ public:
     SC_DLLPUBLIC ScColorScaleEntry();
     ScColorScaleEntry(const ScColorScaleEntry& rEntry);
     ScColorScaleEntry(ScDocument& rDoc, const ScColorScaleEntry& rEntry);
-    SC_DLLPUBLIC ~ScColorScaleEntry() COVERITY_NOEXCEPT_FALSE;
+    SC_DLLPUBLIC ~ScColorScaleEntry();
 
     const Color& GetColor() const { return maColor;}
     void SetColor(const Color&);

sc/source/core/data/colorscale.cxx

@@ -209,7 +209,7 @@ void ScColorScaleEntry::ImplDestroy()
         mpCell->EndListeningTo(mpCell->GetDocument());
 }
 
-ScColorScaleEntry::~ScColorScaleEntry() COVERITY_NOEXCEPT_FALSE
+ScColorScaleEntry::~ScColorScaleEntry()
 {
     suppress_fun_call_w_exception(ImplDestroy());
 }

sc/source/ui/unoobj/funcuno.cxx

@@ -70,7 +70,7 @@ private:
 
 public:
     explicit ScTempDocSource( ScTempDocCache& rDocCache );
-    ~ScTempDocSource() COVERITY_NOEXCEPT_FALSE;
+    ~ScTempDocSource();
 
     ScDocument*     GetDocument();
 };
@@ -97,7 +97,7 @@ ScTempDocSource::ScTempDocSource( ScTempDocCache& rDocCache ) :
     }
 }
 
-ScTempDocSource::~ScTempDocSource() COVERITY_NOEXCEPT_FALSE
+ScTempDocSource::~ScTempDocSource()
 {
     if ( !pTempDoc )
         rCache.SetInUse( false );

slideshow/source/engine/slide/slideanimations.cxx

@@ -38,7 +38,7 @@ namespace slideshow::internal
                               "SlideAnimations::SlideAnimations(): Invalid SlideShowContext" );
         }
 
-        SlideAnimations::~SlideAnimations() COVERITY_NOEXCEPT_FALSE
+        SlideAnimations::~SlideAnimations()
         {
             if( !mpRootNode )
                 return;

slideshow/source/engine/slide/slideanimations.hxx

@@ -49,7 +49,7 @@ namespace slideshow::internal
              */
             SlideAnimations( SlideShowContext      aContext,
                              const ::basegfx::B2DVector& rSlideSize );
-            ~SlideAnimations() COVERITY_NOEXCEPT_FALSE;
+            ~SlideAnimations();
 
             /** Import animations from a SMIL root animation node.
 

vcl/inc/saltimer.hxx

@@ -35,7 +35,7 @@ class VCL_PLUGIN_PUBLIC SalTimer
 
 public:
     SalTimer() : m_pProc( nullptr ) {}
-    virtual ~SalTimer() COVERITY_NOEXCEPT_FALSE;
+    virtual ~SalTimer();
 
     // AutoRepeat and Restart
     virtual void            Start( sal_uInt64 nMS ) = 0;

vcl/inc/salusereventlist.hxx

@@ -70,7 +70,7 @@ protected:
     inline bool HasUserEvents_NoLock() const;
 public:
     SalUserEventList();
-    virtual ~SalUserEventList() COVERITY_NOEXCEPT_FALSE;
+    virtual ~SalUserEventList();
 
     inline const SalFrameSet& getFrames() const;
     inline SalFrame* anyFrame() const;

vcl/source/app/salusereventlist.cxx

@@ -38,7 +38,7 @@ SalUserEventList::SalUserEventList()
 {
 }
 
-SalUserEventList::~SalUserEventList() COVERITY_NOEXCEPT_FALSE
+SalUserEventList::~SalUserEventList()
 {
 }
 

vcl/source/app/salvtables.cxx

@@ -180,7 +180,7 @@ void SalInstance::DoQuit()
         std::abort();
 }
 
-SalTimer::~SalTimer() COVERITY_NOEXCEPT_FALSE {}
+SalTimer::~SalTimer() {}
 
 void SalBitmap::DropScaledCache()
 {

vcl/source/app/scheduler.cxx

@@ -787,7 +787,7 @@ Task::Task( const Task& rTask )
         Start();
 }
 
-Task::~Task() COVERITY_NOEXCEPT_FALSE
+Task::~Task()
 {
     if ( !IsStatic() )
     {