Mike Kaganski
1dc3b23162
A placeholder clipped to an outline carries it as custom geometry, which an image shape has nowhere to keep, so the outline was dropped on load and the save wrote a plain rectangle over it. Read it into GraphicClipPolyPolygon, and write it back from there. The two directions are not equally capable. Import reads paths of literal coordinates: one driven by guides or formulas, and an arc, both need the custom-shape machinery. A quadratic curve is read, converting exactly to the cubic the model keeps. A path that states no w and h is not read either - such coordinates are absolute EMU rather than a space to scale from, and no file authored that way turned up to check the reading against. Export writes whatever polygon the model holds, so that direction loses nothing - a geometry the import gave up on was never stored. A curve that closes a contour states no end point of its own, and the point the contour started from answers for it. A path that states fill="none" states that it paints nothing, and PowerPoint leaves it out of the clip: a picture clipped by two paths shows through the plain one and not through the nofill one, while the same file with that one attribute removed - or with stroke="0" in its place - shows through both. So such a path is read past, while the shading variants and stroke="0" are not: those say how an area is painted, not whether there is one. Several paths become one polygon by area, not by concatenation: the contours of one path are filled by the even-odd rule, so two of them overlapping leave a hole, while paths are filled one after another and the shape covers what they cover together. Concatenating them instead cut a hole wherever two paths overlap, which the file does not describe and PowerPoint does not draw. A shape's own custom geometry now replaces the one it inherits, the way a preset geometry already did. Saving states the outline on the slide as well as on its layout, so reading that back gave the slide placeholder its own geometry beside the inherited one, and two geometries at once are not one this reads - the placeholder came back unclipped while PowerPoint showed the same file correctly. The outline reaches the drawing the commit before this one added, so a placeholder read from a file shows what sits behind the parts it does not cover. It survives a round-trip through ODF as well, where the property already travels as coext:graphic-clip-poly, with nothing to carry until now. Signed-off-by: Mike Kaganski <mike.kaganski@collabora.com> Change-Id: I87bd21e68bcea648c8c9151b6af5439578f1c2cf Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/9303 Tested-by: Jenkins CPCI <releng@collaboraoffice.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 04bbb74a24bad4ae54f257b6b028f3fd48955272) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210123 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
LibreOffice
LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.
A quick overview of the LibreOffice code structure.
Overview
You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs and Developers Guide. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.
The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.
The Build Chain and Runtime Baselines
These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:
- Windows:
- Runtime: Windows 10
- Build: wsl-as-helper + Visual Studio 2022
- macOS:
- Runtime: 11
- Build: 13 or later + Xcode 14.3 or later (using latest version available for a given version of macOS)
- Linux:
- Runtime: RHEL 9 or CentOS 9 and comparable
- Build: either GCC 13; or Clang 18 with libstdc++ 11
- iOS (only for LibreOfficeKit):
- Runtime: 14.5 (only support for newer i devices == 64 bit)
- Build: Xcode 12.5 and iPhone SDK 14.5
- Android:
- Build: NDK 27 and SDK 30.0.3
- Emscripten / WASM:
- Runtime: a browser with SharedMemory support (threads + atomics)
- Build: Qt 5.15 with Qt supported Emscripten 1.39.8
- See README.wasm
Java is required for building many parts of LibreOffice. In TDF Wiki article Development/Java, the exact modules that depend on Java are listed.
The baseline for Java is Java Development Kit (JDK) Version 17 or later.
The baseline for Python is version 3.11. It follows the version available in SUSE Linux Enterprise Desktop and the Maintenance Support version of Red Hat Enterprise Linux.
If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 18. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.
You can find the TDF configure switches in the distro-configs/ directory.
To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.
For more information see the build instructions for your platform in the TDF wiki.
The Important Bits of Code
Each module should have a README.md file inside it which has some
degree of documentation for that module; patches are most welcome to
improve those. We have those turned into a web page here:
However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:
| Module | Description |
|---|---|
| sal/ | this provides a simple System Abstraction Layer |
| tools/ | this provides basic internal types: Rectangle, Color etc. |
| vcl/ | this is the widget toolkit library and one rendering abstraction |
| framework/ | UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files |
| sfx2/ | legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc. |
| svx/ | drawing model related helper code, including much of Draw/Impress |
Then applications
| Module | Description |
|---|---|
| desktop/ | this is where the main() for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop |
| sw/ | Writer |
| sc/ | Calc |
| sd/ | Draw / Impress |
There are several other libraries that are helpful from a graphical perspective:
| Module | Description |
|---|---|
| basegfx/ | algorithms and data-types for graphics as used in the canvas |
| canvas/ | new (UNO) canvas rendering model with various backends |
| cppcanvas/ | C++ helper classes for using the UNO canvas |
| drawinglayer/ | View code to render drawable objects and break them down into primitives we can render more easily. |
Rules for #include Directives (C/C++)
Use the "..." form if and only if the included file is found next to the
including file. Otherwise, use the <...> form. (For further details, see the
mail Re: C[++]: Normalizing include syntax ("" vs
<>).)
The UNO API include files should consistently use double quotes, for the benefit of external users of this API.
loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.
Finding Out More
Beyond this, you can read the README.md files, send us patches, ask
on the mailing list libreoffice@lists.freedesktop.org (no subscription
required) or poke people on IRC #libreoffice-dev on irc.libera.chat -
we're a friendly and generally helpful mob. We know the code can be
hard to get into at first, and so there are no silly questions.
SAST Tools
PVS-Studio - static analyzer for C, C++, C#, and Java code.