Caolán McNamara
fcbb911c70
add example of %notify=NONE and %notify=OWNER
...
Change-Id: Icda847105524c9021b3105c85cc1f4d949c2d1c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191777
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-10-02 18:57:08 +02:00
Caolán McNamara
ccebcef309
fix: Theme parsing error: Not using units is deprecated. Assuming 'px'
...
Change-Id: I33d47ea088ffc870d61db383ae93409bf272ee75
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191776
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-10-02 18:57:00 +02:00
Caolán McNamara
992fd7689e
scale without adjustment
...
Change-Id: I302687bb7b226d91b5a53781b0e459afd8bc7e50
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190986
Reviewed-by: Miklos Vajna <vmiklos@collabora.com >
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com >
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191774
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-10-02 17:52:16 +02:00
Caolán McNamara
7590fde54b
add test for vertical placement of exploded pdf
...
Change-Id: I05c608a18e5b714a611bc986b88721521456b3d3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190985
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com >
Reviewed-by: Miklos Vajna <vmiklos@collabora.com >
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191773
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-10-02 15:44:57 +02:00
Caolán McNamara
6bcbed0f57
match pdf text size and vertical positioning
...
Change-Id: Icaf9630ee287b817685cc74de0fcf85522937c11
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190984
Reviewed-by: Miklos Vajna <vmiklos@collabora.com >
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com >
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191772
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-10-02 15:44:47 +02:00
Caolán McNamara
a44927269b
use same map mode that line breaking will use
...
Change-Id: I29fd267e21f246d2de9bc3f75675b1465a0a6dfa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190983
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com >
Reviewed-by: Miklos Vajna <vmiklos@collabora.com >
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191771
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-10-02 15:44:32 +02:00
Caolán McNamara
643930454b
use same reference device DPI that draw/impress uses
...
Change-Id: I738b5cc3527eceb1536ba5c2eca7a6240976f684
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190982
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com >
Reviewed-by: Miklos Vajna <vmiklos@collabora.com >
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191770
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-10-02 15:44:17 +02:00
Caolán McNamara
b93f880259
add basic test of exploding pdf
...
Change-Id: I96c070a072af45c3b361f34d769832a5f047d748
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190975
Reviewed-by: Miklos Vajna <vmiklos@collabora.com >
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com >
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191769
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-10-02 15:36:00 +02:00
Caolán McNamara
5f3d9649ab
optionally explode pdf into odf elements as fodg export time
...
e.g. instdir/program/soffice --headless --convert-to \
'fodg:OpenDocument Drawing Flat XML:{"DecomposePDF":{"type":"boolean","value":"true"}}' \
sample.pdf
Change-Id: I1e36b3d0c12e8716aada52e5d34526d06fe28cc5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190967
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com >
Reviewed-by: Miklos Vajna <vmiklos@collabora.com >
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191768
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-10-02 14:00:48 +02:00
Caolán McNamara
c851462409
add FilterOptions to ODF export
...
support Json string here like pdf export does. Just one property
initially so extract the single thing supported as now to a bool
in the Impl.
Change-Id: I59d94a9147595a55236847c2f450b3c11c60e5ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190966
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com >
Reviewed-by: Miklos Vajna <vmiklos@collabora.com >
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191763
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-10-02 11:57:55 +02:00
Caolán McNamara
ae2f5a5774
cid#1666419 Uninitialized pointer field
...
Change-Id: I65e80f0f344d2659d487bd8567f36f9a43a9458b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191759
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-10-02 10:32:43 +02:00
Caolán McNamara
1771937962
const up openssl more
...
Change-Id: I239dbba7716fecdacbf52c36405cf403769d68c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188368
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-29 11:12:46 +02:00
Caolán McNamara and Noel Grandin
2b515d095d
upgrade pixman and cairo
...
Co-authored-by: Noel Grandin <noel.grandin@collabora.co.uk >
Change-Id: I21b8c772138b544d3192b786a6bae4c64ebcac94
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191199
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-27 21:38:46 +02:00
Caolán McNamara
e2a855623d
create dummy pkgconfig file for internal libpng
...
Change-Id: Ic2d58898c804d1fea1959a94aafdd14afd19e0b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191516
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-26 20:25:03 +02:00
Caolán McNamara
5763df08a4
create dummy pkgconfig file for internal zlib
...
Change-Id: Ie1c0a62779fe72afdcad7aa29b1eb2898ab75825
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191503
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-09-25 20:56:21 +02:00
Caolán McNamara
e44a2c4f0f
cid#1666412 Result is not floating-point
...
and
cid#1666413 Result is not floating-point
Change-Id: I884d4c23159ef173ede9f4c03a3c3a9814161ca5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191478
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-09-25 10:58:55 +02:00
Caolán McNamara
38e8b08b92
tweak fontconfig configure to set pkgconfig include/lib dirs to build locations
...
Change-Id: I00ffd3de87157fdcdeaae6862ff6bc0445a79ab6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191388
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-09-25 10:49:39 +02:00
Caolán McNamara
89ef80185c
deadlock on iOS if launched from a non-main thread too
...
The same problem mentioned in:
commit 123c7b8044https://gerrit.libreoffice.org/c/core/+/190619
Reviewed-by: Skyler Grey <skyler.grey@collabora.com >
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com >
(cherry picked from commit 11967c72b20b27972aa29c246101bb6da39b456a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191315
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-22 13:53:52 +02:00
Caolán McNamara
edc6033e39
don't require pkg-config on macOS either
...
Change-Id: Icaca4f047060c73dee9562385fb3d5e3f6b99cd6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191316
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-22 12:46:03 +02:00
Caolán McNamara
9d584509f7
cid#1666316 Uninitialized pointer field
...
Change-Id: I0225372b5e3741033eb0a9ecff1583f24f0f16ef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191309
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-22 11:17:35 +02:00
Caolán McNamara
f27daa7b39
cid#1666319 Division or modulo by float zero
...
Change-Id: I3babfb373fe6c3b5b3738c9d70368b236efd4d20
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191285
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-21 15:51:04 +02:00
Caolán McNamara
80b5fff947
cid#1666320 Variable copied when it could be moved
...
and
cid#1666318 Variable copied when it could be moved
Change-Id: Ib06132040d9c201c53464953975fa08ee0a2dc10
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191283
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-21 13:11:19 +02:00
Caolán McNamara
4b23066f6e
cid#1666317 Logically dead code
...
Change-Id: Ia039d52bf45c80df81fc1cb3c0242940a800f1bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191284
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-21 13:10:26 +02:00
Caolán McNamara
9ee57c6ac2
don't split surrogate pairs in line breaking
...
Change-Id: I66e25d3a4e2f360d63bdf7895b1a7d6c8bb0dcfc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191188
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-19 13:35:53 +02:00
Caolán McNamara
33f5ab8172
cid#1665431 Dereference null return value
...
Change-Id: Icba6d8bdc8f07c8125c7c4784f93c19dd7d1bd7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191000
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-16 13:38:28 +02:00
Caolán McNamara
92946dc006
cid#1660287 silence Overflowed constant
...
Change-Id: I2158a8ccfdf7d463fdb30fabfa338427cf9b02f6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190998
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-16 09:21:11 +02:00
Caolán McNamara
7a949f651e
cid#1660155 Division or modulo by float zero
...
Change-Id: I1ce2be046b3a9504e00b45d6d96b2630ecac5447
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190997
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-09-16 09:21:05 +02:00
Caolán McNamara
41182ce78c
cid#1660276 silence Division or modulo by float zero
...
Change-Id: Icd58779009aea80836510d7c13093fee0e425e0f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190996
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-16 09:20:58 +02:00
Caolán McNamara
b8e20e1bdf
cid#1665432 Variable copied when it could be moved
...
Change-Id: I1515f7254d6880eea0220bd79d06b708da0fc663
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190995
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-09-16 09:20:40 +02:00
Caolán McNamara
830a06afe2
Resolves: tdf#168306 set current line width at popup time
...
Change-Id: I82c8151566459d1429cd3b4517b43ace3fbeca60
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190934
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-14 22:02:58 +02:00
Caolán McNamara
178622b89b
some unused suppressions
...
Change-Id: I0a9c29f7481ea6ad1b7067163c2a04dddc0c1591
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190925
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-14 12:12:32 +02:00
Caolán McNamara
f4e2563012
Resolves: tdf#156739 implement dnd for menu/toolbar customization pages
...
dubious as a regression, but can be done now regardless
Change-Id: I67bc322cd63e65b5347b3e54651e3618d09a99b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190917
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-09-14 12:12:25 +02:00
Caolán McNamara
741695ee60
ofz#442170526 webp Out-of-memory
...
Change-Id: Iafee871926668f02380113da3e381194bd9fc3d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190864
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-09-12 14:48:26 +02:00
Caolán McNamara
5de3f31897
there is no difference between PixelMode::Split and PixelMode::Direct
...
Change-Id: I6b8f588c3ced2a7f9e864d9de67a15f1ad55035a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190863
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-09-12 14:47:35 +02:00
Caolán McNamara
3fbe7459d5
ofz#444495246 avoid timeout when fuzzing
...
Change-Id: I2c1df68551300fa4b32cf20346b01d86bdcb85c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190866
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-12 13:51:08 +02:00
Caolán McNamara
dedf0c1bcb
cid#1659918 Data race condition
...
and
cid#1660133 Data race condition
cid#1660238 Data race condition
etc.
Change-Id: Ic0278e430c62abda92e8ce0e590a4726a4488b30
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190791
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-12 09:37:43 +02:00
Caolán McNamara
9b74900076
ofz#442383407 Integer-overflow
...
Change-Id: I96c62fd03a6c7b4c5e1ddaa62df4bb577fbdb8ae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190812
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-09-11 18:14:53 +02:00
Caolán McNamara
65d88dde31
cid#1660311 silence Division or modulo by float zero
...
and
cid#1660494 Division or modulo by float zero
Change-Id: Ib3b27ab2ea527bea62e70910dffc0892be0b1532
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190792
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-09-11 16:20:00 +02:00
Caolán McNamara
329465f19d
ofz#438873386 pngfuzzer Out-of-memory
...
we can skip the intermediate buffer now and use
the bitmap data itself as the buffer.
Change-Id: Ifea467ca16ffb5a6f5b1b88dfb08f9a0426168f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190797
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-11 16:03:13 +02:00
Caolán McNamara
d3cd09eae4
PNG_COLOR_TYPE_RGB_ALPHA and PNG_COLOR_TYPE_RGBA are the same thing
...
use one consistently
Change-Id: Ie36fb9e30c5d82e435ee3d245d0ad3d132a15e65
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190796
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-09-11 13:02:14 +02:00
Caolán McNamara
2827bd9e46
move ItemInfoPackageSwAttributes to SwModule
...
for the edgecase that DeInitVCL isn't called during lokit teardown,
so in a dbgutil version the SolarMutex assert fires when the
g_aItemInfoPackageSwAttributes is destroyed on exit because DeInitVCL
unsets the pDbgTestSolarMutex pointer
In this scenario the SwDLL is still destoyed at a sensible time due
to the unique_disposing_solar_mutex_reset_ptr SwDLLInstance. So move
the ItemInfoPackageSwAttributes to someplace which SwDLLInstance
shutdown can clear it, SwModule seems like the sensible place as
its the owner of the primorial SwAttrPool, so make SwModule
own the ItemInfoPackageSwAttributes
Change-Id: I0f075ee5b488df5a8011648457779eddbbd95c37
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190207
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com >
Reviewed-by: Miklos Vajna <vmiklos@collabora.com >
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190736
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-10 13:04:00 +02:00
Caolán McNamara
aa46db406f
Resolves: tdf#152129 Save/IsChanged for the SvxRectCTL
...
looks to me that we should make this behave like other controls
and generally set the m_eDefRP when explicitly asked to save
so that "Reset" resets back to that saved value.
And then we can check if the control is "changed" by comparison
of m_eDefRP vs m_eRP and use that to apply the properties.
Change-Id: Icef87fb7e3dd653267e6882f4e8d22adb3e0ff68
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190694
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-09 14:03:45 +02:00
Caolán McNamara
999bc1cd15
cid#1660284 Dereference null return value
...
Change-Id: Icee3c790d4f541841e6010c4f10e07026e5fb94f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190645
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-09-07 22:30:37 +02:00
Caolán McNamara
3c43863a56
cid#1665183 silence Logically dead code
...
Change-Id: I051bb812d885a084770d607917649555c6e2c9ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190638
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-06 15:32:00 +02:00
Caolán McNamara
71a13b0369
Related: cid#1660010 don't need this now
...
Change-Id: Ie243d8c58598ef1653fd31608fc7dc426a7d6779
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190637
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-06 14:17:46 +02:00
Caolán McNamara
0c72ae925e
cid#1665283 Variable copied when it could be moved
...
and
cid#1665282 Variable copied when it could be moved
cid#1665279 Variable copied when it could be moved
cid#1665278 Variable copied when it could be moved
cid#1665276 Variable copied when it could be moved
cid#1665275 Variable copied when it could be moved
cid#1665257 Variable copied when it could be moved
Change-Id: I222860c6385693610b95f4d674d4d0da59e75a5f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190635
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-06 12:36:30 +02:00
Caolán McNamara
38f4e1c84e
cid#1665261 Argument cannot be negative
...
and approx 24 other similar cases
Change-Id: I6bd05c61f6d1b7fcd983947ec4fa677f1c9ad2f8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190634
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-06 12:36:23 +02:00
Caolán McNamara
653fbde736
cid#1665272 Uninitialized scalar variable
...
Change-Id: I1930f0941994cac6d5a987595a591d1e0a00d050
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190633
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-09-06 12:35:42 +02:00
Caolán McNamara
9c73fcad37
cid#1660010 silence Overflowed constant
...
Change-Id: I8b02798e933404737711bbf776917a9d406d42a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190519
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-02 16:22:37 +02:00
Caolán McNamara
4d3ca43ac7
cid#1659708 Data race condition
...
Change-Id: I599782383b48417841854fbf0cea213b3316e18d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190518
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-02 16:16:22 +02:00
Caolán McNamara
87a553be37
cid#1665198 'Constant' variable guards dead code
...
dead code now since:
commit e7b460f919https://gerrit.libreoffice.org/c/core/+/190517
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-02 16:15:37 +02:00
Caolán McNamara
325cf2232d
cid#1665199 Variable copied when it could be moved
...
Change-Id: Ibcda574263358ab31cb80d304aa505033ffc8c51
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190516
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-02 16:15:23 +02:00
Caolán McNamara
70eaa5f7c5
cid#1665183 Logically dead code
...
Change-Id: I15991fac2f31b09d53a0d7c5dc30d40992fd70f1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190442
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-09-01 09:18:03 +02:00
Caolán McNamara
b644eb81c7
cid#1660394 silence Division or modulo by float zero
...
Change-Id: I26bf7ad7bfd0164d158239f73ccd7b822490a5b8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190446
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-09-01 09:17:55 +02:00
Caolán McNamara
a91ceefcad
cid#1660530 silence Data race condition
...
rejig this so coverity is satisfied
Change-Id: Iad58f680b6f6fe879866c0162a88a3439af2c3f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190445
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-01 09:17:48 +02:00
Caolán McNamara
51781f04b6
cid#1660144 silence bogus Data race condition
...
Change-Id: I023214c154ab3a44fca3b3b504c20b4670da2f99
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190444
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-01 09:17:06 +02:00
Caolán McNamara
756adb5751
cid#1665185 silence Untrusted loop bound
...
like the other "makers" in the module
Change-Id: Idb8a672e422690a09240d4508bbd07d8d9091bea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190443
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-09-01 09:16:30 +02:00
Caolán McNamara
d929702e83
cid#1665188 Variable copied when it could be moved
...
and
cid#1665187 Variable copied when it could be moved
cid#1665186 Variable copied when it could be moved
cid#1665184 Variable copied when it could be moved
Change-Id: If36872293c53263ad2a42b06463c9b50c243068d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190441
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-08-31 22:23:21 +02:00
Caolán McNamara
248ff6232d
crashtesting: fix assert
...
nNumer is > 0 but isn't less than 8, thinko of mine there
Change-Id: I6e0c5a1f3862b2b0f440092eb39f639e5c70cb18
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190145
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-08-25 00:15:21 +02:00
Caolán McNamara
1cecf9f2a4
cid#1660010 Overflowed constant
...
Change-Id: Ie8d50e3178713029197a1df3a80ce3319c0f77ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190107
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-08-23 22:05:20 +02:00
Caolán McNamara
6dfe95364d
cid#1665122 silence bogus Bad bit shift operation
...
Change-Id: I12783972fba8f37288eeed0a109e0b8453f6fef6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190099
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-08-23 17:28:50 +02:00
Caolán McNamara
172dab3ee4
cid#1665121 silence bogus Improper use of negative value
...
Change-Id: If6455f30d9634eaa427cb7221b904ac6c3fe1a9c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190088
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-08-23 14:36:13 +02:00
Caolán McNamara
d54453ef49
cid#1660072 Overflowed return value
...
Change-Id: I71d6ac5321d500c1cef16c118be758edca01a26f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190087
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-08-23 14:36:06 +02:00
Caolán McNamara
f71d0ce6d9
cid#1660550 silence Division or modulo by float zero
...
Change-Id: Ib6c176b3c6429294ef582d9dc392f1a355c4e8a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190086
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-08-23 14:35:59 +02:00
Caolán McNamara
c5bd87c788
cid#1659646 Data race condition
...
minimal no-real-change effort
Change-Id: Ie4e54400d321a9396bc2efe62230be5a2f36f535
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190029
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-08-23 10:58:13 +02:00
Caolán McNamara
a6dc33e5b4
Resolves: tdf#156297 restore copy area optimization
...
This reverts commit 344d90b20bdf95e9888f916672bbe51a5d700d02.
"tdf#152094 don't attempt scroll paint optimization for devices with a mapmode"
It slows calc scroll down too much, and things have moved on with text
placement otherwise, so this hack is possibly redundant anyway.
Change-Id: Ic4337e71ddd38250a1e5e305acb97b3f1a93f20c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190054
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-08-22 13:10:23 +02:00
Caolán McNamara
dfa2688357
gtk: Don't force redraw if "resize" didn't resize
...
rather spurious resize events seen on pressing and holding gtk scrollbar
in calc in tdf#156297 where the main topic is windows/gen
Change-Id: I65591a09be1d3e3f5a92407df8a550a6bc2296d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190050
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-08-22 13:09:16 +02:00
Caolán McNamara
a527d8da15
cid#1665118 suppress Overflowed return value
...
and
cid#1665116 Overflowed return value
Change-Id: Ibd6447909d89fe9523aa5d0653155e0b859dcf93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190028
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-08-21 22:13:26 +02:00
Caolán McNamara
3fba303985
cid#1665114 Variable copied when it could be moved
...
and
cid#1665115 Variable copied when it could be moved
Change-Id: I7ebc4baeae449f969e58fbd167149d010e0f043a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190025
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-08-21 21:51:10 +02:00
Caolán McNamara
7d2b92d0e7
Resolves: tdf#150743 disable keep ratio is any value is zero
...
can't divide by zero
Change-Id: Ia6f60e1614a621cee7eaa6029cf0eefda32210bc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189997
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-08-21 15:04:19 +02:00
Caolán McNamara
fd47b9073d
cid#1660323 silence Division or modulo by float zero
...
Change-Id: I49f88360697ceb7a7461b964a0b6ba9122c60c19
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189965
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-08-20 15:30:57 +02:00
Caolán McNamara
be6015e3c4
cid#1659971 silence Overflowed return value
...
and
cid#1659699 Overflowed return value
cid#1659759 Overflowed return value
cid#1659922 Overflowed return value
cid#1660190 Overflowed return value
cid#1660286 Overflowed return value
cid#1660457 Overflowed return value
Change-Id: Ie9fffe4994b10ed3d4feb14eaf7950e3f01714ef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189927
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-08-20 15:08:44 +02:00
Caolán McNamara
5cdefeef2a
Resolves: tdf#168017 fix a crash loading some documents
...
a problem since:
commit 6e870c040bhttps://gerrit.libreoffice.org/c/core/+/189956
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-08-20 14:54:46 +02:00
Caolán McNamara
24232da6d4
cid#1660808 Big parameter passed by value
...
and
cid#1660812 Big parameter passed by value
cid#1660820 Big parameter passed by value
cid#1660823 Big parameter passed by value
Change-Id: I13d0de398089681f3cabd75499f772e75a313541
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189961
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-08-20 14:41:11 +02:00
Caolán McNamara
9e5b85ca52
cid#1660543 avoid Division or modulo by float zero
...
rather feeble effort
Change-Id: Ibefe91d44877288668839d0593987a14bff4c51a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189962
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-08-20 14:20:29 +02:00
Caolán McNamara
7aab3f08de
cid#1662039 Data race condition
...
Change-Id: I58ed464b9f49ddf12f21995f08a8a70f430e2669
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189930
Reviewed-by: Michael Stahl <michael.stahl@collabora.com >
Tested-by: Jenkins
2025-08-20 11:00:44 +02:00
Caolán McNamara
3f3aed0045
cid#1642989 Wait without held lock
...
restore the lock at the end of SerfLockStore::stopTicker
SerfLockStore::removeLockImpl calls this, and that is called
by SerfLockStore::refreshLocks in a loop, so if it was unlocked
at the end of the first loop, then its still unlocked on a 2nd
loop.
Probably doesn't matter as there's only a 2nd unlock attempt
if m_aLockInfoMap.empty() which presumably can only happen once.
Change-Id: Iede91b1b4ef9368bcf4e62cb85bf5a0c745e0ba7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189058
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-08-20 09:27:02 +02:00
Caolán McNamara
dc584b4dd8
always pass fCandidateLength in at the boundary
...
Change-Id: Idcddf4e576bb74f241c532fbf66b8772f3cd1c6f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189932
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-08-20 09:25:44 +02:00
Caolán McNamara
910dcef906
cid#1664876 silence Overflowed integer argument
...
and
cid#1664874 Overflowed integer argument
Change-Id: I7b1000f0032bd70f53e09de44815f13f55489a53
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189931
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-08-20 09:25:34 +02:00
Caolán McNamara
0649349f62
cid#1660817 silence Dereference before null check
...
Change-Id: I819d08876eb53238692d80030248fe8dc177409e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189929
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-08-20 09:24:58 +02:00
Caolán McNamara
eb9056a854
cid#1660249 silence Division or modulo by float zero
...
Change-Id: Iee59ecdb3bde87efa05257c03d78ef0f77afcff9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189928
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-08-19 22:31:14 +02:00
Caolán McNamara
b8f891d87e
don't export an empty tables tag in connections.xml
...
Change-Id: Idd8f03e0964610c22082266988e3e48f4f7cf1eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189919
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-08-19 18:31:09 +02:00
Caolán McNamara
d0829662d5
add a constructor to TStorageInfo
...
Change-Id: I74cd5c9a82976e5cfb31fe622db543e8133bfee1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189863
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-08-18 18:02:15 +02:00
Caolán McNamara
d4ab276bcd
null deref of StyleSheetPool seen
...
#0 0x00007fca2fa09df2 in std::__shared_ptr<svl::IndexedStyleSheets, (__gnu_cxx::_Lock_policy)2>::get (this=<optimized out>)
at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/shared_ptr_base.h:1665
#1 std::__shared_ptr_access<svl::IndexedStyleSheets, (__gnu_cxx::_Lock_policy)2, false, false>::_M_get (this=<optimized out>)
at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/shared_ptr_base.h:1363
#2 std::__shared_ptr_access<svl::IndexedStyleSheets, (__gnu_cxx::_Lock_policy)2, false, false>::operator-> (
this=<optimized out>) at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/shared_ptr_base.h:1357
#3 SfxStyleSheetIterator::Find(rtl::OUString const&) () at svl/source/items/style.cxx:525
#4 0x00007fca2fa0b406 in SfxStyleSheetBasePool::Find(rtl::OUString const&, SfxStyleFamily, SfxStyleSearchBits) [clone .localalias] () at svl/source/items/style.cxx:722
#5 0x00007fca1f228c76 in oox::xls::CellStyle::createCellStyle() ()
at include/unotools/resmgr.hxx:41
#6 0x00007fca1f229c11 in oox::xls::CellStyleBuffer::createCellStyle (
rxCellStyle=std::shared_ptr<oox::xls::CellStyle> (use count 3, weak count 0) = {...})
at sc/source/filter/oox/stylesbuffer.cxx:2804
#7 oox::xls::CellStyleBuffer::getDefaultStyleName (this=0x3c4ea458)
at sc/source/filter/oox/stylesbuffer.cxx:2759
#8 oox::xls::StylesBuffer::getDefaultStyleName (this=0x3c4ea350)
at sc/source/filter/oox/stylesbuffer.cxx:3008
#9 0x00007fca1f26c762 in oox::xls::WorksheetGlobals::initializeWorksheetImport() ()
at sc/source/filter/oox/worksheethelper.cxx:923
#10 0x00007fca1f26c7dd in oox::xls::WorksheetHelper::initializeWorksheetImport (this=this@entry=0x3c594168)
at sc/source/filter/oox/worksheethelper.cxx:1614
#11 0x00007fca1f262e34 in oox::xls::WorksheetFragment::initializeImport() ()
at sc/source/filter/oox/worksheetfragment.cxx:616
Change-Id: I5bc25e361da17b811af4e552ca74b4becf0181ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189832
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-08-18 18:02:05 +02:00
Caolán McNamara
f2eda851f7
cid#1660547 avoid Division or modulo by float zero warning
...
and
cid#1659880 Division or modulo by float zero
drop the default arguments, they are always explicitly set
except for one single case.
Change-Id: I1fce4e7f6ff5c9421c40628e0b6a1e291650e51c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189862
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-08-18 16:30:36 +02:00
Caolán McNamara
003449bd9f
reduce the 'Returnvalue has wrong Type' log spam
...
if there was no result found don't misleadingly warn that it's of the
wrong type
Change-Id: I647c847e68a6ac7ca93f7fc860a8e376acce06e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189853
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-08-18 14:04:42 +02:00
Caolán McNamara
7841de4bf7
drop outdated coverity directives
...
Change-Id: Icbe3f0bb9433cfcf08efd28bc4eab1ba82efab74
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189850
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-08-18 12:40:58 +02:00
Caolán McNamara
3e77ce3e93
ofz#439092820 Null-dereference READ
...
Change-Id: I765d5959c4edfcd326c3bce453ddc97c1aeae889
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189830
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-08-18 11:02:49 +02:00
Caolán McNamara
0a6e131e12
cid#1664819 Unchecked return value
...
and
cid#1664820 Unchecked return value
Change-Id: I55e6ecdb6a16b5b8b461ac542874eca0f421de07
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189826
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-08-17 15:35:00 +02:00
Caolán McNamara
2df011d176
cid#1664822 silence Uncaught exception
...
Change-Id: I417bdfaf9b5bc09a3ff3472d288bc36dc2cb11d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189825
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-08-17 15:34:40 +02:00
Caolán McNamara
23f77eb0e2
cid#1660546 suppress Division or modulo by float zero
...
in spreadsheet related code, similar to runtime cases of
bin/sanitize-excludelist.txt but probably more dubious.
also:
cid#1660554 Division or modulo by float zero
cid#1660545 Division or modulo by float zero
cid#1660527 Division or modulo by float zero
cid#1660501 Division or modulo by float zero
cid#1660485 Division or modulo by float zero
cid#1660442 Division or modulo by float zero
cid#1660396 Division or modulo by float zero
cid#1660241 Division or modulo by float zero
cid#1660134 Division or modulo by float zero
cid#1660066 Division or modulo by float zero
cid#1659994 Division or modulo by float zero
cid#1659979 Division or modulo by float zero
cid#1659964 Division or modulo by float zero
cid#1659940 Division or modulo by float zero
cid#1659913 Division or modulo by float zero
cid#1659893 Division or modulo by float zero
cid#1659890 Division or modulo by float zero
cid#1659868 Division or modulo by float zero
cid#1659745 Division or modulo by float zero
cid#1659721 Division or modulo by float zero
cid#1659711 Division or modulo by float zero
cid#1659611 Division or modulo by float zero
cid#1659814 Division or modulo by float zero
Change-Id: I29830cad3170e5e45348f7bd4e08f028d21a4543
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189823
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-08-17 15:34:28 +02:00
Caolán McNamara
9a9d8f6ed3
cid#1660798 silence Overflowed constant
...
Change-Id: I0e94d3fdb67f05ddf7078267dfdcb85e10972718
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189822
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-08-17 15:33:55 +02:00
Caolán McNamara
b60a410a90
cid#1660532 Overflowed constant
...
Change-Id: Id0e494aa0465e6c04c7a8210597be891b734c461
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189821
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-08-17 15:33:35 +02:00
Caolán McNamara
72e538b9bd
tainted_data_return is deprecated
...
in favour of taint_source, lets drop them all first
Change-Id: I9c4e5c143fcbd6de9491360c993a8ea1b89a726e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189820
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-08-17 15:33:16 +02:00
Caolán McNamara
598c7deeb4
cid#1664821 Resource leak
...
Change-Id: Id9b071d63a3245501bc3c5501279d290a44ea936
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189818
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-08-17 15:32:48 +02:00
Caolán McNamara
9fc99321c1
Resolves: tdf#141033 make combobox max width the same as editboxes
...
i.e. 30 chars wide, otherwise a long table name will stretch the
page too wide to be useful
Change-Id: I65151e864f178de0236cb35d133830c8bca95b9f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189808
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-08-17 12:31:24 +02:00
Caolán McNamara
84e9f30fef
cid#1660340 silence Division or modulo by float zero
...
and
cid#1660450 silence Division or modulo by float zero
we're guarded against this already
Change-Id: I4ef9a8febccfc34b7be8514e4c0720307960dcb1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189726
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-08-16 15:13:09 +02:00
Caolán McNamara
73b5a1e2af
cid#1660019 silence Division or modulo by zero
...
and
cid#1659794 Division or modulo by zero
Change-Id: I7e8289992e071994389caf8077b6c6e1d3ce5c1d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189673
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-08-15 13:49:24 +02:00
Caolán McNamara
d3fcc9a5b6
drop apparently no longer needed coverity markup
...
Change-Id: Ia8b3b271bb5cc67131b50d563bed58400da5b317
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189662
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Tested-by: Jenkins
2025-08-15 11:25:12 +02:00
Caolán McNamara
6d1841c1e6
cid#1664055 Variable copied when it could be moved
...
Change-Id: I6dcdb52011ad3461cb34209ae1429d35c5450866
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189661
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com >
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com >
2025-08-15 11:25:05 +02:00
Caolán McNamara