ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
501,636 Commits 3 Branches 3 Tags
f1ab6d3e046c261ac0cc0de35bed3e61ba052dca
Commit Graph
14572 Commits
Author SHA1 Message Date
Noel Grandin 193207c5ab improve loplugin passparamsbyref 
I think I managed to disable this when I converted it to
use the shared plugin infrastructure.

So fix that, and then make it much smarter to avoid various
false positives.

Change-Id: I0a4657cff3b40a00434924bf764d024dbfd7d5b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176646
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-11-19 07:46:25 +01:00
Adam Seskunas 37e082bd2b dbaccess/qa - Seperate database connection so it can be reused 
Change-Id: I982cf589aff159149190c7f0f78dc8085a700240
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174981
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2024-11-18 10:06:15 +01:00
Julien Nabet bf0374b64e tdf#130564: getTableTypes retrieves only table types of the current database 
So indicate to LO that at least PostgreSQL and MySQL/MariaDB support views

Change-Id: I241fa3cfc599e11c1f1523a78a1905beadc80307
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176308
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2024-11-15 16:56:43 +01:00
Stephan Bergmann 86b86ac87e Give DocumentEventHolder (aka EventHolder<DocumentEvent>) a key function 
...that is not inline, so that RTTI and vtable are not emitted for each dynamic
library individually.  (Where they would be internal on macOS, which could break
optimized uses of dynamic_cast for that final class just checking vtable pointer
identity, as could happen for the dynamic_cast at
dbaccess/source/core/dataaccess/documenteventnotifier.cxx:232:51,

>   232 |         const DocumentEventHolder& rEventHolder = dynamic_cast< const DocumentEventHolder& >( _rEvent );
>       |                                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

And with the extern explicit template instantiation, EventHolder needs to be
SAL_DLLPUBLIC_TEMPLATE instead of just SAL_DLLPUBLIC_RTTI now, so that
Library_comphelper will export the DocumentEventHolder ctors and
DocumentEventHolder::getEventObject.)

(This would ideally have been caught by an upcoming improvement of
loplugin:dyncastvisibility, but might be complicated to check there for template
instantiations.)

Change-Id: I1e6280b185535968a870fbfadaff6238d38858e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176547
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
 2024-11-14 11:10:30 +01:00
Noel Grandin fb745b54d2 new loplugin:reftotemp 
look for places where we are taking a reference (i.e. "&") to a
temporary object, which is misleading.

Change-Id: Id0eb4dce3f1ca559f86e02edcbea3ca17bea8e76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175978
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2024-11-13 13:08:16 +01:00
Oromidayo Owolabi 7a7ba9cbee tdf#145614 Convert #define to enum class 
Converted #define to enum class

Change-Id: I16195a439643bcf0111c591a829272b5bf70179d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175027
Reviewed-by: Hossein   <hossein@libreoffice.org>
Tested-by: Jenkins
 2024-11-12 15:27:34 +01:00
Noel Grandin 681c7292b2 clang-tidy: performance-unnecessary-copy-initialization in dbaccess 
Change-Id: If72f9eea59e5f2a4e183b98888a037ea26333cb8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176377
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2024-11-11 10:58:19 +01:00
Mike Kaganski 1180b3473a com::sun::star -> css 
Change-Id: I890ec73e30d3cc6b210903ecee29431f3cb5f635
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175979
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2024-11-10 10:50:15 +01:00
Noel Grandin 5962006370 loplugin:reftotemp in dbaccess..editeng 
Change-Id: I51f5e47fb2fca37928ac58952a6a34b7351ca53c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176277
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2024-11-08 19:38:38 +01:00
Noel Grandin ed0b12f4ea no need to take a copy of the getProcessComponentContext return value 
we can just take a "const &".

(found by running clang-tidy with the
performance-unnecessary-copy-initialization warning)

Change-Id: I20fd208c65303da78170b1ac06c638fdf3aa094b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176267
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2024-11-08 15:23:52 +01:00
Mike Kaganski 56f3dbffdf Simplify a bit 
Change-Id: I618b0f8bcb2e8032ee12367c73e1136685f66b3e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176183
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2024-11-08 05:34:20 +01:00
Noel Grandin 2de45b8557 loplugin:passstuffbyref in cui..dbaccess 
Change-Id: Ie15974919f7c0764e661225ef14a9f50917ab083
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176189
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2024-11-07 14:30:52 +01:00
Michael Weghorn 92a36bbd4f [API CHANGE] a11y: Switch AccessibleRelationType to enum 
Switch css::accessibility::AccessibleRelationType
from integer constants to an enum.

This provides more type safety and improves the debugging
experience, e.g. GDB now prints

    com::sun::star::accessibility::AccessibleRelationType::AccessibleRelationType_CONTENT_FLOWS_TO

instead of just "2" when printing the value of a
corresponding variable, so it's no longer necessary
to manually look up what constant has that integer
value to know what relation this refers to.

offapi/com/sun/star/accessibility/AccessibleRelationType.idl
had this comment:

> <p>We are using constants instead of a more typesafe enum.  The reason
> for this is that IDL enums may not be extended.  Therefore, in order to
> include future extensions to the set of roles we have to use constants
> here.</p>

However, the a11y UNO API is internal (not published),
so that shouldn't be a concern.

Change-Id: I44a7d56cb085dc24effb24fcd34bb222b78ef4cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176153
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
 2024-11-07 08:50:13 +01:00
Caolán McNamara 92f5913aef cid#1556442 COPY_INSTEAD_OF_MOVE 
and

cid#1607753 COPY_INSTEAD_OF_MOVE
cid#1554790 COPY_INSTEAD_OF_MOVE
cid#1556463 COPY_INSTEAD_OF_MOVE
cid#1554838 COPY_INSTEAD_OF_MOVE
cid#1556231 COPY_INSTEAD_OF_MOVE
cid#1556878 COPY_INSTEAD_OF_MOVE
cid#1554913 COPY_INSTEAD_OF_MOVE
cid#1558064 COPY_INSTEAD_OF_MOVE
cid#1557043 COPY_INSTEAD_OF_MOVE
cid#1556985 COPY_INSTEAD_OF_MOVE
cid#1556766 COPY_INSTEAD_OF_MOVE
cid#1557351 COPY_INSTEAD_OF_MOVE
cid#1554863 COPY_INSTEAD_OF_MOVE
cid#1556764 COPY_INSTEAD_OF_MOVE
cid#1556279 COPY_INSTEAD_OF_MOVE
cid#1555970 COPY_INSTEAD_OF_MOVE
cid#1556942 COPY_INSTEAD_OF_MOVE
cid#1557964 COPY_INSTEAD_OF_MOVE
cid#1555166 COPY_INSTEAD_OF_MOVE
cid#1556496 COPY_INSTEAD_OF_MOVE
cid#1557175 COPY_INSTEAD_OF_MOVE
cid#1558054 COPY_INSTEAD_OF_MOVE
cid#1557392 COPY_INSTEAD_OF_MOVE
cid#1557850 COPY_INSTEAD_OF_MOVE
cid#1555118 COPY_INSTEAD_OF_MOVE
cid#1557131 COPY_INSTEAD_OF_MOVE
cid#1556614 COPY_INSTEAD_OF_MOVE
cid#1609650 COPY_INSTEAD_OF_MOVE
cid#1555114 COPY_INSTEAD_OF_MOVE
cid#1555241 COPY_INSTEAD_OF_MOVE
cid#1555442 COPY_INSTEAD_OF_MOVE
cid#1556473 COPY_INSTEAD_OF_MOVE
cid#1557654 COPY_INSTEAD_OF_MOVE
cid#1554689 COPY_INSTEAD_OF_MOVE
cid#1556316 COPY_INSTEAD_OF_MOVE
cid#1557929 COPY_INSTEAD_OF_MOVE
cid#1554807 COPY_INSTEAD_OF_MOVE
cid#1554858 COPY_INSTEAD_OF_MOVE
cid#1555103 COPY_INSTEAD_OF_MOVE
cid#1555517 COPY_INSTEAD_OF_MOVE
cid#1556424 COPY_INSTEAD_OF_MOVE
cid#1557252 COPY_INSTEAD_OF_MOVE
cid#1557566 COPY_INSTEAD_OF_MOVE
cid#1608020 COPY_INSTEAD_OF_MOVE
cid#1557742 COPY_INSTEAD_OF_MOVE
cid#1555884 COPY_INSTEAD_OF_MOVE
cid#1554809 COPY_INSTEAD_OF_MOVE
cid#1555336 COPY_INSTEAD_OF_MOVE
cid#1555173 COPY_INSTEAD_OF_MOVE
cid#1556067 COPY_INSTEAD_OF_MOVE
cid#1557040 COPY_INSTEAD_OF_MOVE
cid#1556235 COPY_INSTEAD_OF_MOVE
cid#1557366 COPY_INSTEAD_OF_MOVE
cid#1555910 COPY_INSTEAD_OF_MOVE
cid#1556716 COPY_INSTEAD_OF_MOVE
cid#1558022 COPY_INSTEAD_OF_MOVE
cid#1555769 COPY_INSTEAD_OF_MOVE
cid#1555940 COPY_INSTEAD_OF_MOVE
cid#1557077 COPY_INSTEAD_OF_MOVE
cid#1555270 COPY_INSTEAD_OF_MOVE
cid#1555660 COPY_INSTEAD_OF_MOVE
cid#1556302 COPY_INSTEAD_OF_MOVE
cid#1555678 COPY_INSTEAD_OF_MOVE
cid#1556538 COPY_INSTEAD_OF_MOVE
cid#1557689 COPY_INSTEAD_OF_MOVE
cid#1555009 COPY_INSTEAD_OF_MOVE
cid#1555433 COPY_INSTEAD_OF_MOVE
cid#1555671 COPY_INSTEAD_OF_MOVE
cid#1555255 COPY_INSTEAD_OF_MOVE
cid#1557681 COPY_INSTEAD_OF_MOVE
cid#1557512 COPY_INSTEAD_OF_MOVE
cid#1554958 COPY_INSTEAD_OF_MOVE
cid#1555758 COPY_INSTEAD_OF_MOVE
cid#1555597 COPY_INSTEAD_OF_MOVE
cid#1558040 COPY_INSTEAD_OF_MOVE
cid#1556476 COPY_INSTEAD_OF_MOVE
cid#1557646 COPY_INSTEAD_OF_MOVE
cid#1557950 COPY_INSTEAD_OF_MOVE
cid#1557019 COPY_INSTEAD_OF_MOVE
cid#1557885 COPY_INSTEAD_OF_MOVE
cid#1556402 COPY_INSTEAD_OF_MOVE
cid#1557906 COPY_INSTEAD_OF_MOVE
cid#1556619 COPY_INSTEAD_OF_MOVE
cid#1554683 COPY_INSTEAD_OF_MOVE
cid#1556549 COPY_INSTEAD_OF_MOVE
cid#1554747 COPY_INSTEAD_OF_MOVE
cid#1554929 COPY_INSTEAD_OF_MOVE
cid#1555362 COPY_INSTEAD_OF_MOVE
cid#1557053 COPY_INSTEAD_OF_MOVE
cid#1557891 COPY_INSTEAD_OF_MOVE
cid#1555043 COPY_INSTEAD_OF_MOVE
cid#1555107 COPY_INSTEAD_OF_MOVE
cid#1557203 COPY_INSTEAD_OF_MOVE
cid#1556728 COPY_INSTEAD_OF_MOVE
cid#1557773 COPY_INSTEAD_OF_MOVE
cid#1556845 COPY_INSTEAD_OF_MOVE

Change-Id: I001fb67e597b096e992fd8a0cd6f3ec577767c33
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176098
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
 2024-11-06 13:58:54 +01:00
Noel Grandin 5de73f04f3 new loplugin:staticconstexpr 
Change-Id: Ida1996dfffa106bf95fd064e8191b8033b4002f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175336
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-11-04 08:51:00 +01:00
Xisco Fauli 30dee23a76 UnoApiTest: check mxComponent right after loading 
Change-Id: Ia834d19a5af999440f7d5847aeeae863daacd952
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175784
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
 2024-10-29 13:50:40 +01:00
Xisco Fauli a38a22c7e5 UnoApiTest: rename load to loadFromURL and use it everywhere 
Change-Id: Ie67eebec74f783fa0c29acfb23bb83bc582812b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175724
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
 2024-10-29 09:11:37 +01:00
Caolán McNamara 7bbe74b2be cid#1555789 COPY_INSTEAD_OF_MOVE 
and

cid#1556865 COPY_INSTEAD_OF_MOVE
cid#1556871 COPY_INSTEAD_OF_MOVE
cid#1556939 COPY_INSTEAD_OF_MOVE
cid#1556951 COPY_INSTEAD_OF_MOVE
cid#1556964 COPY_INSTEAD_OF_MOVE
cid#1556966 COPY_INSTEAD_OF_MOVE
cid#1556968 COPY_INSTEAD_OF_MOVE
cid#1556971 COPY_INSTEAD_OF_MOVE
cid#1556989 COPY_INSTEAD_OF_MOVE
cid#1557001 COPY_INSTEAD_OF_MOVE
cid#1557011 COPY_INSTEAD_OF_MOVE
cid#1557032 COPY_INSTEAD_OF_MOVE
cid#1557038 COPY_INSTEAD_OF_MOVE
cid#1557041 COPY_INSTEAD_OF_MOVE
cid#1557055 COPY_INSTEAD_OF_MOVE
cid#1557056 COPY_INSTEAD_OF_MOVE
cid#1557057 COPY_INSTEAD_OF_MOVE
cid#1557065 COPY_INSTEAD_OF_MOVE
cid#1557068 COPY_INSTEAD_OF_MOVE
cid#1557087 COPY_INSTEAD_OF_MOVE
cid#1557090 COPY_INSTEAD_OF_MOVE
cid#1557093 COPY_INSTEAD_OF_MOVE
cid#1557113 COPY_INSTEAD_OF_MOVE
cid#1557122 COPY_INSTEAD_OF_MOVE
cid#1557126 COPY_INSTEAD_OF_MOVE
cid#1557145 COPY_INSTEAD_OF_MOVE
cid#1557151 COPY_INSTEAD_OF_MOVE
cid#1557152 COPY_INSTEAD_OF_MOVE
cid#1557197 COPY_INSTEAD_OF_MOVE
cid#1557216 COPY_INSTEAD_OF_MOVE
cid#1557245 COPY_INSTEAD_OF_MOVE
cid#1557272 COPY_INSTEAD_OF_MOVE
cid#1557310 COPY_INSTEAD_OF_MOVE
cid#1557314 COPY_INSTEAD_OF_MOVE
cid#1557318 COPY_INSTEAD_OF_MOVE
cid#1557333 COPY_INSTEAD_OF_MOVE
cid#1557340 COPY_INSTEAD_OF_MOVE
cid#1557358 COPY_INSTEAD_OF_MOVE
cid#1557359 COPY_INSTEAD_OF_MOVE
cid#1557365 COPY_INSTEAD_OF_MOVE
cid#1557367 COPY_INSTEAD_OF_MOVE
cid#1557395 COPY_INSTEAD_OF_MOVE
cid#1557418 COPY_INSTEAD_OF_MOVE
cid#1557488 COPY_INSTEAD_OF_MOVE
cid#1557493 COPY_INSTEAD_OF_MOVE
cid#1557506 COPY_INSTEAD_OF_MOVE
cid#1557514 COPY_INSTEAD_OF_MOVE
cid#1557528 COPY_INSTEAD_OF_MOVE
cid#1557534 COPY_INSTEAD_OF_MOVE
cid#1557537 COPY_INSTEAD_OF_MOVE
cid#1557562 COPY_INSTEAD_OF_MOVE
cid#1557563 COPY_INSTEAD_OF_MOVE
cid#1557592 COPY_INSTEAD_OF_MOVE
cid#1557608 COPY_INSTEAD_OF_MOVE
cid#1557615 COPY_INSTEAD_OF_MOVE
cid#1557619 COPY_INSTEAD_OF_MOVE
cid#1557637 COPY_INSTEAD_OF_MOVE
cid#1557648 COPY_INSTEAD_OF_MOVE
cid#1557712 COPY_INSTEAD_OF_MOVE
cid#1557750 COPY_INSTEAD_OF_MOVE
cid#1557762 COPY_INSTEAD_OF_MOVE
cid#1557765 COPY_INSTEAD_OF_MOVE

Change-Id: I10db1910627e04a26e25836c05ad5c2707abd18b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175696
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
 2024-10-27 20:19:12 +01:00
Bogdan Buzea 91a7592016 tdf#163486: PVS: Identical branches 
V1037 Two or more case-branches perform the same actions. Check lines: 425, 499
V1037 Two or more case-branches perform the same actions. Check lines: 463, 469
V1037 Two or more case-branches perform the same actions. Check lines: 552, 576
V1037 Two or more case-branches perform the same actions. Check lines: 555, 582

Change-Id: I1a41401569ee9893bf853bd3f56c2559aeb36a87
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175386
Reviewed-by: David Gilbert <freedesktop@treblig.org>
Tested-by: Jenkins
 2024-10-27 19:04:27 +01:00
Bogdan Buzea a74ef20928 tdf#163486: PVS: Identical branches 
V1037 Two or more case-branches perform the same actions. Check lines: 817, 830
V1037 Two or more case-branches perform the same actions. Check lines: 1251, 1254

Change-Id: I4e121ec3b0c4465f5637b114d2e91e5b639c398c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175276
Tested-by: Jenkins
Reviewed-by: David Gilbert <freedesktop@treblig.org>
 2024-10-27 01:24:45 +02:00
Caolán McNamara 6f1508f4de cid#1555767 COPY_INSTEAD_OF_MOVE 
and

cid#1555770 COPY_INSTEAD_OF_MOVE
cid#1555788 COPY_INSTEAD_OF_MOVE
cid#1555789 COPY_INSTEAD_OF_MOVE
cid#1555798 COPY_INSTEAD_OF_MOVE
cid#1555816 COPY_INSTEAD_OF_MOVE
cid#1555822 COPY_INSTEAD_OF_MOVE
cid#1555835 COPY_INSTEAD_OF_MOVE
cid#1555845 COPY_INSTEAD_OF_MOVE
cid#1555859 COPY_INSTEAD_OF_MOVE
cid#1555864 COPY_INSTEAD_OF_MOVE
cid#1555868 COPY_INSTEAD_OF_MOVE
cid#1555892 COPY_INSTEAD_OF_MOVE
cid#1555896 COPY_INSTEAD_OF_MOVE
cid#1555921 COPY_INSTEAD_OF_MOVE
cid#1555932 COPY_INSTEAD_OF_MOVE
cid#1555935 COPY_INSTEAD_OF_MOVE
cid#1555944 COPY_INSTEAD_OF_MOVE
cid#1555952 COPY_INSTEAD_OF_MOVE
cid#1555985 COPY_INSTEAD_OF_MOVE
cid#1556024 COPY_INSTEAD_OF_MOVE
cid#1556038 COPY_INSTEAD_OF_MOVE
cid#1556042 COPY_INSTEAD_OF_MOVE
cid#1556044 COPY_INSTEAD_OF_MOVE
cid#1556060 COPY_INSTEAD_OF_MOVE
cid#1556083 COPY_INSTEAD_OF_MOVE
cid#1556085 COPY_INSTEAD_OF_MOVE
cid#1556090 COPY_INSTEAD_OF_MOVE
cid#1556136 COPY_INSTEAD_OF_MOVE
cid#1556157 COPY_INSTEAD_OF_MOVE
cid#1556159 COPY_INSTEAD_OF_MOVE
cid#1556172 COPY_INSTEAD_OF_MOVE
cid#1556179 COPY_INSTEAD_OF_MOVE
cid#1556187 COPY_INSTEAD_OF_MOVE
cid#1556255 COPY_INSTEAD_OF_MOVE
cid#1556256 COPY_INSTEAD_OF_MOVE
cid#1556266 COPY_INSTEAD_OF_MOVE
cid#1556275 COPY_INSTEAD_OF_MOVE
cid#1556290 COPY_INSTEAD_OF_MOVE
cid#1556294 COPY_INSTEAD_OF_MOVE
cid#1556301 COPY_INSTEAD_OF_MOVE
cid#1556311 COPY_INSTEAD_OF_MOVE
cid#1556318 COPY_INSTEAD_OF_MOVE
cid#1556326 COPY_INSTEAD_OF_MOVE
cid#1556369 COPY_INSTEAD_OF_MOVE
cid#1556374 COPY_INSTEAD_OF_MOVE
cid#1556387 COPY_INSTEAD_OF_MOVE
cid#1556388 COPY_INSTEAD_OF_MOVE
cid#1556417 COPY_INSTEAD_OF_MOVE
cid#1556425 COPY_INSTEAD_OF_MOVE
cid#1556435 COPY_INSTEAD_OF_MOVE
cid#1556495 COPY_INSTEAD_OF_MOVE
cid#1556497 COPY_INSTEAD_OF_MOVE
cid#1556501 COPY_INSTEAD_OF_MOVE
cid#1556503 COPY_INSTEAD_OF_MOVE
cid#1556520 COPY_INSTEAD_OF_MOVE
cid#1556523 COPY_INSTEAD_OF_MOVE
cid#1556562 COPY_INSTEAD_OF_MOVE
cid#1556573 COPY_INSTEAD_OF_MOVE
cid#1556576 COPY_INSTEAD_OF_MOVE
cid#1556598 COPY_INSTEAD_OF_MOVE
cid#1556615 COPY_INSTEAD_OF_MOVE
cid#1556626 COPY_INSTEAD_OF_MOVE
cid#1556671 COPY_INSTEAD_OF_MOVE
cid#1556689 COPY_INSTEAD_OF_MOVE
cid#1556701 COPY_INSTEAD_OF_MOVE
cid#1556713 COPY_INSTEAD_OF_MOVE
cid#1556758 COPY_INSTEAD_OF_MOVE
cid#1556759 COPY_INSTEAD_OF_MOVE
cid#1556788 COPY_INSTEAD_OF_MOVE
cid#1556811 COPY_INSTEAD_OF_MOVE
cid#1556821 COPY_INSTEAD_OF_MOVE
cid#1556824 COPY_INSTEAD_OF_MOVE
cid#1556825 COPY_INSTEAD_OF_MOVE
cid#1556862 COPY_INSTEAD_OF_MOVE

Change-Id: I4925a79688a983bb07252600430039ec0bcb75b8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175678
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
 2024-10-26 19:25:03 +02:00
Bogdan Buzea cf9b7e36fe tdf#163486: PVS: Identical branches 
V1037 Two or more case-branches perform the same actions. Check lines: 105, 155

Change-Id: I077ba811fb9050eca4ba97d225323c807ee8e9cf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175390
Reviewed-by: David Gilbert <freedesktop@treblig.org>
Tested-by: Jenkins
 2024-10-25 03:03:09 +02:00
Xisco Fauli c69ce3a0c3 tdf#163486: PVS: check pTabWinTmp 
V595 	The 'pTabWinTmp' pointer was utilized before it was verified against nullptr. Check lines: 496, 499.

Change-Id: Ie263524d6a06adaf7f99555d7aa872e815cab96c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175504
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
 2024-10-23 20:26:03 +02:00
Caolán McNamara ee4554b0ac cid#1555259 COPY_INSTEAD_OF_MOVE 
and

cid#1555264 COPY_INSTEAD_OF_MOVE
cid#1555280 COPY_INSTEAD_OF_MOVE
cid#1555303 COPY_INSTEAD_OF_MOVE
cid#1555313 COPY_INSTEAD_OF_MOVE
cid#1555314 COPY_INSTEAD_OF_MOVE
cid#1555323 COPY_INSTEAD_OF_MOVE
cid#1555333 COPY_INSTEAD_OF_MOVE
cid#1555338 COPY_INSTEAD_OF_MOVE
cid#1555349 COPY_INSTEAD_OF_MOVE
cid#1555364 COPY_INSTEAD_OF_MOVE
cid#1555379 COPY_INSTEAD_OF_MOVE
cid#1555398 COPY_INSTEAD_OF_MOVE
cid#1555410 COPY_INSTEAD_OF_MOVE
cid#1555411 COPY_INSTEAD_OF_MOVE
cid#1555416 COPY_INSTEAD_OF_MOVE
cid#1555429 COPY_INSTEAD_OF_MOVE
cid#1555434 COPY_INSTEAD_OF_MOVE
cid#1555441 COPY_INSTEAD_OF_MOVE
cid#1555446 COPY_INSTEAD_OF_MOVE
cid#1555480 COPY_INSTEAD_OF_MOVE
cid#1555490 COPY_INSTEAD_OF_MOVE
cid#1555524 COPY_INSTEAD_OF_MOVE
cid#1555527 COPY_INSTEAD_OF_MOVE
cid#1555531 COPY_INSTEAD_OF_MOVE
cid#1555578 COPY_INSTEAD_OF_MOVE
cid#1555581 COPY_INSTEAD_OF_MOVE
cid#1555591 COPY_INSTEAD_OF_MOVE
cid#1555614 COPY_INSTEAD_OF_MOVE
cid#1555619 COPY_INSTEAD_OF_MOVE
cid#1555633 COPY_INSTEAD_OF_MOVE
cid#1555654 COPY_INSTEAD_OF_MOVE
cid#1555707 COPY_INSTEAD_OF_MOVE
cid#1555712 COPY_INSTEAD_OF_MOVE
cid#1555746 COPY_INSTEAD_OF_MOVE
cid#1555763 COPY_INSTEAD_OF_MOVE

Change-Id: Ibcc1a3649c5663328e60474c06e51902aa74db52
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175407
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
 2024-10-22 17:53:07 +02:00
Bogdan Buzea 6884f6cd61 tdf#163486: PVS: Identical branches 
V1037 Two or more case-branches perform the same actions. Check lines: 692, 695

Change-Id: I7a7b321b10437897b285c31403aee908da8cd929
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175343
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2024-10-22 12:09:01 +02:00
Xisco Fauli 990d710bf7 tdf#163486: PVS: fix copy&paste error 
Since
commit f02e1a0abc
Author: Kurt Zenker <kz@openoffice.org>
Date:   Thu Mar 6 16:58:17 2008 +0000

    INTEGRATION: CWS odbmacros2 (1.36.2); FILE MERGED

V524 	It is odd that the body of 'removeStorageChangeListener' function is fully equivalent to the body of 'addStorageChangeListener' function.

Change-Id: Ie5456f4ef7397d5f9144ac3167724f6c2ca32c56
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175251
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
 2024-10-20 16:14:47 +02:00
Xisco Fauli c64ac05bed tdf#163486: PVS: variable is assigned values twice successively 
V519 	The 'sNewUrl' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 527, 554.

Change-Id: I35e1b9e78f71958e99586385ba0c86e553e65997
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175140
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
 2024-10-20 10:32:47 +02:00
Xisco Fauli 6250d512e5 tdf#163486: PVS: variable is assigned values twice successively 
V519 	The 'bParserSuccess' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1941, 1944.

Change-Id: I4dac8d01533706a5423fd0d75e5ccdc0d3cf00c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175161
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2024-10-18 19:30:02 +02:00
Chizoba ODINAKA 2d84bab85c tdf#145614 Convert #define to 'enum' 
Change-Id: I92cd029034015fe8b664ee75b4e4f107ba365e1d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175034
Reviewed-by: Hossein   <hossein@libreoffice.org>
Tested-by: Jenkins
 2024-10-17 09:24:24 +02:00
Caolán McNamara 23d7910c1e cid#1554844 COPY_INSTEAD_OF_MOVE 
and

cid#1554878 COPY_INSTEAD_OF_MOVE
cid#1554907 COPY_INSTEAD_OF_MOVE
cid#1555082 COPY_INSTEAD_OF_MOVE
cid#1555224 COPY_INSTEAD_OF_MOVE
cid#1555301 COPY_INSTEAD_OF_MOVE
cid#1555378 COPY_INSTEAD_OF_MOVE
cid#1555395 COPY_INSTEAD_OF_MOVE
cid#1555452 COPY_INSTEAD_OF_MOVE
cid#1555466 COPY_INSTEAD_OF_MOVE
cid#1555514 COPY_INSTEAD_OF_MOVE
cid#1555566 COPY_INSTEAD_OF_MOVE
cid#1555753 COPY_INSTEAD_OF_MOVE
cid#1555782 COPY_INSTEAD_OF_MOVE
cid#1555825 COPY_INSTEAD_OF_MOVE
cid#1555842 COPY_INSTEAD_OF_MOVE
cid#1555891 COPY_INSTEAD_OF_MOVE
cid#1555917 COPY_INSTEAD_OF_MOVE
cid#1555961 COPY_INSTEAD_OF_MOVE
cid#1556021 COPY_INSTEAD_OF_MOVE
cid#1556055 COPY_INSTEAD_OF_MOVE
cid#1556307 COPY_INSTEAD_OF_MOVE
cid#1556349 COPY_INSTEAD_OF_MOVE
cid#1556436 COPY_INSTEAD_OF_MOVE
cid#1556665 COPY_INSTEAD_OF_MOVE
cid#1556696 COPY_INSTEAD_OF_MOVE
cid#1556718 COPY_INSTEAD_OF_MOVE
cid#1556775 COPY_INSTEAD_OF_MOVE
cid#1556835 COPY_INSTEAD_OF_MOVE
cid#1556877 COPY_INSTEAD_OF_MOVE
cid#1556994 COPY_INSTEAD_OF_MOVE
cid#1557010 COPY_INSTEAD_OF_MOVE
cid#1557074 COPY_INSTEAD_OF_MOVE
cid#1557111 COPY_INSTEAD_OF_MOVE
cid#1557142 COPY_INSTEAD_OF_MOVE
cid#1557163 COPY_INSTEAD_OF_MOVE
cid#1557164 COPY_INSTEAD_OF_MOVE
cid#1557214 COPY_INSTEAD_OF_MOVE
cid#1557254 COPY_INSTEAD_OF_MOVE
cid#1557322 COPY_INSTEAD_OF_MOVE
cid#1557327 COPY_INSTEAD_OF_MOVE
cid#1557492 COPY_INSTEAD_OF_MOVE
cid#1557565 COPY_INSTEAD_OF_MOVE
cid#1557663 COPY_INSTEAD_OF_MOVE
cid#1557798 COPY_INSTEAD_OF_MOVE

Change-Id: I2ae9c184dcc18d44a65437e18c49e16b27f4d81d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174893
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-10-14 15:28:24 +02:00
Stephan Bergmann f72c9777f5 -Werror,-Wdeprecated-literal-operator 
Change-Id: I4e2c4c1083587bfddd9f6a355f1ea7888573cc14
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174876
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
 2024-10-14 08:05:29 +02:00
Noel Grandin da8a36b4f4 CID#1607066:Data race condition (MISSING_LOCK) 
which means we need to push knowledge
about the locking down into ucbhelper::Result
since the implementation classes there
want to call back into the parent.

and also

CID#1607968:Data race condition (MISSING_LOCK)
CID#1606657:Data race condition (MISSING_LOCK)
CID#1607112:Data race condition (MISSING_LOCK)
CID#1608365:Data race condition (MISSING_LOCK)
CID#1607159:Data race condition (MISSING_LOCK)
CID#1607018:Data race condition (MISSING_LOCK)
CID#1607421:Data race condition (MISSING_LOCK)
CID#1607766:Data race condition (MISSING_LOCK)
CID#1606872:Data race condition (MISSING_LOCK)
CID#1608523:Data race condition (MISSING_LOCK
CID#1607191:Data race condition (MISSING_LOCK)
CID#1608345:Data race condition (MISSING_LOCK)
CID#1608577:(#1 of 1):Data race condition (MISSING_LOCK)
CID#1607210:Data race condition (MISSING_LOCK)
CID#1607132:Data race condition (MISSING_LOCK)
CID#1608256:Data race condition (MISSING_LOCK)
CID#1607482:Data race condition (MISSING_LOCK)
CID#1607935:Data race condition (MISSING_LOCK)
CID#1608070:Data race condition (MISSING_LOCK)
CID#1607901:Data race condition (MISSING_LOCK)
CID#1608013:Data race condition (MISSING_LOCK)
CID#1607506:Data race condition (MISSING_LOCK)
CID#1607526:Data race condition (MISSING_LOCK)
CID#1607044:Data race condition (MISSING_LOCK)
CID#1607708:Data race condition (MISSING_LOCK)
CID#1608041:Data race condition (MISSING_LOCK)
CID#1608207:Data race condition (MISSING_LOCK)
CID#1608028:Data race condition (MISSING_LOCK)
CID#1608168:Data race condition (MISSING_LOCK)
CID#1607561:Data race condition (MISSING_LOCK)

CID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)
CID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)
CID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)
CID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)
CID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)
CID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)
CID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)
CID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)
CID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)
CID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)

Change-Id: Ifbe908a4a86ab8c5fa1c4ed3b6f9466508e4900e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174204
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-09-30 18:24:30 +02:00
Noel Grandin c2306ddbac cid#1607790 Overflowed constant 
Change-Id: Ia2b180d6a93f139a0f83653ee45b4ad929ccef45
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174110
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-09-28 18:08:33 +02:00
Xisco Fauli b617ac7322 ODF 1.4: add ODFVER_014_TEXT constant 
Change-Id: I219c854b11a5bd4be3d789b93a96e045e3dca29f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173991
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
 2024-09-26 19:14:29 +02:00
Noel Grandin fff43a2e76 use more concrete UNO types in dbaccess 
Change-Id: Ibcf54e3bbdad4888c5da1f52f636951356e0aa51
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173818
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-09-24 12:13:47 +02:00
Caolán McNamara c46c109204 cid#1607535 silence Overflowed constant 
and

cid#1608504 Overflowed constant
cid#1607518 Overflowed constant

Change-Id: Ife45a2f414ea703f627b7083d746bc11f6d4f359
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173832
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-09-24 10:12:44 +02:00
Noel Grandin 5ceff2c65c use more concrete UNO types in dbaccess 
Change-Id: If34294e2db4dc3365a7308c90658d5fa0c0e6532
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173817
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-09-24 08:18:18 +02:00
Noel Grandin 87039e3e77 use more concrete UNO types in dbaccess 
Change-Id: I3f689e6ec296fe0c8876ba5cc68133f28902b3fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173816
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-09-23 18:32:24 +02:00
Andrea Gelmini ba0c69e66b Fix typo 
Change-Id: I917ad7304c479d8f0c807cfd77d87c56cfb25b93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173603
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2024-09-18 16:58:42 +02:00
Noel Grandin 26fd88df80 remove OSubComponent from RowSet 
which attempts to implement a very dodgy and almost but not actually
thread-safe dispose function. Rather just hold a weak reference to the
rowset that created us.

Change-Id: I1881ac34320b61866eefc3641b455f618d0759d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173573
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2024-09-18 08:06:55 +02:00
Noel Grandin f7354e1873 remove OSubComponent from OStatementBase 
which attempts to implement a very dodgy and almost but not actually
thread-safe dispose function. Rather just hold a weak reference to the
connection that created us.

Change-Id: I01e4f5fc0a8aeb33adc14a2981ce09522a0306bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173572
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-09-18 08:06:47 +02:00
Noel Grandin e877d6ae74 use more concrete UNO types in dbaccess 
Change-Id: I6cb15b347dae28878110f76064645095d5771e3c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173382
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-09-15 16:35:16 +02:00
Mike Kaganski 1091e04fbd Simplify use of connectivity::OConnectionWrapper 
Make it use cppu::WeakComponentImplHelper, because all its derived
classes used that template. In the derived classes, switch to use
of cppu::ImplInheritanceHelper. That simplifies the hierarchy, and
doesn't require to re-implement many basic methods.

Change-Id: I40ec05a471af4437098586d20540f9a815677952
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173370
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
 2024-09-15 06:27:30 +02:00
Noel Grandin a3afc0e38b remove OSubComponent from OConnection 
which attempts to implement a very dodgy and almost but not actually
thread-safe dispose function. Rather just hold a weak reference to the
data source that created us.

Change-Id: I431bb43aef1d6ce92d7987e7d731b724b64a9767
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173341
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-09-14 09:21:37 +02:00
Noel Grandin dff484283d use more concrete UNO types in dbaccess 
Change-Id: I017d4fd7131735dfd2dba6e1b046fbe691522745
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173280
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-09-13 12:45:54 +02:00
Noel Grandin 76c6436faa convert OKeySetValue to a struct 
for better readability

Change-Id: I9750668a31740bb1de0b6f024912d5cc73f7e766
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173279
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-09-13 08:18:58 +02:00
Julien Nabet c0fd5f82ff tdf#162833: don't use an OUStringBuffer directly in a concat to assign itself 
SUM( CASE WHEN \"dtPayTyp\" = 1 THEN \"dtPayBetrag\" * - 1 ELSE \"dtPayBetrag\" END )
is transformed into:
Sum(Sum( WHEN \"dtPayTyp\" = 1 THEN \"dtPayBetrag\" * - 1 ELSE \"dtPayBetrag\" END)

See https://bugs.documentfoundation.org/show_bug.cgi?id=162833#c3

Change-Id: Ie73dd6871bcda1c22cf6f469bd05ecc4d9dacb4c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172989
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-09-07 21:48:38 +02:00
Noel Grandin d50f3fa9f5 tsan: data race 
Read of size 1 at 0x7250000be3fd by thread T19:
 0 dbaccess::ODatabaseDocument::queryInterface(com::sun::star::uno::Type const&)
 1 non-virtual thunk to dbaccess::ODatabaseDocument::queryInterface(com::sun::star::uno::Type const&)
 2 com::sun::star::uno::BaseReference::iquery(com::sun::star::uno::XInterface*, com::sun::star::uno::Type const&)
 3 com::sun::star::uno::Reference<com::sun::star::frame::XFrame>::iquery(com::sun::star::uno::XInterface*)

Previous write of size 1 at 0x7250000be3fd by thread T8 (mutexes: write M0):
 0 dbaccess::ODatabaseDocument::storeAsURL(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
 1 non-virtual thunk to dbaccess::ODatabaseDocument::storeAsURL(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
 2 gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*)

Change-Id: I40ce0b5995f94455b5d9ca1d652a58df96b5f553
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172873
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-09-05 11:29:59 +02:00
Andrea Gelmini 1799fb8a5a Fix typo 
Change-Id: I799609afc33913fc09f7020a5bc53c83de36bff0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172879
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2024-09-05 09:10:00 +02:00
Heiko Tietze 0266763e05 Resolves tdf#140298 - Improve UX for SQL dialog 
* dialog made resizable
* user input remembered across session
* number of results shown (inkluding plural form)

Change-Id: I5b08064ed68a02a2c20fa658dbc6ed5cde656417
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172803
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
 2024-09-05 07:38:22 +02:00