It is inherited per CSS Fonts, so the children of a group must inherit
it when set on the group.
Change-Id: I3a7f1c58b249e0d647c3b8a15f9e2043b7d6c891
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209212
Reviewed-by: Khaled Hosny <khaled@libreoffice.org>
Tested-by: Jenkins
We added a rectangle using PolygonHairlinePrimitive2D to the
HiddenGeometryPrimitive2D, so we can mark the boundary of the
SVG image. The problem with using the hairline primitive for this
is that the hairline size is grown by 0.5 in each direction
(implGrowHairline, which is called in getB2DRange), which also makes
our SVG size 1px bigger than it should be.
Using FilledRectanglePrimitive2D instead fixes this problem as the
rectangle isn't grown in size.
Also needed to change a lot of tests that were using SVG images
and asserted the size of the image in ome way.
Change-Id: Ic2aa98b3df1f0746e4cfbd3474b6a93d0f4072ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200440
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit aa2c07951b565cd5464a36a2b0721f888ab8531c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200433
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Since some code needs flexibility in error handling, where hardcoded
error value of -1 wasn't handy, o3tl::convertToHex was changed to
accept the error value as its template parameter.
Change-Id: Ifc771cc8fa29a801d4556dea969fc3ea7e620df5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199367
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
these were skipped in previous runs, since they contain some code behind #if
After inspecting these, it seems like the removals should not cause trouble.
Change-Id: I867ffc53254057e4bae43690214a2ab7ce0caa8f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197493
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
Tested-by: Jenkins
I get a bunch of warnings when opening e.g. Writer:
warn:svgio:38509:18012388:svgio/source/svgreader/SvgNumber.cxx:74: SvgNumber not set (!)
warn:svgio:38509:18012388:svgio/source/svgreader/SvgNumber.cxx:74: SvgNumber not set (!)
warn:svgio:38509:18012388:svgio/source/svgreader/SvgNumber.cxx:74: SvgNumber not set (!)
warn:svgio:38509:18012388:svgio/source/svgreader/SvgNumber.cxx:74: SvgNumber not set (!)
warn:svgio:38509:18012388:svgio/source/svgreader/SvgNumber.cxx:74: SvgNumber not set (!)
warn:svgio:38509:18012388:svgio/source/svgreader/SvgNumber.cxx:74: SvgNumber not set (!)
warn:svgio:38509:18012388:svgio/source/svgreader/SvgNumber.cxx:74: SvgNumber not set (!)
warn:svgio:38509:18012388:svgio/source/svgreader/SvgNumber.cxx:74: SvgNumber not set (!)
warn:svgio:38509:18012388:svgio/source/svgreader/SvgNumber.cxx:74: SvgNumber not set (!)
warn:svgio:38509:18012388:svgio/source/svgreader/SvgNumber.cxx:74: SvgNumber not set (!)
warn:svgio:38509:18012388:svgio/source/svgreader/SvgNumber.cxx:74: SvgNumber not set (!)
warn:svgio:38509:18012388:svgio/source/svgreader/SvgNumber.cxx:74: SvgNumber not set (!)
warn:svgio:38509:18012388:svgio/source/svgreader/SvgNumber.cxx:74: SvgNumber not set (!)
warn:svgio:38509:18012388:svgio/source/svgreader/SvgNumber.cxx:74: SvgNumber not set (!)
warn:svgio:38509:18012388:svgio/source/svgreader/SvgNumber.cxx:74: SvgNumber not set (!)
warn:svgio:38509:18012388:svgio/source/svgreader/SvgNumber.cxx:74: SvgNumber not set (!)
warn:svgio:38509:18012388:svgio/source/svgreader/SvgNumber.cxx:74: SvgNumber not set (!)
warn:svgio:38509:18012388:svgio/source/svgreader/SvgNumber.cxx:74: SvgNumber not set (!)
warn:svgio:38509:18012388:svgio/source/svgreader/SvgNumber.cxx:74: SvgNumber not set (!)
warn:svgio:38509:18012388:svgio/source/svgreader/SvgNumber.cxx:74: SvgNumber not set (!)
This happens when reading translate transform without y position. Since
y is optional, we should initialize aTransY to avoid the noisy warning.
Change-Id: I503a126aa7ce0be9caca366247710dd46316b255
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191872
Reviewed-by: Khaled Hosny <khaled@libreoffice.org>
Tested-by: Jenkins
This is follow up to commit:
commit b9f0caad5d
Author: Khaled Hosny <khaled@aliftype.com>
Date: Tue Aug 23 04:13:28 2022 +0200
tdf#66819: Disable ligatures with character spacing
Even though editengine was applying letter spacing, when drawing with
drawinglayer, letter spacing was not propagated which caused VCL to not
disable the ligature features.
Change-Id: Ia8bf2231478720262484a757e16fe5afec3cd28e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191512
Reviewed-by: Khaled Hosny <khaled@libreoffice.org>
Tested-by: Jenkins
now that Bitmap can handle transparency.
Which exposes a bug in skia, where an unfortunate optimisation
breaks bitmaps with alpha data, because it overwrites said
alpha data.
So remove that skia optimisation.
Change-Id: If821f6f04f464ee4ad42ba1c6571db6c69525ece
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188885
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
The embedding cannot rely on SVG providing all
values of x/y/w/h, so added fallbacks to real
geometric size. Also removed double-adding
geometry.
Change-Id: I1914ed0c3e1e42ba899db4f3eb9193fd29e9c4be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179831
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
These will never compare with tolerance (the zero is a special case
in rtl_math_approxEqual used internally), so the calls like those
don't do what they appear to do in these cases.
Change-Id: I495ac92b7f45637e118e4fdc04bb6fad6fff31ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171391
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Partially revert 56039daae4
"tdf#149673: only check opacity from parent..." to make
getOpacity behave as before and move the new behaviour
of getOpacity inside add_postProcess
Change-Id: If475cddbc4967308fa06adacda621cb3790c6f70
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170376
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Andrea Gelmini