Commit Graph
9 Commits
Author SHA1 Message Date
Kurt Nordback 0686b19728 tdf#167941 - Chart color sequence OOXML import/export
Support import, storage, and export of OOXML chart color styles
(color sequence). In OOXML, chart color styles are in files such
as colors1.xml, and conform to the chartStyle schema. This commit
supports I/O of color styles, and provides supports storing them
in the chart document model. It does not include any features for
using or modifying the color styles, so at this point it has no
appreciable effect on users.

Change-Id: I5c02137ebf9c25e11951eea55c4c77fda35b0e80
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194998
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2025-12-05 02:12:41 +01:00
Kurt Nordback a07bad0cc8 oox: next step to replace oox::drawingml::Color with ComplexColor
ComplexColor is a replacement for oox::drawingml::Color, so both
share a lot in common, but oox::drawingml::Color is only used to
resolve the colors inside oox. The idea is to replace step by step
oox::drawingml::Color with ComplexColor. In this step a lot of
ComplexColor types are used instead in oox::drawingml::Color types.

Additionally oox::drawingml::Color is not mandatory anymore for
a lot of contexts, so depending on the need ComplexColor can be
used or oox::drawingml::Color.

Change-Id: I6613a0f63cc9b7d070841d4f667363b03e6cbaa8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194645
Code-Style: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Jenkins
2025-11-27 01:33:12 +01:00
Kurt Nordback 6556116e3d tdf#168472 - Chart round-trip MSO -> LO -> MSO broken
Follow-up to earlier commit for this bug, improving the handling of
cs:ST_StyleColorVal and adding CI testing for FontReference and StyleReference

Change-Id: If8c86b780de07c38dfd67e4ba6c7739935698a27
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191416
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2025-09-24 14:58:17 +02:00
Andrea Gelmini 8023d9a3c1 Fix typo
Change-Id: I4e7b5365dcfb27dd5d0d4de0d092f74b5791583b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191364
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2025-09-22 23:30:20 +02:00
Kurt Nordback 5effa8d097 tdf#168472 - Chart round-trip MSO -> LO -> MSO broken
Chart style import/export was not handling a:ST_FontCollectionIndex
correctly. Despite the name, its value is not an integer index,
but one of three strings (major, minor, none). Separate the
FontReference and StyleReference code better in order to handle
this OOXML value correctly.

Change-Id: I1638f6484ecfe5a9bd8c1adab8d854cff47ce14f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191195
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Jenkins
2025-09-22 06:04:55 +02:00
Kurt Nordback f3e728aead tdf#167941 - Chart style file is not supported in OOXML
Implement chart style file export, beginning to use the document
model data rather than hard-coded text. Also add a simple test
that style data round-trips OOXML -> LO -> OOXML properly.

This uses oox structures in docmodel. That will be fixed in a
subsequent commit.

Change-Id: Icc0ef5b212cc32c8c84b51529bc4cf05ab54636c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190586
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2025-09-16 09:20:37 +02:00
Caolán McNamara 0c72ae925e cid#1665283 Variable copied when it could be moved
and

cid#1665282 Variable copied when it could be moved
cid#1665279 Variable copied when it could be moved
cid#1665278 Variable copied when it could be moved
cid#1665276 Variable copied when it could be moved
cid#1665275 Variable copied when it could be moved
cid#1665257 Variable copied when it could be moved

Change-Id: I222860c6385693610b95f4d674d4d0da59e75a5f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190635
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2025-09-06 12:36:30 +02:00
Caolán McNamara 653fbde736 cid#1665272 Uninitialized scalar variable
Change-Id: I1930f0941994cac6d5a987595a591d1e0a00d050
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190633
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
2025-09-06 12:35:42 +02:00
Kurt Nordback 33bbf0bd20 tdf#167941 - Chart style file is not supported in OOXML
Parse the style*.xml file in the OOXML package, and store the imported
styles in XChartDocument via a new XChartStyle. Some areas are yet to be
fleshed out, but the intent here is to get a review of the general approach
and architecture. This includes no work on the export side (or the UI and
application of styles to a chart, which is a separate but related project).

Change-Id: I9d5b9f5aa44fb7944b2d971edc26e04dc2256c7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189531
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2025-09-03 16:54:45 +02:00