ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
520,211 Commits 3 Branches 3 Tags
ec8be139bcc01abaee775353eac3ce94de57559a
Commit Graph
867 Commits
Author SHA1 Message Date
Andrea Gelmini 8ee79ac196 Fix typos 
Change-Id: Ic7a97a5219d8a0d30b1753c2502995ea4c2cd32f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210563
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
 2026-09-10 16:22:54 +02:00
Kurt Nordback d72a7d1be6 tdf#165742 Step 5.15: Don't export default shape props (continued) 
In more cases, avoid exporting spPr when the intent is to use the default
value. Explicit spPr locks the settings, preventing override by styles, for
instance.

Signed-off-by: Kurt Nordback <kurt.nordback@collabora.com>
Change-Id: Ic73016a4d3ac3ebd0d3739a2c76dfaa3d9a70d4c
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/7903
Reviewed-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit dcbcd6246f137dec36763a2824463a9246c6cf68)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209242
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-08-19 08:42:01 +02:00
Kurt Nordback b6a5834277 tdf#165742 Step 5.14: Assorted axis unit fixes 
Support round-trip for axis min, max, majorUnit, minorUnit, and some
handling for numFmt, all for chartex.

Signed-off-by: Kurt Nordback <kurt.nordback@collabora.com>
Change-Id: Ibef74b0efc27d5ff7923800b169603758e276ada
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/5901
Reviewed-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit 05420f729d5399c127d9a15fcad043fa6673dd6a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209241
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
 2026-08-18 15:53:56 +02:00
Kurt Nordback 0c8160d7e8 tdf#165742 Step 5.13: Support ownerIdx attribute 
It appears that the ownerIdx attribute of <cx:series> is used to indicate
that series share data. At least that seems to be the case with pareto
charts, which have both a clustered column and a pareto line series. Going
on that assumption, implement parsing/export of ownerIdx, and don't write
a dataId tag when ownerIdx is present. That fixes round-tripping of
pareto charts, at least based on what I've seen.

Signed-off-by: Kurt Nordback <kurt.nordback@collabora.com>
Change-Id: Ie948d2e5992b778462e34e1ef90681631c867332
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/5900
Reviewed-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit 8c37a25ffb7711f69de978045b4e3dc8d52759da)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209240
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
 2026-08-18 15:53:52 +02:00
Kurt Nordback c26599741c tdf#165742 Step 5.12: Improve axis handling 
Implement better handling of <cx:axisId> and <cx:axis> tags. In particular,
ensure we output the correct number of axisId elements, based on the chart
type, and ensure that corresponding axes (and only those) are captured in the
appropriate <cx:axis> data.

Signed-off-by: Kurt Nordback <kurt.nordback@collabora.com>
Change-Id: Ifed17afc05c70dced89e75f18dcf375fdef97f6e
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/5775
Reviewed-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit 833f782bca98c891097d887a45365bc7a5322c4d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209239
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-08-18 13:08:26 +02:00
Kurt Nordback f201337f3b tdf#165742 Step 5.11: Don't output empty tick mark tags in chartex 
Chartex has different tick mark defaults from old-style charts. Don't
output <cx:majorTickmarks> or <cx:minorTickmarks> when no tick marks are
intended, including if there were no such tags on input.

Change-Id: Ib6caecaca917204ddc99208cbece8f6adff8f5ca
Signed-off-by: Kurt Nordback <kurt.nordback@collabora.com>
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/3067
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.com>
(cherry picked from commit 5353e467dea04ba6b12b616b90e269f0a096375a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208843
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
 2026-07-30 17:13:30 +02:00
Kurt Nordback 1403eb3621 tdf#165742 Step 5.10a: Only export non-default dataLabels 
Don't always output series dataLabels element for chartex. Only output it if
necessary, meaning a non-default value.

Change-Id: Ie47b956cde0337bb82b268725c77d511da981d41
Signed-off-by: Kurt Nordback <kurt.nordback@collabora.com>
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/2966
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.com>
(cherry picked from commit 38af704dc0a8feab90007fbf3cd5388e0efd8294)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/206025
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
 2026-06-05 12:02:22 +02:00
Kurt Nordback a16459fc63 tdf#165742 Step 5.10: Don't export default shape props 
Don't export a series shape properties (spPr) for chartex charts if none was
present on input. Also a basic test for this.

Signed-off-by: Kurt Nordback <kurt.nordback@collabora.com>
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/2961
Reviewed-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit 32886b30c0539bfe1443434beeb1b3b27c93a4a7)
Change-Id: I5daf1d49762fe3b32c1c9254e0792b9eb34494e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205699
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-26 19:48:18 +02:00
Devansh Varshney 2049356d4f chart2: avoid overwriting values-y 
Implements a new calculated-y data structure which will be
useful in new chart types like histogram charts where the
axes are modified and hence have to preserve original raw
input values.

Change-Id: I339211d700501f263201a977741206cdb73e1cea
(cherry picked from commit 7bcf35bc40a3d0bb7452cff56c88d8b86c4b2d79)
Signed-off-by: Devansh Varshney <varshney.devansh614@gmail.com>
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/1877
Reviewed-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit 48a8b3165c543d1b46b92c1cf4941adc40fc11cd)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203687
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-23 00:09:26 +02:00
Kurt Nordback 8bf5b36ce1 tdf#165742 Step 5.9e: Store enumerated geography parameters as enums 
The projection type and region type are described in the OOXML spec as
enumerated values. Store them internally as such, converting from string on
input and to string on output.

Change-Id: I5ee9b6996362bf8cc8db28fc921f3b95bfb7ff46
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/2065
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.com>
(cherry picked from commit 00cb914655c1250656f81eed96ffd9df198387fb)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/204761
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-05-14 12:54:34 +02:00
Kurt Nordback cf04cdbcfa tdf#165742 Step 5.9d: Support for <cx:geography> tag 
Add support for import, storage, and export of <cx:geography> and its
children. This tag is used to express geography for regionMap charts. Also
includes one simple round-trip test.

Change-Id: Iccaef8b8cd2848ae3e48532c72507469c55ebefc
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/719
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.com>
(cherry picked from commit d5bfa4677609d5618a82d4aa3e182bba00054a01)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/204150
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-04-23 15:47:47 +02:00
Kurt Nordback 03ecbbadd4 tdf#165742 Step 5.9b: Support more children of layoutPr 
Provide round-tripping support for parentLabelLayout, regionLabelLayout,
statistics, and subtotals tags.

Change-Id: I6d5fb04ce54061dbb1e886157f9869030ff941d4
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/717
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.com>
(cherry picked from commit e91d8ff7a4cd84f444a9b01b64ad6df8d45f910e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/204148
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-04-23 13:37:43 +02:00
Kurt Nordback 9db38b095c tdf#165742 Step 5.9a: Support visibility child tag of layoutPr 
Provide round-tripping support for the <cx:visibility> child of
<cx:layoutPr> in chartex.

Change-Id: I23f4058e67cb00fa986f6a4e7d1c63e97d44a4d0
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/688
Reviewed-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit ef7013f120422cc796e8994ff7ba1396c5e84609)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/204147
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-04-23 13:37:34 +02:00
Xisco Fauli 5d9dfab134 Revert "tdf#165742 Step 5.10: Don't export default shape props" 
This reverts commit d160c4a17d.

Pushed accidentally.

Change-Id: I3ffb711f953cd0e1b9e3a92ac6852618bd72cf83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/204166
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-04-23 13:36:50 +02:00
Kurt Nordback d160c4a17d tdf#165742 Step 5.10: Don't export default shape props 
Don't export a series shape properties (spPr) for chartex charts if none was
present on input. Also a basic test for this.

Change-Id: I1692e8dbd160fa7d0db6fd0d50ca1ba42a9e9fca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202633
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
 2026-04-23 13:33:41 +02:00
Mehul Sharma 4381d485fc tdf#163738 Use insert() to add multiple values in containers 
instead of loop

Replace push_back with corresponding insert without changing the
behaviour of the code

Change-Id: Ib09ee67400131d68ce84148b8affcc881aecdd38
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203415
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
 2026-04-11 07:24:04 +02:00
Kurt Nordback c26dd0e1f2 tdf#165742 Step 5.8: Add minimal support for layout props 
Add framework for import/export of chartex layout properties (cx:layoutPr).
Also support the child cx:binning property, used for clusteredColumn charts
(and perhaps others). This allows the binning property to round-trip
successfully MSO -> LO -> MSO.

Change-Id: I54bd1692ce4fb59dd70c9d4ac68f108c33cbca8a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199553
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
 2026-03-24 06:57:32 +01:00
Noel Grandin 4b10710e09 loplugin:passstuffbyref 
Change-Id: I559d246b25c99e5cb7a28ba94e04a2acedd3e720
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200943
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2026-03-04 19:22:19 +01:00
Noel Grandin 8d5a6870a7 InternalDataProvider constructor always has 
bDefaultDataInColumns == true

Change-Id: I93c64a310852f1b823327874d9cc487c653c6222
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200860
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2026-03-03 07:58:19 +01:00
Gabor Kelemen a9e9175ba6 tdf#146619 Use more forward declarations in include/sfx2 
This shaves off some 300M of input
Change-Id: I2fae9ff6c6dab31010986e55365676d4a01f402d

Change-Id: I3b2551a1937929100f25c01c0c416a419e7fbb51
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199388
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
Tested-by: Jenkins
 2026-02-23 12:19:48 +01:00
Xisco Fauli 76ef93a709 crashreporting: fix crash in impl_createReferenceSizeProvider() 
Seen in https://crashreport.libreoffice.org/stats/crash_details/deb8f144-001b-4f79-9a7b-c0e8dd7d8c55

Most likely after
commit 76d296f760
Author: Noel Grandin <noelgrandin@gmail.com>
Date:   Thu Apr 10 20:02:01 2025 +0200

    fold ChartModelHelper functions into ChartModel

Change-Id: I959b1210254e741ac9dca492f2e70d86e86f3929
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197083
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2026-01-12 17:00:44 +01:00
Noel Grandin bc8765cd9f loplugin:unusedmethods 
Change-Id: Ib11352e8abb69b0923a19005f5eb1d4a0c748107
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196155
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-12-23 17:12:09 +01:00
Kurt Nordback 0686b19728 tdf#167941 - Chart color sequence OOXML import/export 
Support import, storage, and export of OOXML chart color styles
(color sequence). In OOXML, chart color styles are in files such
as colors1.xml, and conform to the chartStyle schema. This commit
supports I/O of color styles, and provides supports storing them
in the chart document model. It does not include any features for
using or modifying the color styles, so at this point it has no
appreciable effect on users.

Change-Id: I5c02137ebf9c25e11951eea55c4c77fda35b0e80
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194998
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
 2025-12-05 02:12:41 +01:00
Tomaž Vajngerl f15e0583c2 chart2: Add ComplexColor to many properties of chart elements 
This adds ComplexColor to many of the color properties that are
available in charts. It also handles some import code in oox, so
the complex colors are set correctly to the chart elements if an
OOXML document is loaded. This doesn't yet handle export and if
a theme is changed, as well if a color is changed manually in
the chart.

Change the tests so they now assert the scheme color like it is
defined in the source document and not the calculated derived
color.

In addition change the WriteRunProperties to have a struct as
an input instead a number of parameters, which in most cases don't
need to be filled out and are using the default value.

This was needed for the new parameter bUseTextSchemeColors, which
is used for charts, so the text colors use tx1 and tx2 elements
instead dk1 and dk2, which are usually used in Impress.

Change-Id: Iaebbaea983c5232c51233c1a02bd8fe1da24d551
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194939
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
 2025-12-04 08:21:07 +01:00
Noel Grandin 1bd04a5413 [API CHANGE] remove XPivotTableDataProvider 
in favor of a regular C++ interface class, since this is purely used internally to LO

Change-Id: I84991efb1b0c8829e2175dc083b0f8627fcb1712
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194512
Code-Style: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-11-26 10:06:23 +01:00
Silvery Freakz 86488ad12d Use assign() instead of insert() 
Since aOldBroadcasters is empty at this point, assign() is efficient than insert(). This is a cleanup following the already merged patch.

Change-Id: I8315a5c8021a67f003f84f3002a13c1511dc04c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192744
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
 2025-10-21 06:36:24 +02:00
codemaestro 4ce8861dd5 tdf#163738 Use insert() to add multiple values in containers instead 
of a loop

Change-Id: Ia8d4fa56dcb1e3b105a38b083365e35927d38384
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192582
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
 2025-10-20 12:18:13 +02:00
Kurt Nordback 33bbf0bd20 tdf#167941 - Chart style file is not supported in OOXML 
Parse the style*.xml file in the OOXML package, and store the imported
styles in XChartDocument via a new XChartStyle. Some areas are yet to be
fleshed out, but the intent here is to get a review of the general approach
and architecture. This includes no work on the export side (or the UI and
application of styles to a chart, which is a separate but related project).

Change-Id: I9d5b9f5aa44fb7944b2d971edc26e04dc2256c7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189531
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
 2025-09-03 16:54:45 +02:00
Noel Grandin 423f95aa13 tdf#168191 Incorrect labels of X-Axis in chart 
revert
    commit eeb8ca44ac
    Author: Noel Grandin <noel.grandin@collabora.co.uk>
    Date:   Fri Apr 4 10:02:06 2025 +0200
    tdf#147874 slow sheet switching with large chart2 (2)

Change-Id: I67dcea417be01982b769dd2bea387b4d29f0e732
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190520
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-09-02 15:46:41 +02:00
Marco Cecchetti 150525a38e lok: color preview: avoid chart color palette reset on preview 
Notify color preview state: enabled/disabled
Avoid current color palette to be cleared if user is just previewing a
color for a data series or a data point with the color picker.

Change-Id: I8b5fcd7e675d34f68b0323703ec509493fc48492
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186337
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190035
Tested-by: Jenkins
Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
 2025-08-24 23:21:44 +02:00
Manish 8cf9bdbade tdf#158237 Use C++20 contains() instead of find() and end() 
Change-Id: I9a17900837330031a906cb3526b624936ec87bd7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188790
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
 2025-08-08 21:07:16 +02:00
Markus Mohrhard 33f644074e OOXML handling of 1904 null date for charts with internal data provider 
Change-Id: Id7b70bd8d0f471fc56ffb3c8ce43a01a871491bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187835
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2025-07-15 18:47:14 +02:00
Kurt Nordback 4313451fc7 tdf#167368 - Chart style index is not exported to OOXML 
Add support for style index export, and a CI test for this.

Change-Id: Idb109ef705a6bf8338e18040d447c2806c0781ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187425
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
 2025-07-11 18:32:56 +02:00
Noel Grandin 5f69e0da74 use more concrete UNO classes 
Change-Id: I50cc798040c691ef95d351ba3869eebbb912784a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186592
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-06-18 07:54:36 +02:00
Noel Grandin f78f6f790c inline some constants 
these are only used in a single place

Change-Id: I9aae2331bc22e7ac842870a6b27030fc57c01b08
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186591
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-06-17 18:50:06 +02:00
Noel Grandin b144cc2fe1 use more concrete UNO class 
Change-Id: Id6616fac101cdcad0c7330b948e209c3905d993d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186590
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-06-17 09:58:22 +02:00
Marco Cecchetti e85be68352 chart color palette for data series: sidebar panel 
Change-Id: I6f661515e2de11ea1ead0b79435413d6a0e81c9d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184264
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185142
Tested-by: Jenkins
 2025-05-13 14:29:46 +02:00
Noel Grandin 796f8ff332 Revert "use more concrete UNO in chart2" 
This reverts commit 1886ecf7ee.

because reportdesign will pass in a OReportDefinition* and not a SvNumberFormatsSupplierObj*

Change-Id: Ic0068d18a10ce24ed74bb86cfef4cb9f34e9eeb2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184437
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-04-22 15:45:50 +02:00
Tomaž Vajngerl f355ddcbf2 chart2: fold isSupported* functions into ChartType 
This moves isSupported* function from ChartTypeHelper to ChartType
where it better belongs to. We can access the concrete classes now
instead of accessing through UNO si this is possible to do.

Change-Id: Icc52a8ba0d8ab6d5907d7942a1834cc6f7093cce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182712
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Jenkins
 2025-04-14 02:48:06 +02:00
Noel Grandin deb736a4f3 no need to use Sequence here 
Change-Id: I88b24d4703d6a1dcbe6a90936a01eb9f893e386a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184118
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-04-13 17:11:51 +02:00
Noel Grandin 4e5ea3b1fd fold DataSeriesHelper functions into DataSeries 
Where it better belongs, and where we can do a much better implementation.

Change-Id: I370bd23ee0dfb1570d6376d21b8dac4c83591096
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184098
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-04-13 14:20:31 +02:00
Noel Grandin 7bb586c436 fold DataSeriesHelper functions into DataSeries 
Where it better belongs, and where we can do a much better implementation.

Change-Id: I81aa687f28816aabed58a3fd26d22a8340c8bfc9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184070
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-04-12 19:48:37 +02:00
Noel Grandin 1aa34c45b6 fold DataSeriesHelper functions into DataSeries 
Where it better belongs, and where we can do a much better implementation.

Change-Id: Iec0c932b40512819bd6cc10afa3e2da93fa1e1b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184069
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-04-12 19:48:26 +02:00
Noel Grandin 18d5b8c5e5 fold DataSeriesHelper functions into DataSeries 
This moves functions from DataSeriesHelper to DataSeries
where it better belongs. We can access the concrete classes now
instead of accessing through UNO.

Change-Id: I15d38c782df3b04aeb2637049ba665b1d0e060ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184068
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-04-12 19:48:03 +02:00
Noel Grandin c804e7ffd6 fold DataSeriesHelper functions into DataSeries 
This moves functions from ChartModelHelper to ChartModel
where it better belongs. We can access the concrete classes now
instead of accessing through UNO.

Change-Id: I35ea769fdbd0af75ae791931505b61c73c4eeac6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184066
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-04-12 13:15:13 +02:00
Noel Grandin b81f1bce73 fold ColorPerPointHelper into DataSeries 
Where it better belongs, and where we can do a much better implementation.

Change-Id: I0ea8004778c3697bda97972cb842241459538c30
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184065
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-04-11 21:46:25 +02:00
Noel Grandin 76d296f760 fold ChartModelHelper functions into ChartModel 
This moves functions from ChartModelHelper to ChartModel
where it better belongs to. We can access the concrete classes now
instead of accessing through UNO si this is possible to do.

Change-Id: I21dce8aabe8f8a956863beef7ca5cb4ec6f3b44b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183990
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-04-11 07:07:23 +02:00
Noel Grandin 6a75480ce4 remove dead code in ChartModelHelper 
the new ChartModel class does not implement the older chart::XChartDocument
interface.

Change-Id: I952a870e6c7b592851d30bb0b55de3c5fb41f428
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183989
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-04-11 07:07:15 +02:00
Noel Grandin eeb8ca44ac tdf#147874 slow sheet switching with large chart2 (2) 
ExplicitCategoriesProvider is rather expensive to create, and we do it
twice.

So store it on the BaseCoordinateSystem object and share it, which means
we only need to construct it once.

This reduces switching time from 2s to 1s.

Note that I am not sure that this is the best location to store this,
the entire architecture of chart2 is a little opaque.

Change-Id: Ic9dc9573f7495bcb76de14caa7cc7d5ad61d9ed1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183700
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2025-04-04 17:49:31 +02:00
Noel Grandin 1886ecf7ee use more concrete UNO in chart2 
Change-Id: Id71c919abb85039d7fdfdb334e505f293e530255
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183706
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2025-04-04 14:21:15 +02:00