Commit Graph
11 Commits
Author SHA1 Message Date
Noel Grandin 423f95aa13 tdf#168191 Incorrect labels of X-Axis in chart
revert
    commit eeb8ca44ac
    Author: Noel Grandin <noel.grandin@collabora.co.uk>
    Date:   Fri Apr 4 10:02:06 2025 +0200
    tdf#147874 slow sheet switching with large chart2 (2)

Change-Id: I67dcea417be01982b769dd2bea387b4d29f0e732
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190520
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
2025-09-02 15:46:41 +02:00
Noel Grandin eeb8ca44ac tdf#147874 slow sheet switching with large chart2 (2)
ExplicitCategoriesProvider is rather expensive to create, and we do it
twice.

So store it on the BaseCoordinateSystem object and share it, which means
we only need to construct it once.

This reduces switching time from 2s to 1s.

Note that I am not sure that this is the best location to store this,
the entire architecture of chart2 is a little opaque.

Change-Id: Ic9dc9573f7495bcb76de14caa7cc7d5ad61d9ed1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183700
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
2025-04-04 17:49:31 +02:00
Noel Grandin a8b21abb09 Move cppu::BaseMutex up to the base class OPropertySet
Change-Id: I0e51987714e32ece19609c7a6d500995e6fc3601
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143674
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-06 09:11:18 +00:00
Noel Grandin 9c2e77152c loplugin:unusedfields make some fields private
this is one of the secondary analyses this plugin performs

Change-Id: Iaa4424c2396470c6f1df85b0290fbffdda35fa08
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143177
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-23 20:49:03 +01:00
Gabor Kelemen fef939d8ff Recheck module chart2 with IWYU
See tdf#42949 for motivation

Change-Id: Id4cdca3eed8618c289f30913d506f8f2bd46f0bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133112
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-04-23 16:33:58 +02:00
Noel Grandin 9f958c076a loplugin:passstuffbyref
Change-Id: I336fd329b577b6fa141265d8bc7ce67784bd7306
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133210
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-20 15:24:34 +02:00
Noel Grandin 333ccb081b use more concrete types in chart2, Axis
Change-Id: If80b6487ad2b8ac75f98f798b839aff2b8a5c23e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129522
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-05 20:39:03 +01:00
Noel Grandin d5e1fee5af use more concrete types in chart2, BaseCoordinateSystem
Change-Id: I780b391ffbff7cb79201eb2895702a7a9a07f89d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128829
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-23 20:21:21 +01:00
Noel Grandin 8a728ac6cf use more concrete types in chart2, ChartType
Change-Id: Ibd299e2e8d82169706d810af98c29d684809c320
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128741
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-22 16:08:05 +01:00
Noel Grandin c42a13c491 asan: fix symbol visibility in chart2
asan needs some more RTTI

Change-Id: I77ffe652c3252a6d9b71f3b29b085170963eba3d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128728
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-21 14:49:08 +01:00
Noel Grandin 2064cdb1cd use more concrete types in chart2, BaseCoordinateSystem
Change-Id: I1c246a3ea37595647ac254f492170a9e18540794
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128623
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-19 20:00:25 +01:00