Commit Graph
515582 Commits
Author SHA1 Message Date
Christian Lohmaier e03f367dce Update git submodules
* Update translations from branch 'master'
  to cb6093201d3db06cb268ba9c1ba91ab717998174
  - update translations for master
    
    and force-fix errors using pocheck
    
    Change-Id: Id7c6f38c6136c8b559e3af09fc0dd6bf54d914bf
2026-03-30 21:25:29 +02:00
Aron Budea 513b033c24 oox: Fix typo in DOCM filter name during detection
Otherwise affected files eg. fdo83844-1.doc fail to open.

Regression from 0f7cf56ca10e8b6cf34767d25281d783b416fbeb.

Change-Id: I55ba367b43e1ecdf586522ac1e47bb322bf12702
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202943
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Aron Budea <aron.budea@collabora.com>
(cherry picked from commit 026bd8e1f3be8c2d7c9fd64f7ff03833313d2d30)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202982
Reviewed-by: Justin Luth <jluth@mail.com>
Tested-by: Jenkins
2026-03-30 19:51:16 +02:00
RashmiVid 2d09ec6611 tdf#158237 Use contains() instead of find() != end() for maps/sets
Replace occurrences of find() != end() with contains() where supported.

Change-Id: Ie8e4625dc2e0f6e6b7273fe2190e52580eef90f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202908
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
2026-03-30 18:13:10 +02:00
iwritepoem 4abb556ae6 tdf#168520 Rename testTdf134053 to testTdf134053_dashed_line_round_cap
Change-Id: If267bc2ae1dfb3da2f586c28b3967909603cbca4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202700
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2026-03-30 17:49:58 +02:00
Hossein 228c03d878 Make odk unoapploader C code build with GCC 15.2
With GCC 15.2, compiler produces this error message:

[LOC] top level modules: odk
odk/source/unoapploader/unx/unoapploader.c: In function ‘createCommandName’:
odk/source/unoapploader/unx/unoapploader.c:285:13: error: assignment discards
‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
  285 |         sep = strrchr( prgname, SEPARATOR );
      |             ^
cc1: all warnings being treated as errors

By defining sep as "const char*" instead of "char*", the problem goes away.

Change-Id: If1d628dba8bb4ec657b916fa61927b250d3039c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202942
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
2026-03-30 17:41:16 +02:00
Xisco Fauli 107aff7382 sd: silence warning C6011: Dereferencing NULL pointer 'pObj'
Change-Id: Iff351140dd3ccbe3374ffdd4ecf657e4428c9e72
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202972
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2026-03-30 14:40:53 +02:00
Michael Weghorn 6669db65b7 qt6 configure: Fix file name in comment
Other than on Linux, library file names don't have a "lib"
prefix on Windows.

Change-Id: I1019ea4cc8c778c46ab2c8acca60623631dc7092
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202958
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2026-03-30 13:46:49 +02:00
Miklos Vajna 941872c82a svx: prefix members of SvxRuler
Change-Id: I5e8773c8513a94ab197b4a52b0755cab154d15c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202955
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2026-03-30 10:54:39 +02:00
Rafał Dobrakowski 8f76899b2d tdf#168771 - Convert enum to enum class
The package supporting the “pdfium” library has been improved.
Numeric values have been converted to a fixed-size enumeration type.
The changes apply to all occurrences of the older version of this code.

Change-Id: Ie9d0bd98d7c323f890ac3051bb1f08a50d51e046
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201303
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2026-03-30 10:05:05 +02:00
Jan Luethi c6cdc6dff5 tdf#143148: Use pragma once instead of include guards
Change-Id: I52d7fa6245a798e33dd3e4d38caa75f7081ecc92
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202782
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2026-03-30 07:35:56 +02:00
Jan Luethi 1ee5a42fff tdf#143148: Use pragma once instead of include guards
Change-Id: Ie9b08a5cd2ee826289b58141e38f39b80a7fc830
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202783
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2026-03-30 07:35:37 +02:00
Jim Raykowski 64a7d5179b tdf#140880 Navigator draw objects: Show group indicator
Enhancement for Writer Navigator to make grouped drawing object entries
expandable to show drawing objects in the group.

Change-Id: Iae6a20c50379e2f5473848bea649f4c0db593d72
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200914
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Jenkins
2026-03-30 03:47:16 +02:00
Shubham Shrivastav b3cef06759 tdf#143148: Use pragma once instead of include guards
Change-Id: I2fc2ca48c51b308379eebde77a40075e044c8587
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201968
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Dmitriy Usov <du@thesec.net>
2026-03-29 19:07:21 +02:00
Xisco Fauli eba177f95a tdf#171372 {ar-SA} currency symbol is ⃁ U+20C1 SAUDI RIYAL SIGN
... and displayed before amount.

Change-Id: I74c465961934c0e746479b82d2c4370ebda372d0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202472
Reviewed-by: Khaled Hosny <khaled@libreoffice.org>
Tested-by: Jenkins
2026-03-29 14:54:06 +02:00
Stephan Bergmann 06722ab080 -Werror,-Wundef (Emscripten)
Change-Id: I214ab5ad19173372849bf43a11a66f3c0b052238
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202930
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
2026-03-29 12:55:28 +02:00
Andrea Gelmini 1a70694e33 Fix typo "then"->"than" + "its" -> "it's"
Change-Id: I5386ca02fdcd415eb56f9a593d180ac991d88656
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202914
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
2026-03-29 09:50:27 +02:00
Andrea Gelmini ac3f25a2b2 Fix typo "then"->"than" + "its" -> "it's"
Change-Id: I3b258d33b9b18d3ea3ed1d9f30c821798802ce70
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202918
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2026-03-29 09:49:42 +02:00
Andrea Gelmini ad83edd7d6 Fix typo "then"->"than"
Change-Id: If44203c2b37491ff3ba7b1542789b62d7a0afbca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202917
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
2026-03-29 09:48:53 +02:00
Andrea Gelmini c217fca8a4 Fix typo "then"->"than"
Change-Id: I7003b14c27f91c792591c593a177ab21e1c7219d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202921
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
2026-03-29 09:48:07 +02:00
Andrea Gelmini 6da6760ed1 Fix typo "then"->"than" + "its" -> "it's"
Change-Id: I824cee5fe1ad6596e99ab0423797cefa29c81139
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202915
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2026-03-29 09:47:37 +02:00
Andrea Gelmini 23e66a1c71 Fix typo "then"->"than"
Change-Id: I1fb43e16d4a15b7e2cb15939fac408322e3531a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202913
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2026-03-29 09:46:56 +02:00
Andrea Gelmini 0b101f9534 Fix typo "then"->"than" + "its" -> "it's"
Change-Id: Ic9075594c73cbca92d800f01e613e12deff49dfd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202920
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2026-03-29 09:46:23 +02:00
Andrea Gelmini e95334a66e Fix typo "then"->"than"
Change-Id: Ic8a5797b0196f36288bf0af984dd074a2a443198
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202919
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2026-03-29 09:45:27 +02:00
Andrea Gelmini 19c19b98a8 Fix typo "then"->"than"
Change-Id: Idaea43025716b80e42f908544da31cded63c99db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202916
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2026-03-29 09:44:50 +02:00
Neil S Patel 2975a0bf92 tdf#158727 Support attribute leftvec leftharpoon in Math
. . . for improved RTL support

This includes wide variants for both wideleftvec and wideleftharpoon. OpenSymbol has been updated to include uni20D0 COMBINING LEFT HARPOON ABOVE and uni20D6 COMBINING LEFT ARROW ABOVE.

Change-Id: Id7f4ce2d3aad493a731f6b1be736c0aa8faa2027
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202922
Reviewed-by: Khaled Hosny <khaled@libreoffice.org>
Tested-by: Jenkins
2026-03-29 05:26:59 +02:00
4d3a291b5d Add Qt6 support for Windows
This patch makes it possible to build LibreOffice with Qt6 VCL plugin on
Windows.

In the configuration stage, it is required to add --enable-qt6 to the
configuration options, and also set the QT6DIR to the place where Qt6 is
installed:

export QT6DIR=/cygdrive/c/qt/6.10.2/msvc2022_64

When building with --enable-headless in addition, Cairo
based rendering is used by default, but the QFont based rendering
can explicitly be enabled by setting environment variable
SAL_VCL_QT_USE_QFONT=1 when starting LibreOffice, as is the case on
Linux.
When using the QFont based rendering, two asserts related
to logic related to alpha/transparency support not fully being implemented
for that rendering path yet are triggered (in QtVirtualDevice::SetSize
and QtGraphicsBackend::getBitmap). They can be commented for
further experiments. That also matches the behavior seens on
Linux.

For a debug build of Qt, the file names of the libraries include
an additional "d" in fron of the ".lib" file extension, e.g. a file
name of "Qt6Widgetsd.lib" instead of just "Qt6Widgets.lib",
so support both variants in configure.

This is partially based on a previous commits from jmux for Qt5 in 2018.
One may see the old patches using:

$ git checkout remotes/origin/feature/qt5-win+mac

A subsequent patch is planned to add Qt6 support for macOS.

Co-authored-by: Jan-Marek Glogowski <glogow@fbihome.de>
Co-authored-by: Michael Weghorn <m.weghorn@posteo.de>
Change-Id: I42a3059c738fa95464fa49ae4aab1c9f686fee46
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199615
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Reviewed-by: Hossein <hossein@libreoffice.org>
2026-03-29 01:08:40 +01:00
Michael Weghorn 047d4877b3 qt6 configure: Search moc also in $QT6DIR/bin
If QT6DIR is set, search for moc (Qt's meta object compiler)
also in the "bin" subdirectory, which is where moc is placed
in Qt installations on Windows, unlike the "libexec" subdir
that (typically) gets used on Linux.

Only use the $QT6DIR subdirectories when the QT6DIR variable
is actually set (i.e. don't add /bin or /libexec to the search path
otherwise, which was previously the case for /libexec, though
other than /bin that doesn't typically exist on a Linux
system) and give the $QT6DIR subdirectories the highest
preference by putting them first.

This prepares for the pending Gerrit change [1] to
support the qt6 vcl plugin also on Windows.

[1] https://gerrit.libreoffice.org/c/core/+/199615

Change-Id: I38d5f7116368e10b12a242bd1ad122a5f4a82736
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202905
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
2026-03-29 01:06:47 +01:00
Justin Luth 0731c7ec7c tdf#171527 doc import: add ParaFrameProperties grabbag to Apo
When DOCX imports a frame
that has been defined by paragraph properties (framePr),
it simply flags that with a grabbag.

Do the same for DOC import.

That is because you CAN have fly-in-framePr,
but you can't have fly-in-fly,
and that was how we were importing DOC previously.

This matters at export time,
since DOCX reports a file as corrupt if it has fly-in-fly.

make CppunitTest_sw_ooxmlexport27 \
    CPPUNIT_TEST_NAME=testTdf171527_flyInFramePr

Change-Id: Iace48a119194baa580206140f9564de8d4e0ab1c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202892
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
2026-03-28 12:56:39 +01:00
Michael Weghorn 9b1e5b102b vcl win: Move WindowsInstance::m_aPrinters to WindowsInstanceData
Move the list of printers from WindowsInstance
to the WindowsInstanceData owned by WindowsInstance,
to make this consistent with other data owned by
the WindowsInstance, see previous commits

    Change-Id: I409a0b05fea9a538c97c493fead9836f01665ed1
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Fri Mar 27 17:13:41 2026 +0100

        vcl win: Move temp font paths from SalData to WindowsInstance

and

    Change-Id: I1f3719d5bccb6af2d661050de23770896494db4a
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Sat Mar 28 01:16:09 2026 +0100

        vcl win: Move text renderers from SalData to WindowsInstance

that introduced WindowsInstanceData and moved other
members from SalData to that new struct after

    commit b343973bc4
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Fri Mar 27 10:16:40 2026 +0100

        vcl win: Move printers list from SalData to WindowsInstance

had previously moved the printers list directly to WindowsInstance
when WindowsInstanceData didn't exist yet.

Change-Id: I7c1c68e0b2cb38eb1be59a4bb96953a8ccd3f577
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202898
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2026-03-28 12:30:27 +01:00
Michael Weghorn d574c9544e vcl win: Move text renderers from SalData to WindowsInstance
Instead of having the text renderers owned by the Windows-
specific SalData, let them be owned by WindowsInstance,
by moving them to the WindowsInstanceData struct introduced
in previous commit

    Change-Id: I409a0b05fea9a538c97c493fead9836f01665ed1
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Fri Mar 27 17:13:41 2026 +0100

        vcl win: Move temp font paths from SalData to WindowsInstance

to move another member for the same reason.

Storing this in the WindowsInstance makes sure
that this also works for WindowsInstance subclasses
that don't use the Windows-specific implementation
of SalData.

This will be relevant for the qt6 vcl plugin on Windows
(see WIP change at [1] when using Cairo rendering
(with the --enable-headless autogen switch enabled)
where GenericUnixSalData will be used for the
SalData implementation in order to get FreeType
and Fontconfig support, but the text renderes
now moved to the WindowsInstance are still used
in the process of printing, so need to be available.

[1] https://gerrit.libreoffice.org/c/core/+/199615

Change-Id: I1f3719d5bccb6af2d661050de23770896494db4a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202897
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2026-03-28 12:30:02 +01:00
Michael Weghorn 1529c020bc vcl win: Move temp font paths from SalData to WindowsInstance
Instead of storing the paths for temporary fonts
in the SalData, let them be owned by WindowsInstance,
by introducing a new WindowsInstanceData struct
that initially has a `m_aTempFontPaths` member
that replaces the previous SalData::maTempFontPaths.

Storing this in the WindowsInstance makes sure
that this also works for WindowsInstance subclasses
that don't use the Windows-specific implementation
of SalData.

This will be relevant for the qt6 vcl plugin on Windows
(see WIP change at [1] when using Cairo rendering
(with the --enable-headless autogen switch enabled)
where GenericUnixSalData will be used for the
SalData implementation in order to get FreeType
and Fontconfig support, but the temporary fonts
now moved to the WindowsInstance are still used
in the process of printing, so need to be available.

[1] https://gerrit.libreoffice.org/c/core/+/199615

Change-Id: I409a0b05fea9a538c97c493fead9836f01665ed1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202896
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2026-03-28 12:29:49 +01:00
Michael Weghorn a633dbd1c4 vcl: Return instead of using out param in psp::getPrinterPathList
Change-Id: Ib952e6c1b79e3d99ff4034921616b3d0b04c559f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202846
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
2026-03-28 12:28:58 +01:00
Michael Weghorn 771d4aeace vcl: Pass SalInfoPrinter::SetData's job setup param by ref
... instead of by pointer. This makes more clear
that it's always non-null.

Change-Id: Iaaf806a9575b20cdb7065b24b409aa9cfdf6f74b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202845
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2026-03-28 12:28:35 +01:00
Michael Weghorn 29c794be69 vcl: Deduplicate/Unify SalInfoPrinter::SetPrinterData comments
Sync the one in the base class with the comment in
the PspSalInfoPrinter subclass, tune grammar a bit,
and drop the comment in the subclass as it's not
specific to that one.

Change-Id: Ib37aafc07346e521785b58719460d07f3a1316f6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202844
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2026-03-28 12:28:12 +01:00
Michael Weghorn 5504e75006 vcl: Pass SalInfoPrinter::Setup params by ref
... instead of by pointer. This makes clear they're
always non-null (and allows to drop corresponding
checks done in one, but not all implementations).

Change-Id: Icb459121fe637a1d0f63c192af3bbc360bef6547
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202843
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2026-03-28 12:27:54 +01:00
Michael Weghorn 4d1d71b6b8 vcl: Iterate directly over the PrinterInfoManager printer map
Instead of having PrinterInfoManager::listPrinters as a getter
that returns the keys in the std::unordered_map and then calling
PrinterInfoManager::getPrinterInfo for each of the keys to get
the corresponding entry again, add a new getter to return
a const ref to the map and iterate over that one directly
in SalGenericInstance::GetPrinterQueueInfo and
SvpSalInstance::GetPrinterQueueInfo.

Change-Id: I36a0ec712bd8f815c2de51afcdd7f7a605a28ab0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202842
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2026-03-28 12:27:25 +01:00
Michael Weghorn da945e1343 vcl: Drop PrinterInfoManager::Printer struct with only one member
After

    Change-Id: Ic1d5c510c7a69de53d760aa3fc9729c61a31aa10
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Fri Mar 27 04:59:41 2026 +0100

        vcl: Drop PrinterInfoManager::Printer::m_aAlternateFiles etc.

, the PrinterInfoManager::Printer struct now only has a single
PrinterInfo member.

Drop the struct, and use PrinterInfo directly instead.

Change-Id: I88f05675cdf1ecfa8ba26974c6f4a704ee415315
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202841
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2026-03-28 08:39:43 +01:00
Michael Weghorn 0b15784704 vcl: Drop PrinterInfoManager::Printer::m_aAlternateFiles etc.
PrinterInfoManager::Printer::m_aAlternateFiles is only written
to, never read from, apparently since

    commit 1534025a03
    Date:   Sun Sep 23 08:48:06 2018 +0200

        loplugin:methodcycles more graph theory for the win

Drop it.

This also makes PrinterInfoManager::Printer::m_aFile useless,
so drop that as well.

Change-Id: Ic1d5c510c7a69de53d760aa3fc9729c61a31aa10
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202840
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2026-03-28 08:39:12 +01:00
Michael Weghorn 14e77b3a8e vcl: Pass SalGenericInstance::configurePspInfoPrinter params by ref
... instead of by pointer. Also make the method private. It's only
used internally.

Change-Id: I6d9c539ca0b8181294492d341c04d6990ef51dc6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202777
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2026-03-28 08:38:58 +01:00
Michael Weghorn b6ad2ad5a6 vcl: Pass SalInfoPrinter::SetPrinterData param by ref
... instead of by pointer.

Change-Id: I61ced0232935c35de4d3036df15ee0b744b07068
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202770
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2026-03-28 08:38:30 +01:00
Michael Weghorn 24877653c2 vcl iOS: Drop redefinition of SalGenericInstance::PostPrintersChanged
This method is now already defined in the header since

    commit 8f4c0c4fa6
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Wed Mar 11 04:10:27 2026 +0100

        vcl: Have a default SalGenericInstance::PostPrintersChanged impl

, so drop the earlier dummy implementation for iOS.

Change-Id: Ifabb4c1030aa2f351af44f2959f6c439f593908e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202769
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
2026-03-28 08:38:10 +01:00
Michael Weghorn b329866eb1 vcl iOS: NULL -> nullptr
Change-Id: I8f12247e36d2140531734e5114de51fca7fe7822
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202768
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2026-03-28 08:37:52 +01:00
Michael Weghorn 516d53743e vcl: Pass SalInstance::CreateInfoPrinter's ImplJobSetup param by ref
... instead of by pointer.

This also allows dropping a few null checks.

Change-Id: I0b215bcf9c2f691f93990530a412546859e492a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202767
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2026-03-28 08:37:39 +01:00
Michael Weghorn f696f14641 vcl: Pass SalInstance::CreateInfoPrinter's queue info param by ref
... instead of by pointer.

This also allows dropping a null check in
AquaSalInstance::CreateInfoPrinter.

Change-Id: Ibd8045ec0560e6490c54ad45266cc369eece2363
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202766
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
2026-03-28 08:37:21 +01:00
Michael Weghorn 48ff44e464 vcl: Pass SalInstance::GetPrinterQueueInfo param by ref
... instead of by pointer that is always non-null.

Change-Id: Id57f7b613170a4cae122967ee85a4280a38c325d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202765
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2026-03-28 08:36:56 +01:00
Michael Weghorn ff0db9a9e4 vcl: Pass Printer::ImplInit param by ref
... instead of by poiner. It's known to be non-null.

Change-Id: I7194b7df11804acc19d586e41730d9ca6b4fc2f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202763
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
2026-03-28 08:36:33 +01:00
Michael Weghorn 5215ad6d47 vcl win: Use more specific type for SalData::m_pD2DWriteTextOutRenderer
Use the more specific D2DWriteTextOutRenderer type from the
start instead of casting later in TextOutRenderer::get.

Change-Id: I3e1b7650fd0262b98f7b13357fbc373efaa845eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202887
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2026-03-28 01:22:29 +01:00
Michael Weghorn ea6b1da65d qt configure: Move vars closer to use, have separate one for suffix
Instead of having a `qt6_test_library` var that includes both
the base name and the suffix, have the suffix in a separate
variable. This will make it easier to support Windows as well,
where the suffix can be either just ".lib" or "d.lib", because
libraries built with debug symbols have the extra "d" in the name.

(Prepares for supporting debug builds of Qt in pending WIP
change [1] to support the qt6 VCL plugin on Windows.)

[1] https://gerrit.libreoffice.org/c/core/+/199615

Change-Id: I57f916189ea62b630a88f3977c89c4e9382a574b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202883
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
2026-03-28 01:22:20 +01:00
Michael Weghorn ceaa1818f3 vcl win: Drop TempFontItem struct
After previous commit

    Change-Id: I1133854b67e526092e4939e685c6812b9292ca21
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Fri Mar 27 11:16:51 2026 +0100

        vcl win: Use std::unordered_set for temp font items in SalData

, the TempFontItem struct only has a single OUString member.

Use OUstring directly and drop the TempFontItem struct.

Change-Id: Ic46246d68a3554afe9c7d909bc4c23f66844aa41
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202863
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2026-03-28 01:22:12 +01:00
Michael Weghorn 3ae8f07ebb vcl win: Use std::unordered_set for temp font items in SalData
... instead of manually implementing a linked list.

The order of the elements is irrelevant and there
is no need to store duplicate elements, so an
unordered set seems appropriate.

Further simplification will follow in an upcoming commit.

Change-Id: I1133854b67e526092e4939e685c6812b9292ca21
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202862
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2026-03-28 01:21:33 +01:00