...that had been missing because the plugin didn't implement postRun, so it
didn't report anything when run as part of the shared plugin. (But did report
the expected warnings when run as a standalone plugin during
CompilerTest_compilerplugins_clang.)
Most fixes are straightforward. A noteworthy one is PreparedStatement::setBytes
in connectivity/source/drivers/postgresql/pq_preparedstatement.cxx: The old
preallocation of a 20 character OStringBuffer might have prevented
buf.append( reinterpret_cast<char *>(escapedString), len -1 );
from potentially throwing std::bad_alloc, which would have caused escapedString
to be leaked. Even though that 20-character preallocation was likely just
random junk and not meant to address the potential leak, lets address it now.
Change-Id: Ib506332d061684a22a74e5e39e591539fd2c4900
Reviewed-on: https://gerrit.libreoffice.org/80925
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Which is now exactly the same as PROP_FOLLOW_TEXT_FLOW, so no need to
set it separately.
Change-Id: I32e1e2bdfb8ac46eb6a07f5187f780275d334b2f
Reviewed-on: https://gerrit.libreoffice.org/80926
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
if in cpu-threaded mode so that we can avoid the unnecessary
locked SvNumberFormatter::GetType() calls (Mapping between NF index
and NF-type does not change while formula-group-threading
is running).
Change-Id: I648bc08c885da845f0b09cd57013cc1c23e01a61
Reviewed-on: https://gerrit.libreoffice.org/80848
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
and compile it with -arch:SSE2 if Windows.
This code however gets called only if cpuid::hasSSE2()
is true, so this does not cause problems with machines
without SSE2 support.
Change-Id: Ice23ac71d4c577b8811b08c74a3ca500a94fdc09
Reviewed-on: https://gerrit.libreoffice.org/80847
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
and reuse them for interpret'ing all cells under the
respective threads. This gives a sizeable win in the execution
time especially for long formula-groups.
Change-Id: Ib340950f21e863b5b821d20c092214d8bc5012aa
Reviewed-on: https://gerrit.libreoffice.org/80845
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
It started out as a wrapper around character literals, but has by now become a
wrapper around arbitrary single characters. Besides updating the documentation,
this change is a mechanical
for i in $(git grep -Fl OUStringLiteral1); do sed -i -e s/OUStringLiteral1/OUStringChar/g "$i"; done
Change-Id: I1b9eaa4b3fbc9025ce4a4bffea3db1c16188b76f
Reviewed-on: https://gerrit.libreoffice.org/80892
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Followup for LO 5.4 commit 6f2ad89b33d972f9642bb53eeb91f41df3b6b0e6
which set Calibri/11pt as default. That is true if there is
no style.xml file, or more specifically if there is no
DocDefaults rPrDefault node. But if that node exists, then
the age-old defaults are still valid.
Earlier in LO 4.3, the default templates changed to use
Liberation fonts by default. But in the same vein as using Calibri
(and depending on LO to fallback to Carlito), set Word's default
Times New Roman font and depend on LO to fallback to Liberation.
That will make it better for MSWord users who share the document
and who have less likelihood of knowing about Liberation/Carlito.
Note that 10pt fontsize was already added to m_pDefaultCharProps
earlier, so that part was already reset long ago.
Change-Id: I3ba8a529fe95b05fbe2889cf1ebdbabb25963e8b
Reviewed-on: https://gerrit.libreoffice.org/80854
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
The combination "PRINTER+false" is not supported, i.e. it's
currently not supported to generate individual print jobs for
a subset of data records instead of one job per mail merge run.
The possibility to do so had been added by commit
138d29aa09
("support fast MM printing in non-single-file mode only for CUPS"),
but was removed again by commit dea0abc58c
("tdf#93236 Revert "support fast MM printing in...") and
commit b6a698b093
("tdf#95251 MM just allow print as single document"), so
update the README accordingly.
Change-Id: I83afc1949915434c95bdcb58e1d09dc2c900c500
Reviewed-on: https://gerrit.libreoffice.org/80884
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This extends the filter comparison from commit c3a1c83ff5
("tdf#42316 preserve macro signature of templates").
The original patch just stripped "_template" from the source
filter to find equal document types, which just enables the
"template => document" case. This patch also strips the
"_template" from the target filter, which fixes the "document
or template => template" cases.
This also extends the signing save tests:
* OTT 1.2 => OTT 1.2 - preserve
* ODT 1.2 => OTT 1.2 - preserve
* OTT 1.0 => OTT 1.0 - preserve
* ODT 1.0 => OTT 1.0 - preserve
* OTT 1.0 => OTT 1.2 - drop
Change-Id: Ie297258a4d9f9aa4beb25786c6ba240b6f16f49b
Reviewed-on: https://gerrit.libreoffice.org/80654
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Now change tracking protection from Writer or from ODT files
is exported to DOCX.
In Writer it's always possible to disable change tracking
protection without password in File->Properties->Security page->
Record Changes after confirmation.
Now Writer uses the same confirmation to remove change
tracking protection imported from DOCX, for example clicking
on Record Track Changes. Disabled protection removes the
export of the grab-bagged change tracking protection, too,
to avoid of creating bad DOCX with enabled change tracking
protection and disabled Record change tracking.
See also commit d416250f4f
"tdf#106843 DOCX: forbid disabling protected Record Changes"
Change-Id: Ida4d72c57dbe5450ea22028bbed69d413f5a786d
Reviewed-on: https://gerrit.libreoffice.org/80784
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
and extend O*StringView to have a constructor that takes a pointer and a
length
Change-Id: I6120e96280f030757e855a6596efdae438b7e1e8
Reviewed-on: https://gerrit.libreoffice.org/80872
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
w:framePr of page header doesn't mean real frame conversion,
so don't store and lose redlines after it.
Regression from commit e8bae67b3d
"tdf#125894: DOCX: import tracked changes in frames".
Change-Id: I46cd153cccef4824deca1f64341f2ea6672cdc42
Reviewed-on: https://gerrit.libreoffice.org/80871
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
We want debug builds there, but the debugging symbols for debugger
themselves are not actually needed (Linux builds use the debug symbols
for printing backtraces when a unittest crashes, but Win/Mac do not).
This should save generating the needless debug info (CPU and I/O).
Change-Id: I3fc8bdb66e4822838216359b23b8a2dd5f2a0f42
Reviewed-on: https://gerrit.libreoffice.org/80732
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
They always start with 'make clean' (at least according to the logs),
so they are always one-time builds where creating dependencies
is not needed.
Change-Id: If402fbaa21bd213e3f781985479dd49c266ca511
Reviewed-on: https://gerrit.libreoffice.org/80730
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Grab focus of the TreeView when the macro chooser is created
Change-Id: Idfe3d2435840103eb2fa0ec5d17efce0931cfabd
Reviewed-on: https://gerrit.libreoffice.org/80095
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
by hand, because I don't feel like teaching this specific idiom to the
plugin
Change-Id: If400677dac842ca740c4532ed79f6f18f752b730
Reviewed-on: https://gerrit.libreoffice.org/80842
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
I removed the same check in the WW8 import in commit
d630f69d90 (Related: tdf#124601 DOC
import: improve fLayoutInCell handling, 2019-09-26). There is no reason
the DOCX import shouldn't do the same, just for consistency.
Change-Id: I9e56a3fcd0b13ba08e347fbc06b0960ac21b372c
Reviewed-on: https://gerrit.libreoffice.org/80856
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
The implementation of 'SwEditShell::ApplyAdvancedClassification'
helped to find out how to access the text in the header.
Change-Id: If044eea2e7d012ef56c0fff38a17af4aa59fea25
Reviewed-on: https://gerrit.libreoffice.org/80815
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Don't only check the first SwPageDesc, but also its
follows whether they have a header or footer and copy
the page styles in this case, since otherwise the
header/footer content can be wrong if the first page's
page style doesn't have header/footer but a following
one does.
Change-Id: If5ef76a7faf93ad533976b501f35f171336615c8
Reviewed-on: https://gerrit.libreoffice.org/80814
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
Stephan Bergmann