* Update helpcontent2 from branch 'master'
to 1f0e174580e7a87f2979a728f38e6be86eb741c4
- tdf#134628 Update help text to match UI after commit f331da1fe4
Change-Id: I03164545179d3aa714130881081786d7944c6cfd
* Update helpcontent2 from branch 'master'
to bed08b8295929631de2eab46387541d97a9805bc
- Use actual degree symbol instead of superior letter
Easily confusable, because in some countries, keyboards include “°” and
in others “º”. In. The. Same. Key. I despise whomever decided that.
Change-Id: Id30e8f86e3cc2eafc12acda9a13c00d8a5b64053
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/203393
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
-Using positive phrase "Apply system input language to new text".
-Inverted the checkbox logic in the UI to match the phrase.
-Renamed UI to reflect positive phrase (useinputlanguage)
-Updated tooltip to describe the behavior.
Co-authored-by: Isha Desai <2020.isha.desai@ves.ac.in>
Change-Id: Ib443e86671e1defc7e49ae3a5fed2aef8dc5ecda
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203205
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Jenkins
When performing a fill operation, only visible cells are affected
skipping filtered rows (done in ScTable::FillSeries).
Change-Id: Ie05afa31aebce2397a9aea2837dd0929793570bf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203334
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Instead of having one switch/case to create the tab page
and another one where the newly created tab page needs to
be cast to the specific subclass in order to call methods,
rather create the tab pages of the specific subclasses right
in the same switch/case where the methods are then called.
Adjust the return value of the various <TabPageName>::Create
methods to return the specific subclass of which they create
instances.
Change-Id: If16c7d73c50894a19751eb54f9c3caa522ad12b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203383
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
(`git show --ignore-space-change` can help to see the
"actual" change more easily.)
Change-Id: I7226c21980d2c9c03d5640b7f1908b52e4aa7f36
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203382
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
This e.g. makes sure that double-clicking on an item in
the icon view in Writer's "Insert" -> "Fontwork" dialog
activates the item and thus triggers its insertion instead
of entering edit mode and allowing to enter a text for the item
when using the qt6 VCL plugin with SAL_VCL_QT_USE_WELDED_WIDGETS=1.
Change-Id: Iaaaabb4b1728024a52d2063390bae496b58297e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203381
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Drop SvxColorTabPage::SetPropertyList and set
SvxColorTabPage::m_pColorList directly instead,
without requiring casting because of passing
a less concrete rtl::Reference to
SvxColorTabPage::SetPropertyList first.
Change-Id: If62ff1777619520d26294e58fda23e7e18ca68cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203379
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Earlier commit
Change-Id: Ie749ca45cf7da76faf38e8e42eb9a41346f00856
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Thu Apr 9 14:37:25 2026 +0200
weld: Deduplicate item selection change signal logic
moved the logic to signal about selection changes in
weld::TreeView and weld::IconView to the weld::ItemView base
class.
Also deduplicate the logic in the qt weld implementations,
by connecting to the QItemSelectionModel::selectionChanged
signal and calling weld::ItemView::signal_selection_changed
in the QtInstanceItemView base class, instead of implementing
the same in each of the two subclasses.
Change-Id: Ib1fa9d48fbda8c1d82d0188ae1455b9084b1f77a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203370
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Drop QtInstanceIconView::m_pSelectionModel and
QtInstanceTreeView::m_pSelectionModel and instead
reuse the existing getter in the QtInstanceItemView
base class to get the selection model from the view
on demand.
Change-Id: I703b009cf49ed4a6301ac7928945b350ac79bdfc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203369
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
weld::TreeView and weld::IconView implement the same
logic for signalling about selection changes.
Deduplicate that by moving it to the weld::ItemView
base class.
Change-Id: Ie749ca45cf7da76faf38e8e42eb9a41346f00856
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203368
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Switch the param for the signal and handlers used when
the selection in a weld::IconView changes from weld::IconView&
to the base class, weld::ItemView&.
This is in preparation of moving the logic to the weld::ItemView
base class in an upcoming commit.
This is the IconView equivalent of previous commit
Change-Id: I0bbf8fe1dbd95906a5224155d48d832bcd144532
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Thu Apr 9 13:45:18 2026 +0200
weld: Switch TreeView selection changed signal param to ItemView
Change-Id: I87fad3a129128d4387adfdd75d18e93f05af5e84
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203367
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Switch the param for the signal and handlers used when
the selection in a weld::TreeView changes from weld::TreeView&
to the base class, weld::ItemView&.
This is in preparation of moving the logic to the weld::ItemView
base class in an upcoming commit.
Handler implementations that require a weld::TreeView
instance can use the one that the signal is connected
to, e.g. use the class member directly inside of the
implementation instead of using the param (as is done
in most of the places anyway).
Change-Id: I0bbf8fe1dbd95906a5224155d48d832bcd144532
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203366
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Use SwNumPositionTabPage::m_xLevelLB directly instead of
the weld::TreeView& param passed to the handler.
That is the weld::TreeView that the handler is connected to.
This prepares for switching the signal/handler param to
weld::ItemView& in an upcoming commit, in order to deduplicate
the weld::TreeView and weld::IconView implementations by moving
the logic to their shared weld::ItemView base class.
Change-Id: I94b414f479ae4afb4de1e1b2140f4384d137c03d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203365
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Extract the SwOutlineSettingsTabPage::LevelHdl logic to a new
helper method SwOutlineSettingsTabPage::ApplyLevelSelection
that doesn't require passing the
SwOutlineSettingsTabPage::m_xLevelLB member, but uses it directly.
This is also in preparation for switching the signal/handler param to
weld::ItemView& in an upcoming commit, in order to deduplicate
the weld::TreeView and weld::IconView implementations by moving
the logic to their shared weld::ItemView base class.
Change-Id: Ia977a2db5c7f4d40a11ad0fc6279176ca4c0b052
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203364
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Extract the SwGlossaryDlg::GrpSelect logic to a new
helper method SwGlossaryDlg::SelectGroup
that doesn't require passing the
SwEditRegionDlg::m_xCategoryBox member every time, but
uses it directly.
This is also in preparation for switching the signal/handler param to
weld::ItemView& in an upcoming commit, in order to deduplicate
the weld::TreeView and weld::IconView implementations by moving
the logic to their shared weld::ItemView base class.
Change-Id: I0e3cee95bd1954659acac69b0bce70847d274b03
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203363
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Extract the SwEditRegionDlg::GetFirstEntryHdl logic to a new
helper method SwEditRegionDlg::UpdateFromSelection
that doesn't require passing the
SwEditRegionDlg::m_xTree member every time, but
uses it directly.
This is also in preparation for switching the signal/handler param to
weld::ItemView& in an upcoming commit, in order to deduplicate
the weld::TreeView and weld::IconView implementations by moving
the logic to their shared weld::ItemView base class.
Change-Id: Ib8fb1eedc20d11e7b7490e3c15d86b93681bfe19
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203362
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Use SvxBulletAndPositionDlg::m_xLevelLB directly instead of
the weld::TreeView& param passed to the handler.
That is the weld::TreeView that the handler is connected to.
This prepares for switching the signal/handler param to
weld::ItemView& in an upcoming commit, in order to deduplicate
the weld::TreeView and weld::IconView implementations by moving
the logic to their shared weld::ItemView base class.
Change-Id: I689c6edb4dba442c3eb7616286ecd78e9b76f63a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203360
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Use OfaAutocorrReplacePage::m_xReplaceTLB directly instead of
the weld::TreeView& param passed to the handler.
That is the weld::TreeView that the handler is connected to.
This prepares for switching the signal/handler param to
weld::ItemView& in an upcoming commit, in order to deduplicate
the weld::TreeView and weld::IconView implementations by moving
the logic to their shared weld::ItemView base class.
Change-Id: If35adae3843821c9d8cee1d07e146634064103e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203358
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
There is nothing specific to weld::TreeView in that
method, so move it to the weld::ItemView base class.
This allows to reuse it for weld::IconView as well,
which also subclasses weld::ItemView.
Change-Id: Ia6ef9e1aee19d99bf82b07d02ded700c1914f450
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203357
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Now that
Change-Id: I0281645e99492139d53f6a50403237eff8cde6a2
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Thu Apr 9 09:33:32 2026 +0200
weld: Deduplicate IconView/TreeView item activation signalling
moved the previously duplicated logic from the weld::IconView
and weld::TreeView base classes to the weld::ItemView
base class, also do similarly for the qt weld implementations:
Implement logic once in the QtInstanceItemView base class,
instead of having the same logic in both, QtInstanceIconView
and QtInstanceTreeView.
Change-Id: I4c0acfa7e65e2838fd727012f772ec73a312227b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203356
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Now that
Change-Id: I0281645e99492139d53f6a50403237eff8cde6a2
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Thu Apr 9 09:33:32 2026 +0200
weld: Deduplicate IconView/TreeView item activation signalling
moved the previously duplicated logic from the weld::IconView
and weld::TreeView base classes to the weld::ItemView
base class, also do similarly for the vcl implementations:
Implement logic once in the SalInstanceItemView base class,
instead of having the same logic in both, SalInstanceIconView
and SalInstanceTreeView.
Change-Id: I99aa6cb208c89e20917cf725e6f5171f27b2d47d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203355
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
In MacroManagerDialog::SelectHdl remember the TreeView widget
for the m_xScriptContainersListBox and use that instead of the
TreeView param after checking that both are the same widget.
This prepares for switching the signal/handler param to
weld::ItemView& in an upcoming commit, in order to deduplicate
the weld::TreeView and weld::IconView implementations by moving
the logic to their shared weld::ItemView base class.
Change-Id: I751e7b4018de6fcb321819375e92f83bd4da4122
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203354
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Use SvxThesaurusDialog::m_xAlternativesCT directly instead of
the weld::TreeView& param passed to the handler.
That is the weld::TreeView that the handler is connected to.
This prepares for switching the signal/handler param to
weld::ItemView& in an upcoming commit, in order to deduplicate
the weld::TreeView and weld::IconView implementations by moving
the logic to their shared weld::ItemView base class.
Change-Id: I4ab385d1db78490d6215d98e958ffca08da0c38f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203353
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Use SvBaseLinksDlg::m_xTbLinks directly instead of
the weld::TreeView& param passed to the handler.
That is the weld::TreeView that the handler is connected to.
This prepares for switching the signal/handler param to
weld::ItemView& in an upcoming commit, in order to deduplicate
the weld::TreeView and weld::IconView implementations by moving
the logic to their shared weld::ItemView base class.
Change-Id: I0d0488cb49ae5451e2f6612c50618dad7fb30547
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203352
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
weld::IconView and weld::TreeView implement the same logic
to subscribe to and emit signals when an item/row is activated.
Deduplicate that by moving the logic to the shared
weld::ItemView base class.
While at it, also adjust the connect_item_activated
doc so far only explaining the TreeView case (for both
implementations, also the IconView one, which was
probably just copy-pasted earlier) to also take
into account the IconView case.
Change-Id: I0281645e99492139d53f6a50403237eff8cde6a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203351
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Rename methods and field related to signalling activation
of a weld::TreeView row to use the same names as the equivalent
ones for signalling activation of an entry in weld::IconView:
* weld::TreeView::m_aRowActivatedHdl -> weld::TreeView::m_aItemActivatedHdl
* weld::TreeView::signal_row_activated -> weld::TreeView::signal_item_activated
* weld::TreeView::connect_row_activated -> weld::TreeView::connect_item_activated
This is in preparation of deduplicating the weld::TreeView
and weld::IconView implementations for these by moving them
to the common weld::ItemView base class in an upcoming commit.
Change-Id: I4ca4dec1295c57cea574b68fd41b89c12144c4f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203350
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Since commit
Change-Id: Ie6a962702d4f7f069b2f7b77a22a78722b2a6408
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Wed Apr 8 18:48:12 2026 +0200
weld: Pass activated row in TreeView::signal_row_activated
, the activated row is passed as a param to the signal
handler. Make use of it, instead of determining the activated
row a different way.
Change-Id: I3722fc3ff3bb80b865b709c1c46e2f9a46965ac5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203349
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Since commit
Change-Id: Ie6a962702d4f7f069b2f7b77a22a78722b2a6408
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Wed Apr 8 18:48:12 2026 +0200
weld: Pass activated row in TreeView::signal_row_activated
, the activated row is passed as a param to the signal
handler. Make use of it, instead of determining the activated
row a different way.
Change-Id: I4558a4a4edcaa16c09d8d8fd40c6224d21149b54
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203348
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Since commit
Change-Id: Ie6a962702d4f7f069b2f7b77a22a78722b2a6408
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Wed Apr 8 18:48:12 2026 +0200
weld: Pass activated row in TreeView::signal_row_activated
, the activated row is passed as a param to the signal
handler. Make use of it, instead of determining the activated
row a different way.
Change-Id: Ic68e6ced72dd94065206d77121ee005a997a6334
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203347
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Since commit
Change-Id: Ie6a962702d4f7f069b2f7b77a22a78722b2a6408
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Wed Apr 8 18:48:12 2026 +0200
weld: Pass activated row in TreeView::signal_row_activated
, the activated row is passed as a param to the signal
handler. Make use of it, instead of determining the activated
row a different way.
Change-Id: I44eb9500590a1e2b8d26955cc7771899c8bc894c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203346
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Since previous commit
Change-Id: Ie6a962702d4f7f069b2f7b77a22a78722b2a6408
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Wed Apr 8 18:48:12 2026 +0200
weld: Pass activated row in TreeView::signal_row_activated
, the activated row is passed as a param to the signal
handler. Make use of it, instead of determining the activated
row a different way.
Change-Id: I83930363857b6fb17371e1b427fd38f22a95f87c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203345
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Sets default numbering format of subdocuments to be 012_ABC rather than
previous ABC12, which allows for formatting.
1. Introduces a class `PaddedSequentialTokens` to "pad" the number
with leading zeroes
2. Introduces a function `concatFunc` in parameters to customize
format of numbered subdocuments
Change-Id: I95aaf552189a5e1b9bdf7a178cbc3a83c8ab8e16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187939
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Balance word spacing within the consecutive lines
to get uniform grayness and less rivers for better
readability, enabled by the new paragraph property
com::sun::star::text::ParaComposer
and the following developments:
* Add Paragraph Composer checkbox on Alignment pane of the
paragraph formatting dialog window (not default yet);
* Implement paragraph composer: big word spacing of a
line is decreased by shifting the last word from the
previous line, only if the word spacing is better, than
before, and the increased word spacing in the previous
line doesn't exceed the Maximum word spacing (limited
paragraph composer);
* When Maximum word spacing is not greater than the Desired
word spacing, shifting of the last word is not limited
by the Maximum word spacing (unlimited paragraph composer)
* Add loext:paragraph-composer attribute, as LibreOffice
ODF extension;
* Add ODF unit tests for the limited and not limited
paragraph composer.
Note: "Smart justify" line breaking algorithm chooses
space shrinking (limited by Minimum word spacing)
only if shifting the last word isn't better based
on the desired word spacing. This was still a greedy
line breaking algorithm, resulting big word spacing
in the lines before a longer word.
The paragraph composer shifts the last word (or the
first part of the hyphenated last word) from the previous
line to decrease big word spacing in the actual line.
Note: balancing very big word spacing in narrow consecutive
lines can result vertical rivers. To avoid this, use limited
paragraph composer by setting maximum word spacing.
Follow-up to "smart justify", word spacing, letter spacing
and glyph scaling developments. Selected commits:
commit 529755f091 "tdf#166113
sw smart justify: adjust algorithm for interoperability",
commit 7d08767b89 "tdf#130088
"tdf#119908 smart justify: fix DOCX line count + compat opt.",
commit 7d6696757d "tdf#159923
sw cui offapi xmloff: add custom word spacing",
commit 5a48070f59 "tdf#126154
sw offapi xmloff cui: add min/max word spacing",
commit f83a04c510 "tdf#167648
cui offapi xmloff sw: add DTP-feature maximum letter spacing",
commit 3c53797210 "tdf#167648
sw letter spacing: implement minimum letter spacing",
commit 45ec7bd761 "tdf#168251
cui offapi xmloff sw glyph scaling: extend UNO/UX/ODF".
Change-Id: I727caad70536c86be524bc9d9b52bc71208c202a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203288
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: Jenkins
elioperdreau
Adolfo Jayme Barrientos