Commit Graph
28 Commits
Author SHA1 Message Date
Stephan Bergmann 604df2f608 [API CHANGE] Fix typo in prop implemented by stardiv.UnoControls.FrameControl
There is exactly one implementation of css.frame.FrameControl (which demands a
property named "ComponentUrl" not "ComponentURL"), and exactly one place where
that property is used.  So switch those two places to use the spelling of the
property name as documented in the UNOIDL service.  (Even though that can be
considered an incompatible change, in the unlikely case that 3rd party code
expects to be able to access the given implementation's property with the mis-
spelled name.)

Change-Id: I4fa3f21851b61079c09deea1a24aac22bc96f36f
Reviewed-on: https://gerrit.libreoffice.org/51766
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-23 13:02:45 +01:00
Stephan Bergmann 198b1ed586 blacklist should have been static
Change-Id: I2f9172ba9d9724b39ce00f0e5a24a5d4032789a9
Reviewed-on: https://gerrit.libreoffice.org/51765
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-23 10:56:44 +01:00
Stephan Bergmann ffc525e348 CppunitTest_services: check service impls support properties as advertised
...blacklisting existing violations for now (to be cleaned up)

Change-Id: Ie94de44d44e04ed45c0ae10d518157da76332bda
Reviewed-on: https://gerrit.libreoffice.org/51654
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-21 10:26:22 +01:00
Andrea Gelmini c101df2171 Fix typos
Change-Id: Iedd82d035454c940d76a94c7e910c81827c1389c
Reviewed-on: https://gerrit.libreoffice.org/48828
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-29 13:26:15 +01:00
Stephan Bergmann 11cf64b730 Better fix for CppunitTest_services
...than 25313923b0 "Fix CppunitTest_services for
constructor-based implementations..." (which this commit reverts again).  My
claim that "the 'factory' would be the object itself" is nonsense, it would
rather be an ImplementationWrapper (but one that was freshly created for each
ServiceManager::createContentEnumeration).

Change-Id: I85c683cff6f9ba78d0f8567a53f8fcbc56fe55cf
2017-10-27 10:37:26 +02:00
Stephan Bergmann 25313923b0 Fix CppunitTest_services for constructor-based implementations...
(i.e., using constructor="..." in the .component file) that implement multiple
services, but are not implemented as single-instance objects (i.e., always
return different objects from that constructor function).  In that case, the
"factory" would be the object itself, and would thus be different for different
instantiations of that implementation.  erAck ran into such a case with new code
he's writing.

Change-Id: Ib134a4c6d1400b43a7df3cf6a115f8206fb80c93
2017-10-26 18:26:02 +02:00
Noel Grandin 65e293f524 clang-tidy modernize-use-emplace in package..sax
Change-Id: Ibc0258fd79df987a0e295552bcc5bf89ee12007a
Reviewed-on: https://gerrit.libreoffice.org/42173
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-12 08:03:09 +02:00
Miklos Vajna e71ed748ac sw: fix remaining loplugin:cppunitassertequals warnings
Now only subsequentchecks are remaining, as far as I see.

Change-Id: Id5e5a874f8de08c0fd3722aecdc02967ae5d421f
Reviewed-on: https://gerrit.libreoffice.org/33346
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-01-20 14:07:27 +00:00
Noel Grandin 2087484c65 use consistent #define checks for the Windows platform
stage 2 of replacing usage of various checks for the windows platform
with the compiler-defined '_WIN32' macro

In this stage we focus on replacing usage of the WIN macro

Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84
Reviewed-on: https://gerrit.libreoffice.org/22393
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-17 11:33:57 +00:00
Stephan Bergmann 61a3be76c2 tdf#92668: Revert some implementation names, for backwards compatibility
These implementation names of Calc, Draw, Impress, and Writer documents are the
most likely to be checked by existing third-party code, so revert the
corresponding parts of 3099c70b11 "Fix various
XServiceInfo implementations" (and instead add fixups in CppunitTest_serives).

Change-Id: I1a760adbf4c89a1b4477d6e628abba8d2028ccfe
2015-07-13 13:47:50 +02:00
Stephan Bergmann 0620451818 Revert "give this a copy ctor"
This reverts commit da42d11008, problem is fixed
now with fc56579e9d "Keep GCC 4.6 happy"

Conflicts:
	postprocess/qa/services.cxx

Change-Id: If819749d322a0887c1668fbbe563d14e0402ac78
2015-03-25 11:59:57 +01:00
Stephan Bergmann fc56579e9d Keep GCC 4.6 happy
Change-Id: Iaaab55a9ac1ba8e0550f9cb35ed13489e4e4d851
2015-03-25 09:29:00 +01:00
Caolán McNamara da42d11008 give this a copy ctor
Change-Id: I144679e93e61f1bc19319ebf8893529c164ae0ee
2015-03-24 21:04:31 +00:00
Stephan Bergmann 131c9beffe CppunitTest_services: Check that XServiceInfo and .component data matches
Change-Id: I660c261a90d0ce7ace045f97e28808bc924fefd9
2015-03-24 18:08:40 +01:00
Stephan Bergmann 5e5a2e3e4d Fill in bug ID
Change-Id: I9aef1c4e74f296fa06bee98781462dd8138eebe4
2015-02-12 16:52:04 +01:00
Stephan Bergmann f7cd7b2ce4 Make CppunitTest_services instantiate even more services
Change-Id: Id9bfb3886e4a9cbc15a7bf7ef3aefa73bd160e3b
2015-02-12 16:01:55 +01:00
Markus Mohrhard 22fe5da542 add log message about untested services
Change-Id: I3e8da0ae510ce40421767de2bd106d39ec254a17
2015-02-11 23:20:59 +01:00
Caolán McNamara b1964a24a6 ReportDefinition is the one that is failing for me under Linux too
Change-Id: I00480813d8c3703039a55a7a706937d33e8e8463
2014-06-24 16:05:50 +01:00
Stephan Bergmann 0b5568b9dd Fix CppunitTest_services on Windows
...by blacklisting the problematic service

Change-Id: I524a7c7af2cb374911db7b204021c3d2bcd1fdd6
2014-06-12 12:29:24 +02:00
Stephan Bergmann c4444ea0c4 Avoid Solar Mutex deadlocks when disposing services
...as test code using gb_CppunitTest_use_vcl is implicitly run with Solar Mutex locked

Change-Id: I480b4bcce7c6a94922019679099b0883b3ee1030
2014-06-12 12:29:23 +02:00
Markus Mohrhard 336364b46d Revert "Revert "Make sure to dispose services supporting the XComponent protocol""
This reverts commit 044be7107a.

It only works sometimes. Still a deadlock based on a race condition.
2014-06-09 04:55:22 +02:00
Markus Mohrhard 044be7107a Revert "Make sure to dispose services supporting the XComponent protocol"
This reverts commit 4cacc6080e.
2014-06-07 04:34:10 +02:00
Stephan Bergmann 4cacc6080e Make sure to dispose services supporting the XComponent protocol
...to e.g. avoid leftover temp files from instantiating
com.sun.star.comp.report.OReportDefinition.  But dispose all instances only at
the very end, to avoid disposing some single-instance services too early.

Change-Id: I71fc50e80f4b5d1a1ca16e392725903b079ce2d1
2014-05-15 12:23:39 +02:00
Noel Grandin 78b9537b6a various: sal_Bool->bool
Change-Id: I30fa5227f30373f95060148f269450d2945c1bb9
2014-05-08 11:48:14 +02:00
Chris Sherlock c05ef7eeb1 Make service unit test easier to debug
It's sort of hard to break into this function with gdb. Seperating it out
makes it a lot easier to work out where things are breaking.

Change-Id: If99effd44fe677452ac3c1012b99da7da80c720e
Reviewed-on: https://gerrit.libreoffice.org/8844
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-04-04 08:53:05 -05:00
Jan Holesovsky d8db8edded Add more logging so that we have the info even in case of weird crashes.
Change-Id: I5888fb3e1ffa1bfdf9b91c06087ef5b7ccbb82ec
2014-01-14 09:58:16 +01:00
Stephan Bergmann 014fbd610e Improve CppunitTest_services
Change-Id: I4b22ce7e5fa91d5008f72e1f351d25063065ba43
2013-12-19 22:46:34 +01:00
Matúš Kukan ff9614a744 Add a unit test trying to create every available service with default ctor.
Change-Id: I79e70aeabdb816eaf7a719d2094034d78d11c90b
2013-12-18 07:15:50 +01:00