[API CHANGE] Fix typo in prop implemented by stardiv.UnoControls.FrameControl

There is exactly one implementation of css.frame.FrameControl (which demands a
property named "ComponentUrl" not "ComponentURL"), and exactly one place where
that property is used.  So switch those two places to use the spelling of the
property name as documented in the UNOIDL service.  (Even though that can be
considered an incompatible change, in the unlikely case that 3rd party code
expects to be able to access the given implementation's property with the mis-
spelled name.)

Change-Id: I4fa3f21851b61079c09deea1a24aac22bc96f36f
Reviewed-on: https://gerrit.libreoffice.org/51766
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This commit is contained in:
Stephan Bergmann
2018-03-23 13:02:45 +01:00
parent 119d813769
commit 604df2f608
3 changed files with 3 additions and 4 deletions
+1 -1
View File
@@ -344,7 +344,7 @@ IPropertyArrayHelper& FrameControl::getInfoHelper()
// attention: properties need to be sorted by name!
static OPropertyArrayHelper ourPropertyInfo(
{
Property( "ComponentURL", PropertyHandle::Componenturl, cppu::UnoType<OUString>::get(),
Property( "ComponentUrl", PropertyHandle::Componenturl, cppu::UnoType<OUString>::get(),
PropertyAttribute::BOUND | PropertyAttribute::CONSTRAINED ),
Property( "Frame", PropertyHandle::Frame, cppu::UnoType<XFrame>::get(),
PropertyAttribute::BOUND | PropertyAttribute::TRANSIENT ),
+1 -2
View File
@@ -493,8 +493,7 @@ void Test::createInstance(
{"com.sun.star.comp.report.OFormattedField", "TextColor"},
{"com.sun.star.comp.report.OFormattedField", "TextLineColor"},
{"com.sun.star.comp.report.OFormattedField", "TreatAsNumber"},
{"stardiv.Toolkit.UnoControlRoadmapModel", "Interactive"},
{"stardiv.UnoControls.FrameControl", "ComponentUrl"}};
{"stardiv.Toolkit.UnoControlRoadmapModel", "Interactive"}};
if (blacklist.find({implementationName, prop->getName()}) != blacklist.end()) {
continue;
}
+1 -1
View File
@@ -147,7 +147,7 @@ void SwOneExampleFrame::CreateControl()
xPrSet->setPropertyValue( "LoaderArguments", aArgs );
//save and set readonly???
xPrSet->setPropertyValue("ComponentURL", aURL);
xPrSet->setPropertyValue("ComponentUrl", aURL);
m_aLoadedIdle.Start();
m_bServiceAvailable = true;