Commit Graph
110 Commits
Author SHA1 Message Date
Szymon Kłos 596fd41b9b tdf#116536 Fix bullet position with linespacing > 100
Change-Id: I862246d9c69e754bdd883787fe42c7d61a1a53d3
Reviewed-on: https://gerrit.libreoffice.org/51790
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-03-29 16:59:55 +02:00
Szymon Kłos 63311c2d51 tdf#116101 Correct bullet position for linespacing > 100%
Change-Id: Ia900636d4013ab2a9c893c8246391db867fe1543
Reviewed-on: https://gerrit.libreoffice.org/51017
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-03-09 21:21:32 +01:00
Szymon Kłos 4b59a110dd tdf#116101 Correct position for linespacing > 100%
Change-Id: Ia3d90d521e03ed59312d1603b2cf5e5680b00781
Reviewed-on: https://gerrit.libreoffice.org/51005
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-03-09 16:45:16 +01:00
Stephan Bergmann ba8a70365e New loplugin:nestedunnamed
Change-Id: Ifb434589ef08428ce609bc7a40b015d4df13224c
Reviewed-on: https://gerrit.libreoffice.org/50048
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-21 08:09:46 +01:00
Tamás Zolnai 156f5105e5 Increase delta value for these checks
Change-Id: I14582541bf076340cfc95a17e1a9070a596c67db
Reviewed-on: https://gerrit.libreoffice.org/50073
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-02-21 04:18:31 +01:00
Stephan Bergmann 3be02487f0 Blind fix for -Werror,-Wunused-variable on macOS
...after c40ef4d19b "workaround jenkins failure on
OSX".  Probably better to keep executing the code under test than to #if-out the
whole block.

Change-Id: I83c21c532cd69f72834e4a242f767cca419b04ea
2018-02-20 11:28:47 +01:00
Noel Grandin c40ef4d19b workaround jenkins failure on OSX
Change-Id: I82fd0bba275c4c58f1a39b823c75fd18889987ed
Reviewed-on: https://gerrit.libreoffice.org/50024
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-20 10:12:30 +01:00
Tamás Zolnai f0485ba2d9 tdf#115639: Handle alignment correctly for multiple paragraph case
I used the wrong calculator method to get the line width.
This commit also fixes the crashes found by crashtest.

Change-Id: I25392f86af912ee54c07b14480d82282210ac346
Reviewed-on: https://gerrit.libreoffice.org/49994
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-02-19 23:38:17 +01:00
Tamás Zolnai 1da3a3cb74 tdf#115639: Align right/center with trailing spaces the same as MS PowerPoint
* Add HoriAlignIgnoreTrailingWhitespace compatibility option.
** For MSO file formats it is set to true
** For ODP format it's set to false by default
** The flag is saved to ODP format as user data if the document
comes from an MSO format.

Change-Id: Ie22233d33a25e605de46120bfc2195038dffd63c
Reviewed-on: https://gerrit.libreoffice.org/49889
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-02-17 07:50:00 +01:00
Stephan Bergmann 54a8e708b4 More loplugin:cstylecast: editeng
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable
loplugin:cstylecast for some more cases" plus
solenv/clang-format/reformat-formatted-files

Change-Id: I09a4d688e6f3c1ecbe05a7d27ebd955e8ba1eb65
2018-01-12 20:25:09 +01:00
Szymon Kłos 2bd2717635 tdf#114628 unit test for line spacing
* two cases 60% and 150% line spacing

Change-Id: I2ce66cd19f459b738243052b5c12da0bbb883ebe
Reviewed-on: https://gerrit.libreoffice.org/47303
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-01-07 11:15:22 +01:00
Caolán McNamara 03567d1156 rhbz#1517407 Capitalize every word doesn't work after brackets
Change-Id: Iab2da3f74f6116bb1b9855044df2a2ece977bb95
Reviewed-on: https://gerrit.libreoffice.org/45335
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-27 21:58:07 +01:00
Stephan Bergmann 38ef960bf7 loplugin:includeform: editeng
Change-Id: If2aa2cbbfabe164ccf0f68522fa18fa3bae2225d
2017-10-23 22:46:09 +02:00
Stephan Bergmann 141873715b Move editeng/source/editeng include files to common include directory
...that are included from various source directories.  Change done in
preparation of loplugin:includeform.

Change-Id: I4c2160d1c682b37e93e1161796c67097866bf659
2017-10-16 17:22:21 +02:00
Noel Grandin 70e5520653 convert SvxURLFormat to scoped enum
Change-Id: Ie2199cf0bcfb6d649f8aa33325ab645b18e7c000
Reviewed-on: https://gerrit.libreoffice.org/42343
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-16 14:43:04 +02:00
Eike Rathke 06d14411a4 Related: tdf#108795 a shared SvxAutoCorrect instance can not be stateful
An SvxAutoCorrect instance is shared via SvxAutoCorrCfg::Get().GetAutoCorrect().
Since commit 284eb10676 and following the
SvxAutoCorrect::bRunNext/HasRunNext() introduced a state whether a previously
inserted NO-BREAK SPACE should be removed again, depending on the next
character input. That does not work, for example, if
SvxAutoCorrect::DoAutoCorrect() is called from two different EditEngine
instances, like it is the case in the Calc input line and cell which are
synchronized; or any other two or more instances for that matter. The caller
has to pass and remember a flag that is maintained by SvxAutoCorrect.

Change-Id: I79a26d2ba44cc40771979a78b686c89f0c80b412
Reviewed-on: https://gerrit.libreoffice.org/41475
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
2017-08-24 00:30:37 +02:00
Varun Dhall 006a7b5054 Removing unused serialisation code
Change-Id: I86911c77f0831d448ff803afae2a74ec55ad4dd8
Reviewed-on: https://gerrit.libreoffice.org/41233
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-17 10:54:59 +02:00
Stephan Bergmann aa371639ee loplugin:oncevar: empty strings: editeng
Change-Id: I3b60b918277b408038a99f2c4801a454e6aa7b4a
2017-07-13 11:46:41 +02:00
Varun Dhall e333183d43 EditEngine: Making ODF Format Default for Copy/Paste
Change-Id: Idfb4dacf4a1595ff974bbca195e419ff6a98418b
Reviewed-on: https://gerrit.libreoffice.org/39876
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-12 23:28:06 +02:00
Varun Dhall 2de270e4fd EditEngine: Added test for large para copy/paste
Change-Id: Ica1e5ae18f71470a3124fd0389213d2fbfc7e521
Reviewed-on: https://gerrit.libreoffice.org/39615
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-06 21:13:26 +02:00
Varun Dhall 6e7300d104 EditEngine: Added test to check multi para start copy/paste
Change-Id: Ic253af5ab75783280926f2ed8387f69015014227
Reviewed-on: https://gerrit.libreoffice.org/39488
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-03 23:43:17 +02:00
Noel Grandin 71112060e0 loplugin:oncevar various
Change-Id: I8b82d46d4688b1a59d6fe1b05da7d5c8dfc13ca6
Reviewed-on: https://gerrit.libreoffice.org/38766
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-29 08:18:35 +02:00
Varun Dhall 1ace4ed5c7 EditEngine: Added test to check MultiPara Copy/Paste with Bold/Italic text
Change-Id: Ic94338662009a4e0ddbc28e21ac1f5028ddd9126
Reviewed-on: https://gerrit.libreoffice.org/39219
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-26 17:10:35 +02:00
Andrea Gelmini dbcc169d8c Fix typos
Change-Id: I2ce725f87ee6f8ebcffbac268cc7e7f8850023e5
Reviewed-on: https://gerrit.libreoffice.org/39232
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-26 09:20:18 +02:00
Varun Dhall 41f1474e63 EditEngine: Added test to check MultiPara SelectiveSelection Copy/Paste
Change-Id: Iffb55599c90483b231820f60536c93ec3bfec2c9
Reviewed-on: https://gerrit.libreoffice.org/39140
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-23 22:11:01 +02:00
Varun Dhall 84284429de EditEngine: Added test to check Multi Para Copy/Paste
Change-Id: Ida45d5861068c71e5c8d75eb711aaacbf543be79
Reviewed-on: https://gerrit.libreoffice.org/39119
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-23 22:08:03 +02:00
Noel Grandin bf39807c67 loplugin:oncevar editeng..extensions
Change-Id: I3a63e3e3b873ef8a2d708d39be084124a6ad1346
Reviewed-on: https://gerrit.libreoffice.org/39153
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-23 13:23:42 +02:00
Caolán McNamara 3212a24194 consider field marks as text for auto quotes
Change-Id: I511a13f7785a0de6efaa8439d3f0bff20a1644ed
2017-06-19 16:27:16 +01:00
Arnaud Versini 1fdb0e1897 Replace all OUString("") with OUString()
Change-Id: Ie14c4d76cb61cfbe0410103adfc1afc8ade0f3e0
Reviewed-on: https://gerrit.libreoffice.org/37146
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-04 08:39:18 +02:00
Varun Dhall 07c8e72b8e Added Test for EditEngine - Copy/Paste with Hyperlinks in Text
Change-Id: Iabe11ddac346f1c48b355c21797c11de8db54b1f
Reviewed-on: https://gerrit.libreoffice.org/35593
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-24 22:00:39 +00:00
Varun Dhall 0115a5f908 Added Test for EditEngine - Copy/Paste with Tabs in Text
Change-Id: If40dabc53d35c01e61f8a17799f26e6ef9fd6b08
Reviewed-on: https://gerrit.libreoffice.org/35579
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-24 21:50:00 +00:00
Varun Dhall cfe2411ae0 Added Test for EditEngine - Copy/Paste using Underline Text
Just because Underline is as important as Bold/Italic we cannot skip a test for it :)

Change-Id: I6c240a3232cf97794c8265afe66f58ce6f68fa43
Reviewed-on: https://gerrit.libreoffice.org/35217
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-24 21:35:41 +00:00
Noel Grandin f2a873cd13 convert SvxBorderStyle to scoped enum
and rename to SvxBorderLineStyle

Change-Id: I19e530f162e4ca6290a0ad076e7fe3d5775ae6bc
Reviewed-on: https://gerrit.libreoffice.org/35265
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-17 06:04:30 +00:00
Varun Dhall 35067628a2 Added Test for EditEngine - Copy/Paste using Bold/Italic Text
Change-Id: Ifd2fd8088590493377749866f37b1e663f97fa76
Reviewed-on: https://gerrit.libreoffice.org/34983
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-13 17:21:52 +00:00
Caolán McNamara d7685eb3f4 ensure SfxApplication exists for editeng test
Change-Id: I73814e38437f83f8aa7b87addc285e82f7357bea
2017-03-10 14:53:47 +00:00
Varun Dhall 685767dbe7 Added Test for EditEngine - Copy/Paste using Legacy Format
Change-Id: I3153010f4e327abd2ef48bdefa50ade1c0ba2f81
Reviewed-on: https://gerrit.libreoffice.org/34552
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2017-02-24 16:41:12 +00:00
Miklos Vajna 5878bb1d2f editeng: fix loplugin:cppunitassertequals warnings
Change-Id: Icccd2db45616de708d83058d76ace312db8af94e
2016-09-23 11:30:10 +02:00
Stephan Bergmann 61794421b1 Related cid#1371287: Improve code to not depend on missing move assignment
Change-Id: I4c03ad08078e25ea7f7d754e6eaa587da7984c9d
2016-09-20 11:20:31 +02:00
Caolán McNamara 6752590fec don't autocapitalize words that follow a field mark
Change-Id: Ia8efa88aaf47edba9a590c858d0ea30d7bfe2977
2016-07-01 14:49:03 +01:00
Stephan Bergmann 4d49c9601c Let loplugin:passstuffbyref also look at fn defn not preceded by any decl
Change-Id: I752bc96d2d521d790e919283cabb14b6526626f4
2016-06-08 17:14:34 +02:00
Noel Grandin 0b23eec200 teach refcounting clang plugin about uno::Reference
uno::Reference is only allowed to used with classes that have a
::static_type member.
So convert all those places to rtl::Reference.

Maybe we need some LIBO_INTERNAL_ONLY constructors on rtl::Reference and
uno::Reference to make this a little smoother?

Change-Id: Icdcb35d71ca40a87b1dc474096776412adbfc7e3
Reviewed-on: https://gerrit.libreoffice.org/25516
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31 06:25:45 +00:00
Noel Grandin b14224fe97 loplugin:unusedmethods
using an idea from dtardon:

<dtardon> noelgrandin, hi. could you try to run the unusedmethods clang
plugin with "make build-nocheck"? that would catch functions that are
only used in tests. e.g., i just removed the whole o3tl::range class,
which has not been used in many years, but htere was a test for it...
<noelgrandin> dtardon, interesting idea! Sure, I can do that.

Change-Id: I5653953a426a2186a1e43017212d87ffce520387
Reviewed-on: https://gerrit.libreoffice.org/22041
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-08 06:08:14 +00:00
Noel Grandin 1f9a610de1 loplugin:unusedmethods unused return value in include/editeng
Change-Id: I1314480950b0d3a3e5ed066d71c175604dd41970
Reviewed-on: https://gerrit.libreoffice.org/21361
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-12 07:39:42 +00:00
Stephan Bergmann 217f7f236f loplugin:nullptr (automatic rewrite)
Change-Id: I9fe00eef7ddcd4a3c87e497a8d62f98e71a0d6d8
2015-11-10 10:31:24 +01:00
Stephan Bergmann 108ecc45ce loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)
Change-Id: Icf08e69ba327225da816bd57648d4242dcbf3280
2015-11-06 09:35:37 +01:00
Stephan Bergmann b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
Caolán McNamara 3a00aaef2a boost->std
Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0
Reviewed-on: https://gerrit.libreoffice.org/18670
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-18 07:59:14 +00:00
Caolán McNamara 267f401e2a cppcheck: noExplicitConstructor
Change-Id: I2a1add8cf526cdb305ad99ccb138454a88f2fdbd
2015-09-07 09:56:07 +01:00
Noel Grandin 2660d24a07 new loplugin: refcounting
This was a feature requested by mmeeks, as a result of
tdf#92611.

It validates that things that extend XInterface are not
directly heap/stack-allocated, but have their lifecycle managed
via css::uno::Reference or rtl::Reference.

Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692
Reviewed-on: https://gerrit.libreoffice.org/16924
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-03 06:37:16 +00:00
Stephan Bergmann eb0f855f8c editeng: Use appropriate OUString functions on string constants
Change-Id: Iab879390c18a3ce2c5bfc49548ca273ce0b907da
2014-12-18 14:12:25 +01:00