ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

cppcheck: noExplicitConstructor

Browse Source 
Change-Id: I2a1add8cf526cdb305ad99ccb138454a88f2fdbd
This commit is contained in:
Caolán McNamara
2015-09-07 09:56:07 +01:00
parent b0f3024304
commit 267f401e2a
32 changed files with 46 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files
avmedia/source/gstreamer/gstwindow.hxx
+2 -2
View File
@@ -39,8 +39,8 @@ class Window : public ::cppu::WeakImplHelper< css::media::XPlayerWindow,
{
public:
Window( const css::uno::Reference< css::lang::XMultiServiceFactory >& rxMgr );
virtual ~Window();
explicit Window( const css::uno::Reference< css::lang::XMultiServiceFactory >& rxMgr );
virtual ~Window();
// XPlayerWindow
virtual void SAL_CALL update( ) throw (css::uno::RuntimeException, std::exception) SAL_OVERRIDE;
chart2/source/controller/sidebar/ChartAreaPanel.cxx
+1 -1
View File
@@ -207,7 +207,7 @@ GraphicObject getXBitmapFromName(css::uno::Reference<css::frame::XModel> xModel,
class PreventUpdate
{
public:
PreventUpdate(bool& bUpdate):
explicit PreventUpdate(bool& bUpdate):
mbUpdate(bUpdate)
{
mbUpdate = false;
chart2/source/controller/sidebar/ChartLinePanel.cxx
+1 -1
View File
@@ -93,7 +93,7 @@ css::uno::Any getLineDash(
class PreventUpdate
{
public:
PreventUpdate(bool& bUpdate):
explicit PreventUpdate(bool& bUpdate):
mbUpdate(bUpdate)
{
mbUpdate = false;
chart2/source/controller/sidebar/ChartSidebarModifyListener.hxx
+1 -1
View File
@@ -30,7 +30,7 @@ class ChartSidebarModifyListener : public cppu::WeakImplHelper1<css::util::XModi
{
public:
ChartSidebarModifyListener(ChartSidebarModifyListenerParent* pParent);
explicit ChartSidebarModifyListener(ChartSidebarModifyListenerParent* pParent);
virtual ~ChartSidebarModifyListener();
virtual void SAL_CALL modified(const css::lang::EventObject& rEvent)
chart2/source/controller/sidebar/ChartSidebarSelectionListener.hxx
+1 -1
View File
@@ -35,7 +35,7 @@ class ChartSidebarSelectionListener : public cppu::WeakImplHelper1<css::view::XS
public:
// listen to all chart selection changes
ChartSidebarSelectionListener(ChartSidebarSelectionListenerParent* pParent);
explicit ChartSidebarSelectionListener(ChartSidebarSelectionListenerParent* pParent);
// only liste to the changes of eType
ChartSidebarSelectionListener(ChartSidebarSelectionListenerParent* pParent, ObjectType eType);
virtual ~ChartSidebarSelectionListener();
dbaccess/source/ui/app/AppDetailPageHelper.hxx
+1 -1
View File
@@ -66,7 +66,7 @@ namespace dbaui
protected:
virtual void DataChanged(const DataChangedEvent& rDCEvt) SAL_OVERRIDE;
public:
OPreviewWindow(vcl::Window* _pParent);
explicit OPreviewWindow(vcl::Window* _pParent);
// Window overrides
virtual void Paint(vcl::RenderContext& /*rRenderContext*/, const Rectangle& rRect) SAL_OVERRIDE;
dbaccess/source/ui/querydesign/JoinController.cxx
+1 -1
View File
@@ -82,7 +82,7 @@ class AddTableDialogContext : public IAddTableDialogContext
OJoinController& m_rController;
public:
AddTableDialogContext( OJoinController& _rController )
explicit AddTableDialogContext( OJoinController& _rController )
:m_rController( _rController )
{
}
dbaccess/source/ui/uno/DBTypeWizDlgSetup.hxx
+1 -1
View File
@@ -33,7 +33,7 @@ class ODBTypeWizDialogSetup
bool m_bStartTableWizard;
protected:
ODBTypeWizDialogSetup(const css::uno::Reference< css::uno::XComponentContext >& _rxORB);
explicit ODBTypeWizDialogSetup(const css::uno::Reference< css::uno::XComponentContext >& _rxORB);
public:
// XTypeProvider
dbaccess/source/ui/uno/TableFilterDlg.hxx
+1 -1
View File
@@ -31,7 +31,7 @@ class OTableFilterDialog
{
protected:
OTableFilterDialog(const css::uno::Reference< css::uno::XComponentContext >& _rxORB);
explicit OTableFilterDialog(const css::uno::Reference< css::uno::XComponentContext >& _rxORB);
public:
// XTypeProvider
dbaccess/source/ui/uno/UserSettingsDlg.hxx
+1 -1
View File
@@ -31,7 +31,7 @@ class OUserSettingsDialog
{
protected:
OUserSettingsDialog(const css::uno::Reference< css::uno::XComponentContext >& _rxORB);
explicit OUserSettingsDialog(const css::uno::Reference< css::uno::XComponentContext >& _rxORB);
public:
// XTypeProvider
dbaccess/source/ui/uno/admindlg.hxx
+1 -1
View File
@@ -31,7 +31,7 @@ class ODataSourcePropertyDialog
{
protected:
ODataSourcePropertyDialog(const css::uno::Reference< css::uno::XComponentContext >& _rxORB);
explicit ODataSourcePropertyDialog(const css::uno::Reference< css::uno::XComponentContext >& _rxORB);
public:
// XTypeProvider
dbaccess/source/ui/uno/composerdialogs.hxx
+3 -3
View File
@@ -51,7 +51,7 @@ namespace dbaui
// </properties>
protected:
ComposerDialog(const css::uno::Reference< css::uno::XComponentContext >& _rxORB);
explicit ComposerDialog(const css::uno::Reference< css::uno::XComponentContext >& _rxORB);
virtual ~ComposerDialog();
public:
@@ -77,7 +77,7 @@ namespace dbaui
class RowsetFilterDialog : public ComposerDialog
{
public:
RowsetFilterDialog(
explicit RowsetFilterDialog(
const css::uno::Reference< css::uno::XComponentContext >& _rxORB
);
@@ -102,7 +102,7 @@ namespace dbaui
class RowsetOrderDialog : public ComposerDialog
{
public:
RowsetOrderDialog(
explicit RowsetOrderDialog(
const css::uno::Reference< css::uno::XComponentContext >& _rxORB
);
dbaccess/source/ui/uno/copytablewizard.cxx
+2 -2
View File
@@ -189,7 +189,7 @@ namespace dbaui
bool isInitialized() const { return m_xSourceConnection.is() && m_pSourceObject.get() && m_xDestConnection.is(); }
protected:
CopyTableWizard( const Reference< XComponentContext >& _rxORB );
explicit CopyTableWizard( const Reference< XComponentContext >& _rxORB );
virtual ~CopyTableWizard();
// OGenericUnoDialog overridables
@@ -355,7 +355,7 @@ private:
class CopyTableAccessGuard
{
public:
CopyTableAccessGuard( CopyTableWizard& _rWizard )
explicit CopyTableAccessGuard( CopyTableWizard& _rWizard )
:m_rWizard( _rWizard )
{
m_rWizard.getMutex().acquire();
dbaccess/source/ui/uno/dbinteraction.hxx
+2 -2
View File
@@ -125,7 +125,7 @@ namespace dbaui
class SQLExceptionInteractionHandler : public BasicInteractionHandler
{
public:
SQLExceptionInteractionHandler(
explicit SQLExceptionInteractionHandler(
const css::uno::Reference< css::uno::XComponentContext >& rxContext
)
:BasicInteractionHandler( rxContext, false )
@@ -153,7 +153,7 @@ namespace dbaui
class LegacyInteractionHandler : public BasicInteractionHandler
{
public:
LegacyInteractionHandler(
explicit LegacyInteractionHandler(
const css::uno::Reference< css::uno::XComponentContext >& rxContext
)
:BasicInteractionHandler( rxContext, true )
dbaccess/source/ui/uno/textconnectionsettings_uno.cxx
+1 -1
View File
@@ -70,7 +70,7 @@ namespace dbaui
PropertyValues m_aPropertyValues;
protected:
OTextConnectionSettingsDialog( const Reference<XComponentContext>& _rContext );
explicit OTextConnectionSettingsDialog( const Reference<XComponentContext>& _rContext );
virtual ~OTextConnectionSettingsDialog();
public:
dbaccess/source/ui/uno/unoDirectSql.hxx
+1 -1
View File
@@ -44,7 +44,7 @@ namespace dbaui
OUString m_sInitialSelection;
css::uno::Reference< css::sdbc::XConnection > m_xActiveConnection;
protected:
ODirectSQLDialog(const css::uno::Reference< css::uno::XComponentContext >& _rxORB);
explicit ODirectSQLDialog(const css::uno::Reference< css::uno::XComponentContext >& _rxORB);
virtual ~ODirectSQLDialog();
public:
desktop/source/app/desktopcontext.hxx
+1 -1
View File
@@ -28,7 +28,7 @@ namespace desktop
class DesktopContext: public cppu::WeakImplHelper< com::sun::star::uno::XCurrentContext >
{
public:
DesktopContext( const com::sun::star::uno::Reference< com::sun::star::uno::XCurrentContext > & ctx);
explicit DesktopContext( const com::sun::star::uno::Reference< com::sun::star::uno::XCurrentContext > & ctx);
// XCurrentContext
virtual com::sun::star::uno::Any SAL_CALL getValueByName( const OUString& Name )
desktop/source/app/officeipcthread.hxx
+1 -1
View File
@@ -45,7 +45,7 @@ oslSignalAction SAL_CALL SalMainPipeExchangeSignal_impl(void* /*pData*/, oslSign
// that was given by command line or by IPC pipe communication.
struct ProcessDocumentsRequest
{
ProcessDocumentsRequest(boost::optional< OUString > const & cwdUrl):
explicit ProcessDocumentsRequest(boost::optional< OUString > const & cwdUrl):
aCwdUrl(cwdUrl), pcProcessed( NULL ), bTextCat( false ) {}
boost::optional< OUString > aCwdUrl;
drawinglayer/source/attribute/materialattribute3d.cxx
+1 -1
View File
@@ -44,7 +44,7 @@ namespace drawinglayer
{
}
ImpMaterialAttribute3D(const basegfx::BColor& rColor)
explicit ImpMaterialAttribute3D(const basegfx::BColor& rColor)
: maColor(rColor),
maSpecular(1.0, 1.0, 1.0),
maEmission(),
drawinglayer/source/dumper/EnhancedShapeDumper.hxx
+2 -4
View File
@@ -34,11 +34,9 @@
class EnhancedShapeDumper
{
public:
EnhancedShapeDumper(xmlTextWriterPtr writer)
:
xmlWriter(writer)
explicit EnhancedShapeDumper(xmlTextWriterPtr writer)
: xmlWriter(writer)
{
}
// auxiliary functions
drawinglayer/source/primitive2d/graphicprimitivehelper2d.cxx
+1 -1
View File
@@ -53,7 +53,7 @@ namespace
sal_uInt32 generateStepTime(sal_uInt32 nIndex) const;
public:
animatedBitmapExPreparator(const Graphic& rGraphic);
explicit animatedBitmapExPreparator(const Graphic& rGraphic);
sal_uInt32 count() const { return maSteps.size(); }
sal_uInt32 loopCount() const { return (sal_uInt32)maAnimation.GetLoopCount(); }
editeng/qa/unit/core-test.cxx
+1 -1
View File
@@ -347,7 +347,7 @@ namespace {
class UrlEditEngine : public EditEngine
{
public:
UrlEditEngine(SfxItemPool *pPool) : EditEngine(pPool) {}
explicit UrlEditEngine(SfxItemPool *pPool) : EditEngine(pPool) {}
virtual OUString CalcFieldValue( const SvxFieldItem&, sal_Int32, sal_Int32, Color*&, Color*& ) SAL_OVERRIDE
{
editeng/source/accessibility/AccessibleEditableTextPara.cxx
+1 -1
View File
@@ -896,7 +896,7 @@ namespace accessibility
struct IndexCompare
{
const PropertyValue* pValues;
IndexCompare( const PropertyValue* pVals ) : pValues(pVals) {}
explicit IndexCompare( const PropertyValue* pVals ) : pValues(pVals) {}
bool operator() ( const sal_Int32& a, const sal_Int32& b ) const
{
return pValues[a].Name < pValues[b].Name;
editeng/source/editeng/editdoc.cxx
+5 -5
View File
@@ -470,7 +470,7 @@ class FindTextPortionByAddress : std::unary_function<TextPortion, bool>
{
const TextPortion* mp;
public:
FindTextPortionByAddress(const TextPortion* p) : mp(p) {}
explicit FindTextPortionByAddress(const TextPortion* p) : mp(p) {}
bool operator() (const TextPortion& v) const
{
return &v == mp;
@@ -1991,7 +1991,7 @@ class RemoveEachItemFromPool : std::unary_function<ContentNode, void>
{
EditDoc& mrDoc;
public:
RemoveEachItemFromPool(EditDoc& rDoc) : mrDoc(rDoc) {}
explicit RemoveEachItemFromPool(EditDoc& rDoc) : mrDoc(rDoc) {}
void operator() (const ContentNode& rNode)
{
mrDoc.RemoveItemsFromPool(rNode);
@@ -2896,7 +2896,7 @@ class FindByAddress : std::unary_function<EditCharAttrib, bool>
{
const EditCharAttrib* mpAttr;
public:
FindByAddress(const EditCharAttrib* p) : mpAttr(p) {}
explicit FindByAddress(const EditCharAttrib* p) : mpAttr(p) {}
bool operator() (const EditCharAttrib& r) const
{
return &r == mpAttr;
@@ -2985,7 +2985,7 @@ class FindByStartPos : std::unary_function<EditCharAttrib, bool>
{
sal_Int32 mnPos;
public:
FindByStartPos(sal_Int32 nPos) : mnPos(nPos) {}
explicit FindByStartPos(sal_Int32 nPos) : mnPos(nPos) {}
bool operator() (const EditCharAttrib& r) const
{
return r.GetStart() >= mnPos;
@@ -3015,7 +3015,7 @@ class RemoveEmptyAttrItem : std::unary_function<EditCharAttrib, void>
{
SfxItemPool& mrItemPool;
public:
RemoveEmptyAttrItem(SfxItemPool& rPool) : mrItemPool(rPool) {}
explicit RemoveEmptyAttrItem(SfxItemPool& rPool) : mrItemPool(rPool) {}
void operator() (const EditCharAttrib& r)
{
if (r.IsEmpty())
editeng/source/editeng/editobj.cxx
+1 -1
View File
@@ -877,7 +877,7 @@ class FindByParagraph : std::unary_function<editeng::Section, bool>
{
sal_Int32 mnPara;
public:
FindByParagraph(sal_Int32 nPara) : mnPara(nPara) {}
explicit FindByParagraph(sal_Int32 nPara) : mnPara(nPara) {}
bool operator() (const editeng::Section& rAttr) const
{
return rAttr.mnParagraph == mnPara;
editeng/source/editeng/editundo.cxx
+1 -1
View File
@@ -505,7 +505,7 @@ struct RemoveAttribsFromPool : std::unary_function<ContentAttribsInfo, void>
{
SfxItemPool& mrPool;
public:
RemoveAttribsFromPool(SfxItemPool& rPool) : mrPool(rPool) {}
explicit RemoveAttribsFromPool(SfxItemPool& rPool) : mrPool(rPool) {}
void operator() (ContentAttribsInfo& rInfo)
{
rInfo.RemoveAllCharAttribsFromPool(mrPool);
editeng/source/editeng/fieldupdater.cxx
+1 -1
View File
@@ -22,7 +22,7 @@ class FieldUpdaterImpl
{
EditTextObjectImpl& mrObj;
public:
FieldUpdaterImpl(EditTextObject& rObj) : mrObj(*rObj.mpImpl) {}
explicit FieldUpdaterImpl(EditTextObject& rObj) : mrObj(*rObj.mpImpl) {}
FieldUpdaterImpl(const FieldUpdaterImpl& r) : mrObj(r.mrObj) {}
void updateTableFields(int nTab)
editeng/source/editeng/impedit2.cxx
+4 -2
View File
@@ -1731,8 +1731,10 @@ namespace {
struct FindByPos
{
FindByPos(sal_Int32 nPos):
mnPos(nPos) {}
explicit FindByPos(sal_Int32 nPos)
: mnPos(nPos)
{
}
bool operator()(const ScriptTypePosInfos::value_type& rValue)
{
editeng/source/items/frmitems.cxx
+1 -1
View File
@@ -3317,7 +3317,7 @@ public:
//copied to the GraphicObject when necessary
SvStream* pStream;
SvxBrushItem_Impl( GraphicObject* p ) : pGraphicObject( p ), nGraphicTransparency(0), pStream(0) {}
explicit SvxBrushItem_Impl( GraphicObject* p ) : pGraphicObject( p ), nGraphicTransparency(0), pStream(0) {}
};
editeng/source/lookuptree/Trie.cxx
+1 -1
View File
@@ -26,7 +26,7 @@ struct TrieNode
TrieNode* mLatinArray[LATIN_ARRAY_SIZE];
TrieNode(sal_Unicode aCharacter = '\0');
explicit TrieNode(sal_Unicode aCharacter = '\0');
virtual ~TrieNode();
void markWord();
editeng/source/xml/editsource.hxx
+2 -2
View File
@@ -28,7 +28,7 @@ class SvxEditEngineSourceImpl;
class SvxEditEngineSource : public SvxEditSource
{
public:
SvxEditEngineSource( EditEngine* pEditEngine );
explicit SvxEditEngineSource( EditEngine* pEditEngine );
virtual ~SvxEditEngineSource();
virtual SvxEditSource* Clone() const SAL_OVERRIDE;
@@ -36,7 +36,7 @@ public:
virtual void UpdateData() SAL_OVERRIDE;
private:
SvxEditEngineSource( SvxEditEngineSourceImpl* pImpl );
explicit SvxEditEngineSource( SvxEditEngineSourceImpl* pImpl );
SvxEditEngineSourceImpl* mpImpl;
};
editeng/source/xml/xmltxtexp.cxx
+1 -29
View File
@@ -57,12 +57,8 @@ using namespace com::sun::star::lang;
using namespace com::sun::star::xml::sax;
using namespace cppu;
class SvxEditEngineSourceImpl;
class SvxEditEngineSourceImpl
{
private:
@@ -74,7 +70,7 @@ private:
~SvxEditEngineSourceImpl();
public:
SvxEditEngineSourceImpl( EditEngine* pEditEngine );
explicit SvxEditEngineSourceImpl( EditEngine* pEditEngine );
void SAL_CALL acquire();
void SAL_CALL release();
@@ -82,11 +78,6 @@ public:
SvxTextForwarder* GetTextForwarder();
};
SvxEditEngineSourceImpl::SvxEditEngineSourceImpl( EditEngine* pEditEngine )
: maRefCount(0),
mpEditEngine( pEditEngine ),
@@ -94,30 +85,22 @@ SvxEditEngineSourceImpl::SvxEditEngineSourceImpl( EditEngine* pEditEngine )
{
}
SvxEditEngineSourceImpl::~SvxEditEngineSourceImpl()
{
delete mpTextForwarder;
}
void SAL_CALL SvxEditEngineSourceImpl::acquire()
{
osl_atomic_increment( &maRefCount );
}
void SAL_CALL SvxEditEngineSourceImpl::release()
{
if( ! osl_atomic_decrement( &maRefCount ) )
delete this;
}
SvxTextForwarder* SvxEditEngineSourceImpl::GetTextForwarder()
{
if (!mpTextForwarder)
@@ -126,40 +109,29 @@ SvxTextForwarder* SvxEditEngineSourceImpl::GetTextForwarder()
return mpTextForwarder;
}
// SvxTextEditSource
SvxEditEngineSource::SvxEditEngineSource( EditEngine* pEditEngine )
{
mpImpl = new SvxEditEngineSourceImpl( pEditEngine );
mpImpl->acquire();
}
SvxEditEngineSource::SvxEditEngineSource( SvxEditEngineSourceImpl* pImpl )
{
mpImpl = pImpl;
mpImpl->acquire();
}
SvxEditEngineSource::~SvxEditEngineSource()
{
mpImpl->release();
}
SvxEditSource* SvxEditEngineSource::Clone() const
{
return new SvxEditEngineSource( mpImpl );
}
SvxTextForwarder* SvxEditEngineSource::GetTextForwarder()
{
return mpImpl->GetTextForwarder();