ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
466,135 Commits 3 Branches 3 Tags
8ff57504f75ddd35c3f585cf2224c6fcc3863ca3
Commit Graph
629 Commits
Author SHA1 Message Date
Stephan Bergmann 43542cc07e Missing include 
(for std::unique_ptr, with recent libstdc++ 12 trunk)

Change-Id: I61b7823dd740ea7cdfe0d7403a50ac73b24d1c4e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120229
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2021-08-10 07:39:00 +02:00
Noel Grandin 14cfff500e Pass context and resource string down to boost::locale separately 
because this is often on a hot path, and we can avoid the splitting and
joining of strings like this.

Change-Id: Ia36047209368ca53431178c2e8723a18cfe8260a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119220
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-08-05 09:39:11 +02:00
Noel Grandin 6783afe24d no need to allocate these on the heap 
Change-Id: Ie11353c8711e970cc20059227d8283c79e4b126d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116586
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-06-02 18:23:45 +02:00
Caolán McNamara a5bdce555a comment on suspicious code 
Change-Id: I92b16c22815a755ec23503db1b8f7bb3444f89e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115560
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2021-05-13 18:13:37 +02:00
Stephan Bergmann 10d29c390d throw() -> noexcept, part 2/3: Automatic loplugin:noexcept rewrite 
Change-Id: I076f16d0536b534abf0ced4d76051eadb4c0e033
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114949
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2021-05-02 17:02:28 +02:00
Noel Grandin c7c6f0af6c loplugin:stringadd convert chained append to + 
which can use the more efficient *StringConcat

Also fix a crash in stringview plugin which
started happening while I working on this.

Change-Id: I91a5b9b7707d1594d27d80b73930f5afac8ae608
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114568
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-04-27 14:07:56 +02:00
Noel Grandin 335de1a221 no need makeStringAndClear() when appending to buffer 
it just creates an unnecessary temporary

Change-Id: Ide3cd99b2ac4f2a621e5d55ce4bdc95d05430709
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114467
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-04-22 12:37:39 +02:00
Vincent LE GARREC 90c978f839 tdf#124176 Use pragma once in f* 
filter, forms, fpicker, framework

Change-Id: I55a25ad2dc3749e63465e638e8eeea3c322eabbf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112047
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
 2021-03-23 13:07:09 +01:00
Noel 9c1ec55152 loplugin:refcounting in forms 
Change-Id: Idba46c8b30a3c44f12c0aaa8a00477865ecfb848
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111542
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-02-26 10:00:06 +01:00
Noel 7ffb71e759 loplugin:refcounting in forms 
Change-Id: I19d67e54f77e354eaddaaa7de1f3e22c2b7cdbf6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111280
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-02-21 16:10:51 +01:00
Noel 7767ff7b52 loplugin:referencecasting in editeng..framework 
Change-Id: Ia3375011ecd0a65afed0f131f477fc1542603fde
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110948
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-02-16 07:52:37 +01:00
Stephan Bergmann 042033f1e6 loplugin:stringviewparam: operator + 
Change-Id: I044dd21b63d7eb03224675584fa143009c6b6008
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108418
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2020-12-29 16:42:33 +01:00
Bayram Çiçek ea14c98aab tdf#88205: Adapt uses of css::uno::Sequence to use initializer_list ctor 
Change-Id: Id4034a57580f37fd71f841deec9edfe9b7c26a67
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108286
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2020-12-26 17:15:18 +01:00
Stephan Bergmann 35e471bb4d Adapt the remaining OUString functions to std string_view 
...for LIBO_INTERNAL_ONLY.  These had been missed by
1b43cceaea "Make many OUString functions take
std::u16string_view parameters" because they did not match the multi-overload
pattern that was addressed there, but they nevertheless benefit from being
changed just as well (witness e.g. the various resulting changes from copy() to
subView()).

This showed a conversion from OStringChar to std::string_view to be missing
(while the corresponding conversion form OUStringChar to std::u16string_view was
already present).

The improvement to loplugin:stringadd became necessary to fix

> [CPT] compilerplugins/clang/test/stringadd.cxx
> error: 'error' diagnostics expected but not seen:
>   File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 43 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:42): simplify by merging with the preceding assignment [loplugin:stringadd]
>   File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 61 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:60): simplify by merging with the preceding assignment [loplugin:stringadd]
> 2 errors generated.

Change-Id: Ie40de0616a66e60e289c1af0ca60aed6f9ecc279
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107602
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2020-12-11 21:25:10 +01:00
Noel d6d80c4e17 OSL_FAIL.*exception -> TOOLS_WARN_EXCEPTION 
Change-Id: I6800e23ead2767d245d5da71d2d40e0f8a6d7e1f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106859
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-12-01 09:28:52 +01:00
Noel bb06f51308 loplugin:stringviewparam extend to comparison operators 
which means that some call sites have to change to use
unicode string literals i.e. u"foo" instead of "foo"

Change-Id: Ie51c3adf56d343dd1d1710777f9d2a43ee66221c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106125
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-11-24 09:45:04 +01:00
Stephan Bergmann 19926ed35e loplugin:stringview: Flag empty string converted to string view 
Change-Id: Idf412dc5f235230512160cb4fb7e1a00baa1cfa7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106085
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2020-11-19 07:09:58 +01:00
Philipp Hofer 951764106e tdf#123936 Formatting files in module forms with clang-format 
Change-Id: I230375bd002147642db37728fa0287b6a554e330
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105670
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
 2020-11-13 15:17:55 +01:00
Stephan Bergmann f34ac579fa New loplugin:stringviewparam 
...to "Find functions that take rtl::O[U]String parameters that can be
generalized to take std::[u16]string_view instead."  (Which in turn can avoid
costly O[U]String constructions, see e.g. loplugin:stringview and subView.)

Some of those functions' call sites, passing plain char string literals, needed
to be adapted when converting them.

Change-Id: I644ab546d7a0ce9e470ab9b3196e3e60d1e812bc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105622
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2020-11-12 16:53:30 +01:00
Gabor Kelemen a5389cb5dd tdf#42949 Fix new IWYU warnings in directories [e-f]* 
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I963aa5fb892a0be36212fd0587b69f217f017947
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105469
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
 2020-11-12 10:53:07 +01:00
Andrea Gelmini 59fee59094 Fix typo in code 
It passed "make check"

Change-Id: I4cbe4a471c18e9bd26f6161d98a49cb32666816f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101791
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2020-09-01 15:30:50 +02:00
Noel Grandin da7489eb6a compact namespace decl 
used
   git grep -lw namespace
    | xargs perl -i -p0e 's/(\w+)\s*.\{.\s*namespace\s*(\w+)/\1::\2/smg;'
 to do the initial replace, then compiled and fixed.

Change-Id: If69904d75940c851aeffab0e78c4ba02cc968d44
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98526
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-07-20 10:12:57 +02:00
Stephan Bergmann ddb1bbf0ab Upcoming loplugin:elidestringvar: forms 
Change-Id: Ic95f4dc57dd19654e2dace60883c0c6f1d14b9ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95464
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2020-06-04 09:08:04 +02:00
Noel Grandin 89340fcb65 use for-range on Sequence in f* 
Change-Id: I820255001c1b96d1f4b76a203f3c0f76fa09fe66
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94567
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-05-21 08:48:26 +02:00
Caolán McNamara a5458d1f21 limit forms to http[s] 
Change-Id: I3ed0bc626f693ec03f610dc7361f93cad914c9d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94015
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2020-05-12 17:03:35 +02:00
Noel Grandin 366d08f2f6 new loplugin:simplifypointertobool 
Change-Id: Iff68e8f379614a6ab6a6e0d1bad18e70bc76d76a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91907
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-05-10 12:02:44 +02:00
Noel Grandin eecf74d417 compact namespace in filter..framework 
Change-Id: Id3c2d9b1fdf9d617adea0fa1ab2fa9a2de12ef50
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93727
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-05-08 21:13:05 +02:00
Noel Grandin fcabb9a726 loplugin:flatten in forms 
Change-Id: I7e264cc1e60280b80a4e2e87b8944de4912c563d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92162
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-04-14 13:33:20 +02:00
Yukio Siraichi 8e173a965d tdf#130977 replace rtl::math::isFinite with std::isfinite. 
- make all calls look like `std::isfinite`.
- change the comments referring `rtl::math::isFinite`.

Change-Id: I0cde9ceb9f20150467b454cddde5e62003cfde1a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90234
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2020-03-12 10:34:46 +01:00
Muhammet Kara c691aed634 clang-format f*,h* with under 5-percent lines of change 
Files which could become clang-format conformant with
under 5-percent lines of change relative to the total
count of lines in the file are found by using bin/find-clang-format.py,
and fixed with /opt/lo/bin/clang-format -i <path-of-the-file>

There will be follow-up patches to fix all 'under-5-percent' files.

Change-Id: I702c09bcd3a9a113b3d66c30edb6cf3b7e6a6593
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88776
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
 2020-02-16 14:10:39 +01:00
Gabor Kelemen f0c8312bc6 tdf#42949 Fix IWYU warnings in forms/ 
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I4afb3616c4f93155c187da11b2981b84d0984e9f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87943
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2020-02-14 10:55:43 +01:00
Noel Grandin c82efb610b clang-tidy modernize-concat-nested-namespace 
Change-Id: Iab35a8b85b3ba1df791c774f40b037f9420a071a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86708
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-01-31 18:36:09 +01:00
Noel Grandin 02b24d7747 sal_Char->char in forms..framework 
Change-Id: I756c1f54d50403aa9b4f03dbbc2a387556f07084
Reviewed-on: https://gerrit.libreoffice.org/85475
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-12-19 09:33:33 +01:00
Stephan Bergmann 8b4719c29f Rename OUStringLiteral1 to OUStringChar 
It started out as a wrapper around character literals, but has by now become a
wrapper around arbitrary single characters.  Besides updating the documentation,
this change is a mechanical

  for i in $(git grep -Fl OUStringLiteral1); do sed -i -e s/OUStringLiteral1/OUStringChar/g "$i"; done

Change-Id: I1b9eaa4b3fbc9025ce4a4bffea3db1c16188b76f
Reviewed-on: https://gerrit.libreoffice.org/80892
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-10-17 07:28:49 +02:00
Noel Grandin 3b13f813da loplugin:constmethod in forms..fpicker 
Change-Id: I1673e00be0a6c9d34ce02437bf68d929c56952f7
Reviewed-on: https://gerrit.libreoffice.org/79540
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-09-26 03:04:34 +02:00
Noel Grandin d48d9c0f96 loplugin:returnconstval in desktop..forms 
Change-Id: I268e352e4e3054d1c1a8e61e52d91fd99794b359
Reviewed-on: https://gerrit.libreoffice.org/78057
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-08-24 18:14:37 +02:00
Stephan Bergmann f018d6274d Improved loplugin:stringconstant (now that GCC 7 supports it): forms 
Change-Id: I105fc954a983280ec07759a7f9d21e726a970a80
Reviewed-on: https://gerrit.libreoffice.org/76676
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-07-31 12:58:39 +02:00
Noel Grandin 6595240f39 loplugin:referencecasting in forms..fpicker 
Change-Id: I0aa040b6d3264d2efde5797f79994d3d65ceaddf
Reviewed-on: https://gerrit.libreoffice.org/75957
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-07-19 18:29:34 +02:00
Arkadiy Illarionov e2814bc4d3 tdf#39593 Remove static xforms::Binding::getModelImpl 
Replace with comphelper::getUnoTunnelImplementation.

Change-Id: I001293ca25387a34cff9872c6db2ab72c6c4d617
Reviewed-on: https://gerrit.libreoffice.org/74385
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-06-20 10:20:23 +02:00
Arkadiy Illarionov 9950aab9f0 tdf#39593 Remove xforms::Model::getModel 
Replace with comphelper::getUnoTunnelImplementation.

Change-Id: I52f780059be7626a03bf79044cfc580bb33f3fd3
Reviewed-on: https://gerrit.libreoffice.org/74383
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-06-20 08:04:47 +02:00
Arkadiy Illarionov 9e1fa327b1 tdf#39593 Remove xforms::Binding::getBinding 
Replace with comphelper::getUnoTunnelImplementation.

Change-Id: Ic569783ae01f731f54b54775b8e0eba162cc4b78
Reviewed-on: https://gerrit.libreoffice.org/74381
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-06-20 08:03:59 +02:00
Arkadiy Illarionov d6a45af91b tdf#39593 Remove xforms::Submission::getSubmission 
Replace with comphelper::getUnoTunnelImplementation.

Change-Id: I8dcd0bf1cfbaa02fbb7c128421506f1c30d87773
Reviewed-on: https://gerrit.libreoffice.org/74387
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-06-20 08:02:26 +02:00
Noel Grandin 7508c1d1e7 loplugin:logexceptionnicely in filter..framework 
Change-Id: I8cf70ee278c641767e3fcfcfd151d99d791b3468
Reviewed-on: https://gerrit.libreoffice.org/74098
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-06-16 08:55:07 +02:00
Andrea Gelmini 93bc4fe035 Fix typo 
Change-Id: Ie9174d46b3936ee19a7d1e70f85af6fed2c0c6d4
Reviewed-on: https://gerrit.libreoffice.org/73637
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2019-06-07 07:07:16 +02:00
Andrea Gelmini 466a98b5ad Fix typo 
Change-Id: I1a657bd08ff7a6108a20d57d5ebe9f104fcbe3fd
Reviewed-on: https://gerrit.libreoffice.org/73420
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2019-06-04 07:12:28 +02:00
Stephan Bergmann c18e2ea2a5 New loplugin:data 
...following up on 1453c2c8f1 "prefer vector::data
to &vector[0]"

Change-Id: I7c113747d92d144a521d49b89384dd8bf1215c01
Reviewed-on: https://gerrit.libreoffice.org/72765
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-05-22 16:35:20 +02:00
Noel Grandin 04112bce50 loplugin:sequentialassign in filter..fpicker 
Change-Id: I4ba0e1e982897bd570612f6cda8ba1e6a9fa5dbd
Reviewed-on: https://gerrit.libreoffice.org/70700
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-04-13 14:46:53 +02:00
Matteo Casalin 83f1068ff6 Use char version of OString/OStringBuffer methods 
Change-Id: I0222e6675f63797f870746fd34a29702ad190311
Reviewed-on: https://gerrit.libreoffice.org/69240
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
 2019-04-06 23:42:36 +02:00
Gabor Kelemen 97ab50f381 Remove unused using declarations in directories [e-l]* 
Found by:
run-clang-tidy-7 -checks=-*,misc-unused-using-decls

Change-Id: Iee4e9df37d4c971ea97256d041afbc3d3aaa3d27
Reviewed-on: https://gerrit.libreoffice.org/70027
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2019-04-05 09:27:08 +02:00
Matteo Casalin dfb2feca54 Improve parseDateTime tokenization and reduce OUString copies 
Change-Id: If84f455c235176d56d72bdc11d813f1ee1e3122e
Reviewed-on: https://gerrit.libreoffice.org/69241
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
 2019-03-20 07:31:10 +01:00